RFR(XS): 7901298: jcheck should check that every file ends with exactly one newline

[Iris Clark]

Hi, Magnus.

> Is it really the case that there can be no changes to jcheck which do not make all existing changesets in all existing forests pass?  How on earth are we then ever going to be able to raise the bar for quality?

Theoretically, I don't think that there's a problem with modifying jcheck to improve the quality of the code.  The issue is that as the tool is currently written and used, there is no migration path for a higher bar.  The provided patch does not include a solution to this problem.

Thanks,
iris

-----Original Message-----
From: Magnus Ihse Bursie 
Sent: Tuesday, May 05, 2015 2:54 PM
To: Jonathan Gibbons; code-tools-dev at openjdk.java.net; hg-tools-dev at openjdk.java.net
Subject: Re: RFR(XS): 7901298: jcheck should check that every file ends with exactly one newline

On 2015-05-05 23:35, Jonathan Gibbons wrote:
>
> On 05/05/2015 02:31 PM, Magnus Ihse Bursie wrote:
>> On 2015-02-13 12:01, Volker Simonis wrote:
>>> Hi,
>>>
>>> could somebody please review and sponsor the following small change 
>>> which adds a test for exactly one newline at the and of a file to
>>> check:
>>>
>>> http://cr.openjdk.java.net/~simonis/webrevs/2015/7901298/
>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901298
>>
>> Found this mail again now, when I wondered why it was not already fixed.
>>
>> The fix looks good to me, and I wish it was already in place :-). I'm 
>> not a formal jcheck reviewer though. :(
>>
>> /Magnus
>
> Magnus,
>
> Please see the follow-up discussion on hg-tools-dev.
> http://mail.openjdk.java.net/pipermail/hg-tools-dev/2015-April/thread.
> html
>

Quoting that discussion:
> Do all of the changesets (-r 0:tip) in all existing forests where 
> jcheck is enabled pass with this change?

Is it really the case that there can be no changes to jcheck which do not  make all existing changesets in all existing forests pass? How on earth are we then ever going to be able to raise the bar for quality?

/Magnus