RFR(XS): 7901298: jcheck should check that every file ends with exactly one newline
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Thu May 7 12:13:28 UTC 2015
On 2015-05-07 11:35, Chris Hegarty wrote:
> I cannot answer the questions about the operation of the mercurial server, others better positioned than I should do that, but if jcheck is to ever evolve in a manner like you are suggesting then a repository may need a way to indicate to jcheck what level of checks should be done for certain regions of its history. Say, the .jcheck/conf file in the repo had an entry with a value of a changeset from where jcheck would enable this “new” stricter checking. It would be opt in by the repo/project and could be configurable to its local history ( i.e. enable from this changeset hash onward ). Previous changsets would be checked as they are today.
I still don't understand why jcheck must be able to approve already
Are we talking about a technical limitation in the way jcheck is
currently implemented? Or a technical limitation on what's possible to
run on a mercurial server? Or is this a design choice?
Your suggestion might be required if it is a technical limitation in how
mercurial server extensions work, but if it is a limitation in the
current implementation in jcheck, it seems better to fix it in jcheck
than to add special tracking files to the repositories. And if it is a
pure design choice, well, I can't see the value of having to keep track
exactly what level of jcheck historical commits pasts.
More information about the hg-tools-dev