RFR(XS): 7901298: jcheck should check that every file ends with exactly one newline

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon May 25 10:13:06 UTC 2015

On 2015-05-13 11:37, Chris Hegarty wrote:
> On 13/05/15 08:35, Volker Simonis wrote:
>> Ping...
>> Can anybody please have a look at the new webrev?
> I am not a Reviewer on this project, but I quickly skimmed the webrev 
> and it seems ok.
>> I think the proposed solution is not so bad :)
> I agree. If we want to evolve jcheck in a manner that enables more 
> strict checking, then such an approach seems reasonable.

I seems that this approach will lead to each improvement requiring a new 
line in the configuration. I think that's not ideal. But then again, we 
need *some* way of being able to evolve jcheck. And if the requirement 
is to be backward compatible with all previous commits, then this might 
be the only way.

So I'm in favour for Volker's fix, at least until someone finds a better 
way to evolve jcheck.


More information about the hg-tools-dev mailing list