RFR: Make trees work with hg 4.6

Martin Buchholz martinrb at google.com
Thu Jun 7 18:25:22 UTC 2018


Hej Erik,

You may find my colleague's fixes useful.  I've made them available on cr.

http://cr.openjdk.java.net/~martin/trees/

(too many Martins?!)

---

This change seems unrelated to hg 4.6:
It seems too easy to get false positives if you're simply looking for 'rc'
Probably gratuitously different string quotes '' vs "" could be fixed.

-    tags = filter(lambda t: not t.endswith('-rc') and t != "tip", tags)
+    tags = filter(lambda t: 'rc' not in t and t != "tip", tags)

The other changes look good to me but I'm not a python or trees developer.


On Mon, Jun 4, 2018 at 3:34 PM, Erik Joelsson <erik.joelsson at oracle.com>
wrote:

> Hello,
>
> I've rebased my patch for getting trees to work with hg 4.6 on top of
> Mark's latest commits. This patch also fixes an issue with the internal
> verlist plugin if the default mercurial on the system running the tests is
> newer than 3.8. It also widens the filtering of release candidate tags in
> the hg main repo to catch the 4.6rc1 and 4.6rc2 tags.
>
> Webrev: http://cr.openjdk.java.net/~erikj/trees-4.6/webrev.01/
>
> /Erik
>
>


More information about the hg-tools-dev mailing list