Bug in LIRGenerator::generate_address on sparc?

[Gary Benson]

Tom Rodriguez wrote:
> That does indeed look wrong.  I don't think your changes to reduce
> register wastage are a good idea though.  Keep in mind that these
> are virtual registers and should generally be created every time a
> new value is defined.  They should never be reused for multiple defs
> otherwise you may be killing a value which is used in some later
> part of the code.  The allocator should be a reasonable job of
> reusing registers for you particularly within a basic block.  Are
> you see problems caused by these extra virtual registers?

Ah, I didn't realise they were virtual.  That makes a lot more sense.

Cheers,
Gary