Request for reviews (S): 6741738: TypePtr::add_offset() set incorrect offset when the add overflows

[John Rose]

That's good, and (like many nice changes we'd like) long overdue.   
While you are at it, check that the addition result is not OffsetTop;  
if so, change it to OffsetBot.

Some day we'll clean out the rest of the 'int' from pointer types.

-- John

On Aug 27, 2008, at 8:53 AM, Vladimir Kozlov wrote:

> http://webrev.invokedynamic.info/kvn/6741738/index.html
>
> Fixed 6741738: TypePtr::add_offset() set incorrect offset when the  
> add overflows
>
> Problem:
> AddPNode::bottom_type() and AddPNode::Value() have the point fix
> to prevent an offset add overflows and AddPNode::mach_bottom_type()
> does not have it. This leads to the type mismatch in Matcher.
>
> Solution:
> TypePtr::add_offset() should set the offset to OffsetBot
> when the add overflows.
>
> Reviewed by:
> Fix verified (y/n): y, failed test.
>
> Other testing:
> JPRT
>