From Vladimir.Kozlov at Sun.COM Wed Dec 3 07:05:17 2008 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Wed, 03 Dec 2008 07:05:17 -0800 Subject: Request for reviews (S): 6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(),"object must be locked now") Message-ID: <4936A02D.10106@sun.com> http://webrev.invokedynamic.info/kvn/6775880/index.html Fixed 6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(),"object must be locked now") Problem: Locks elimination for non-escaping objects incorrectly assumes that different objects have different BoxLock nodes. It is not true, BoxLock could be shared for locking different objects. As result "eliminated" status of BoxLock node is incorrect when locks for one object were eliminated and for an other they were not. This affects debug info and leads to the assert during deoptimization. Solution: - ConnectionGraph::escape_state(n, phase) should return the state of JavaObject. - Use EA information during all optimizations since optimizations can not change the escape state to worse but they can change the lock's obj_node input to non-escaping one which will allow to eliminate the lock (for example, after parser the obj_node is a phi which points to an incoming parameter and non-escaping allocation, and during optimizations the parameter path became dead). - Create new "eliminated" BoxLock node and use it in monitor debug info when corresponding locks are eliminated. - Add the check "eliminated" status to BoxLock node's hash() and cmp() methods to distinguish such nodes. - Also delete FastLock node when the lock code is removed from graph. Added the regression test. Reviewed by: Fix verified (y/n): y Other testing: JPRT, CTW (with -XX:+DeoptimizeALot -XX:+DoEscapeAnalysis) From vladimir.kozlov at sun.com Wed Dec 3 16:38:34 2008 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Thu, 04 Dec 2008 00:38:34 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(), "object must be locked now") Message-ID: <20081204003841.A983ADF75@hg.openjdk.java.net> Changeset: 424f9bfe6b96 Author: kvn Date: 2008-12-03 13:41 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/424f9bfe6b96 6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(),"object must be locked now") Summary: Create new "eliminated" BoxLock node for monitor debug info when corresponding locks are eliminated. Reviewed-by: never ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/locknode.cpp ! src/share/vm/opto/locknode.hpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/output.cpp + test/compiler/6775880/Test.java From vladimir.kozlov at sun.com Thu Dec 4 10:51:46 2008 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Thu, 04 Dec 2008 18:51:46 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 16 new changesets Message-ID: <20081204185221.76F8ADFC0@hg.openjdk.java.net> Changeset: 316c0b576ea1 Author: xdono Date: 2008-11-20 11:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/316c0b576ea1 Added tag jdk7-b40 for changeset 81a0cbe3b284 ! .hgtags Changeset: ab42bab113e0 Author: trims Date: 2008-11-21 16:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/ab42bab113e0 Merge - src/share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.hpp Changeset: f9d938ede196 Author: trims Date: 2008-11-21 16:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/f9d938ede196 6775176: Bump HS14 build number to 08 Summary: Update the Hotspot build number to 08 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 2b42b31e7928 Author: coleenp Date: 2008-11-21 08:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/2b42b31e7928 6676175: BigApps crash JVM Client VM (build 10.0-b22, mixed mode, sharing) with SIGSEGV (0xb) Summary: Add test for biased locking epoch before walking own thread stack in case of rare race Reviewed-by: phh, never ! src/share/vm/runtime/biasedLocking.cpp Changeset: ba7f9d894282 Author: kamg Date: 2008-11-21 15:10 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/ba7f9d894282 Merge - src/share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.hpp Changeset: 171e581e8161 Author: xlu Date: 2008-11-22 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/171e581e8161 6554406: Change switch UseVMInterruptibleIO default to false (sol) Summary: The default value of UseVMInterruptibleIO is changed to false for JDK 7, but the default isn't changed for JDK 6 and earlier. Reviewed-by: never, acorn, dholmes, kamg, alanb ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: b22701a8b88f Author: coleenp Date: 2008-11-24 14:45 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/b22701a8b88f 6474243: suspicious jvmti code that uses oop unsafely across GC point Summary: oop stored in unsafely in Lscratch noticed by visual inspection will not be updated by GC. Reviewed-by: kamg, never, kvn ! src/cpu/sparc/vm/templateTable_sparc.cpp Changeset: a60eabc24e2c Author: kamg Date: 2008-11-25 15:59 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/a60eabc24e2c Merge Changeset: 00b023ae2d78 Author: ysr Date: 2008-11-20 12:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/00b023ae2d78 6722113: CMS: Incorrect overflow handling during precleaning of Reference lists Summary: When we encounter marking stack overflow during precleaning of Reference lists, we were using the overflow list mechanism, which can cause problems on account of mutating the mark word of the header because of conflicts with mutator accesses and updates of that field. Instead we should use the usual mechanism for overflow handling in concurrent phases, namely dirtying of the card on which the overflowed object lies. Since precleaning effectively does a form of discovered list processing, albeit with discovery enabled, we needed to adjust some code to be correct in the face of interleaved processing and discovery. Reviewed-by: apetrusenko, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/runtime/globals.hpp Changeset: c96030fff130 Author: ysr Date: 2008-11-20 16:56 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/c96030fff130 6684579: SoftReference processing can be made more efficient Summary: For current soft-ref clearing policies, we can decide at marking time if a soft-reference will definitely not be cleared, postponing the decision of whether it will definitely be cleared to the final reference processing phase. This can be especially beneficial in the case of concurrent collectors where the marking is usually concurrent but reference processing is usually not. Reviewed-by: jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/includeDB_core ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/referencePolicy.cpp ! src/share/vm/memory/referencePolicy.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/utilities/macros.hpp Changeset: df4305d4c1a1 Author: ysr Date: 2008-11-24 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/df4305d4c1a1 6774607: SIGSEGV or (!is_null(v),"oop value can never be zero") assertion when running with CMS and COOPs Summary: Use the more permissive set_klass_or_null() and klass_or_null() interfaces in ParNew's workqueue overflow code that manipulates the klass-word. Reviewed-by: coleenp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/oops/oop.inline.hpp Changeset: 434912c745cf Author: iveresov Date: 2008-11-26 09:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/434912c745cf Merge ! src/share/vm/runtime/globals.hpp Changeset: b6272ef4a18f Author: poonam Date: 2008-11-27 18:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/b6272ef4a18f 6743339: Enable building sa-jdi.jar and sawindbg.dll on Windows with hotspot build Summary: These changes enable the SA binaries build with hotspot build on Windows Reviewed-by: swamyv ! make/windows/build.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/sa.make Changeset: 27a80744a83b Author: ysr Date: 2008-12-01 23:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/27a80744a83b 6778647: snap(), snap_policy() should be renamed setup(), setup_policy() Summary: Renamed Reference{Policy,Pocessor} methods from snap{,_policy}() to setup{,_policy}() Reviewed-by: apetrusenko ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/referencePolicy.cpp ! src/share/vm/memory/referencePolicy.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp Changeset: 95cad1ab2510 Author: jmasa Date: 2008-12-03 14:44 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/95cad1ab2510 Merge Changeset: 1f54ed41d6ae Author: kvn Date: 2008-12-04 08:55 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/1f54ed41d6ae Merge From John.Rose at Sun.COM Thu Dec 4 11:25:41 2008 From: John.Rose at Sun.COM (John Rose) Date: Thu, 04 Dec 2008 11:25:41 -0800 Subject: for review (S): 6771309: debugging AD files is difficult without #line directives in generated code In-Reply-To: <689A41AC-8041-4267-BF91-EB6878B4A19D@sun.com> References: <689A41AC-8041-4267-BF91-EB6878B4A19D@sun.com> Message-ID: Second call: Can I have a review of this please? -- John On Nov 13, 2008, at 1:15 PM, John Rose wrote: > http://webrev.invokedynamic.info/jrose/6771309 From Vladimir.Kozlov at Sun.COM Thu Dec 4 14:07:15 2008 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Thu, 04 Dec 2008 14:07:15 -0800 Subject: CreateEx at the start of a block In-Reply-To: References: <49383A66.1070000@sun.com> Message-ID: <49385493.2000408@sun.com> Tom, This problem and 6776584 bug happened with nsk.stress test nsk/stress/jck60/jck60017 I tried to reproduce it with CTW rt.jar and got an other problem: Current function is PhaseChaitin::verify_base_ptrs 306 assert(check->is_Mach() && check->as_Mach()->ideal_Opcode() == Op_AddP,"Bad derived pointer") [t at 8 l at 8]: print check->dump() 27 loadP === 11 13 12 [[ 2130 2776 2297 713 ]] byte[int:>=0]:exact * !jvms: ByteBuffer::array @ bci:1 IDLJavaSerializationInputStream::printBuffer @ bci:4 I have to comment the phi check: /* && check->_idx >= _oldphi */ since the graph has old phis which merge lea instructions. _oldphi = 2206U 27 loadP === 11 13 12 [[ 2130 2776 2297 713 ]] byte[int:>=0]:exact * !jvms: ByteBuffer::array @ bci:1 IDLJavaSerializationInputStream::printBuffer @ bci:4 2297 MachSpillCopy === _ 27 [[ 353 345 339 316 308 296 287 279 271 263 236 230 225 202 190 181 176 168 160 133 127 122 98 90 2230 1619 1459 1348 1341 1333 2494 2705 ]] 2230 MachSpillCopy === _ 2297 [[ 966 ]] 967 leaPIdxOff === _ 2631 2681 2682 [[ 2683 ]] #16 2683 MachSpillCopy === _ 967 [[ 966 ]] 966 Phi === 80 2230 2683 [[ 2508 ]] #byte[int:>=0]:NotNull:exact+any * 2508 Phi === 79 966 2508 [[ 2509 71 935 923 914 909 901 893 884 872 864 858 850 842 834 2508 ]] #byte[int:>=0]:NotNull:exact+any * As I understand it could be also a problem. Note: I tested without EA. Thanks, Vladimir Tom Rodriguez wrote: > It certainly must be at the beginning of the block during register > allocation, otherwise I don't think the interference graph will be > handled correctly. The CreateEx represents the incoming exception in a > fixed register and it needs to interfere with every value coming into > the exception handler. If a MachSpillCopy is before it then a value > could be live into the exception point in the exception oop register, > where it would be blown away. So I think it's a pretty hard rule. When > are you hitting this assert? > > tom > > On Dec 4, 2008, at 12:15 PM, Vladimir Kozlov wrote: > >> How strict that CreateEx should be at the start of a block? >> >> History: >> I am investigating 6776584: EA on sparcV9 Error: before block local >> scheduling >> I also reproduced the problem with 32-bits VM on x86: >> >> two separate float values coming into the block >> use the same register: >> >> [t at 8 l at 8]: print n->dump(1) >> 2409 Phi === 348 2822 2388 [[ 725 2475 2824 2823 2475 >> 725 756 756 756 756 756 756 ]] #float >> 725 cmpX_cc === _ 2409 2409 [[ 726 724 ]] >> >> [t at 8 l at 8]: print _reg_node[reg_lo]->dump(1) >> 2388 MachSpillCopy === _ 2279 [[ 2409 2411 ]] >> 2411 MoveF2I_reg_reg_sse === _ 2388 [[ 724 ]] !orig=[727] >> >> [t at 8 l at 8]: print OptoReg::dump(reg_lo) >> XMM1a >> >> The problem is reported by Scheduling::verify_good_schedule(). >> So I am trying to find when it happened. During RA some verification >> is done under VerifyOpto. But currently it is broken - it reports too >> many problems (we miss ton of places where a node is subsumed >> but it uses were not put on igvn working list, an other bug too fix, >> I spent day yesterday but still hitting problem so I drop it for now). >> >> I added new flag VerifyRegisterAllocator to check only RA. >> And it immediately gives this: >> >> Current function is PhaseCFG::verify >> 894 "CreateEx must be first instruction in block" ); >> >> [t at 8 l at 8]: print b->dump() >> B23: # B35 B24 B34 <- N269 Freq: 5.49441e-06 >> 286 Region === 286 117 [[ 286 114 119 ]] >> 399 MachSpillCopy === _ 91 [[ 114 ]] >> Oop:java/lang/String:NotNull:exact * >> 398 MachSpillCopy === _ 95 [[ 114 443 ]] >> 397 MachSpillCopy === _ 353 [[ 114 442 ]] >> 396 MachSpillCopy === _ 352 [[ 114 441 ]] >> Oop:java/util/Locale:exact * >> 395 MachSpillCopy === _ 380 [[ 114 440 ]] >> Oop:java/util/ResourceBundle$Control * >> 119 CreateException === 286 100 [[ 393 ]] >> java/lang/Throwable:NotNull * Oop:java/lang/Throwable:NotNull * !jvms: >> ResourceBundle::loadBundle @ bci:83 >> ... >> >> Is this a problem? >> >> Thanks, >> Vladimir >> >> > From john.coomes at sun.com Thu Dec 4 20:59:35 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 05 Dec 2008 04:59:35 +0000 Subject: hg: jdk7/hotspot-comp: 2 new changesets Message-ID: <20081205045935.8A768D0E0@hg.openjdk.java.net> Changeset: 541bdc5ad32f Author: ohair Date: 2008-12-01 15:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/541bdc5ad32f 6750229: Upgrade Recommended Linux and Windows Build OS Reviewed-by: xdono ! README-builds.html Changeset: a20db75d7f33 Author: xdono Date: 2008-12-04 11:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/a20db75d7f33 Added tag jdk7-b41 for changeset 541bdc5ad32f ! .hgtags From john.coomes at sun.com Thu Dec 4 21:01:23 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 05 Dec 2008 05:01:23 +0000 Subject: hg: jdk7/hotspot-comp/corba: Added tag jdk7-b41 for changeset c90eeda9594e Message-ID: <20081205050125.64962D0E5@hg.openjdk.java.net> Changeset: d9a0ca94dcf8 Author: xdono Date: 2008-12-04 11:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/d9a0ca94dcf8 Added tag jdk7-b41 for changeset c90eeda9594e ! .hgtags From john.coomes at sun.com Thu Dec 4 21:05:29 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 05 Dec 2008 05:05:29 +0000 Subject: hg: jdk7/hotspot-comp/jaxp: Added tag jdk7-b41 for changeset 0758bd3e2852 Message-ID: <20081205050532.542F1D0EB@hg.openjdk.java.net> Changeset: 036e0dca841a Author: xdono Date: 2008-12-04 11:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/036e0dca841a Added tag jdk7-b41 for changeset 0758bd3e2852 ! .hgtags From john.coomes at sun.com Thu Dec 4 21:07:22 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 05 Dec 2008 05:07:22 +0000 Subject: hg: jdk7/hotspot-comp/jaxws: Added tag jdk7-b41 for changeset a8379d24aa03 Message-ID: <20081205050725.412E6D0F0@hg.openjdk.java.net> Changeset: 621c02d83abc Author: xdono Date: 2008-12-04 11:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/621c02d83abc Added tag jdk7-b41 for changeset a8379d24aa03 ! .hgtags From john.coomes at sun.com Thu Dec 4 21:09:34 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 05 Dec 2008 05:09:34 +0000 Subject: hg: jdk7/hotspot-comp/jdk: 17 new changesets Message-ID: <20081205051309.7927FD0F5@hg.openjdk.java.net> Changeset: 5102df668164 Author: mullan Date: 2008-11-05 15:55 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/5102df668164 6744888: OCSP validation code should permit some clock skew when checking validity of OCSP responses Summary: Allow for up to 10 minutes of clock skew when validating OCSP responses Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java Changeset: 6923a82c1036 Author: mullan Date: 2008-11-06 11:58 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/6923a82c1036 Merge Changeset: 3a3e02a55de8 Author: mullan Date: 2008-11-06 12:12 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/3a3e02a55de8 6765046: CertPathValidatorException(Throwable).getMessage() always returns null since b37 Reviewed-by: vinnie ! src/share/classes/java/security/cert/CertPathValidatorException.java + test/java/security/cert/CertPathValidatorException/GetMessage.java Changeset: 810a95940b99 Author: emcmanus Date: 2008-11-07 11:48 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/810a95940b99 5072267: A way to communicate client context such as locale to the JMX server Summary: Support for client contexts and also for localization of descriptions Reviewed-by: dfuchs ! src/share/classes/com/sun/jmx/defaults/ServiceName.java ! src/share/classes/com/sun/jmx/event/EventParams.java ! src/share/classes/com/sun/jmx/event/LeaseManager.java ! src/share/classes/com/sun/jmx/interceptor/SingleMBeanForwarder.java ! src/share/classes/com/sun/jmx/mbeanserver/JmxMBeanServer.java - src/share/classes/com/sun/jmx/namespace/JMXNamespaceUtils.java ! src/share/classes/com/sun/jmx/namespace/ObjectNameRouter.java ! src/share/classes/com/sun/jmx/namespace/RoutingConnectionProxy.java ! src/share/classes/com/sun/jmx/namespace/RoutingProxy.java ! src/share/classes/com/sun/jmx/namespace/RoutingServerProxy.java ! src/share/classes/com/sun/jmx/remote/util/EventClientConnection.java + src/share/classes/javax/management/ClientContext.java ! src/share/classes/javax/management/Descriptor.java ! src/share/classes/javax/management/JMX.java ! src/share/classes/javax/management/MBeanInfo.java ! src/share/classes/javax/management/MBeanServerNotification.java ! src/share/classes/javax/management/Notification.java ! src/share/classes/javax/management/event/EventClient.java ! src/share/classes/javax/management/event/EventClientDelegate.java ! src/share/classes/javax/management/event/EventClientDelegateMBean.java ! src/share/classes/javax/management/event/EventRelay.java ! src/share/classes/javax/management/event/package-info.java ! src/share/classes/javax/management/namespace/JMXNamespaces.java ! src/share/classes/javax/management/namespace/JMXRemoteNamespace.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/JMXConnectorServer.java ! src/share/classes/javax/management/remote/JMXConnectorServerMBean.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! test/javax/management/Introspector/AnnotationTest.java + test/javax/management/context/ContextForwarderTest.java + test/javax/management/context/ContextTest.java + test/javax/management/context/LocaleAwareBroadcasterTest.java + test/javax/management/context/LocaleTest.java + test/javax/management/context/LocalizableTest.java + test/javax/management/context/RemoteContextTest.java + test/javax/management/context/localizable/MBeanDescriptions.properties + test/javax/management/context/localizable/MBeanDescriptions_fr.java + test/javax/management/context/localizable/Whatsit.java + test/javax/management/context/localizable/WhatsitMBean.java ! test/javax/management/eventService/CustomForwarderTest.java ! test/javax/management/eventService/EventClientExecutorTest.java ! test/javax/management/eventService/EventManagerTest.java ! test/javax/management/eventService/ListenerTest.java ! test/javax/management/eventService/NotSerializableNotifTest.java ! test/javax/management/eventService/UsingEventService.java ! test/javax/management/namespace/EventWithNamespaceControlTest.java ! test/javax/management/namespace/JMXNamespaceSecurityTest.java ! test/javax/management/namespace/JMXNamespaceViewTest.java ! test/javax/management/namespace/JMXRemoteTargetNamespace.java ! test/javax/management/namespace/NamespaceNotificationsTest.java ! test/javax/management/namespace/NullDomainObjectNameTest.java ! test/javax/management/namespace/NullObjectNameTest.java ! test/javax/management/openmbean/CompositeDataStringTest.java ! test/javax/management/remote/mandatory/connectorServer/ForwarderChainTest.java ! test/javax/management/remote/mandatory/connectorServer/StandardForwardersTest.java ! test/javax/management/remote/mandatory/provider/ProviderTest.java ! test/javax/management/remote/mandatory/subjectDelegation/SimpleStandard.java Changeset: 2410a0b48d06 Author: emcmanus Date: 2008-11-07 19:19 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/2410a0b48d06 6336968: Methods to convert AttributeList to/from Map 6750008: Add JMX.getSpecificationVersion(MBeanServerConnection) and document interop 6750472: Add a way to convert a CompositeData into a Map 6752563: Allow CompositeDataSupport to have zero items Summary: Small JMX RFEs Reviewed-by: dfuchs ! src/share/classes/javax/management/AttributeList.java ! src/share/classes/javax/management/JMX.java ! src/share/classes/javax/management/MBeanServerConnection.java ! src/share/classes/javax/management/MBeanServerNotification.java ! src/share/classes/javax/management/QueryNotificationFilter.java ! src/share/classes/javax/management/openmbean/CompositeDataSupport.java ! src/share/classes/javax/management/package.html + test/javax/management/MBeanServer/AttributeListMapTest.java + test/javax/management/MBeanServer/AttributeListTypeSafeTest.java + test/javax/management/openmbean/CompositeDataToMapTest.java + test/javax/management/remote/mandatory/version/JMXSpecVersionTest.java Changeset: 275fa248e808 Author: alanb Date: 2008-11-11 08:59 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/275fa248e808 6763122: ZipFile ctor does not throw exception when file is not a zip file Reviewed-by: bristor ! src/share/native/java/util/zip/zip_util.c ! test/java/util/zip/TestEmptyZip.java Changeset: e81b47f0b40f Author: alanb Date: 2008-11-11 09:07 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/e81b47f0b40f Merge - src/share/classes/com/sun/jmx/namespace/JMXNamespaceUtils.java Changeset: d2f96992b77b Author: weijun Date: 2008-11-12 16:00 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/d2f96992b77b 6733095: Failure when SPNEGO request non-Mutual Reviewed-by: valeriep ! src/share/classes/sun/security/jgss/GSSContextImpl.java ! src/share/classes/sun/security/jgss/spnego/SpNegoContext.java ! test/sun/security/krb5/auto/Context.java + test/sun/security/krb5/auto/NonMutualSpnego.java Changeset: 76edd0698e0a Author: weijun Date: 2008-11-12 16:01 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/76edd0698e0a 6765491: Krb5LoginModule a little too restrictive, and the doc is not clear. Reviewed-by: valeriep ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java ! test/sun/security/krb5/auto/Context.java ! test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/auto/LoginModuleOptions.java Changeset: a85ef87f9eaa Author: chegar Date: 2008-11-12 16:38 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/a85ef87f9eaa 6755625: Add HttpURLConnection.setFixedLengthStreamingMode(long) Reviewed-by: jccollet ! src/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java ! src/share/classes/java/net/HttpURLConnection.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/net/www/protocol/https/HttpsURLConnectionImpl.java ! test/com/sun/net/httpserver/bugs/FixedLengthInputStream.java Changeset: 84bd7fd5fb65 Author: chegar Date: 2008-11-13 09:40 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/84bd7fd5fb65 Merge Changeset: 5c1a8571946f Author: tbell Date: 2008-11-13 11:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/5c1a8571946f Merge - src/share/classes/com/sun/jmx/namespace/JMXNamespaceUtils.java Changeset: 16efbe49c725 Author: xuelei Date: 2008-11-13 23:08 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/16efbe49c725 6728126: Parsing Extensions in Client Hello message is done in a wrong way Summary: the inputStream.read(byte[], int, 0) is not always return zero. Reviewed-by: wetmore, weijun ! src/share/classes/sun/security/ssl/HelloExtensions.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/EmptyExtensionData.java Changeset: dcb8d806d731 Author: xuelei Date: 2008-11-13 23:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/dcb8d806d731 6745052: SLServerSocket file descriptor leak Summary: SSLServerSocketImpl.checkEnabledSuites() does not release the temporary socket properly Reviewed-by: wetmore, weijun ! src/share/classes/sun/security/ssl/BaseSSLSocketImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: 67718d2bd49c Author: dfuchs Date: 2008-11-14 17:22 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/67718d2bd49c 6683213: CounterMonitor's derived Gauge badly initialized Reviewed-by: emcmanus ! src/share/classes/javax/management/monitor/CounterMonitor.java ! src/share/classes/javax/management/monitor/GaugeMonitor.java ! src/share/classes/javax/management/monitor/Monitor.java + test/javax/management/monitor/DerivedGaugeMonitorTest.java Changeset: 44941f893cea Author: tbell Date: 2008-11-21 15:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/44941f893cea Merge Changeset: b213ea31bcb3 Author: xdono Date: 2008-12-04 11:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/b213ea31bcb3 Added tag jdk7-b41 for changeset 44941f893cea ! .hgtags From john.coomes at sun.com Thu Dec 4 21:17:31 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 05 Dec 2008 05:17:31 +0000 Subject: hg: jdk7/hotspot-comp/langtools: 3 new changesets Message-ID: <20081205051738.35698D0FB@hg.openjdk.java.net> Changeset: 4cdaaf4c5dca Author: mcimadamore Date: 2008-11-12 14:17 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/4cdaaf4c5dca 6768932: Add support for multiline diagnostics Summary: Added basic support for multiline/tabular diagnostics Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/AbstractLog.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/LayoutCharacters.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/MandatoryWarningHandler.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java Changeset: ded6b40f558e Author: tbell Date: 2008-11-21 15:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/ded6b40f558e Merge Changeset: 1d4f01925bd0 Author: xdono Date: 2008-12-04 11:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/1d4f01925bd0 Added tag jdk7-b41 for changeset ded6b40f558e ! .hgtags From Vladimir.Kozlov at Sun.COM Mon Dec 8 15:30:04 2008 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Mon, 08 Dec 2008 15:30:04 -0800 Subject: Request for reviews (S): 6782232: assert("CreateEx must be first instruction in block" ) Message-ID: <493DADFC.2040204@sun.com> http://webrev.invokedynamic.info/kvn/6782232/index.html Fixed 6782232: assert("CreateEx must be first instruction in block" ) Problem: The check for CreateEx is missing in the code which adds MachSpillCopy nodes to a block. Solution: - Add the missing check for CreateEx. - Add new notproduct flag VerifyRegisterAllocator to check graph integrity during RA. It helped to find this bug. VerifyOpto has a lot of false positive asserts during IGVN optimizations which currently prevents its usage during RA. - Fix verification code in method verify_base_ptrs() to check all Phi's paths and type of derived and base pointers. Reviewed by: Fix verified (y/n): y Other testing: JPRT, CTW (with VerifyRegisterAllocator) From john.rose at sun.com Mon Dec 8 22:04:59 2008 From: john.rose at sun.com (john.rose at sun.com) Date: Tue, 09 Dec 2008 06:04:59 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6779339: turn off LinkWellKnownClasses by default pending further testing Message-ID: <20081209060504.EB14CD450@hg.openjdk.java.net> Changeset: 7a018855d2f0 Author: jrose Date: 2008-12-08 17:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/7a018855d2f0 6779339: turn off LinkWellKnownClasses by default pending further testing Summary: temporarily turn off LinkWellKnownClasses optimization Reviewed-by: never, kvn ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/runtime/globals.hpp From Vladimir.Kozlov at Sun.COM Tue Dec 9 08:43:49 2008 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Tue, 09 Dec 2008 08:43:49 -0800 Subject: Request for reviews (XS): 6778657 and 6778662: Patchs from Red Hat Message-ID: <493EA045.4070606@sun.com> http://webrev.invokedynamic.info/kvn/6778657/index.html Fixed 6778662: fixes overflows that are undefined behaviour in C++ http://webrev.invokedynamic.info/kvn/6778662/index.html Fixed 6778662: fixes directory search paths. Other testing: JPRT From twisti at complang.tuwien.ac.at Tue Dec 9 08:51:38 2008 From: twisti at complang.tuwien.ac.at (Christian Thalinger) Date: Tue, 09 Dec 2008 17:51:38 +0100 Subject: Request for reviews (XS): 6778657 and 6778662: Patchs from Red Hat In-Reply-To: <493EA045.4070606@sun.com> References: <493EA045.4070606@sun.com> Message-ID: <1228841498.20039.16.camel@localhost.localdomain> On Tue, 2008-12-09 at 08:43 -0800, Vladimir Kozlov wrote: > http://webrev.invokedynamic.info/kvn/6778662/index.html > > Fixed 6778662: fixes directory search paths. Probably I should talk to Gary about that one, but shouldn't SPARC also be added here (and MIPS/MIPSEL for Zero)? + #if defined(AMD64) || defined(_LP64) && (defined(PPC) || defined(S390)) - Christian From john.rose at sun.com Tue Dec 9 15:34:25 2008 From: john.rose at sun.com (john.rose at sun.com) Date: Tue, 09 Dec 2008 23:34:25 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6771309: debugging AD files is difficult without #line directives in generated code Message-ID: <20081209233431.2FC68D566@hg.openjdk.java.net> Changeset: 284d0af00d53 Author: jrose Date: 2008-12-09 12:41 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/284d0af00d53 6771309: debugging AD files is difficult without #line directives in generated code Summary: more and better #line and #define directives in the generated code; ADLC itself accepts #line directives Reviewed-by: never, kvn ! make/linux/adlc_updater ! make/linux/makefiles/adlc.make ! make/solaris/adlc_updater ! make/solaris/makefiles/adlc.make ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/adlparse.hpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/dfa.cpp ! src/share/vm/adlc/filebuff.hpp ! src/share/vm/adlc/formssel.cpp From svferro at gmail.com Wed Dec 10 11:19:03 2008 From: svferro at gmail.com (Sal) Date: Wed, 10 Dec 2008 14:19:03 -0500 Subject: a hotspot-powered Javascript engine Message-ID: Hi - I'm new to the list, if this is the wrong place to ask please forgive me! I recently have been reviewing the openjdk codebase, and have been thinking to attempt a javascript-engine which is based on the openjdk. The idea: to give the same performance to javascript, in a web browser that of Java. (Or close to it.). And create an engine that can be embedded into the different browsers (Chrome, firefox, etc.) My question: Is there any existing project(s) already doing this? I would hate to reinvent the wheel. If not, can any experts on the list give any potential roadblocks/advice to help along the effort? Thanks much in advance! - Sal -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20081210/84957ecc/attachment.html From john.pampuch at sun.com Wed Dec 10 13:41:59 2008 From: john.pampuch at sun.com (John Pampuch) Date: Wed, 10 Dec 2008 13:41:59 -0800 Subject: a hotspot-powered Javascript engine In-Reply-To: References: Message-ID: <494037A7.9000201@sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20081210/00fa1559/attachment.html From charles.nutter at sun.com Wed Dec 10 15:05:20 2008 From: charles.nutter at sun.com (Charles Oliver Nutter) Date: Thu, 11 Dec 2008 00:05:20 +0100 Subject: a hotspot-powered Javascript engine In-Reply-To: <494037A7.9000201@sun.com> References: <494037A7.9000201@sun.com> Message-ID: <49404B30.90603@sun.com> John Pampuch wrote: >> My question: Is there any existing project(s) already doing this? I >> would hate to reinvent the wheel. If not, can any experts on the >> list give any potential roadblocks/advice to help along the effort? > You definitely want to look at Rhino from the Mozilla organization. It > could be a good start. Rhino needs work, but it would be far easier to get it running fast than most of the other dynamic languages. I've wanted to try to tackle it myself. Keep us posted on how it goes if you try it yourself. - Charlie From svferro at gmail.com Thu Dec 11 07:28:30 2008 From: svferro at gmail.com (Sal) Date: Thu, 11 Dec 2008 10:28:30 -0500 Subject: a hotspot-powered Javascript engine In-Reply-To: <49404B30.90603@sun.com> References: <494037A7.9000201@sun.com> <49404B30.90603@sun.com> Message-ID: On Wed, Dec 10, 2008 at 6:05 PM, Charles Oliver Nutter < charles.nutter at sun.com> wrote: > John Pampuch wrote: > >> My question: Is there any existing project(s) already doing this? I would >>> hate to reinvent the wheel. If not, can any experts on the list give any >>> potential roadblocks/advice to help along the effort? >>> >> You definitely want to look at Rhino from the Mozilla organization. It >> could be a good start. >> > > Rhino needs work, but it would be far easier to get it running fast than > most of the other dynamic languages. I've wanted to try to tackle it myself. > Keep us posted on how it goes if you try it yourself. Thanks for the references to Rhino by the way - I do remember now seeing that project some time back but had forgotten about it. I am looking at their implementation now. From some benchmarks available it seems Rhino works at almost 2x slower than actual Java. My question - is there a theoretical reason for such a slowdown? I have been working with the openjdk hotspot codebase for a little bit now, and pulling the bytecodes from a Javascript AST rather than a Java-generated-classfile would seem fairly straightforward, I don't see reasons yet why performance would fall to 2x - so my guess is the Rhino implementation may need some work - what are others' thoughts? Does something like Javascript on the JVM really have to run that poorly? It was nice to see their implementation, I was planning on actually using some of the Hotspot code out of openjdk directly, dynamically generating the bytecodes in memory directly from Javascript, and compiling/recompiling block of dynamic bytecode in memory to deal with some of the dynamic features for Javascript... this approach might solve some of the performance issues the Rhino engine might be finding. (Also - thanks for the reference to daVinci project! I did come across this earlier, it seems to be a great effort, very well planned that will make a complete environment for new dynamic languages on the JVM. I would love to leverage their work - I just would like to evaluate if it would take more time to complete their platform, then go on with the Javascript effort, or if it would be faster to just less-generically hash in Javascript directly to the Hotspot engine... I will definately look into it more. Any thoughts on this idea too would be great!) Thanks again for all the help/feedback - I will definately keep persons updated on any progress, I'm hoping after all to have an opensource codebase that anyone can integrate into their browser(s) - and I'm thinking that it should be the most performant Javascript engine available if it is implemented correctly. Leveraging something like the JVM technology which has been matured/refined over 20 years, just makes the most sense for something like this, to me! - Sal -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20081211/ea7379bc/attachment.html From Thomas.Rodriguez at Sun.COM Thu Dec 11 09:48:56 2008 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Thu, 11 Dec 2008 09:48:56 -0800 Subject: Request for reviews (XS): 6778657 and 6778662: Patchs from Red Hat In-Reply-To: <1228841498.20039.16.camel@localhost.localdomain> References: <493EA045.4070606@sun.com> <1228841498.20039.16.camel@localhost.localdomain> Message-ID: <000DB728-371C-4DD0-9489-2C5878B8F19F@sun.com> Why isn't defined(_LP64) sufficient? I don't know about S390 but it should be for AMD64 and 64 bit sparc. tom On Dec 9, 2008, at 8:51 AM, Christian Thalinger wrote: > On Tue, 2008-12-09 at 08:43 -0800, Vladimir Kozlov wrote: >> http://webrev.invokedynamic.info/kvn/6778662/index.html >> >> Fixed 6778662: fixes directory search paths. > > Probably I should talk to Gary about that one, but shouldn't SPARC > also > be added here (and MIPS/MIPSEL for Zero)? > > + #if defined(AMD64) || defined(_LP64) && (defined(PPC) || > defined(S390)) > > - Christian > From Vladimir.Kozlov at Sun.COM Thu Dec 11 10:04:28 2008 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Thu, 11 Dec 2008 10:04:28 -0800 Subject: Request for reviews (XS): 6778657 and 6778662: Patchs from Red Hat In-Reply-To: <000DB728-371C-4DD0-9489-2C5878B8F19F@sun.com> References: <493EA045.4070606@sun.com> <1228841498.20039.16.camel@localhost.localdomain> <000DB728-371C-4DD0-9489-2C5878B8F19F@sun.com> Message-ID: <4941562C.50505@sun.com> I will go with #ifdef _LP64 Vladimir Tom Rodriguez wrote: > Why isn't defined(_LP64) sufficient? I don't know about S390 but it > should be for AMD64 and 64 bit sparc. > > tom > > On Dec 9, 2008, at 8:51 AM, Christian Thalinger wrote: > >> On Tue, 2008-12-09 at 08:43 -0800, Vladimir Kozlov wrote: >>> http://webrev.invokedynamic.info/kvn/6778662/index.html >>> >>> Fixed 6778662: fixes directory search paths. >> >> Probably I should talk to Gary about that one, but shouldn't SPARC also >> be added here (and MIPS/MIPSEL for Zero)? >> >> + #if defined(AMD64) || defined(_LP64) && (defined(PPC) || defined(S390)) >> >> - Christian >> > From twisti at complang.tuwien.ac.at Thu Dec 11 10:09:20 2008 From: twisti at complang.tuwien.ac.at (Christian Thalinger) Date: Thu, 11 Dec 2008 19:09:20 +0100 Subject: Request for reviews (XS): 6778657 and 6778662: Patchs from Red Hat In-Reply-To: <000DB728-371C-4DD0-9489-2C5878B8F19F@sun.com> References: <493EA045.4070606@sun.com> <1228841498.20039.16.camel@localhost.localdomain> <000DB728-371C-4DD0-9489-2C5878B8F19F@sun.com> Message-ID: <1229018960.13572.4.camel@localhost.localdomain> On Thu, 2008-12-11 at 09:48 -0800, Tom Rodriguez wrote: > Why isn't defined(_LP64) sufficient? I don't know about S390 but it > should be for AMD64 and 64 bit sparc. I think this is because of multi-/biarch architectures. Architectures that only support 64-bit, like Alpha, don't have /lib64 or /usr/lib64. Their libraries are simply in /lib and /usr/lib. - Christian From Thomas.Rodriguez at Sun.COM Thu Dec 11 10:26:26 2008 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Thu, 11 Dec 2008 10:26:26 -0800 Subject: Request for reviews (XS): 6778657 and 6778662: Patchs from Red Hat In-Reply-To: <1229018960.13572.4.camel@localhost.localdomain> References: <493EA045.4070606@sun.com> <1228841498.20039.16.camel@localhost.localdomain> <000DB728-371C-4DD0-9489-2C5878B8F19F@sun.com> <1229018960.13572.4.camel@localhost.localdomain> Message-ID: That makes sense, though searching those locations when they don't exist doesn't seem that bad. Maybe specifying the exceptions instead of enumerating the platforms where it applies would require fewer changes going forward. It's also more benign when it's wrong. #if defined(_LP64) && !defined(ALPHA) tom On Dec 11, 2008, at 10:09 AM, Christian Thalinger wrote: > On Thu, 2008-12-11 at 09:48 -0800, Tom Rodriguez wrote: >> Why isn't defined(_LP64) sufficient? I don't know about S390 but it >> should be for AMD64 and 64 bit sparc. > > I think this is because of multi-/biarch architectures. Architectures > that only support 64-bit, like Alpha, don't have /lib64 or /usr/lib64. > Their libraries are simply in /lib and /usr/lib. > > - Christian > From Vladimir.Kozlov at Sun.COM Thu Dec 11 14:40:54 2008 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Thu, 11 Dec 2008 14:40:54 -0800 Subject: Request for reviews (XS): 6778657 and 6778662: Patchs from Red Hat In-Reply-To: References: <493EA045.4070606@sun.com> <1228841498.20039.16.camel@localhost.localdomain> <000DB728-371C-4DD0-9489-2C5878B8F19F@sun.com> <1229018960.13572.4.camel@localhost.localdomain> Message-ID: <494196F6.3030601@sun.com> Web search shows that currently only ALPHA and IA64 use /lib for 64-bits libraries. So the check will be: #if defined(_LP64) && !defined(ALPHA) && !defined(IA64) Vladimir Tom Rodriguez wrote: > That makes sense, though searching those locations when they don't exist > doesn't seem that bad. Maybe specifying the exceptions instead of > enumerating the platforms where it applies would require fewer changes > going forward. It's also more benign when it's wrong. > > #if defined(_LP64) && !defined(ALPHA) > > tom > > On Dec 11, 2008, at 10:09 AM, Christian Thalinger wrote: > >> On Thu, 2008-12-11 at 09:48 -0800, Tom Rodriguez wrote: >>> Why isn't defined(_LP64) sufficient? I don't know about S390 but it >>> should be for AMD64 and 64 bit sparc. >> >> I think this is because of multi-/biarch architectures. Architectures >> that only support 64-bit, like Alpha, don't have /lib64 or /usr/lib64. >> Their libraries are simply in /lib and /usr/lib. >> >> - Christian >> > jdk7 changes suggestion: http://webrev.invokedynamic.info/kvn/6778662/ From Igor.Veresov at Sun.COM Thu Dec 11 14:55:23 2008 From: Igor.Veresov at Sun.COM (Igor Veresov) Date: Fri, 12 Dec 2008 01:55:23 +0300 Subject: Request for reviews (XS): 6778657 and 6778662: Patchs from Red Hat In-Reply-To: <494196F6.3030601@sun.com> References: <493EA045.4070606@sun.com> <494196F6.3030601@sun.com> Message-ID: <200812120155.23524.igor.veresov@sun.com> That's not quite true. Some Linux distributions have /lib for 64-bit libs. For example on Gentoo(amd64) I have: lib32, lib64, and lib symlinked to lib64. igor On Friday 12 December 2008 01:40:54 Vladimir Kozlov wrote: > Web search shows that currently only ALPHA and IA64 use > /lib for 64-bits libraries. So the check will be: > > #if defined(_LP64) && !defined(ALPHA) && !defined(IA64) > > Vladimir > > Tom Rodriguez wrote: > > That makes sense, though searching those locations when they don't exist > > doesn't seem that bad. Maybe specifying the exceptions instead of > > enumerating the platforms where it applies would require fewer changes > > going forward. It's also more benign when it's wrong. > > > > #if defined(_LP64) && !defined(ALPHA) > > > > tom > > > > On Dec 11, 2008, at 10:09 AM, Christian Thalinger wrote: > >> On Thu, 2008-12-11 at 09:48 -0800, Tom Rodriguez wrote: > >>> Why isn't defined(_LP64) sufficient? I don't know about S390 but it > >>> should be for AMD64 and 64 bit sparc. > >> > >> I think this is because of multi-/biarch architectures. Architectures > >> that only support 64-bit, like Alpha, don't have /lib64 or /usr/lib64. > >> Their libraries are simply in /lib and /usr/lib. > >> > >> - Christian > > jdk7 changes suggestion: > > http://webrev.invokedynamic.info/kvn/6778662/ From vladimir.kozlov at sun.com Thu Dec 11 23:14:03 2008 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Fri, 12 Dec 2008 07:14:03 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 12 new changesets Message-ID: <20081212071426.65DDCD68A@hg.openjdk.java.net> Changeset: 85f1b9537f70 Author: iveresov Date: 2008-12-03 14:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/85f1b9537f70 6779436: NUMA allocator: libnuma expects certain size of the buffer in numa_node_to_cpus() Summary: In os::Linux::rebuild_cpu_to_node_map() fix the size of the CPU bitmap. Fixed arithmetic in MutableNUMASpace::adaptive_chunk_size() that could cause overflows and underflows of the chunk_size variable. Reviewed-by: apetrusenko ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/runtime/globals.hpp Changeset: ab25f609be4a Author: jmasa Date: 2008-12-04 09:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/ab25f609be4a Merge Changeset: 8a0c882e46d6 Author: jmasa Date: 2008-12-04 13:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/8a0c882e46d6 Merge Changeset: dc16daa0329d Author: poonam Date: 2008-12-04 17:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/dc16daa0329d 6739363: Xcheck jni doesn't check native function arguments Summary: Fix adds support for verifying arguments with -Xcheck:jni. Reviewed-by: coleenp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/includeDB_core ! src/share/vm/includeDB_features ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jniCheck.hpp ! src/share/vm/runtime/javaCalls.cpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 63d1bf926938 Author: poonam Date: 2008-12-04 17:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/63d1bf926938 Merge - src/share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.hpp Changeset: 8724fb00c422 Author: blacklion Date: 2008-12-05 15:06 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/8724fb00c422 Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/includeDB_core Changeset: 2e4f74ff86a1 Author: xdono Date: 2008-12-04 11:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/2e4f74ff86a1 Added tag jdk7-b41 for changeset f9d938ede196 ! .hgtags Changeset: 7cee1a61ffd7 Author: trims Date: 2008-12-05 15:32 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/7cee1a61ffd7 Merge Changeset: 3c4d36b4a7ac Author: trims Date: 2008-12-05 15:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/3c4d36b4a7ac 6781742: Bump HS14 build number to 09 Summary: Update Hotspot 14 build number to b09 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 7b920868b475 Author: coleenp Date: 2008-12-08 15:50 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/7b920868b475 6773838: There is no calling stack for Compiler thread in hs_err file on x86 Summary: On solaris, the inline assembly wasn't being processed. Added volatile to il file fixed it. Reviewed-by: phh, kvn ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/solaris_x86_32.il ! src/os_cpu/solaris_x86/vm/solaris_x86_64.il Changeset: 3ad2b8576c4a Author: coleenp Date: 2008-12-09 09:55 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/3ad2b8576c4a 6689685: Hotspot crash error message should include libraries version Summary: Print out JDK/JRE version that hotspot knows about. Reviewed-by: kamg, blacklion, acorn, alanb ! src/share/vm/utilities/vmError.cpp Changeset: 7b75310e57e2 Author: kvn Date: 2008-12-11 17:20 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/7b75310e57e2 Merge ! src/share/vm/runtime/globals.hpp From Vladimir.Kozlov at Sun.COM Fri Dec 12 20:06:04 2008 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Fri, 12 Dec 2008 20:06:04 -0800 Subject: Request for reviews (XS): 6782820: Server VM fails with "unhandled implicit exception in compiled code" Message-ID: <494334AC.3020906@sun.com> http://webrev.invokedynamic.info/kvn/6782820/index.html Fixed 6782820: Server VM fails with "unhandled implicit exception in compiled code" Problem: Regression introduced by the fix for 6773078. LoadKlass node without control edge moved above the oop NULL check. Note, during parsing LoadKlass node's control edge is not set because it will be set during CCP phase when a CastPP is removed. Solution: Restore the code which sets a control edge for a klass load node. Add the code which sets a control edge for a klass narrow load node instead of DecodeN node to fix 6773078 bug. Add the assert to check that a DecodeN node does not have a control edge (for 6773078). Reviewed by: Fix verified (y/n): y, both tests from 6773078 and 6782820 Other testing: JPRT, CTW (with -XX:+UseCompressedOops) From twisti at complang.tuwien.ac.at Sat Dec 13 01:41:35 2008 From: twisti at complang.tuwien.ac.at (Christian Thalinger) Date: Sat, 13 Dec 2008 10:41:35 +0100 Subject: Request for reviews (XS): 6778657 and 6778662: Patchs from Red Hat In-Reply-To: <200812120155.23524.igor.veresov@sun.com> References: <493EA045.4070606@sun.com> <494196F6.3030601@sun.com> <200812120155.23524.igor.veresov@sun.com> Message-ID: <1229161295.26273.0.camel@localhost.localdomain> On Fri, 2008-12-12 at 01:55 +0300, Igor Veresov wrote: > That's not quite true. Some Linux distributions have /lib for 64-bit libs. For > example on Gentoo(amd64) I have: lib32, lib64, and lib symlinked to lib64. Hmm, right. On Linux some architectures default to 64-bits. - Christian From vladimir.kozlov at sun.com Tue Dec 16 15:15:02 2008 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Tue, 16 Dec 2008 23:15:02 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6782820: Server VM fails with "unhandled implicit exception in compiled code" Message-ID: <20081216231504.059D4D9A0@hg.openjdk.java.net> Changeset: dd70dd4c91de Author: kvn Date: 2008-12-16 12:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/dd70dd4c91de 6782820: Server VM fails with "unhandled implicit exception in compiled code" Summary: Restore the code which sets a control edge for a klass load node. Reviewed-by: never ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/macro.cpp From Vladimir.Kozlov at Sun.COM Thu Dec 18 10:41:56 2008 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Thu, 18 Dec 2008 10:41:56 -0800 Subject: Request for reviews (XS): 6787050: assert(n->in(0) == 0L, "no control") with UseCompressedOops on sparcv9 Message-ID: <494A9974.5070509@sun.com> http://webrev.invokedynamic.info/kvn/6787050/index.html Fixed 6787050: assert(n->in(0) == 0L,"no control") with UseCompressedOops on sparcv9 Problem: Regression introduced by the fix for 6782820. DecodeN could be pinned (has control edge) on platforms (Sparc) where it can't be fold into the address expression. Solution: Relax the assert for such platforms. Reviewed by: Fix verified (y/n): y Other testing: JPRT From vladimir.kozlov at sun.com Thu Dec 18 13:51:15 2008 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Thu, 18 Dec 2008 21:51:15 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6787050: assert(n->in(0) == 0L, "no control") with UseCompressedOops on sparcv9 Message-ID: <20081218215117.6C22BDA9B@hg.openjdk.java.net> Changeset: 5496e074077f Author: kvn Date: 2008-12-18 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/5496e074077f 6787050: assert(n->in(0) == 0L,"no control") with UseCompressedOops on sparcv9 Summary: Relax the assert for Sparc. Reviewed-by: never ! src/share/vm/opto/compile.cpp From john.coomes at sun.com Thu Dec 18 23:56:27 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Dec 2008 07:56:27 +0000 Subject: hg: jdk7/hotspot-comp: 3 new changesets Message-ID: <20081219075627.3F7D4DB35@hg.openjdk.java.net> Changeset: 60aab86966e9 Author: ohair Date: 2008-12-05 17:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/60aab86966e9 6781784: Fix ant link in build readme Reviewed-by: michaelm ! README-builds.html Changeset: 94052b872873 Author: xdono Date: 2008-12-15 10:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/94052b872873 Merge Changeset: 848e684279d2 Author: xdono Date: 2008-12-18 21:33 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/848e684279d2 Added tag jdk7-b42 for changeset 94052b872873 ! .hgtags From john.coomes at sun.com Thu Dec 18 23:58:22 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Dec 2008 07:58:22 +0000 Subject: hg: jdk7/hotspot-comp/corba: 2 new changesets Message-ID: <20081219075825.0A7BDDB3A@hg.openjdk.java.net> Changeset: ccd6a16502e0 Author: xdono Date: 2008-12-15 16:55 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/ccd6a16502e0 6785258: Update copyright year Summary: Update copyright for files that have been modified starting July 2008 to Dec 2008 Reviewed-by: katleman, ohair, tbell ! make/common/Defs-windows.gmk ! make/common/shared/Compiler-msvc.gmk Changeset: 9cd740d48a48 Author: xdono Date: 2008-12-18 21:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/9cd740d48a48 Added tag jdk7-b42 for changeset ccd6a16502e0 ! .hgtags From john.coomes at sun.com Fri Dec 19 00:03:41 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Dec 2008 08:03:41 +0000 Subject: hg: jdk7/hotspot-comp/jaxp: Added tag jdk7-b42 for changeset 036e0dca841a Message-ID: <20081219080344.33708DB3F@hg.openjdk.java.net> Changeset: 96fe28d4a913 Author: xdono Date: 2008-12-18 21:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/96fe28d4a913 Added tag jdk7-b42 for changeset 036e0dca841a ! .hgtags From john.coomes at sun.com Fri Dec 19 00:05:40 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Dec 2008 08:05:40 +0000 Subject: hg: jdk7/hotspot-comp/jaxws: Added tag jdk7-b42 for changeset 621c02d83abc Message-ID: <20081219080543.28CCFDB44@hg.openjdk.java.net> Changeset: 1ad2f51564db Author: xdono Date: 2008-12-18 21:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/1ad2f51564db Added tag jdk7-b42 for changeset 621c02d83abc ! .hgtags From john.coomes at sun.com Fri Dec 19 00:07:52 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Dec 2008 08:07:52 +0000 Subject: hg: jdk7/hotspot-comp/jdk: 15 new changesets Message-ID: <20081219081059.82971DB49@hg.openjdk.java.net> Changeset: 4f985ba72055 Author: sherman Date: 2008-11-19 14:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/4f985ba72055 6714428: 'os.name' system property shows wrong value on 64-bit Windows XP Summary: update to detect the correct os.name for 64-bit XP Reviewed-by: darcy ! src/windows/native/java/lang/java_props_md.c Changeset: 098e456e860e Author: emcmanus Date: 2008-11-20 10:10 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/098e456e860e 6772779: @NotificationInfo does not create MBeanNotificationInfo in the MBean's MBeanInfo 6773593: CompositeDataSupport constructor javadoc is not in sync with the implementation Reviewed-by: sjiang ! src/share/classes/com/sun/jmx/interceptor/DefaultMBeanServerInterceptor.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanIntrospector.java ! src/share/classes/javax/management/openmbean/CompositeDataSupport.java ! test/javax/management/Introspector/AnnotatedNotificationInfoTest.java Changeset: 9df22bc448a3 Author: sherman Date: 2008-11-20 14:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/9df22bc448a3 6745216: missing 4 chraset aliases in sun.nio.cs package Summary: added "834" into x-IBM834's aliase list. Reviewed-by: alanb ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java Changeset: 97e2e87aa035 Author: dfuchs Date: 2008-11-21 18:18 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/97e2e87aa035 6774170: LocalRMIServerSocketFactory should protect against ServerSocket.accept().getInetAddress() being null Reviewed-by: emcmanus, jfdenise ! src/share/classes/sun/management/jmxremote/LocalRMIServerSocketFactory.java + test/sun/management/jmxremote/LocalRMIServerSocketFactoryTest.java Changeset: ce2d0938ea27 Author: tbell Date: 2008-11-21 20:53 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/ce2d0938ea27 Merge Changeset: d7b0a715bd3b Author: martin Date: 2008-11-23 09:56 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/d7b0a715bd3b 6775152: freetype version check program problem main arg order Summary: Fix all compiler warnings Reviewed-by: ohair, tbell ! make/common/shared/Sanity.gmk Changeset: 31cb1c17f524 Author: mullan Date: 2008-11-25 10:17 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/31cb1c17f524 6728890: Add SwissSign root certificates to the JDK 6732157: Add VeriSign TSA Root Cert to the JDK 6754779: Add Camerfirma root certificates to the JDK 6768559: Add t-systems root CA certificate (Deutsche Telekom Root CA 2) to the JRE Reviewed-by: vinnie ! test/lib/security/cacerts/VerifyCACerts.java Changeset: b1620482689a Author: sherman Date: 2008-11-25 10:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/b1620482689a 6774710: spp.sh used by genBasic.sh/genCopyDirectMemory.sh Summary: update the scripts to use java version of spp Reviewed-by: alanb ! test/java/nio/Buffer/genBasic.sh ! test/java/nio/Buffer/genCopyDirectMemory.sh Changeset: b7c47f49a53d Author: alanb Date: 2008-11-25 19:26 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/b7c47f49a53d 6593946: (bf) X-Buffer.compact() does not discard mark as specified Summary: InvalidMarkException now correctly thrown. Thanks to keiths at redhat.com for the bug report and initial fix. Reviewed-by: sherman, darcy ! src/share/classes/java/nio/Buffer.java ! src/share/classes/java/nio/ByteBufferAs-X-Buffer.java ! src/share/classes/java/nio/Direct-X-Buffer.java ! src/share/classes/java/nio/Heap-X-Buffer.java ! test/java/nio/Buffer/Basic-X.java ! test/java/nio/Buffer/Basic.java ! test/java/nio/Buffer/BasicByte.java ! test/java/nio/Buffer/BasicChar.java ! test/java/nio/Buffer/BasicDouble.java ! test/java/nio/Buffer/BasicFloat.java ! test/java/nio/Buffer/BasicInt.java ! test/java/nio/Buffer/BasicLong.java ! test/java/nio/Buffer/BasicShort.java ! test/java/nio/Buffer/genBasic.sh Changeset: a0709a172b6d Author: chegar Date: 2008-11-26 15:37 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/a0709a172b6d 6720866: Slow performance using HttpURLConnection for upload Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/ChunkedOutputStream.java Changeset: 24a31530683d Author: emcmanus Date: 2008-11-27 15:44 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/24a31530683d 6776225: JMX.isNotificationSource wrong when DynamicWrapperMBean + SendNotification injection Reviewed-by: dfuchs, jfdenise ! src/share/classes/com/sun/jmx/mbeanserver/MBeanIntrospector.java ! src/share/classes/javax/management/JMX.java ! src/share/classes/javax/management/StandardEmitterMBean.java ! src/share/classes/javax/management/StandardMBean.java ! test/javax/management/MBeanServer/DynamicWrapperMBeanTest.java Changeset: 3d110bb4dc19 Author: sherman Date: 2008-11-29 20:55 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/3d110bb4dc19 6725399: (ch) Channels.newInputStream should check for null Summary: update to check null arg for all Channels methods Reviewed-by: alanb ! src/share/classes/java/nio/channels/Channels.java ! test/java/nio/channels/Channels/Basic.java Changeset: d782143219d6 Author: tbell Date: 2008-12-05 09:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/d782143219d6 Merge Changeset: 3ef0bdfa7609 Author: xdono Date: 2008-12-15 16:55 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/3ef0bdfa7609 6785258: Update copyright year Summary: Update copyright for files that have been modified starting July 2008 to Dec 2008 Reviewed-by: katleman, ohair, tbell ! make/javax/swing/Makefile ! make/netbeans/jmx/build.xml ! make/sun/net/spi/Makefile ! make/sun/net/spi/nameservice/Makefile ! src/share/classes/com/sun/java/swing/SwingUtilities3.java ! src/share/classes/com/sun/java/swing/plaf/windows/DesktopProperty.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsDesktopManager.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsInternalFrameTitlePane.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsScrollBarUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTabbedPaneUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTableHeaderUI.java ! src/share/classes/com/sun/jmx/defaults/ServiceName.java ! src/share/classes/com/sun/jmx/mbeanserver/ClassLoaderRepositorySupport.java ! src/share/classes/com/sun/jmx/mbeanserver/ObjectInputStreamWithLoader.java ! src/share/classes/com/sun/jmx/mbeanserver/SecureClassLoaderRepository.java ! src/share/classes/com/sun/jmx/mbeanserver/WeakIdentityHashMap.java ! src/share/classes/com/sun/jmx/remote/internal/ArrayNotificationBuffer.java ! src/share/classes/com/sun/jmx/remote/internal/Unmarshal.java ! src/share/classes/com/sun/jmx/remote/util/ClassLoaderWithRepository.java ! src/share/classes/com/sun/jmx/remote/util/ClassLogger.java ! src/share/classes/com/sun/jmx/remote/util/OrderClassLoaders.java ! src/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java ! src/share/classes/java/awt/EventDispatchThread.java ! src/share/classes/java/net/HttpURLConnection.java ! src/share/classes/java/nio/Buffer.java ! src/share/classes/java/nio/channels/SelectableChannel.java ! src/share/classes/java/nio/channels/spi/AbstractSelectableChannel.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/javax/management/ClientContext.java ! src/share/classes/javax/management/DefaultLoaderRepository.java ! src/share/classes/javax/management/JMRuntimeException.java ! src/share/classes/javax/management/MBeanAttributeInfo.java ! src/share/classes/javax/management/MBeanConstructorInfo.java ! src/share/classes/javax/management/MBeanInfo.java ! src/share/classes/javax/management/Notification.java ! src/share/classes/javax/management/NotificationListener.java ! src/share/classes/javax/management/loading/DefaultLoaderRepository.java ! src/share/classes/javax/management/loading/MLetObjectInputStream.java ! src/share/classes/javax/management/modelmbean/ModelMBeanInfo.java ! src/share/classes/javax/management/openmbean/OpenMBeanParameterInfoSupport.java ! src/share/classes/javax/management/relation/MBeanServerNotificationFilter.java ! src/share/classes/javax/management/relation/Role.java ! src/share/classes/javax/management/relation/RoleList.java ! src/share/classes/javax/management/relation/RoleResult.java ! src/share/classes/javax/management/relation/RoleUnresolved.java ! src/share/classes/javax/management/relation/RoleUnresolvedList.java ! src/share/classes/javax/management/remote/rmi/NoCallStackClassLoader.java ! src/share/classes/javax/management/remote/rmi/RMIConnection.java ! src/share/classes/javax/management/remote/rmi/RMIServerImpl.java ! src/share/classes/javax/swing/AbstractCellEditor.java ! src/share/classes/javax/swing/AbstractListModel.java ! src/share/classes/javax/swing/AbstractSpinnerModel.java ! src/share/classes/javax/swing/ActionMap.java ! src/share/classes/javax/swing/AncestorNotifier.java ! src/share/classes/javax/swing/ArrayTable.java ! src/share/classes/javax/swing/ButtonGroup.java ! src/share/classes/javax/swing/DefaultBoundedRangeModel.java ! src/share/classes/javax/swing/DefaultButtonModel.java ! src/share/classes/javax/swing/DefaultFocusManager.java ! src/share/classes/javax/swing/DefaultSingleSelectionModel.java ! src/share/classes/javax/swing/GroupLayout.java ! src/share/classes/javax/swing/InputMap.java ! src/share/classes/javax/swing/JDesktopPane.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JMenuItem.java ! src/share/classes/javax/swing/JSpinner.java ! src/share/classes/javax/swing/JTextField.java ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/KeyboardManager.java ! src/share/classes/javax/swing/LayoutComparator.java ! src/share/classes/javax/swing/LayoutFocusTraversalPolicy.java ! src/share/classes/javax/swing/LegacyGlueFocusTraversalPolicy.java ! src/share/classes/javax/swing/MultiUIDefaults.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/javax/swing/SortingFocusTraversalPolicy.java ! src/share/classes/javax/swing/SpringLayout.java ! src/share/classes/javax/swing/Timer.java ! src/share/classes/javax/swing/TimerQueue.java ! src/share/classes/javax/swing/UIDefaults.java ! src/share/classes/javax/swing/UIManager.java ! src/share/classes/javax/swing/border/CompoundBorder.java ! src/share/classes/javax/swing/plaf/basic/BasicButtonListener.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxEditor.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java ! src/share/classes/javax/swing/plaf/basic/BasicGraphicsUtils.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/basic/BasicLabelUI.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuUI.java ! src/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java ! src/share/classes/javax/swing/plaf/basic/BasicRadioButtonUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSplitPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToggleButtonUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java ! src/share/classes/javax/swing/plaf/basic/DragRecognitionSupport.java ! src/share/classes/javax/swing/plaf/basic/LazyActionMap.java ! src/share/classes/javax/swing/plaf/metal/DefaultMetalTheme.java ! src/share/classes/javax/swing/plaf/metal/MetalBumps.java ! src/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java ! src/share/classes/javax/swing/plaf/metal/MetalInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/metal/MetalRadioButtonUI.java ! src/share/classes/javax/swing/plaf/metal/MetalSliderUI.java ! src/share/classes/javax/swing/plaf/metal/MetalToolBarUI.java ! src/share/classes/javax/swing/plaf/synth/DefaultSynthStyleFactory.java ! src/share/classes/javax/swing/plaf/synth/ImagePainter.java ! src/share/classes/javax/swing/plaf/synth/Region.java ! src/share/classes/javax/swing/plaf/synth/SynthButtonUI.java ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java ! src/share/classes/javax/swing/plaf/synth/SynthContext.java ! src/share/classes/javax/swing/plaf/synth/SynthEditorPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java ! src/share/classes/javax/swing/plaf/synth/SynthParser.java ! src/share/classes/javax/swing/plaf/synth/SynthStyle.java ! src/share/classes/javax/swing/plaf/synth/SynthTextAreaUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java ! src/share/classes/javax/swing/table/AbstractTableModel.java ! src/share/classes/javax/swing/table/DefaultTableModel.java ! src/share/classes/javax/swing/text/AsyncBoxView.java ! src/share/classes/javax/swing/text/ComponentView.java ! src/share/classes/javax/swing/text/DefaultCaret.java ! src/share/classes/javax/swing/text/DefaultFormatter.java ! src/share/classes/javax/swing/text/DefaultHighlighter.java ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/ElementIterator.java ! src/share/classes/javax/swing/text/GapContent.java ! src/share/classes/javax/swing/text/InternationalFormatter.java ! src/share/classes/javax/swing/text/LayoutQueue.java ! src/share/classes/javax/swing/text/MaskFormatter.java ! src/share/classes/javax/swing/text/SegmentCache.java ! src/share/classes/javax/swing/text/SimpleAttributeSet.java ! src/share/classes/javax/swing/text/StringContent.java ! src/share/classes/javax/swing/text/StyleContext.java ! src/share/classes/javax/swing/text/TableView.java ! src/share/classes/javax/swing/text/TextAction.java ! src/share/classes/javax/swing/text/TextLayoutStrategy.java ! src/share/classes/javax/swing/text/ZoneView.java ! src/share/classes/javax/swing/text/html/HRuleView.java ! src/share/classes/javax/swing/text/html/HTML.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/text/html/HTMLWriter.java ! src/share/classes/javax/swing/text/html/Map.java ! src/share/classes/javax/swing/text/html/MinimalHTMLWriter.java ! src/share/classes/javax/swing/text/html/OptionListModel.java ! src/share/classes/javax/swing/text/html/StyleSheet.java ! src/share/classes/javax/swing/text/html/TableView.java ! src/share/classes/javax/swing/text/html/parser/TagStack.java ! src/share/classes/javax/swing/text/rtf/MockAttributeSet.java ! src/share/classes/javax/swing/text/rtf/RTFParser.java ! src/share/classes/javax/swing/text/rtf/RTFReader.java ! src/share/classes/javax/swing/tree/DefaultTreeCellEditor.java ! src/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/share/classes/javax/swing/tree/FixedHeightLayoutCache.java ! src/share/classes/javax/swing/tree/VariableHeightLayoutCache.java ! src/share/classes/javax/swing/undo/StateEdit.java ! src/share/classes/javax/swing/undo/UndoManager.java ! src/share/classes/javax/swing/undo/UndoableEditSupport.java ! src/share/classes/org/jcp/xml/dsig/internal/DigesterOutputStream.java ! src/share/classes/org/jcp/xml/dsig/internal/SignerOutputStream.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheCanonicalizer.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheNodeSetData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheOctetStreamData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMBase64Transform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14NMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalizationMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCryptoBinary.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMDigestMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMEnvelopedTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMExcC14NMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMHMACSignatureMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfo.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfoFactory.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyName.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyValue.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMManifest.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMPGPData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperties.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperty.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMStructure.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSubTreeData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMURIDereferencer.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMUtils.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509Data.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509IssuerSerial.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLObject.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignatureFactory.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXSLTTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/Utils.java ! src/share/classes/sun/awt/im/CompositionArea.java ! src/share/classes/sun/management/jmxremote/LocalRMIServerSocketFactory.java ! src/share/classes/sun/net/ProgressEvent.java ! src/share/classes/sun/net/httpserver/ExchangeImpl.java ! src/share/classes/sun/net/httpserver/FixedLengthInputStream.java ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/www/protocol/https/HttpsURLConnectionImpl.java ! src/share/classes/sun/nio/ch/AbstractPollSelectorImpl.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/share/classes/sun/swing/AccessibleMethod.java ! src/share/classes/sun/swing/SwingLazyValue.java ! src/share/classes/sun/swing/SwingUtilities2.java ! src/share/classes/sun/swing/plaf/synth/DefaultSynthStyle.java ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java ! src/share/classes/sun/util/calendar/ZoneInfo.java ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java ! src/share/native/sun/font/bidi/ubidi.c ! src/solaris/classes/sun/net/www/protocol/http/NTLMAuthentication.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java ! test/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.sh ! test/java/nio/Buffer/Basic-X.java ! test/java/nio/Buffer/Basic.java ! test/java/nio/Buffer/BasicByte.java ! test/java/nio/Buffer/BasicChar.java ! test/java/nio/Buffer/BasicDouble.java ! test/java/nio/Buffer/BasicFloat.java ! test/java/nio/Buffer/BasicInt.java ! test/java/nio/Buffer/BasicLong.java ! test/java/nio/Buffer/BasicShort.java ! test/java/nio/Buffer/genBasic.sh ! test/java/nio/Buffer/genCopyDirectMemory.sh ! test/java/nio/channels/Channels/Basic.java ! test/java/util/TimeZone/OldIDMappingTest.sh ! test/javax/management/Introspector/AnnotationTest.java ! test/javax/management/MBeanServer/MBeanExceptionTest.java ! test/javax/management/context/ContextTest.java ! test/javax/management/context/LocaleTest.java ! test/javax/management/context/LocalizableTest.java ! test/javax/management/context/localizable/MBeanDescriptions_fr.java ! test/javax/management/context/localizable/Whatsit.java ! test/javax/management/context/localizable/WhatsitMBean.java ! test/javax/management/remote/mandatory/provider/ProviderTest.java ! test/javax/management/remote/mandatory/subjectDelegation/SimpleStandard.java ! test/javax/swing/RepaintManager/6608456/bug6608456.java ! test/javax/swing/text/html/HRuleView/Test5062055.java ! test/javax/xml/crypto/dsig/GenerationTests.java Changeset: 51a20a7ee9c8 Author: xdono Date: 2008-12-18 21:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/51a20a7ee9c8 Added tag jdk7-b42 for changeset 3ef0bdfa7609 ! .hgtags From john.coomes at sun.com Fri Dec 19 00:15:53 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Dec 2008 08:15:53 +0000 Subject: hg: jdk7/hotspot-comp/langtools: 6 new changesets Message-ID: <20081219081603.D8A7CDB4E@hg.openjdk.java.net> Changeset: 1d1f34b36535 Author: mcimadamore Date: 2008-11-26 11:07 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/1d1f34b36535 6776289: Regression: javac7 doesnt resolve method calls properly Summary: Superclass' private methods shouldn't be considered during method resolution Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/generics/6711619/T6711619a.out + test/tools/javac/overload/T6776289.java Changeset: 6210fb7e7544 Author: jjg Date: 2008-12-01 12:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/6210fb7e7544 6778493: Fix (langtools) ant build to honor fcs MILESTONE setting Reviewed-by: ohair Contributed-by: mjw at redhat.com ! make/Makefile Changeset: 4674298aaf3b Author: tbell Date: 2008-12-05 09:52 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/4674298aaf3b Merge Changeset: fdfed22db054 Author: xdono Date: 2008-12-15 16:55 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/fdfed22db054 6785258: Update copyright year Summary: Update copyright for files that have been modified starting July 2008 to Dec 2008 Reviewed-by: katleman, ohair, tbell ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/javac/comp/Todo.java ! src/share/classes/com/sun/tools/javac/util/JavacMessages.java ! src/share/classes/com/sun/tools/javac/util/LayoutCharacters.java ! src/share/classes/com/sun/tools/javac/util/MandatoryWarningHandler.java ! src/share/classes/com/sun/tools/javadoc/JavadocTodo.java ! src/share/classes/com/sun/tools/javadoc/Main.java ! src/share/classes/com/sun/tools/javadoc/Start.java ! src/share/classes/javax/tools/FileObject.java ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/lib/JavadocTester.java ! test/com/sun/javadoc/testSupplementary/TestSupplementary.java ! test/tools/apt/Basics/print.sh ! test/tools/apt/Compile/compile.sh ! test/tools/apt/Discovery/discovery.sh ! test/tools/apt/mirror/declaration/AnnoMirror.java ! test/tools/apt/mirror/declaration/AnnoTypeDecl.java ! test/tools/apt/mirror/declaration/AnnoTypeElemDecl.java ! test/tools/apt/mirror/declaration/AnnoVal.java ! test/tools/apt/mirror/declaration/ClassDecl.java ! test/tools/apt/mirror/declaration/ConstExpr.java ! test/tools/apt/mirror/declaration/ConstructorDecl.java ! test/tools/apt/mirror/declaration/EnumDecl.java ! test/tools/apt/mirror/declaration/FieldDecl.java ! test/tools/apt/mirror/declaration/GetAnno.java ! test/tools/apt/mirror/declaration/InterfaceDecl.java ! test/tools/apt/mirror/declaration/MethodDecl.java ! test/tools/apt/mirror/declaration/PackageDecl.java ! test/tools/apt/mirror/declaration/ParameterDecl.java ! test/tools/apt/mirror/type/AnnoTyp.java ! test/tools/apt/mirror/type/ArrayTyp.java ! test/tools/apt/mirror/type/ClassTyp.java ! test/tools/apt/mirror/type/EnumTyp.java ! test/tools/apt/mirror/type/InterfaceTyp.java ! test/tools/apt/mirror/type/PrimitiveTyp.java ! test/tools/apt/mirror/type/TypeVar.java ! test/tools/apt/mirror/type/WildcardTyp.java ! test/tools/apt/mirror/util/Overrides.java ! test/tools/apt/mirror/util/TypeCreation.java ! test/tools/javac/6457284/T6457284.java ! test/tools/javac/links/T.java ! test/tools/javac/links/links.sh ! test/tools/javac/policy/test1/A.java ! test/tools/javac/policy/test1/D.java ! test/tools/javac/policy/test1/Test1a.java ! test/tools/javac/processing/6348193/T6348193.java ! test/tools/javadoc/BooleanConst.java ! test/tools/javadoc/BreakIteratorWarning.java ! test/tools/javadoc/FlagsTooEarly.java ! test/tools/javadoc/InlineTagsWithBraces.java ! test/tools/javadoc/LangVers.java ! test/tools/javadoc/MethodLinks.java ! test/tools/javadoc/NoStar.java ! test/tools/javadoc/T4994049/T4994049.java ! test/tools/javadoc/XWerror.java ! test/tools/javadoc/completionFailure/CompletionFailure.java ! test/tools/javadoc/dupOk/DupOk.java ! test/tools/javadoc/imports/MissingImport.java ! test/tools/javadoc/lib/Tester.java ! test/tools/javadoc/nestedClass/NestedClass.java ! test/tools/javadoc/sourceOnly/p/SourceOnly.java ! test/tools/javadoc/sourceOption/SourceOption.java ! test/tools/javadoc/subpackageIgnore/SubpackageIgnore.java Changeset: 5e5567c2db56 Author: xdono Date: 2008-12-15 17:13 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/5e5567c2db56 Merge Changeset: b044af4939c9 Author: xdono Date: 2008-12-18 21:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/b044af4939c9 Added tag jdk7-b42 for changeset 5e5567c2db56 ! .hgtags From vladimir.kozlov at sun.com Mon Dec 22 13:25:33 2008 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Mon, 22 Dec 2008 21:25:33 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 21 new changesets Message-ID: <20081222212613.C6DEFDD85@hg.openjdk.java.net> Changeset: 24fda36852ce Author: coleenp Date: 2008-12-10 15:14 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/24fda36852ce 6727377: VM stack guard pages on Windows should PAGE_READWRITE not PAGE_EXECUTE_READWRITE Summary: Make reguard_stack change access to RW, not execute and use os::protect_memory with the new parameter when change needed to X. Reviewed-by: acorn, jcoomes ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp Changeset: a7fac4381b50 Author: blacklion Date: 2008-12-11 03:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/a7fac4381b50 6639341: sometimes contended-exit event comes after contended-entered on another thread Summary: DTrace probe "contended-exit" should be fired before unparking object, or context could be lost. Probe firing was moved to proper place. Reviewed-by: coleenp, kamg ! src/share/vm/runtime/synchronizer.cpp Changeset: 06d2c3204df4 Author: blacklion Date: 2008-12-12 10:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/06d2c3204df4 Merge Changeset: d249b360e026 Author: ysr Date: 2008-12-10 23:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/d249b360e026 6782457: CMS: Livelock in CompactibleFreeListSpace::block_size() 6736295: SIGSEGV in product jvm, assertion "these are the only valid states during a mark sweep" in fastdebug Summary: Restructured the code in the perm gen allocation retry loop so as to avoid "safepoint-blocking" on locks, in this case the Heap_lock, while holding uninitialized allocated heap storage. Reviewed-by: apetrusenko, iveresov, jcoomes, jmasa, poonam ! src/share/vm/memory/permGen.cpp Changeset: 7d7a7c599c17 Author: jcoomes Date: 2008-12-11 12:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/7d7a7c599c17 6578152: fill_region_with_object has usability and safety issues Reviewed-by: apetrusenko, ysr ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/parNew/parGCAllocBuffer.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/includeDB_gc ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/sharedHeap.hpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/tenuredGeneration.cpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/arrayOop.hpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.hpp ! src/share/vm/runtime/globals.hpp Changeset: 7c2386d67889 Author: jcoomes Date: 2008-12-11 12:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/7c2386d67889 6765745: par compact - allow young gen spaces to be split Reviewed-by: jmasa ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp Changeset: 0f773163217d Author: jcoomes Date: 2008-12-11 12:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/0f773163217d 6765954: par compact - stress mode for splitting young gen spaces Reviewed-by: jmasa ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: ffe19141e312 Author: jmasa Date: 2008-12-12 15:37 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/ffe19141e312 Merge ! src/share/vm/runtime/globals.hpp Changeset: ac8fe14c93e4 Author: never Date: 2008-12-12 19:53 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/ac8fe14c93e4 6767587: missing call to make_not_entrant after deoptimizing for patching volatiles Reviewed-by: rasbold, kvn ! src/share/vm/c1/c1_Runtime1.cpp Changeset: a738a625039a Author: never Date: 2008-12-12 19:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/a738a625039a 6757316: load_constant() produces a wrong long constant, with high a low words swapped Reviewed-by: rasbold, jrose, kvn ! src/share/vm/c1/c1_LIRGenerator.cpp + test/compiler/6757316/Test6757316.java Changeset: 80206b8a9128 Author: never Date: 2008-12-12 19:55 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/80206b8a9128 6758234: if (k cond (a ? : b: c)) returns reversed answer if k is constant and b and c are longs Reviewed-by: kvn, jrose ! src/share/vm/c1/c1_Optimizer.cpp + test/compiler/6758234/Test6758234.java Changeset: 2494ab195856 Author: swamyv Date: 2008-12-15 13:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/2494ab195856 6653214: MemoryPoolMXBean.setUsageThreshold() does not support large heap sizes. Reviewed-by: ysr, mchung ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/services/management.cpp Changeset: 6c345e1c5992 Author: kvn Date: 2008-12-17 14:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/6c345e1c5992 Merge Changeset: eb811d2ef72e Author: kvn Date: 2008-12-18 13:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/eb811d2ef72e Merge Changeset: d593294016c3 Author: jcoomes Date: 2008-12-18 01:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/d593294016c3 6786195: many nsk.monitoring tests fail with -server -Xcomp Summary: remove Universe::_fillerArrayKlassObj and associated code Reviewed-by: jmasa, tonyp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp Changeset: 234c22e54b98 Author: jcoomes Date: 2008-12-18 10:53 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/234c22e54b98 6784849: par compact - can fail when to_space is non-empty Reviewed-by: jmasa, tonyp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp Changeset: b27c885f75f9 Author: jcoomes Date: 2008-12-18 10:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/b27c885f75f9 6786188: par compact - "SplitALot" stress mode should fill to_space Reviewed-by: jmasa, tonyp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp Changeset: 7aadaf46ecd7 Author: jmasa Date: 2008-12-19 12:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/7aadaf46ecd7 Merge Changeset: c6065343356f Author: poonam Date: 2008-12-18 17:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/c6065343356f 6786340: hs14b09a pit: a lot of tests failed in "-server -Xcomp" on solaris-amd64 using fastdebug bits Summary: Fixes the nsk-jdi PIT failures introduced by fix for 6739363 Reviewed-by: kvn, coleenp ! src/share/vm/runtime/javaCalls.cpp Changeset: 8a25d96bcf08 Author: xlu Date: 2008-12-19 14:40 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/8a25d96bcf08 6784100: getTimeNanos - CAS reduction Summary: Get rid of the CAS loop in getTimeNanos to reduce coherence traffic on Solaris. Reviewed-by: acorn, kvn, ysr ! src/os/solaris/vm/os_solaris.cpp Changeset: ca7d48236048 Author: xlu Date: 2008-12-20 00:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/ca7d48236048 Merge From linuxhippy at gmail.com Mon Dec 22 14:06:35 2008 From: linuxhippy at gmail.com (Clemens Eisserer) Date: Mon, 22 Dec 2008 23:06:35 +0100 Subject: Optimizing saturated casts Message-ID: <194f62550812221406k24f9000cy4a3792c2cd89ae75@mail.gmail.com> Hi, I currently use an utility-class heavily for the XRender Java2D backend, which performs saturated casts: 1.) return (short) (x > Short.MAX_VALUE ? Short.MAX_VALUE : (x < Short.MIN_VALUE ? Short.MIN_VALUE : x)); 2.) return (short) (x > 65535 ? 65535 : (x < 0) ? 0 : x); I spent quite some time benchmarking/tuning the protocol-generation-methods, and a lot of cycles are spent in those saturated casts, even if the utility methods are static. E.g. XRenderFillRectangle takes 40 cycles without clamping, but already 70 cycles with on my core2duo with hotspot-server/jdk 14.0. Hotspot seems to solve the problem always with conditional jumps, although well predictable ones. Modern processors seem to have support for this kind of operation, in x86 there's packssdw in MMX/SSE2. I think something like a saturated cast could be quite useful, there are already cast-methods in Long/Integer/Short - what do you think about adding saturated casts to that API? Those could be instrified to use MMX/SSE2 if available. If that would be too specific how hard would it be to add this kind of optimization to hotspot? How far does SIMD support in hotspot go (I read some time ago there've been some optimizations), if SIMD would be supported 4 casts could be done in a single cycle :) Thanks, Clemens From vladimir.kozlov at sun.com Mon Dec 22 18:09:07 2008 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Tue, 23 Dec 2008 02:09:07 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6778657: Casts in SharedRuntime::f2i, f2l, d2i and d2l rely on undefined C++ behaviour Message-ID: <20081223020909.1ECFCDDC6@hg.openjdk.java.net> Changeset: 6d8fc951eb25 Author: kvn Date: 2008-12-22 15:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/6d8fc951eb25 6778657: Casts in SharedRuntime::f2i, f2l, d2i and d2l rely on undefined C++ behaviour Summary: Replaces SharedRuntime::f2i et al with versions that should work Reviewed-by: never Contributed-by: gbenson at redhat.com ! src/share/vm/runtime/sharedRuntime.cpp + test/compiler/6778657/Test.java From vladimir.kozlov at sun.com Mon Dec 22 20:53:27 2008 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Tue, 23 Dec 2008 04:53:27 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6778662: fixes 64-bits libraries directory search paths on linux Message-ID: <20081223045329.E4601DDCF@hg.openjdk.java.net> Changeset: 9656bebe85a7 Author: kvn Date: 2008-12-22 16:53 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/9656bebe85a7 6778662: fixes 64-bits libraries directory search paths on linux Summary: Fixes 64-bits libraries directory search paths. Reviewed-by: never Contributed-by: langel at redhat.com ! src/os/linux/vm/os_linux.cpp From fw at deneb.enyo.de Sat Dec 27 13:07:57 2008 From: fw at deneb.enyo.de (Florian Weimer) Date: Sat, 27 Dec 2008 22:07:57 +0100 Subject: Optimizing saturated casts In-Reply-To: <194f62550812221406k24f9000cy4a3792c2cd89ae75@mail.gmail.com> (Clemens Eisserer's message of "Mon, 22 Dec 2008 23:06:35 +0100") References: <194f62550812221406k24f9000cy4a3792c2cd89ae75@mail.gmail.com> Message-ID: <87k59ls4wi.fsf@mid.deneb.enyo.de> * Clemens Eisserer: > I currently use an utility-class heavily for the XRender Java2D > backend, which performs saturated casts: > > 1.) return (short) (x > Short.MAX_VALUE ? Short.MAX_VALUE : (x < > Short.MIN_VALUE ? Short.MIN_VALUE : x)); > 2.) return (short) (x > 65535 ? 65535 : (x < 0) ? 0 : x); > > I spent quite some time benchmarking/tuning the > protocol-generation-methods, and a lot of cycles are spent in those > saturated casts, even if the utility methods are static. > E.g. XRenderFillRectangle takes 40 cycles without clamping, but > already 70 cycles with on my core2duo with hotspot-server/jdk 14.0. > Hotspot seems to solve the problem always with conditional jumps, > although well predictable ones. Have you tried Math.min/Math.max? They should avoid those jumps using cmov. Using SSE2 is probably only efficient if the arguments are already in SSE registers (which means some form of vectorization, I guess). > Modern processors seem to have support for this kind of operation, in > x86 there's packssdw in MMX/SSE2. > I think something like a saturated cast could be quite useful, there > are already cast-methods in Long/Integer/Short - what do you think > about adding saturated casts to that API? > Those could be instrified to use MMX/SSE2 if available. I would also like to see (taken from Hacker's Delight): static boolean carry(int a, int b) { return (a ^ b ^ (a + b)) < 0; } static boolean borrow(int a, int b) { return (a ^ b ^ (a - b)) < 0; } static boolean overflow(int a, int b) { return ((~(a ^ b)) & ((x + y) ^ x)) < 0; } static boolean underflow(int a, int b) { return ((x ^ y) & ((x - y) ^ x)) < 0; } All properly intrinsified (in both int and long variants), so that int c = a + b; if (Integer.carry(a, b)) throw new OverflowException(); performs the addition just once on x86 and uses jc. This would enable reasonably cost-effective integer overflow checking for languages running on top of the JVM. Browsing through Hacker's Delight, unsigned int multiplication and access to the upper half of the multiplication result might be useful, too. From fw at deneb.enyo.de Sat Dec 27 13:28:15 2008 From: fw at deneb.enyo.de (Florian Weimer) Date: Sat, 27 Dec 2008 22:28:15 +0100 Subject: hg: jdk7/hotspot-comp/hotspot: 6778657: Casts in SharedRuntime::f2i, f2l, d2i and d2l rely on undefined C++ behaviour In-Reply-To: <20081223020909.1ECFCDDC6@hg.openjdk.java.net> (vladimir kozlov's message of "Tue, 23 Dec 2008 02:09:07 +0000") References: <20081223020909.1ECFCDDC6@hg.openjdk.java.net> Message-ID: <87fxk9s3yo.fsf@mid.deneb.enyo.de> * vladimir kozlov: > 6778657: Casts in SharedRuntime::f2i, f2l, d2i and d2l rely on undefined C++ behaviour > Summary: Replaces SharedRuntime::f2i et al with versions that should work This: JRT_LEAF(jlong, SharedRuntime::f2l(jfloat x)) - if (g_isnan(x)) {return 0;} - jlong lltmp = (jlong)x; - if (lltmp != min_jlong) { - return lltmp; - } else { - if (x < 0) { - return min_jlong; - } else { - return max_jlong; - } - } + if (g_isnan(x)) + return 0; + if (x >= (jfloat) max_jlong) + return max_jlong; + if (x <= (jfloat) min_jlong) + return min_jlong; + return (jlong) x; JRT_END doesn't look right because (jfloat) max_jlong and (jfloat) min_jlong are not fully specified, either (they can be off by one, and so the comparison could be false even if the subsequent cast is undefined).