Request for reviews (XS): 6778657 and 6778662: Patchs from Red Hat

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Thu Dec 11 14:40:54 PST 2008


Web search shows that currently only ALPHA and IA64 use
/lib for 64-bits libraries. So the check will be:

#if defined(_LP64) && !defined(ALPHA) && !defined(IA64)

Vladimir

Tom Rodriguez wrote:
> That makes sense, though searching those locations when they don't exist 
> doesn't seem that bad.  Maybe specifying the exceptions instead of 
> enumerating the platforms where it applies would require fewer changes 
> going forward.  It's also more benign when it's wrong.
> 
> #if defined(_LP64) && !defined(ALPHA)
> 
> tom
> 
> On Dec 11, 2008, at 10:09 AM, Christian Thalinger wrote:
> 
>> On Thu, 2008-12-11 at 09:48 -0800, Tom Rodriguez wrote:
>>> Why isn't defined(_LP64) sufficient?  I don't know about S390 but it
>>> should be for AMD64 and 64 bit sparc.
>>
>> I think this is because of multi-/biarch architectures.  Architectures
>> that only support 64-bit, like Alpha, don't have /lib64 or /usr/lib64.
>> Their libraries are simply in /lib and /usr/lib.
>>
>> - Christian
>>
> 
jdk7 changes suggestion:

http://webrev.invokedynamic.info/kvn/6778662/



More information about the hotspot-compiler-dev mailing list