review (S) for 6717150

Chuck Rasbold Chuck.Rasbold at Sun.COM
Mon Oct 13 14:22:39 PDT 2008


On 10/13/08 14:15, Christian Thalinger wrote:
> On Mon, 2008-10-13 at 11:07 -0700, Chuck Rasbold wrote:
>> http://webrev.invokedynamic.info/rasbold/6717150
>>
>> 6717150: improper constant folding of subnormal strictfp multiplications 
>> and divides
>> Summary: suppress constant folding of double divides and multiplications 
>> on ia32
>> Reviewed-by:
>>
>> This workaround fix is already in HS13, needs to be brought forward
>> into HS14.  We should do a more elegant fix in the future.
> 
> Hi Chuck!
> 
> IMHO there is a typo in the comment of src/share/vm/opto/divnode.cpp:
> "multiplication" should read "division".  Just to not confuse people who
> are trying to understand that code.
> 

Christian -

Indeed.  I will make that change.

Thanks.

-- Chuck

> - Christian
> 




More information about the hotspot-compiler-dev mailing list