From chuck.rasbold at sun.com Tue Sep 2 09:14:05 2008 From: chuck.rasbold at sun.com (chuck.rasbold at sun.com) Date: Tue, 02 Sep 2008 16:14:05 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6 new changesets Message-ID: <20080902161417.55384D078@hg.openjdk.java.net> Changeset: 1e5d20c34408 Author: tonyp Date: 2008-08-19 17:55 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/1e5d20c34408 6736341: PermGen size is insufficient for jconsole Summary: Removing two buggy methods that should not be used, but ended up being used due to a re-organization in the class hierarchy. Reviewed-by: jmasa, ysr, kamg, coleenp ! src/share/vm/memory/compactingPermGenGen.cpp ! src/share/vm/memory/compactingPermGenGen.hpp Changeset: 331eaa715e58 Author: ysr Date: 2008-08-20 11:23 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/331eaa715e58 Merge Changeset: bfcb639d5bca Author: ysr Date: 2008-08-20 15:41 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/bfcb639d5bca 6739357: CMS: Switch off CMSPrecleanRefLists1 until 6722113 can be fixed Summary: Temporarily switch off the precleaning of Reference lists completely until related issues are fixed in 6722113. Reviewed-by: jmasa, poonam, tonyp ! src/share/vm/runtime/globals.hpp Changeset: 387a62b4be60 Author: jmasa Date: 2008-08-20 23:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/387a62b4be60 6728478: Assertion at parallel promotion from young to old generation Summary: The fix avoids a call to address_for_index() in this particular situation where it is not known if the passed index is in bounds. Reviewed-by: tonyp ! src/share/vm/gc_implementation/parNew/parGCAllocBuffer.cpp ! src/share/vm/memory/blockOffsetTable.hpp Changeset: 58eb97387b90 Author: ysr Date: 2008-08-25 12:16 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/58eb97387b90 Merge Changeset: cf6f0e32e518 Author: rasbold Date: 2008-09-02 06:55 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/cf6f0e32e518 Merge - src/cpu/x86/vm/assembler_x86_32.cpp - src/cpu/x86/vm/assembler_x86_32.hpp - src/cpu/x86/vm/assembler_x86_32.inline.hpp - src/cpu/x86/vm/assembler_x86_64.cpp - src/cpu/x86/vm/assembler_x86_64.hpp - src/cpu/x86/vm/assembler_x86_64.inline.hpp - src/os_cpu/linux_x86/vm/assembler_linux_x86_32.cpp - src/os_cpu/linux_x86/vm/assembler_linux_x86_64.cpp - src/os_cpu/solaris_x86/vm/assembler_solaris_x86_32.cpp - src/os_cpu/solaris_x86/vm/assembler_solaris_x86_64.cpp - src/os_cpu/windows_x86/vm/assembler_windows_x86_32.cpp - src/os_cpu/windows_x86/vm/assembler_windows_x86_64.cpp From Thomas.Rodriguez at Sun.COM Tue Sep 2 13:35:49 2008 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 02 Sep 2008 13:35:49 -0700 Subject: review (XS) for 6738933 Message-ID: http://webrev.invokedynamic.info/never/6738933/ From thomas.rodriguez at sun.com Tue Sep 2 17:17:47 2008 From: thomas.rodriguez at sun.com (thomas.rodriguez at sun.com) Date: Wed, 03 Sep 2008 00:17:47 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6738933: assert with base pointers must match with compressed oops enabled Message-ID: <20080903001751.BD975D14D@hg.openjdk.java.net> Changeset: 60bc5071073f Author: never Date: 2008-09-02 15:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/60bc5071073f 6738933: assert with base pointers must match with compressed oops enabled Reviewed-by: kvn, rasbold ! src/share/vm/opto/loopopts.cpp From Thomas.Rodriguez at Sun.COM Wed Sep 3 14:43:09 2008 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 03 Sep 2008 14:43:09 -0700 Subject: review (XS) for 6744422 Message-ID: <2C592F4A-4977-42B2-B65C-F4B971DEFA0B@sun.com> http://webrev.invokedynamic.info/never/6744422 From chuck.rasbold at sun.com Thu Sep 4 14:13:40 2008 From: chuck.rasbold at sun.com (chuck.rasbold at sun.com) Date: Thu, 04 Sep 2008 21:13:40 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 5 new changesets Message-ID: <20080904211352.E72F7D287@hg.openjdk.java.net> Changeset: 25c3145237c6 Author: poonam Date: 2008-08-27 22:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/25c3145237c6 6731958: Include all the SA classes into sa-jdi.jar Summary: sa-jdi.jar bundled with JDK should include all the SA classes. Reviewed-by: swamyv ! agent/make/build-pkglist ! make/linux/makefiles/sa.make ! make/sa.files ! make/solaris/makefiles/sa.make ! make/windows/makefiles/sa.make Changeset: 9223f5bb0bf7 Author: poonam Date: 2008-08-28 18:17 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/9223f5bb0bf7 Merge Changeset: a10808f5a4b5 Author: dcubed Date: 2008-09-02 08:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/a10808f5a4b5 Merge Changeset: 3a26e9e4be71 Author: never Date: 2008-09-03 14:57 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/3a26e9e4be71 6744422: incorrect handling of -1 in set_jump_destination Reviewed-by: rasbold ! src/cpu/x86/vm/nativeInst_x86.hpp Changeset: cdbee661c7da Author: rasbold Date: 2008-09-04 09:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/cdbee661c7da Merge From Vladimir.Kozlov at Sun.COM Fri Sep 5 09:53:58 2008 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Fri, 05 Sep 2008 09:53:58 -0700 Subject: Request for reviews (XS): 6676462: JVM sometimes would suddenly consume significant amount of memory Message-ID: <48C16426.70401@sun.com> http://webrev.invokedynamic.info/kvn/6676462/index.html Fixed 6676462: JVM sometimes would suddenly consume significant amount of memory Problem: This is forward port to hs14 of the fix in 1.6 and 1.5 JDK. Missing dead loop checks in AddNode::Ideal(). Solution: Add missing dead loop checks. Reviewed by: Fix verified (y/n): y, tested with fix in 1.5. Other testing: JPRT Note: I don't think it could happen in 1.6 and 7 jdk because of the dead loops elimination changes in 1.6. And all related bug reports filed for 1.5 jdk. But changes are small and safe. So I am not against them. Thanks, Vladimir From vladimir.kozlov at sun.com Fri Sep 5 16:30:01 2008 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Fri, 05 Sep 2008 23:30:01 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6676462: JVM sometimes would suddenly consume significant amount of memory Message-ID: <20080905233006.6CE40D340@hg.openjdk.java.net> Changeset: 2b73d212b1fd Author: kvn Date: 2008-09-05 13:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/2b73d212b1fd 6676462: JVM sometimes would suddenly consume significant amount of memory Summary: Add asserts with dead loop checks in AddNode::Ideal(). Reviewed-by: never ! src/share/vm/opto/addnode.cpp From yamauchi at google.com Mon Sep 8 17:37:09 2008 From: yamauchi at google.com (Hiroshi Yamauchi) Date: Mon, 8 Sep 2008 17:37:09 -0700 Subject: Server compiler crash Message-ID: Hi, I encountered a server compiler crash which happens in a Google server. Unfortunately, my attempt to create a small test for the crash wasn't successful. If I extracted the method from the server code, the crash didn't happen. Also, the -Xcomp option did not trigger the crash in the server. So, it seems to happen only when inlining is applied and/or profile data is used for compilation. But it happens consistently and deterministically in the server. The method that triggers this crash during its compilation has 132 lines of code (588 bytes) and 4 loops (two of them are nested loops) without considering inlining. I ran it with many versions of JDKs and found that it happens with 6u4 and all the way up to the Mercurial master forest (from last Friday). It doesn't happen with 6u1 and 6u3. The only JVM option that is critical to trigger this crash is "-server". This crash can be suppressed by -XX:-SplitIfBlocks or the patch below. The following is more details about the crash. The crash message: # To suppress the following error report, specify this argument # after -XX: or in .hotspotrc: SuppressErrorAt=/loopnode.hpp:634 # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (/home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.hpp:634), pid=20501, tid=3470654384 # Error: assert(n != __null,"Bad immediate dominator info.") # # Java VM: OpenJDK Server VM (14.0-b03-fastdebug mixed mode linux-x86 ) # An error report file with more information is saved as: The stack trace from gdb: #0 0xffffe410 in __kernel_vsyscall () #1 0x4af1fc51 in raise () from /lib/tls/i686/cmov/libc.so.6 #2 0x4af21619 in abort () from /lib/tls/i686/cmov/libc.so.6 #3 0xf778aeb0 in os::abort (dump_core=4160507393) at /home/yamauchi/ws/jdk7/hotspot/src/os/linux/vm/os_linux.cpp:1456 #4 0xf78f9d6e in VMError::report_and_die (this=0xcef4d2d0) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/utilities/vmError.cpp:824 #5 0xf74aa12b in report_assertion_failure () at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/utilities/debug.cpp:173 #6 0xf76fa612 in PhaseIdealLoop::idom_no_update (this=0xcef4e1ec, d=0x8b51b30) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.hpp:634 #7 0xf76fa6b0 in PhaseIdealLoop::idom (this=0xcef4e1ec, d=0x8b51b30) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.hpp:644 #8 0xf7845f1c in PhaseIdealLoop::spinup (this=0xcef4e1ec, iff_dom=0x8ba68b0, new_false=0x81db03c, new_true=0x81db180, use_blk=0x8b51b30, def=0x81da760, cache=0xcef4d4b0) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/split_if.cpp:256 #9 0xf7846361 in PhaseIdealLoop::handle_use (this=0xcef4e1ec, use=0x81d9fac, def=0x81da760, cache=0xcef4d4b0, region_dom=0x8ba68b0, new_false=0x81db03c, new_true=0x81db180, old_false=0x8ba7e40, old_true=0x8ba7dec) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/split_if.cpp:370 #10 0xf7846bc9 in PhaseIdealLoop::do_split_if (this=0xcef4e1ec, iff=0x8ba7d94) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/split_if.cpp:512 #11 0xf770aaeb in PhaseIdealLoop::split_if_with_blocks_post (this=0xcef4e1ec, n=0x8ba7cfc) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopopts.cpp:803 #12 0xf770b441 in PhaseIdealLoop::split_if_with_blocks (this=0xcef4e1ec, visited=0xcef4da14, nstack=0xcef4d9ec) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopopts.cpp:978 #13 0xf7705737 in PhaseIdealLoop::PhaseIdealLoop (this=0xcef4e1ec, igvn=0xcef4de40, verify_me=0x0, do_split_ifs=4145916929) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.cpp:1574 #14 0xf7461980 in Compile::Optimize (this=0xcef4eaa8) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/compile.cpp:1597 #15 0xf7464a85 in Compile::Compile (this=0xcef4eaa8, ci_env=0xcef4ef98, compiler=0x816dd00, target=0x8698368, osr_bci=-1, subsume_loads=3472156161, do_escape_analysis=4155553280) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/compile.cpp:614 #16 0xf73c4f14 in C2Compiler::compile_method (this=0x816dd00, env=, target=0x8698368, entry_bci=-1) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/c2compiler.cpp:110 #17 0xf746c75e in CompileBroker::invoke_compiler_on_method (task=0x8ea3bd8) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/compiler/compileBroker.cpp:1537 #18 0xf746ce63 in CompileBroker::compiler_thread_loop () at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/compiler/compileBroker.cpp:1389 #19 0xf78a8fbe in compiler_thread_entry (thread=0x817dc00, __the_thread__=0x817dc00) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/runtime/thread.cpp:2711 #20 0xf78aa998 in JavaThread::thread_main_inner (this=0x817dc00) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/runtime/thread.cpp:1374 #21 0xf78aaaf3 in JavaThread::run (this=0x817dc00) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/runtime/thread.cpp:1358 #22 0xf778cb27 in java_start (thread=0x817dc00) at /home/yamauchi/ws/jdk7/hotspot/src/os/linux/vm/os_linux.cpp:779 #23 0x4b15e3a8 in start_thread () from /lib/tls/i686/cmov/libpthread.so.0 #24 0x4afc27fe in clone () from /lib/tls/i686/cmov/libc.so.6 (gdb) f 6 #6 0xf76fa612 in PhaseIdealLoop::idom_no_update (this=0xcef4e1ec, d=0x8b51b30) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.hpp:634 634 /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.hpp: No such file or directory. in /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.hpp (gdb) print *d $9 = {_vptr.Node = 0xf7b3e9e8, _in = 0xce031bbc, _out = 0xcdf644b8, _cnt = , _max = , _outcnt = , _outmax = , _idx = , _class_id = 56, _flags = 0, NotAMachineReg = , _in_dump_cnt = , _debug_idx = -2146001392, _debug_orig = 0x0, _hash_lock = 0, _last_del = 0x81d9e30, _del_tick = } (gdb) print (int)d->_idx $10 = 0 (gdb) f 9 #9 0xf7846361 in PhaseIdealLoop::handle_use (this=0xcef4e1ec, use=0x81d9fac, def=0x81da760, cache=0xcef4d4b0, region_dom=0x8ba68b0, new_false=0x81db03c, new_true=0x81db180, old_false=0x8ba7e40, old_true=0x8ba7dec) at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/split_if.cpp:370 370 /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/split_if.cpp: No such file or directory. in /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/split_if.cpp (gdb) print *use_blk $11 = {_vptr.Node = 0xf7b3e9e8, _in = 0xce031bbc, _out = 0xcdf644b8, _cnt = , _max = , _outcnt = , _outmax = , _idx = , _class_id = 56, _flags = 0, NotAMachineReg = , _in_dump_cnt = , _debug_idx = -2146001392, _debug_orig = 0x0, _hash_lock = 0, _last_del = 0x81d9e30, _del_tick = } (gdb) print (int)use_blk->_idx $12 = 0 A patch that suppresses the crash (on a recent jdk7 master workspace): diff --git a/src/share/vm/opto/loopnode.hpp b/src/share/vm/opto/loopnode.hpp --- a/src/share/vm/opto/loopnode.hpp +++ b/src/share/vm/opto/loopnode.hpp @@ -853,6 +853,8 @@ // Helpers for filtered type const TypeInt* filtered_type_from_dominators( Node* val, Node *val_ctrl); + bool detectCrashEarly(Node* region); + // Helper functions void register_new_node( Node *n, Node *blk ); Node *spinup( Node *iff, Node *new_false, Node *new_true, Node *region, Node *phi, small_cache *cache ); diff --git a/src/share/vm/opto/loopopts.cpp b/src/share/vm/opto/loopopts.cpp --- a/src/share/vm/opto/loopopts.cpp +++ b/src/share/vm/opto/loopopts.cpp @@ -698,6 +698,61 @@ : u_loop->_head->in(LoopNode::EntryControl); } +// Detect a crash early +// +// A crash (assertion failure) happens in +// hotspot/src/share/vm/opto/loopnode.hpp:634. The following is what +// I think is happening. +// +// The node passed as the parameter to idom_no_update() has index +// zero, meaning it's the root node of the graph. Because the root +// does not have an immediate dominator, the _idom array has NULL for +// index zero, which causes a null pointer dereference at the above +// crash point. +// +// That is caused by the existence of a bad use node coming into the +// if-splitting optimization. It's the very node that would later be +// passed to idom_no_update() and cause the above crash. Specifically +// the find_use_block() call on the bad use node (and the get_ctrl() +// call in it) in PhaseIdealLoop::handle_use() in +// hotspot/src/share/vm/opto/split_if.cpp:365 returns the same node as +// the above root node, which seems wrong because find_use_block() +// should return the control node (the basic block) that the use node +// belongs to and the root node isn't likely to be that block. +// +// This function looks for the above bad use node early before the +// if-splitting transformation occurs along with other sanity checks +// so that we can bail out of the particular if-splitting. +// +// The bad use node first appears at the two levels down from the +// region node against which the if-splitting is attempted. +// +// This function does what would happen right before the crash point +// by calling get_ctrl() and checking the idom array for the bad +// use node. +// +bool PhaseIdealLoop::detectCrashEarly(Node* region) { + for (DUIterator ii = region->outs(); region->has_out(ii); ii++) { + Node* node = region->out(ii); + if (node->is_Phi()) { + for (DUIterator jj = node->outs(); node->has_out(jj); jj++) { + Node* use = node->out(jj); + if (!use->is_CFG() && !use->is_Phi()) { + for (DUIterator kk = use->outs(); use->has_out(kk); kk++) { + Node* use2 = use->out(kk); + if (!use2->is_CFG() && !use2->is_Phi()) { + Node* use2_blk = get_ctrl(use2); + if (_idom[use2_blk->_idx] == NULL) { + return true; + } + } + } + } + } + } + } +} + //------------------------------split_if_with_blocks_post---------------------- // Do the real work in a non-recursive function. CFG hackery wants to be @@ -728,6 +783,11 @@ assert( bol->is_Bool(), "expect a bool here" ); if( bol->outcnt() != 1 ) return;// Multiple branches from 1 compare? Node *iff = bol->unique_out(); + + // Bail out if a crash condition is detected + if (iff->in(0) != NULL && detectCrashEarly(iff->in(0))) { + return; + } // Check some safety conditions if( iff->is_If() ) { // Classic split-if? It'd be great if server compiler experts can suggest how to diagnose this issue. Alternatively, if this is a known issue, please advise a better fix. Thanks, Hiroshi From Thomas.Rodriguez at Sun.COM Tue Sep 9 07:33:10 2008 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 09 Sep 2008 07:33:10 -0700 Subject: Server compiler crash In-Reply-To: References: Message-ID: <5B2F1C29-CDEA-417E-AB1D-4072130E2CF0@sun.com> Could you dump the graph at the point you detect that there would be an error if you did a split if? You can call dump(999) on any of the nodes involved and it will dump the entire graph. That would help us figure out what's wrong with the graph. We'd also need to idx of the phi that's being processed. tom On Sep 8, 2008, at 5:37 PM, Hiroshi Yamauchi wrote: > Hi, > > I encountered a server compiler crash which happens in a Google > server. > > Unfortunately, my attempt to create a small test for the crash wasn't > successful. If I extracted > the method from the server code, the crash didn't happen. Also, the > -Xcomp option did > not trigger the crash in the server. So, it seems to happen only when > inlining is applied and/or > profile data is used for compilation. But it happens consistently and > deterministically in the server. > > The method that triggers this crash during its compilation has 132 > lines of code (588 bytes) > and 4 loops (two of them are nested loops) without considering > inlining. > > I ran it with many versions of JDKs and found that it happens with 6u4 > and all the way up to > the Mercurial master forest (from last Friday). It doesn't happen with > 6u1 and 6u3. > > The only JVM option that is critical to trigger this crash is > "-server". This crash can be suppressed > by -XX:-SplitIfBlocks or the patch below. > > The following is more details about the crash. > > The crash message: > > # To suppress the following error report, specify this argument > # after -XX: or in .hotspotrc: SuppressErrorAt=/loopnode.hpp:634 > # > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error > (/home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.hpp:634), > pid=20501, tid=3470654384 > # Error: assert(n != __null,"Bad immediate dominator info.") > # > # Java VM: OpenJDK Server VM (14.0-b03-fastdebug mixed mode linux- > x86 ) > # An error report file with more information is saved as: > > > > > The stack trace from gdb: > > #0 0xffffe410 in __kernel_vsyscall () > #1 0x4af1fc51 in raise () from /lib/tls/i686/cmov/libc.so.6 > #2 0x4af21619 in abort () from /lib/tls/i686/cmov/libc.so.6 > #3 0xf778aeb0 in os::abort (dump_core=4160507393) at > /home/yamauchi/ws/jdk7/hotspot/src/os/linux/vm/os_linux.cpp:1456 > #4 0xf78f9d6e in VMError::report_and_die (this=0xcef4d2d0) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/utilities/vmError.cpp:824 > #5 0xf74aa12b in report_assertion_failure () at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/utilities/debug.cpp:173 > #6 0xf76fa612 in PhaseIdealLoop::idom_no_update (this=0xcef4e1ec, > d=0x8b51b30) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.hpp:634 > #7 0xf76fa6b0 in PhaseIdealLoop::idom (this=0xcef4e1ec, d=0x8b51b30) > at /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.hpp:644 > #8 0xf7845f1c in PhaseIdealLoop::spinup (this=0xcef4e1ec, > iff_dom=0x8ba68b0, new_false=0x81db03c, new_true=0x81db180, > use_blk=0x8b51b30, def=0x81da760, cache=0xcef4d4b0) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/split_if.cpp:256 > #9 0xf7846361 in PhaseIdealLoop::handle_use (this=0xcef4e1ec, > use=0x81d9fac, def=0x81da760, cache=0xcef4d4b0, region_dom=0x8ba68b0, > new_false=0x81db03c, new_true=0x81db180, old_false=0x8ba7e40, > old_true=0x8ba7dec) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/split_if.cpp:370 > #10 0xf7846bc9 in PhaseIdealLoop::do_split_if (this=0xcef4e1ec, > iff=0x8ba7d94) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/split_if.cpp:512 > #11 0xf770aaeb in PhaseIdealLoop::split_if_with_blocks_post > (this=0xcef4e1ec, n=0x8ba7cfc) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopopts.cpp:803 > #12 0xf770b441 in PhaseIdealLoop::split_if_with_blocks > (this=0xcef4e1ec, visited=0xcef4da14, nstack=0xcef4d9ec) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopopts.cpp:978 > #13 0xf7705737 in PhaseIdealLoop::PhaseIdealLoop (this=0xcef4e1ec, > igvn=0xcef4de40, verify_me=0x0, do_split_ifs=4145916929) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.cpp:1574 > #14 0xf7461980 in Compile::Optimize (this=0xcef4eaa8) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/compile.cpp:1597 > #15 0xf7464a85 in Compile::Compile (this=0xcef4eaa8, > ci_env=0xcef4ef98, compiler=0x816dd00, target=0x8698368, osr_bci=-1, > subsume_loads=3472156161, do_escape_analysis=4155553280) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/compile.cpp:614 > #16 0xf73c4f14 in C2Compiler::compile_method (this=0x816dd00, > env=, target=0x8698368, entry_bci=-1) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/c2compiler.cpp:110 > #17 0xf746c75e in CompileBroker::invoke_compiler_on_method > (task=0x8ea3bd8) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/compiler/ > compileBroker.cpp:1537 > #18 0xf746ce63 in CompileBroker::compiler_thread_loop () at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/compiler/ > compileBroker.cpp:1389 > #19 0xf78a8fbe in compiler_thread_entry (thread=0x817dc00, > __the_thread__=0x817dc00) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/runtime/thread.cpp:2711 > #20 0xf78aa998 in JavaThread::thread_main_inner (this=0x817dc00) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/runtime/thread.cpp:1374 > #21 0xf78aaaf3 in JavaThread::run (this=0x817dc00) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/runtime/thread.cpp:1358 > #22 0xf778cb27 in java_start (thread=0x817dc00) at > /home/yamauchi/ws/jdk7/hotspot/src/os/linux/vm/os_linux.cpp:779 > #23 0x4b15e3a8 in start_thread () from /lib/tls/i686/cmov/ > libpthread.so.0 > #24 0x4afc27fe in clone () from /lib/tls/i686/cmov/libc.so.6 > (gdb) f 6 > #6 0xf76fa612 in PhaseIdealLoop::idom_no_update (this=0xcef4e1ec, > d=0x8b51b30) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.hpp:634 > 634 /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.hpp: No > such file or directory. > in /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/loopnode.hpp > (gdb) print *d > $9 = {_vptr.Node = 0xf7b3e9e8, _in = 0xce031bbc, _out = 0xcdf644b8, > _cnt = , _max = , _outcnt = , > _outmax = , _idx = , _class_id = 56, _flags = > 0, NotAMachineReg = , _in_dump_cnt = > , _debug_idx = -2146001392, _debug_orig > = 0x0, _hash_lock = 0, _last_del = 0x81d9e30, _del_tick = type>} > (gdb) print (int)d->_idx > $10 = 0 > (gdb) f 9 > #9 0xf7846361 in PhaseIdealLoop::handle_use (this=0xcef4e1ec, > use=0x81d9fac, def=0x81da760, cache=0xcef4d4b0, region_dom=0x8ba68b0, > new_false=0x81db03c, new_true=0x81db180, old_false=0x8ba7e40, > old_true=0x8ba7dec) at > /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/split_if.cpp:370 > 370 /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/split_if.cpp: No > such file or directory. > in /home/yamauchi/ws/jdk7/hotspot/src/share/vm/opto/split_if.cpp > (gdb) print *use_blk > $11 = {_vptr.Node = 0xf7b3e9e8, _in = 0xce031bbc, _out = 0xcdf644b8, > _cnt = , _max = , _outcnt = , > _outmax = , _idx = , _class_id = 56, _flags = > 0, NotAMachineReg = , _in_dump_cnt = > , _debug_idx = -2146001392, _debug_orig > = 0x0, _hash_lock = 0, _last_del = 0x81d9e30, _del_tick = type>} > (gdb) print (int)use_blk->_idx > $12 = 0 > > > > > A patch that suppresses the crash (on a recent jdk7 master workspace): > > diff --git a/src/share/vm/opto/loopnode.hpp b/src/share/vm/opto/ > loopnode.hpp > --- a/src/share/vm/opto/loopnode.hpp > +++ b/src/share/vm/opto/loopnode.hpp > @@ -853,6 +853,8 @@ > // Helpers for filtered type > const TypeInt* filtered_type_from_dominators( Node* val, Node > *val_ctrl); > > + bool detectCrashEarly(Node* region); > + > // Helper functions > void register_new_node( Node *n, Node *blk ); > Node *spinup( Node *iff, Node *new_false, Node *new_true, Node > *region, Node *phi, small_cache *cache ); > diff --git a/src/share/vm/opto/loopopts.cpp b/src/share/vm/opto/ > loopopts.cpp > --- a/src/share/vm/opto/loopopts.cpp > +++ b/src/share/vm/opto/loopopts.cpp > @@ -698,6 +698,61 @@ > : u_loop->_head->in(LoopNode::EntryControl); > } > > +// Detect a crash early > +// > +// A crash (assertion failure) happens in > +// hotspot/src/share/vm/opto/loopnode.hpp:634. The following is what > +// I think is happening. > +// > +// The node passed as the parameter to idom_no_update() has index > +// zero, meaning it's the root node of the graph. Because the root > +// does not have an immediate dominator, the _idom array has NULL for > +// index zero, which causes a null pointer dereference at the above > +// crash point. > +// > +// That is caused by the existence of a bad use node coming into the > +// if-splitting optimization. It's the very node that would later be > +// passed to idom_no_update() and cause the above crash. Specifically > +// the find_use_block() call on the bad use node (and the get_ctrl() > +// call in it) in PhaseIdealLoop::handle_use() in > +// hotspot/src/share/vm/opto/split_if.cpp:365 returns the same node > as > +// the above root node, which seems wrong because find_use_block() > +// should return the control node (the basic block) that the use node > +// belongs to and the root node isn't likely to be that block. > +// > +// This function looks for the above bad use node early before the > +// if-splitting transformation occurs along with other sanity checks > +// so that we can bail out of the particular if-splitting. > +// > +// The bad use node first appears at the two levels down from the > +// region node against which the if-splitting is attempted. > +// > +// This function does what would happen right before the crash point > +// by calling get_ctrl() and checking the idom array for the bad > +// use node. > +// > +bool PhaseIdealLoop::detectCrashEarly(Node* region) { > + for (DUIterator ii = region->outs(); region->has_out(ii); ii++) { > + Node* node = region->out(ii); > + if (node->is_Phi()) { > + for (DUIterator jj = node->outs(); node->has_out(jj); jj++) { > + Node* use = node->out(jj); > + if (!use->is_CFG() && !use->is_Phi()) { > + for (DUIterator kk = use->outs(); use->has_out(kk); kk++) { > + Node* use2 = use->out(kk); > + if (!use2->is_CFG() && !use2->is_Phi()) { > + Node* use2_blk = get_ctrl(use2); > + if (_idom[use2_blk->_idx] == NULL) { > + return true; > + } > + } > + } > + } > + } > + } > + } > +} > + > > //------------------------------ > split_if_with_blocks_post---------------------- > // Do the real work in a non-recursive function. CFG hackery wants > to be > @@ -728,6 +783,11 @@ > assert( bol->is_Bool(), "expect a bool here" ); > if( bol->outcnt() != 1 ) return;// Multiple branches from 1 > compare? > Node *iff = bol->unique_out(); > + > + // Bail out if a crash condition is detected > + if (iff->in(0) != NULL && detectCrashEarly(iff->in(0))) { > + return; > + } > > // Check some safety conditions > if( iff->is_If() ) { // Classic split-if? > > > > It'd be great if server compiler experts can suggest how to diagnose > this issue. > Alternatively, if this is a known issue, please advise a better fix. > > Thanks, > Hiroshi From Thomas.Rodriguez at Sun.COM Tue Sep 9 11:30:14 2008 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 09 Sep 2008 11:30:14 -0700 Subject: review (XS) for 6746320 Message-ID: <406AC8FF-2889-4144-8523-C1AB4F21161A@Sun.COM> http://webrev.invokedynamic.info/never/6746320 From thomas.rodriguez at sun.com Tue Sep 9 15:48:53 2008 From: thomas.rodriguez at sun.com (thomas.rodriguez at sun.com) Date: Tue, 09 Sep 2008 22:48:53 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6746320: Hotspot regression test for 6512111 fails in -Xmixed mode Message-ID: <20080909224856.E6D34D655@hg.openjdk.java.net> Changeset: 6e7305abe64c Author: never Date: 2008-09-09 12:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/6e7305abe64c 6746320: Hotspot regression test for 6512111 fails in -Xmixed mode Reviewed-by: kvn ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp From chuck.rasbold at sun.com Wed Sep 10 08:34:15 2008 From: chuck.rasbold at sun.com (chuck.rasbold at sun.com) Date: Wed, 10 Sep 2008 15:34:15 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 5 new changesets Message-ID: <20080910153425.6CFA0D6EB@hg.openjdk.java.net> Changeset: 5251a9cd8eb8 Author: jcoomes Date: 2008-08-27 15:41 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/5251a9cd8eb8 6742207: jdk7 32-bit windows build failed running pack200 Summary: 6730514 inadvertently disabled perm gen expansion; reenable Reviewed-by: ysr ! src/share/vm/memory/compactingPermGenGen.cpp ! src/share/vm/memory/compactingPermGenGen.hpp Changeset: 5967ae2171f6 Author: xdono Date: 2008-08-28 11:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/5967ae2171f6 Added tag jdk7-b34 for changeset 5251a9cd8eb8 ! .hgtags Changeset: 5c7c20a84e41 Author: trims Date: 2008-09-04 18:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/5c7c20a84e41 6745064: Update Hotspot build number for HS14 Summary: Bump build number for hs14-b04 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 5fa96a5a7e76 Author: trims Date: 2008-09-04 18:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/5fa96a5a7e76 Merge - src/cpu/x86/vm/assembler_x86_32.cpp - src/cpu/x86/vm/assembler_x86_32.hpp - src/cpu/x86/vm/assembler_x86_32.inline.hpp - src/cpu/x86/vm/assembler_x86_64.cpp - src/cpu/x86/vm/assembler_x86_64.hpp - src/cpu/x86/vm/assembler_x86_64.inline.hpp - src/os_cpu/linux_x86/vm/assembler_linux_x86_32.cpp - src/os_cpu/linux_x86/vm/assembler_linux_x86_64.cpp - src/os_cpu/solaris_x86/vm/assembler_solaris_x86_32.cpp - src/os_cpu/solaris_x86/vm/assembler_solaris_x86_64.cpp - src/os_cpu/windows_x86/vm/assembler_windows_x86_32.cpp - src/os_cpu/windows_x86/vm/assembler_windows_x86_64.cpp Changeset: f9847b70eccd Author: rasbold Date: 2008-09-10 06:15 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/f9847b70eccd Merge From Vladimir.Kozlov at Sun.COM Wed Sep 10 13:55:47 2008 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Wed, 10 Sep 2008 13:55:47 -0700 Subject: Request for reviews (XS): 6746892: Register Allocator does not process a data phi with one unique input correctly Message-ID: <48C83453.9030903@sun.com> http://webrev.invokedynamic.info/kvn/6746892/index.html Fixed 6746892: Register Allocator does not process a data phi with one unique input correctly Problem: Register Allocator does not process a data phi with one unique input correctly. In PhaseChaitin::Split() when it see all block's input edges have the same live_range it does not look for existing phi for this live_range in the block. As result the live_range of this phi is not updated and the new live_range is not propagated to successors. So the new live range is lost on this path. Solution: Always look for the existing phi for a processed live_range. Reviewed by: Fix verified (y/n): y, failed CTW test. Other testing: JPRT From Vladimir.Kozlov at Sun.COM Wed Sep 10 14:16:21 2008 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Wed, 10 Sep 2008 14:16:21 -0700 Subject: Request for reviews (XS): 6746907: Improve implicit null check generation Message-ID: <48C83925.1040001@sun.com> http://webrev.invokedynamic.info/kvn/6746907/index.html Fixed 6746907: Improve implicit null check generation Problem: VM doesn't generate implicit null check if there are empty blocks between null test and uncommon_trap call. Also VM specifies the holder of a tested oop in uncommon_trap's debug info instead of passing NULL. This increase registers pressure. Solution: Skip over empty blocks when looking for uncommon_trap and add the missing offset check for compressed oops when looking for an implicit null check opportunities. Set tested oop's value to NULL in uncommon_trap's debug info. Reviewed by: Fix verified (y/n): y, generated code. Other testing: JPRT From vladimir.kozlov at sun.com Wed Sep 10 18:07:14 2008 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Thu, 11 Sep 2008 01:07:14 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6746892: Register Allocator does not process a data phi with one unique input correctly Message-ID: <20080911010716.0B6BED865@hg.openjdk.java.net> Changeset: 1c6e3bfb543a Author: kvn Date: 2008-09-10 14:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/1c6e3bfb543a 6746892: Register Allocator does not process a data phi with one unique input correctly Summary: Always look for the existing phi for a processed live_range. Reviewed-by: rasbold ! src/share/vm/opto/reg_split.cpp From vladimir.kozlov at sun.com Wed Sep 10 20:35:32 2008 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Thu, 11 Sep 2008 03:35:32 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6706829: Compressed Oops: add debug info for narrow oops Message-ID: <20080911033534.78E3CD88D@hg.openjdk.java.net> Changeset: cecd8eb4e0ca Author: kvn Date: 2008-09-10 18:23 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/cecd8eb4e0ca 6706829: Compressed Oops: add debug info for narrow oops Summary: Add support for narrow oops in debug info to avoid decoding. Reviewed-by: rasbold, never ! agent/src/share/classes/sun/jvm/hotspot/code/Location.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/CompiledVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! src/share/vm/code/location.cpp ! src/share/vm/code/location.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/stackValue.cpp ! src/share/vm/runtime/vmStructs.cpp From vladimir.kozlov at sun.com Wed Sep 10 23:02:24 2008 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Thu, 11 Sep 2008 06:02:24 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6746907: Improve implicit null check generation Message-ID: <20080911060226.A7DBED8C6@hg.openjdk.java.net> Changeset: c792b641b8bd Author: kvn Date: 2008-09-10 20:44 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/c792b641b8bd 6746907: Improve implicit null check generation Summary: add missing implicit null check cases. Reviewed-by: never ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/lcm.cpp From Vladimir.Kozlov at Sun.COM Thu Sep 11 11:34:41 2008 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Thu, 11 Sep 2008 11:34:41 -0700 Subject: Request for reviews (M): 6747051: Improve code and implicit null check generation for compressed oops Message-ID: <48C964C1.8010700@sun.com> http://webrev.invokedynamic.info/kvn/6747051/index.html Fixed 6747051: Improve code and implicit null check generation for compressed oops Problem: Currently C2 often generates redundant tests against null with compressed oops: decode_heap_oop R11,R10 testl R10, R10 # compressed ptr jeq B75 P=0.000001 C=-1.000000 movl RDX, [R11 + #12] # range decode_heap_oop also contains a test of R10 that's not exposed to the optimizer. Solution: Push DecodeN node below the test to the non-null path to use decode_heap_oop_not_null mach node which does not have 0 test. Keep CastPP node for such cases and replace CastPP(DecodeN) with DecodeN clone node with NotNull type during final_graph_reshape phase. This will also allow to generate more implicit null checks with compressed oops. On x86_64 the resulting code will be: movl RDX, [R12 + R10 << 3 + #12] (compressed oop addressing) # range NullCheck R10 And on sparc (requires to pin DecodeN to the non-null path): decode_heap_oop_not_null R_L7, R_O1 LDUW [R_O1 + #12],R_L2 ! range NullCheck R_O1 Also don't compare memory address types in Matcher when DecodeN is consumed by an address expression since types will be different at least by nullness. Reviewed by: Fix verified (y/n): y, generated code. Other testing: JPRT, refworkload, specjbb2005, specjvm2008 From john.coomes at sun.com Thu Sep 11 23:19:36 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 12 Sep 2008 06:19:36 +0000 Subject: hg: jdk7/hotspot-comp: 3 new changesets Message-ID: <20080912061936.D7DADDAF2@hg.openjdk.java.net> Changeset: 46a989ab9329 Author: ohair Date: 2008-08-17 09:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/46a989ab9329 6737659: debug bundles are empty Summary: Build order issue with debug build, caused final debug bundle to be empty. Reviewed-by: tbell ! Makefile Changeset: 143c1abedb7d Author: xdono Date: 2008-08-28 11:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/143c1abedb7d Added tag jdk7-b34 for changeset 46a989ab9329 ! .hgtags Changeset: 4d52a6465eb0 Author: xdono Date: 2008-09-11 11:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/4d52a6465eb0 Added tag jdk7-b35 for changeset 143c1abedb7d ! .hgtags From john.coomes at sun.com Thu Sep 11 23:20:28 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 12 Sep 2008 06:20:28 +0000 Subject: hg: jdk7/hotspot-comp/corba: 2 new changesets Message-ID: <20080912062031.59397DAF7@hg.openjdk.java.net> Changeset: 3867c4d14a5b Author: xdono Date: 2008-08-28 11:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/3867c4d14a5b Added tag jdk7-b34 for changeset 0a812b9824e5 ! .hgtags Changeset: 545dffad4849 Author: xdono Date: 2008-09-11 11:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/545dffad4849 Added tag jdk7-b35 for changeset 3867c4d14a5b ! .hgtags From john.coomes at sun.com Thu Sep 11 23:23:09 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 12 Sep 2008 06:23:09 +0000 Subject: hg: jdk7/hotspot-comp/jaxp: 2 new changesets Message-ID: <20080912062313.D5316DAFC@hg.openjdk.java.net> Changeset: eac46d1eb7f0 Author: xdono Date: 2008-08-28 11:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/eac46d1eb7f0 Added tag jdk7-b34 for changeset 01facdf8cabd ! .hgtags Changeset: c84ca638db42 Author: xdono Date: 2008-09-11 11:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/c84ca638db42 Added tag jdk7-b35 for changeset eac46d1eb7f0 ! .hgtags From john.coomes at sun.com Thu Sep 11 23:24:06 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 12 Sep 2008 06:24:06 +0000 Subject: hg: jdk7/hotspot-comp/jaxws: 2 new changesets Message-ID: <20080912062410.4C6DDDB01@hg.openjdk.java.net> Changeset: b0f01c2508b6 Author: xdono Date: 2008-08-28 11:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/b0f01c2508b6 Added tag jdk7-b34 for changeset 7a9f629cd957 ! .hgtags Changeset: f60187f44a0d Author: xdono Date: 2008-09-11 11:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/f60187f44a0d Added tag jdk7-b35 for changeset b0f01c2508b6 ! .hgtags From john.coomes at sun.com Thu Sep 11 23:25:49 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 12 Sep 2008 06:25:49 +0000 Subject: hg: jdk7/hotspot-comp/jdk: 26 new changesets Message-ID: <20080912063107.4E456DB06@hg.openjdk.java.net> Changeset: b010683123b3 Author: ohair Date: 2008-08-14 13:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/b010683123b3 6674227: Missing LICENSE file during build Summary: Just a JPRT usage issue. The top level files (like LICENSE) are needed to create the jdk image (j2sdk-image directory). Reviewed-by: tbell ! make/jprt.properties Changeset: ac68bf5140b2 Author: ohair Date: 2008-08-14 20:59 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/ac68bf5140b2 Merge - make/java/nio/spp.sh - src/windows/classes/sun/java2d/d3d/D3DBackBufferSurfaceData.java - src/windows/classes/sun/java2d/windows/DDBlitLoops.java - src/windows/classes/sun/java2d/windows/DDRenderer.java - src/windows/classes/sun/java2d/windows/DDScaleLoops.java - src/windows/classes/sun/java2d/windows/Win32OffScreenSurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceDataProxy.java - src/windows/classes/sun/java2d/windows/WinBackBuffer.java - src/windows/classes/sun/java2d/windows/WinBackBufferSurfaceData.java - src/windows/classes/sun/java2d/windows/WinVolatileSurfaceManager.java - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.cpp - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.h - src/windows/native/sun/java2d/d3d/D3DTestRaster.h - src/windows/native/sun/java2d/d3d/D3DTextRenderer_md.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.h - src/windows/native/sun/java2d/windows/DDBlitLoops.cpp - src/windows/native/sun/java2d/windows/DDRenderer.cpp - src/windows/native/sun/java2d/windows/RegistryKey.cpp - src/windows/native/sun/java2d/windows/RegistryKey.h - src/windows/native/sun/java2d/windows/Win32OffScreenSurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.h - src/windows/native/sun/java2d/windows/WinBackBufferSurfaceData.cpp - src/windows/native/sun/java2d/windows/ddrawObject.cpp - src/windows/native/sun/java2d/windows/ddrawObject.h - src/windows/native/sun/java2d/windows/ddrawUtils.cpp - src/windows/native/sun/java2d/windows/ddrawUtils.h - src/windows/native/sun/java2d/windows/dxCapabilities.cpp - src/windows/native/sun/java2d/windows/dxCapabilities.h - src/windows/native/sun/java2d/windows/dxInit.cpp - src/windows/native/sun/java2d/windows/dxInit.h Changeset: db4bd081eff2 Author: ksrini Date: 2008-08-19 07:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/db4bd081eff2 6614210: JPRT Windows 32bit msival2 build failure when building 'install' workspace Summary: suppresses wscript's modal dialog on error and no msi validation for jprt. Reviewed-by: ohair, jmelvin ! make/common/shared/Defs-windows.gmk Changeset: 434055a0716e Author: xdono Date: 2008-08-21 09:55 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/434055a0716e Merge Changeset: bf580c41f68f Author: xdono Date: 2008-08-28 11:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/bf580c41f68f Added tag jdk7-b34 for changeset 434055a0716e ! .hgtags Changeset: cf403a69449a Author: jjh Date: 2008-08-15 18:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/cf403a69449a 6737900: TEST: Some JDI regression tests timeout on slow machines Summary: Don't execute useless code, and split test into multiple @runs. Reviewed-by: tbell ! test/com/sun/jdi/ClassesByName2Test.java ! test/com/sun/jdi/ConnectedVMs.java ! test/com/sun/jdi/sde/MangleStepTest.java Changeset: e093efae8c5f Author: ohair Date: 2008-08-17 17:02 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/e093efae8c5f 6496269: Many warnings generated from com/sun/java/util/jar/pack/*.cpp when compiled on Linux Summary: Removal of compiler warnings and fixing of assert logic. Reviewed-by: jrose, ksrini, bristor ! src/share/native/com/sun/java/util/jar/pack/bands.cpp ! src/share/native/com/sun/java/util/jar/pack/bytes.cpp ! src/share/native/com/sun/java/util/jar/pack/bytes.h ! src/share/native/com/sun/java/util/jar/pack/coding.cpp ! src/share/native/com/sun/java/util/jar/pack/coding.h ! src/share/native/com/sun/java/util/jar/pack/defines.h ! src/share/native/com/sun/java/util/jar/pack/jni.cpp ! src/share/native/com/sun/java/util/jar/pack/main.cpp ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! src/share/native/com/sun/java/util/jar/pack/unpack.h ! src/share/native/com/sun/java/util/jar/pack/utils.cpp ! src/share/native/com/sun/java/util/jar/pack/utils.h ! src/share/native/com/sun/java/util/jar/pack/zip.cpp ! src/share/native/com/sun/java/util/jar/pack/zip.h Changeset: 092985e71d9e Author: tbell Date: 2008-08-18 09:20 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/092985e71d9e Merge Changeset: 17527939e5b1 Author: swamyv Date: 2008-08-18 15:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/17527939e5b1 6705893: javax.script tests should not require a js engine on OpenJDK Summary: Fixed the tests to pass with open JDK. Reviewed-by: darcy ! test/javax/script/E4XErrorTest.java + test/javax/script/Helper.java ! test/javax/script/JavaScriptScopeTest.java ! test/javax/script/NullUndefinedVarTest.java ! test/javax/script/PluggableContextTest.java ! test/javax/script/ProviderTest.java ! test/javax/script/RhinoExceptionTest.java ! test/javax/script/Test1.java ! test/javax/script/Test2.java ! test/javax/script/Test3.java ! test/javax/script/Test4.java ! test/javax/script/Test5.java ! test/javax/script/Test6.java ! test/javax/script/Test7.java ! test/javax/script/Test8.java ! test/javax/script/VersionTest.java + test/sun/tools/jrunscript/CheckEngine.java ! test/sun/tools/jrunscript/common.sh ! test/sun/tools/jrunscript/jrunscript-DTest.sh ! test/sun/tools/jrunscript/jrunscript-argsTest.sh ! test/sun/tools/jrunscript/jrunscript-cpTest.sh ! test/sun/tools/jrunscript/jrunscript-eTest.sh ! test/sun/tools/jrunscript/jrunscript-fTest.sh ! test/sun/tools/jrunscript/jrunscriptTest.sh Changeset: b6f746b0ecc4 Author: swamyv Date: 2008-08-19 12:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/b6f746b0ecc4 6736461: ThreadMXBean Locks.java fails intermittently. Summary: Fixed the test to wait for the right state before calling check thread information. Reviewed-by: jjh ! test/java/lang/management/ThreadMXBean/Locks.java Changeset: 1b114828900b Author: tbell Date: 2008-08-19 16:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/1b114828900b Merge Changeset: 9f53e194687c Author: tbell Date: 2008-08-25 23:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/9f53e194687c Merge Changeset: dc4067f914a2 Author: martin Date: 2008-08-20 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/dc4067f914a2 6739302: Check that deserialization preserves EnumSet integrity Reviewed-by: dl, chegar Contributed-by: jjb at google.com ! src/share/classes/java/util/EnumSet.java + test/java/util/EnumSet/BogusEnumSet.java Changeset: 52fbd007f47b Author: swamyv Date: 2008-08-22 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/52fbd007f47b 6653883: jmap with no option should print mmap instead of heap information. Summary: Changed the default option of jmap to print mmap. Reviewed-by: jjh ! src/share/classes/sun/tools/jmap/JMap.java Changeset: 3a4370604bab Author: ohair Date: 2008-08-22 12:24 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/3a4370604bab 6732421: Removed old javavm and Classic VM files from the jdk7 sources Reviewed-by: alanb ! make/common/Defs.gmk ! make/java/verify/Makefile ! make/netbeans/awt2d/README ! make/tools/GenerateCharacter/check_class.c.template ! src/share/back/debugDispatch.c ! src/share/back/error_messages.c ! src/share/back/inStream.c ! src/share/back/outStream.h ! src/share/instrument/InstrumentationImplNativeMethods.c ! src/share/instrument/JPLISAgent.c ! src/share/javavm/export/jvm.h - src/share/javavm/include/opcodes.h - src/share/javavm/include/opcodes.length - src/share/javavm/include/opcodes.list - src/share/javavm/include/opcodes.weight - src/share/javavm/include/opcodes.wide - src/share/javavm/include/sys_api.h - src/share/javavm/include/typedefs.h ! src/share/native/common/check_code.c ! src/share/native/common/check_format.c ! src/solaris/back/util_md.h ! src/solaris/instrument/FileSystemSupport_md.h ! src/solaris/javavm/export/jvm_md.h - src/solaris/javavm/include/typedefs_md.h ! src/solaris/native/common/gdefs_md.h ! src/solaris/native/common/jlong_md.h ! src/windows/back/util_md.h ! src/windows/hpi/src/socket_md.c ! src/windows/hpi/src/threads_md.c ! src/windows/instrument/FileSystemSupport_md.h ! src/windows/javavm/export/jvm_md.h - src/windows/javavm/include/typedefs_md.h ! src/windows/native/java/net/net_util_md.c Changeset: 3dcc69147ff9 Author: sherman Date: 2008-08-22 14:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/3dcc69147ff9 4486841: UTF-8 decoder should adhere to corrigendum to Unicode 3.0.1 6636317: Optimize UTF-8 coder for ASCII input Summary: re-write the UTF-8 charset to obey the standard and improve the performance Reviewed-by: alanb ! src/share/classes/sun/nio/cs/UTF_8.java + test/sun/nio/cs/TestUTF8.java Changeset: a33cf5828b82 Author: sherman Date: 2008-08-22 22:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/a33cf5828b82 6740702: Comment tag update Summary: tag update Reviewed-by: mr ! src/share/classes/sun/nio/cs/UTF_8.java Changeset: a4ff2fe5b5d9 Author: weijun Date: 2008-08-06 08:11 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/a4ff2fe5b5d9 6731685: CertificateFactory.generateCertificates throws IOException on PKCS7 cert chain Reviewed-by: mullan ! src/share/classes/sun/security/util/DerIndefLenConverter.java + test/sun/security/util/DerValue/Indefinite.java Changeset: 97d08b2b4539 Author: chegar Date: 2008-08-06 07:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/97d08b2b4539 6734171: java.net.NetworkInterface reports XCheck:jni warnings Summary: Removed leading "L" or trailing ";" from FindClass classname param Reviewed-by: alanb ! src/windows/native/java/net/NetworkInterface.c Changeset: 874f4db252e3 Author: wetmore Date: 2008-08-20 00:41 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/874f4db252e3 Merge Changeset: afcf04c535da Author: michaelm Date: 2008-08-21 10:04 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/afcf04c535da 6258215: Num of backlog in ServerSocket(int, int) should be mentioned more explicitly Summary: updated javadoc Reviewed-by: chegar ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/javax/net/ssl/SSLServerSocket.java Changeset: f4289d75cd29 Author: jccollet Date: 2008-08-25 14:38 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/f4289d75cd29 6717876: Make java.net.NetworkInterface.getIndex() public Summary: Make getIndex() and getByIndex() public. Required a name change in native code Reviewed-by: alanb, chegar, michaelm ! make/java/net/mapfile-vers ! src/share/classes/java/net/NetworkInterface.java ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface_winXP.c ! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c ! src/windows/native/java/net/net_util_md.h + test/java/net/NetworkInterface/IndexTest.java Changeset: 872241636752 Author: wetmore Date: 2008-08-25 08:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/872241636752 Merge Changeset: c5f211538cad Author: tbell Date: 2008-08-25 23:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/c5f211538cad Merge - src/share/javavm/include/opcodes.h - src/share/javavm/include/opcodes.length - src/share/javavm/include/opcodes.list - src/share/javavm/include/opcodes.weight - src/share/javavm/include/opcodes.wide - src/share/javavm/include/sys_api.h - src/share/javavm/include/typedefs.h - src/solaris/javavm/include/typedefs_md.h - src/windows/javavm/include/typedefs_md.h Changeset: cf4894b78ceb Author: tbell Date: 2008-08-29 12:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/cf4894b78ceb Merge Changeset: baae64ef16f6 Author: xdono Date: 2008-09-11 11:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/baae64ef16f6 Added tag jdk7-b35 for changeset cf4894b78ceb ! .hgtags From john.coomes at sun.com Thu Sep 11 23:37:47 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 12 Sep 2008 06:37:47 +0000 Subject: hg: jdk7/hotspot-comp/langtools: 4 new changesets Message-ID: <20080912063755.705C1DB19@hg.openjdk.java.net> Changeset: 8889fb6c5af0 Author: xdono Date: 2008-08-28 11:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/8889fb6c5af0 Added tag jdk7-b34 for changeset 4026dece07e8 ! .hgtags Changeset: 37551dc0f591 Author: mcimadamore Date: 2008-08-22 11:46 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/37551dc0f591 6733837: Recent work on javac diagnostic affected javac output Summary: Problems with diagnostic path and tab character in the source code Reviewed-by: darcy, jjg ! src/share/classes/com/sun/tools/javac/api/DiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java + test/tools/javac/api/6733837/T6733837.java Changeset: 81f66dd906eb Author: tbell Date: 2008-08-29 12:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/81f66dd906eb Merge Changeset: ae2a1418f0c8 Author: xdono Date: 2008-09-11 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/ae2a1418f0c8 Added tag jdk7-b35 for changeset 81f66dd906eb ! .hgtags From chuck.rasbold at sun.com Tue Sep 16 13:00:20 2008 From: chuck.rasbold at sun.com (chuck.rasbold at sun.com) Date: Tue, 16 Sep 2008 20:00:20 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 8 new changesets Message-ID: <20080916200038.140E2DD13@hg.openjdk.java.net> Changeset: b33eef719520 Author: xlu Date: 2008-08-25 13:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/b33eef719520 6740526: sun/management/HotspotThreadMBean/GetInternalThreads.java test failed Reviewed-by: dholmes, dcubed ! src/share/vm/runtime/thread.cpp Changeset: 23c6240101a0 Author: apangin Date: 2008-08-31 15:24 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/23c6240101a0 Merge Changeset: 93befa083681 Author: coleenp Date: 2008-09-02 15:18 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/93befa083681 6741004: UseLargePages + UseCompressedOops breaks implicit null checking guard page Summary: Turn off c2 implicit null checking on windows and large pages specified. Reviewed-by: jrose, xlu ! src/share/vm/opto/compile.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/virtualspace.cpp Changeset: 24fc405437c9 Author: acorn Date: 2008-09-10 12:31 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/24fc405437c9 Merge - src/cpu/x86/vm/assembler_x86_32.cpp - src/cpu/x86/vm/assembler_x86_32.hpp - src/cpu/x86/vm/assembler_x86_32.inline.hpp - src/cpu/x86/vm/assembler_x86_64.cpp - src/cpu/x86/vm/assembler_x86_64.hpp - src/cpu/x86/vm/assembler_x86_64.inline.hpp - src/os_cpu/linux_x86/vm/assembler_linux_x86_32.cpp - src/os_cpu/linux_x86/vm/assembler_linux_x86_64.cpp - src/os_cpu/solaris_x86/vm/assembler_solaris_x86_32.cpp - src/os_cpu/solaris_x86/vm/assembler_solaris_x86_64.cpp - src/os_cpu/windows_x86/vm/assembler_windows_x86_32.cpp - src/os_cpu/windows_x86/vm/assembler_windows_x86_64.cpp Changeset: 1eb509f14356 Author: acorn Date: 2008-09-11 09:02 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/1eb509f14356 Merge Changeset: 68e0443dfd9c Author: ohair Date: 2008-09-11 11:04 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/68e0443dfd9c 6745363: Add ability to run packtest to hotspot/test/makefile Reviewed-by: ksrini ! make/jprt.properties ! test/Makefile Changeset: 0ba3ec980ae5 Author: dcubed Date: 2008-09-12 07:04 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/0ba3ec980ae5 Merge Changeset: 7484fa4b8825 Author: rasbold Date: 2008-09-15 09:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/7484fa4b8825 Merge ! src/share/vm/opto/compile.cpp From chuck.rasbold at sun.com Wed Sep 17 11:50:22 2008 From: chuck.rasbold at sun.com (chuck.rasbold at sun.com) Date: Wed, 17 Sep 2008 18:50:22 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6711100: 64bit fastdebug server vm crashes with assert(_base == Int, "Not an Int") Message-ID: <20080917185024.993CEDDEA@hg.openjdk.java.net> Changeset: 8261ee795323 Author: rasbold Date: 2008-09-17 08:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/8261ee795323 6711100: 64bit fastdebug server vm crashes with assert(_base == Int,"Not an Int") Summary: insert CastII nodes to narrow type of load_array_length() node Reviewed-by: never, kvn ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp + test/compiler/6711100/Test.java From thomas.rodriguez at sun.com Wed Sep 17 15:08:55 2008 From: thomas.rodriguez at sun.com (thomas.rodriguez at sun.com) Date: Wed, 17 Sep 2008 22:08:55 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6384206: Phis which are later unneeded are impairing our ability to inline based on static types Message-ID: <20080917220857.1C854DE5E@hg.openjdk.java.net> Changeset: 194b8e3a2fc4 Author: never Date: 2008-09-17 12:59 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types Reviewed-by: rasbold, jrose ! src/share/vm/ci/ciMethodBlocks.cpp ! src/share/vm/ci/ciMethodBlocks.hpp ! src/share/vm/ci/ciTypeFlow.cpp ! src/share/vm/ci/ciTypeFlow.hpp ! src/share/vm/includeDB_compiler2 ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp From Chuck.Rasbold at Sun.COM Tue Sep 23 10:44:06 2008 From: Chuck.Rasbold at Sun.COM (Chuck Rasbold) Date: Tue, 23 Sep 2008 10:44:06 -0700 Subject: Review request (S): 6750588: assert(lrg._area >= 0,"negative spill area") running NSK stmp0101 test In-Reply-To: <48B6B921.7010600@sun.com> References: <48B6B921.7010600@sun.com> Message-ID: <48D92AE6.3050401@sun.com> http://webrev.invokedynamic.info/rasbold/6750588/index.html 6750588: assert(lrg._area >= 0,"negative spill area") running NSK stmp0101 test Summary: handle NaN costs more carefully Reviewed-by: In extreme cases not found in normal programs, an estimated block frequency can become the float value Infinity. Calculations for cost and area estimates in ifg_physical() can then become Inf or NaN. Register allocation still behaves OK with these values, but asserts will trigger without need. The fix changes the cost calculation to not become NaN in the face of an Inf frequency. Two asserts are tweaked to properly check for negative values. From vladimir.kozlov at sun.com Tue Sep 23 16:56:48 2008 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Tue, 23 Sep 2008 23:56:48 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6747051: Improve code and implicit null check generation for compressed oops Message-ID: <20080923235652.DF0B4D134@hg.openjdk.java.net> Changeset: 36ccc817fca4 Author: kvn Date: 2008-09-23 12:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/36ccc817fca4 6747051: Improve code and implicit null check generation for compressed oops Summary: Push DecodeN node below the Null check to the non-null path to use the mach node without 0 test. Reviewed-by: rasbold, never ! src/share/vm/asm/assembler.cpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/matcher.hpp From chuck.rasbold at sun.com Thu Sep 25 08:36:10 2008 From: chuck.rasbold at sun.com (chuck.rasbold at sun.com) Date: Thu, 25 Sep 2008 15:36:10 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6750588: assert(lrg._area >= 0, "negative spill area") running NSK stmp0101 test Message-ID: <20080925153612.19595D27B@hg.openjdk.java.net> Changeset: 5f85534046c2 Author: rasbold Date: 2008-09-24 15:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/5f85534046c2 6750588: assert(lrg._area >= 0,"negative spill area") running NSK stmp0101 test Summary: handle NaN costs more carefully Reviewed-by: kvn, never ! src/share/vm/opto/ifg.cpp From mark at klomp.org Thu Sep 25 14:57:56 2008 From: mark at klomp.org (Mark Wielaard) Date: Thu, 25 Sep 2008 23:57:56 +0200 Subject: hotspot JIT producing incorrect code -how should I report a bug? In-Reply-To: <487E66C9.4050601@Sun.COM> References: <4873C510.6030100@streambase.com> <4873DBBF.1020900@sun.com> <48740CBD.8060705@streambase.com> <4876805F.4030700@Sun.COM> <487E66C9.4050601@Sun.COM> Message-ID: <20080925215747.GA16445@gnu.wildebeest.org> Hi, On Wed, Jul 16, 2008 at 02:23:21PM -0700, Chuck Rasbold wrote: > Ismael Juma wrote: > > Chuck Rasbold writes: > > > >>Thanks for bringing 6707044 to our attention. Is was previously misfiled > >>in the wrong subcategory. I'm looking into a diagnosis right now. > > > > Thanks for looking into it Chuck. It looks like a scary bug and it would > > be very nice to get a fix. > > With a fix now in jdk7/hotspot-comp/hotspot, we're now looking into > getting this fix backported into the 6u10 release. This was indeed a scary bug. And easily triggered. I backported it to the jdk6 hotspot as used in icedtea. I also added the test case for it (that obviously fails before and succeeds after the patch). It would be nice if it could also be added to the hotspot tests. There are unfortunately very little public tests for hotspot and increasing their number would help with making sure no regressings slip in. I didn't take your followup patches (for #6726504 and #6730192) because I wanted a minimal backport. But if you think it would be good to backport those too then I will be happy to take a stab at it. Cheers, Mark P.S. Note to Gary, I didn't try to fix it in the zero hotspot 7b24 version. We should probably just refresh that one completely. -------------- next part -------------- diff -r 4aebfff4f8a2 hotspot/src/share/vm/opto/parse2.cpp --- openjdk.orig/hotspot/src/share/vm/opto/parse2.cpp Mon Sep 15 11:38:34 2008 +0200 +++ openjdk/hotspot/src/share/vm/opto/parse2.cpp Thu Sep 25 21:54:26 2008 +0200 @@ -868,6 +868,8 @@ return prob < PROB_MIN; } +//-------------------------------repush_if_args-------------------------------- +// Push arguments of an "if" bytecode back onto the stack by adjusting _sp. inline void Parse::repush_if_args() { #ifndef PRODUCT if (PrintOpto && WizardMode) { @@ -896,7 +898,6 @@ if (PrintOpto && Verbose) tty->print_cr("Never-taken backedge stops compilation at bci %d",bci()); #endif - repush_if_args(); // to gather stats on loop uncommon_trap(Deoptimization::Reason_unreached, Deoptimization::Action_reinterpret, NULL, "cold"); diff -r 51798f0e554f test/compiler/6707044/LuceneCrash.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ openjdk/hotspot/test/compiler/6707044/LuceneCrash.java Thu Sep 25 21:55:28 2008 +0200 @@ -0,0 +1,40 @@ +/* + * @test + * @bug 6707044 + * @summary uncommon_trap of ifnull bytecode leaves garbage on expression stack + * @run main/othervm -Xbatch LuceneCrash + */ +public class LuceneCrash { + + public static void main(String[] args) throws Throwable { + new LuceneCrash().crash(); + } + + private Object alwaysNull; + + final void crash() throws Throwable { + for (int r = 0; r < 3; r++) { + for (int docNum = 0; docNum < 10000;) { + if (r < 2) { + for(int j=0;j<3000;j++) + docNum++; + } else { + docNum++; + doNothing(getNothing()); + if (alwaysNull != null) { + throw new RuntimeException("BUG: checkAbort is always null: r=" + r + " of 3; docNum=" + docNum); + } + } + } + } + } + + Object getNothing() { + return this; + } + + int x; + void doNothing(Object o) { + x++; + } +} From thomas.rodriguez at sun.com Thu Sep 25 15:19:10 2008 From: thomas.rodriguez at sun.com (thomas.rodriguez at sun.com) Date: Thu, 25 Sep 2008 22:19:10 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6744783: HotSpot segfaults if given -XX options with an empty string argument Message-ID: <20080925221912.D3C94D2CB@hg.openjdk.java.net> Changeset: 885fe0f95828 Author: never Date: 2008-09-25 12:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/885fe0f95828 6744783: HotSpot segfaults if given -XX options with an empty string argument Reviewed-by: kamg, kvn Contributed-by: volker.simonis at gmail.com ! src/share/vm/prims/jvmtiTrace.cpp ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp From Chuck.Rasbold at Sun.COM Thu Sep 25 15:31:59 2008 From: Chuck.Rasbold at Sun.COM (Chuck Rasbold) Date: Thu, 25 Sep 2008 15:31:59 -0700 Subject: hotspot JIT producing incorrect code -how should I report a bug? In-Reply-To: <20080925215747.GA16445@gnu.wildebeest.org> References: <4873C510.6030100@streambase.com> <4873DBBF.1020900@sun.com> <48740CBD.8060705@streambase.com> <4876805F.4030700@Sun.COM> <487E66C9.4050601@Sun.COM> <20080925215747.GA16445@gnu.wildebeest.org> Message-ID: <48DC115F.2050106@sun.com> Mark - I don't think that you need to backport #6726504 and #6730192. The first was just a clean up and the second a bug fix for the cleanup (he writes while eating humble pie). As for the test case, I love it, but based on the channel in which the test case was submitted, Sun does not have ownership rights to the code, so I can't add it to OpenJDK. I am not a lawyer, but someone who is should feel free to correct me. -- Chuck On 09/25/08 14:57, Mark Wielaard wrote: > Hi, > > On Wed, Jul 16, 2008 at 02:23:21PM -0700, Chuck Rasbold wrote: >> Ismael Juma wrote: >>> Chuck Rasbold writes: >>> >>>> Thanks for bringing 6707044 to our attention. Is was previously misfiled >>>> in the wrong subcategory. I'm looking into a diagnosis right now. >>> Thanks for looking into it Chuck. It looks like a scary bug and it would >>> be very nice to get a fix. >> With a fix now in jdk7/hotspot-comp/hotspot, we're now looking into >> getting this fix backported into the 6u10 release. > > This was indeed a scary bug. And easily triggered. > I backported it to the jdk6 hotspot as used in icedtea. > I also added the test case for it (that obviously fails before and > succeeds after the patch). It would be nice if it could also be added > to the hotspot tests. There are unfortunately very little public tests > for hotspot and increasing their number would help with making sure > no regressings slip in. > > I didn't take your followup patches (for #6726504 and #6730192) because > I wanted a minimal backport. But if you think it would be good to > backport those too then I will be happy to take a stab at it. > > Cheers, > > Mark > > P.S. Note to Gary, I didn't try to fix it in the zero hotspot 7b24 > version. We should probably just refresh that one completely. > From john.coomes at sun.com Fri Sep 26 02:30:08 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 26 Sep 2008 09:30:08 +0000 Subject: hg: jdk7/hotspot-comp: 7 new changesets Message-ID: <20080926093009.13388D318@hg.openjdk.java.net> Changeset: 52148b82cfff Author: martin Date: 2008-09-08 17:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/52148b82cfff 6746055: Spelling error in README-builds.html Reviewed-by: ohair ! README-builds.html Changeset: f920f23af0d0 Author: tbell Date: 2008-09-12 14:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/f920f23af0d0 Merge Changeset: e18ad724572f Author: ohair Date: 2008-09-09 15:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/e18ad724572f 6746424: Remove build dependency on findbugs and FINDBUGS_HOME Reviewed-by: tbell ! make/Defs-internal.gmk ! make/README.pre-components ! make/jprt.config Changeset: 2fed245641ed Author: ohair Date: 2008-09-11 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/2fed245641ed Merge Changeset: 1d9112b073d7 Author: ohair Date: 2008-09-17 13:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/1d9112b073d7 6724787: OpenJDK README-builds.html suggested changes 6746440: Add Fedora 9 & CentOS 5.2 instructions to OpenJDK Build README Reviewed-by: weijun, xdono ! README-builds.html Changeset: 4b4f5fea8d7d Author: xdono Date: 2008-09-17 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/4b4f5fea8d7d Merge ! README-builds.html Changeset: b3eb1d558cd2 Author: xdono Date: 2008-09-25 12:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/b3eb1d558cd2 Added tag jdk7-b36 for changeset 4b4f5fea8d7d ! .hgtags From john.coomes at sun.com Fri Sep 26 02:31:11 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 26 Sep 2008 09:31:11 +0000 Subject: hg: jdk7/hotspot-comp/corba: 4 new changesets Message-ID: <20080926093115.50ADDD31D@hg.openjdk.java.net> Changeset: 0d92f2ecc8ff Author: ohair Date: 2008-09-09 15:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/0d92f2ecc8ff 6746424: Remove build dependency on findbugs and FINDBUGS_HOME Reviewed-by: tbell ! make/common/shared/Defs-utils.gmk ! make/jprt.config Changeset: 134c361ed49b Author: xdono Date: 2008-09-10 10:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/134c361ed49b Merge Changeset: 0723891eb8d1 Author: xdono Date: 2008-09-17 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/0723891eb8d1 Merge Changeset: d057050bdb27 Author: xdono Date: 2008-09-25 12:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/d057050bdb27 Added tag jdk7-b36 for changeset 0723891eb8d1 ! .hgtags From john.coomes at sun.com Fri Sep 26 02:34:31 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 26 Sep 2008 09:34:31 +0000 Subject: hg: jdk7/hotspot-comp/jaxp: Added tag jdk7-b36 for changeset c84ca638db42 Message-ID: <20080926093434.4F3D5D322@hg.openjdk.java.net> Changeset: af49591bc486 Author: xdono Date: 2008-09-25 12:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/af49591bc486 Added tag jdk7-b36 for changeset c84ca638db42 ! .hgtags From john.coomes at sun.com Fri Sep 26 02:35:36 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 26 Sep 2008 09:35:36 +0000 Subject: hg: jdk7/hotspot-comp/jaxws: Added tag jdk7-b36 for changeset f60187f44a0d Message-ID: <20080926093538.C7568D327@hg.openjdk.java.net> Changeset: a2a6f9edf761 Author: xdono Date: 2008-09-25 12:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/a2a6f9edf761 Added tag jdk7-b36 for changeset f60187f44a0d ! .hgtags From john.coomes at sun.com Fri Sep 26 02:38:40 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 26 Sep 2008 09:38:40 +0000 Subject: hg: jdk7/hotspot-comp/jdk: 53 new changesets Message-ID: <20080926094918.8DAF7D32C@hg.openjdk.java.net> Changeset: 2a5377a6492e Author: alanb Date: 2008-08-26 09:23 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/2a5377a6492e 6728542: (se) epoll based SelectorProvider should be portable to platforms other than x86 and x64 Reviewed-by: sherman ! make/java/nio/mapfile-linux ! src/solaris/classes/sun/nio/ch/EPollArrayWrapper.java ! src/solaris/native/sun/nio/ch/EPollArrayWrapper.c Changeset: ea45b0c72096 Author: alanb Date: 2008-08-26 10:21 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/ea45b0c72096 6682020: (bf) Support monitoring of direct and mapped buffer usage Reviewed-by: mchung, iris ! make/java/java/FILES_java.gmk ! make/java/nio/FILES_java.gmk ! src/share/classes/java/lang/management/PlatformComponent.java ! src/share/classes/java/nio/Bits.java + src/share/classes/java/nio/BufferPoolMXBean.java ! src/share/classes/java/nio/Direct-X-Buffer.java + src/share/classes/sun/misc/JavaNioAccess.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/nio/ch/FileChannelImpl.java + test/java/nio/BufferPoolMXBean/Basic.java Changeset: 7afa7314d883 Author: emcmanus Date: 2008-08-27 11:03 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/7afa7314d883 5041784: (reflect) generic signature methods needlessly return generic arrays Reviewed-by: darcy ! src/share/classes/sun/reflect/generics/factory/CoreReflectionFactory.java + test/java/lang/reflect/Generics/TestPlainArrayNotGeneric.java Changeset: 2c65a59dd48d Author: ksrini Date: 2008-08-26 10:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/2c65a59dd48d 6685121: (launcher) make ReportErrorMessages accessible by other launcher subsystems Summary: provided error reporting interfaces to other java subsystems that the launcher uses. Reviewed-by: darcy ! make/java/jli/Makefile ! make/java/jli/mapfile-vers ! src/share/bin/emessages.h ! src/share/bin/java.c ! src/share/bin/java.h ! src/solaris/bin/java_md.c ! src/windows/bin/java_md.c Changeset: d6b41950987b Author: sherman Date: 2008-08-27 10:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/d6b41950987b 4849617: (cs)Revise Charset spec to allow '+' in names Summary: Update the spec and code to accept '+' as a charset name character Reviewed-by: alanb ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java ! src/share/classes/sun/nio/cs/standard-charsets + test/sun/nio/cs/CheckICNE.java Changeset: 126760548921 Author: sherman Date: 2008-08-27 10:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/126760548921 Merge Changeset: 5d278726f0dc Author: chegar Date: 2008-08-29 17:46 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/5d278726f0dc 6576763: Thread constructors throw undocumented NPE for null name Summary: update javadoc to specify NPE as well as fix minor bug in implementation. Reviewed-by: alanb ! src/share/classes/java/lang/Thread.java + test/java/lang/ThreadGroup/NullThreadName.java Changeset: dc604a6da888 Author: swamyv Date: 2008-08-29 14:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/dc604a6da888 6614052: jhat fails to read heap dump > 2GB. Summary: Modified the jhat code to use long for unsigned int. This is a forward port of changes from Kevin Walls. Reviewed-by: jjh ! src/share/classes/com/sun/tools/hat/internal/parser/HprofReader.java Changeset: ad45ffa62646 Author: tbell Date: 2008-08-31 11:59 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/ad45ffa62646 Merge Changeset: f9cf71f806eb Author: alanb Date: 2008-08-31 18:32 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/f9cf71f806eb 6570619: (bf) DirectByteBuffer.get/put(byte[]) does not scale well Reviewed-by: iris ! make/java/java/mapfile-vers ! src/share/classes/java/nio/Bits.java ! src/share/classes/java/nio/Direct-X-Buffer.java ! src/share/native/java/nio/Bits.c Changeset: 343253d05123 Author: alanb Date: 2008-08-31 18:39 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/343253d05123 4640544: New I/O: Complete socket-channel functionality Reviewed-by: iris, sherman, chegar ! make/java/nio/FILES_java.gmk ! make/java/nio/Makefile ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! make/mksample/nio/Makefile + make/mksample/nio/multicast/Makefile ! src/share/classes/java/net/NetworkInterface.java + src/share/classes/java/net/ProtocolFamily.java + src/share/classes/java/net/SocketOption.java + src/share/classes/java/net/StandardProtocolFamily.java + src/share/classes/java/net/StandardSocketOption.java ! src/share/classes/java/nio/channels/DatagramChannel.java + src/share/classes/java/nio/channels/MembershipKey.java + src/share/classes/java/nio/channels/MulticastChannel.java + src/share/classes/java/nio/channels/NetworkChannel.java ! src/share/classes/java/nio/channels/ServerSocketChannel.java ! src/share/classes/java/nio/channels/SocketChannel.java ! src/share/classes/java/nio/channels/exceptions + src/share/classes/java/nio/channels/package-info.java - src/share/classes/java/nio/channels/package.html ! src/share/classes/java/nio/channels/spi/SelectorProvider.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/DatagramSocketAdaptor.java + src/share/classes/sun/nio/ch/ExtendedSocketOption.java + src/share/classes/sun/nio/ch/MembershipKeyImpl.java + src/share/classes/sun/nio/ch/MembershipRegistry.java ! src/share/classes/sun/nio/ch/Net.java - src/share/classes/sun/nio/ch/OptionAdaptor.java + src/share/classes/sun/nio/ch/OptionKey.java ! src/share/classes/sun/nio/ch/SelectorProviderImpl.java ! src/share/classes/sun/nio/ch/ServerSocketAdaptor.java ! src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/SocketAdaptor.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java - src/share/classes/sun/nio/ch/SocketOpts.java - src/share/classes/sun/nio/ch/SocketOptsImpl.java - src/share/classes/sun/nio/ch/exceptions ! src/share/native/java/net/net_util.c ! src/share/native/java/net/net_util.h + src/share/native/sun/nio/ch/genSocketOptionRegistry.c + src/share/sample/nio/multicast/MulticastAddress.java + src/share/sample/nio/multicast/Reader.java + src/share/sample/nio/multicast/Sender.java ! src/solaris/native/java/net/net_util_md.c ! src/solaris/native/sun/nio/ch/DatagramChannelImpl.c ! src/solaris/native/sun/nio/ch/FileKey.c ! src/solaris/native/sun/nio/ch/Net.c ! src/solaris/native/sun/nio/ch/ServerSocketChannelImpl.c ! src/solaris/native/sun/nio/ch/SocketChannelImpl.c ! src/solaris/native/sun/nio/ch/nio_util.h ! src/windows/native/java/net/net_util_md.c ! src/windows/native/sun/nio/ch/DatagramChannelImpl.c ! src/windows/native/sun/nio/ch/Net.c ! src/windows/native/sun/nio/ch/ServerSocketChannelImpl.c ! src/windows/native/sun/nio/ch/SocketChannelImpl.c + test/java/nio/channels/DatagramChannel/BasicMulticastTests.java + test/java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java + test/java/nio/channels/DatagramChannel/NetworkConfiguration.java + test/java/nio/channels/DatagramChannel/SocketOptionTests.java + test/java/nio/channels/ServerSocketChannel/SocketOptionTests.java + test/java/nio/channels/SocketChannel/SocketOptionTests.java ! test/java/nio/channels/TestUtil.java + test/java/nio/channels/etc/NetworkChannelTests.java Changeset: 0a427d0e70a7 Author: emcmanus Date: 2008-09-01 17:11 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/0a427d0e70a7 6731410: JMXServiceURL cannot use @ConstructorProperties for compatibility reasons Reviewed-by: dfuchs ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/management/remote/JMXServiceURL.java ! test/javax/management/mxbean/JMXServiceURLTest.java Changeset: 1d1d66438d11 Author: emcmanus Date: 2008-09-02 14:14 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/1d1d66438d11 6405862: Allow CompositeType to have zero items 6737133: Compilation failure of test/javax/management/eventService/LeaseManagerDeadlockTest.java 6737140: Javadoc of some throw clauses of MBeanServer and MBeanServerConnection is garbled 6737143: createMBean of MBeanServer should acquire 2 extra throw clauses present in MBeanServerConnection Reviewed-by: dfuchs ! src/share/classes/javax/management/MBeanServer.java ! src/share/classes/javax/management/MBeanServerConnection.java ! src/share/classes/javax/management/openmbean/CompositeType.java ! test/javax/management/eventService/LeaseManagerDeadlockTest.java Changeset: 00ea8fc81867 Author: emcmanus Date: 2008-09-03 14:31 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/00ea8fc81867 6744132: Spurious failures from test/javax/management/MBeanInfo/NotificationInfoTest.java Reviewed-by: dfuchs ! test/javax/management/MBeanInfo/NotificationInfoTest.java Changeset: 9145ff046bb4 Author: dfuchs Date: 2008-09-04 14:46 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/9145ff046bb4 5072476: RFE: support cascaded (federated) MBean Servers 6299231: Add support for named MBean Servers Summary: New javax.management.namespace package. Reviewed-by: emcmanus ! make/docs/CORE_PKGS.gmk ! src/share/classes/com/sun/jmx/defaults/JmxProperties.java ! src/share/classes/com/sun/jmx/interceptor/DefaultMBeanServerInterceptor.java + src/share/classes/com/sun/jmx/interceptor/DispatchInterceptor.java + src/share/classes/com/sun/jmx/interceptor/DomainDispatchInterceptor.java ! src/share/classes/com/sun/jmx/interceptor/MBeanServerInterceptor.java + src/share/classes/com/sun/jmx/interceptor/MBeanServerInterceptorSupport.java - src/share/classes/com/sun/jmx/interceptor/MBeanServerSupport.java + src/share/classes/com/sun/jmx/interceptor/NamespaceDispatchInterceptor.java ! src/share/classes/com/sun/jmx/interceptor/SingleMBeanForwarder.java ! src/share/classes/com/sun/jmx/mbeanserver/JmxMBeanServer.java ! src/share/classes/com/sun/jmx/mbeanserver/MXBeanLookup.java ! src/share/classes/com/sun/jmx/mbeanserver/Repository.java ! src/share/classes/com/sun/jmx/mbeanserver/SunJmxMBeanServer.java ! src/share/classes/com/sun/jmx/mbeanserver/Util.java + src/share/classes/com/sun/jmx/namespace/DomainInterceptor.java + src/share/classes/com/sun/jmx/namespace/HandlerInterceptor.java + src/share/classes/com/sun/jmx/namespace/JMXNamespaceUtils.java + src/share/classes/com/sun/jmx/namespace/NamespaceInterceptor.java + src/share/classes/com/sun/jmx/namespace/ObjectNameRouter.java + src/share/classes/com/sun/jmx/namespace/RoutingConnectionProxy.java + src/share/classes/com/sun/jmx/namespace/RoutingMBeanServerConnection.java + src/share/classes/com/sun/jmx/namespace/RoutingProxy.java + src/share/classes/com/sun/jmx/namespace/RoutingServerProxy.java + src/share/classes/com/sun/jmx/namespace/package.html + src/share/classes/com/sun/jmx/namespace/serial/DefaultRewritingProcessor.java + src/share/classes/com/sun/jmx/namespace/serial/IdentityProcessor.java + src/share/classes/com/sun/jmx/namespace/serial/JMXNamespaceContext.java + src/share/classes/com/sun/jmx/namespace/serial/RewritingProcessor.java + src/share/classes/com/sun/jmx/namespace/serial/RoutingOnlyProcessor.java + src/share/classes/com/sun/jmx/namespace/serial/SerialRewritingProcessor.java + src/share/classes/com/sun/jmx/namespace/serial/package.html ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/util/EventClientConnection.java ! src/share/classes/javax/management/InstanceNotFoundException.java ! src/share/classes/javax/management/MBeanPermission.java ! src/share/classes/javax/management/MBeanServer.java ! src/share/classes/javax/management/MBeanServerDelegate.java ! src/share/classes/javax/management/MBeanServerFactory.java ! src/share/classes/javax/management/ObjectName.java ! src/share/classes/javax/management/event/EventClient.java ! src/share/classes/javax/management/event/EventClientDelegate.java + src/share/classes/javax/management/namespace/JMXDomain.java + src/share/classes/javax/management/namespace/JMXNamespace.java + src/share/classes/javax/management/namespace/JMXNamespaceMBean.java + src/share/classes/javax/management/namespace/JMXNamespacePermission.java + src/share/classes/javax/management/namespace/JMXNamespaceView.java + src/share/classes/javax/management/namespace/JMXNamespaces.java + src/share/classes/javax/management/namespace/JMXRemoteNamespace.java + src/share/classes/javax/management/namespace/JMXRemoteNamespaceMBean.java + src/share/classes/javax/management/namespace/MBeanServerConnectionWrapper.java + src/share/classes/javax/management/namespace/MBeanServerSupport.java + src/share/classes/javax/management/namespace/VirtualEventManager.java + src/share/classes/javax/management/namespace/package-info.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java + test/javax/management/MBeanServerFactory/NamedMBeanServerTest.java ! test/javax/management/ObjectName/ApplyWildcardTest.java + test/javax/management/namespace/DomainCreationTest.java + test/javax/management/namespace/EventWithNamespaceControlTest.java + test/javax/management/namespace/EventWithNamespaceTest.java + test/javax/management/namespace/ExportNamespaceTest.java + test/javax/management/namespace/JMXDomainTest.java + test/javax/management/namespace/JMXNamespaceSecurityTest.java + test/javax/management/namespace/JMXNamespaceTest.java + test/javax/management/namespace/JMXNamespaceViewTest.java + test/javax/management/namespace/JMXNamespacesTest.java + test/javax/management/namespace/JMXRemoteNamespaceTest.java + test/javax/management/namespace/JMXRemoteTargetNamespace.java + test/javax/management/namespace/LazyDomainTest.java + test/javax/management/namespace/MXBeanRefTest.java + test/javax/management/namespace/NamespaceController.java + test/javax/management/namespace/NamespaceControllerMBean.java + test/javax/management/namespace/NamespaceCreationTest.java + test/javax/management/namespace/NamespaceNotificationsTest.java + test/javax/management/namespace/NullDomainObjectNameTest.java + test/javax/management/namespace/NullObjectNameTest.java + test/javax/management/namespace/QueryNamesTest.java + test/javax/management/namespace/RemoveNotificationListenerTest.java + test/javax/management/namespace/RoutingServerProxyTest.java + test/javax/management/namespace/SerialParamProcessorTest.java + test/javax/management/namespace/SourceNamespaceTest.java + test/javax/management/namespace/VirtualMBeanNotifTest.java + test/javax/management/namespace/VirtualMBeanTest.java + test/javax/management/namespace/VirtualNamespaceQueryTest.java + test/javax/management/namespace/VirtualPropsTest.java + test/javax/management/namespace/Wombat.java + test/javax/management/namespace/WombatMBean.java + test/javax/management/namespace/namespace.policy Changeset: 71a5f3f55b9c Author: tbell Date: 2008-09-04 14:55 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/71a5f3f55b9c Merge - src/share/classes/com/sun/jmx/interceptor/MBeanServerSupport.java - src/share/classes/java/nio/channels/package.html - src/share/classes/sun/nio/ch/OptionAdaptor.java - src/share/classes/sun/nio/ch/SocketOpts.java - src/share/classes/sun/nio/ch/SocketOptsImpl.java - src/share/classes/sun/nio/ch/exceptions Changeset: 59aa6b578cf0 Author: bristor Date: 2008-09-08 13:44 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/59aa6b578cf0 6661861: Decrease memory use of Inflaters by ZipFile Summary: Fix allows release of native resources earlier than without fix Reviewed-by: alanb ! src/share/classes/java/util/zip/Inflater.java ! src/share/classes/java/util/zip/ZipFile.java Changeset: 334efd173b8f Author: bristor Date: 2008-09-08 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/334efd173b8f 6356642: extcheck.exe -verbose throws ArrayIndexOutOfBoundsException exception Summary: Fix causes printing of user-level error messages instead of throwing exceptions Reviewed-by: sherman ! src/share/classes/com/sun/tools/extcheck/ExtCheck.java ! src/share/classes/com/sun/tools/extcheck/Main.java + test/com/sun/tools/extcheck/TestExtcheckArgs.java + test/com/sun/tools/extcheck/TestExtcheckArgs.sh Changeset: 8484e830666e Author: tbell Date: 2008-09-12 14:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/8484e830666e Merge Changeset: a23b7f4f8b3c Author: ohair Date: 2008-09-10 09:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/a23b7f4f8b3c 6746421: Compare images logic needs to be more forgiving Reviewed-by: tbell ! make/common/shared/Defs.gmk Changeset: 395eb8a7846b Author: ohair Date: 2008-09-10 09:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/395eb8a7846b 6746424: Remove build dependency on findbugs and FINDBUGS_HOME Reviewed-by: tbell ! make/common/Sanity.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/jprt.config Changeset: ec301c0956be Author: ohair Date: 2008-09-10 10:16 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/ec301c0956be 6746430: Fix problems with getting 'ant -version' and the required setting of 'ANT_HOME' Reviewed-by: tbell ! make/common/shared/Defs.gmk ! make/common/shared/Sanity.gmk Changeset: 41bcf49eb3a1 Author: ohair Date: 2008-09-10 10:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/41bcf49eb3a1 6746409: Error: dl failure on line 689: Copies of libjvm.so need to have chcon (selinux) re-applied to them Reviewed-by: tbell ! make/common/Defs.gmk Changeset: c7ab37f5976d Author: ohair Date: 2008-09-11 11:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/c7ab37f5976d 6746415: The include file stropts.h is not available in Fedora 9 (STREAMS Kernel Extension?) Reviewed-by: tbell ! src/solaris/native/com/sun/media/sound/PLATFORM_API_SolarisOS_Utils.h Changeset: da5513a6af53 Author: ohair Date: 2008-09-11 11:27 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/da5513a6af53 Merge ! make/common/Defs.gmk - src/share/javavm/include/opcodes.h - src/share/javavm/include/opcodes.length - src/share/javavm/include/opcodes.list - src/share/javavm/include/opcodes.weight - src/share/javavm/include/opcodes.wide - src/share/javavm/include/sys_api.h - src/share/javavm/include/typedefs.h - src/solaris/javavm/include/typedefs_md.h - src/windows/javavm/include/typedefs_md.h Changeset: 16818689f727 Author: xdono Date: 2008-09-17 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/16818689f727 Merge - src/share/classes/com/sun/jmx/interceptor/MBeanServerSupport.java - src/share/classes/java/nio/channels/package.html - src/share/classes/sun/nio/ch/OptionAdaptor.java - src/share/classes/sun/nio/ch/SocketOpts.java - src/share/classes/sun/nio/ch/SocketOptsImpl.java - src/share/classes/sun/nio/ch/exceptions Changeset: 80a4ace80c31 Author: ant Date: 2008-06-04 12:32 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/80a4ace80c31 6280057: I have audited SystemTray and TrayIcon code Summary: small refactoring Reviewed-by: dcherepanov ! src/share/classes/java/awt/SystemTray.java ! src/share/classes/java/awt/TrayIcon.java Changeset: adebdf3701a4 Author: ant Date: 2008-06-04 14:16 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/adebdf3701a4 6708322: test/closed/java/awt/Focus/TemporaryLostComponentDeadlock fails Summary: Introduced new package private object for synchronization purposes. It should replace "this" in some deadlock prone cases. Reviewed-by: anthony, art ! src/share/classes/java/awt/Component.java Changeset: 58a2ba2767be Author: yan Date: 2008-06-11 01:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/58a2ba2767be Merge - src/solaris/classes/sun/java2d/SurfaceManagerFactory.java - src/windows/classes/sun/java2d/SurfaceManagerFactory.java - test/javax/management/Introspector/LegacyIntrospectorTest.java Changeset: a9b5b5d105a8 Author: ant Date: 2008-06-17 13:37 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/a9b5b5d105a8 4685768: A11y issue - Focus set to disabled component, can't Tab/Shift-Tab Summary: The restore-focus procedure should skip disabled components. Reviewed-by: art, dcherepanov ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/Window.java + test/java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java + test/java/awt/Focus/RequestFocusToDisabledCompTest/RequestFocusToDisabledCompTest.java ! test/java/awt/regtesthelpers/Util.java Changeset: d407360176c0 Author: dav Date: 2008-06-18 15:35 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/d407360176c0 6616323: consider benefits of replacing a componen array with other collection from the awt.Container class Reviewed-by: uta, art ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/ScrollPane.java ! src/windows/native/sun/windows/awt_Container.cpp ! src/windows/native/sun/windows/awt_Container.h + test/java/awt/Container/CheckZOrderChange/CheckZOrderChange.java Changeset: 142e19f00424 Author: dav Date: 2008-06-18 19:20 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/142e19f00424 6716137: Fix 6691328 is broken Reviewed-by: dcherepanov, denis ! src/share/classes/java/awt/dnd/DragSourceContext.java Changeset: 321f5f269836 Author: dav Date: 2008-06-18 19:27 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/321f5f269836 Merge Changeset: 38e32b2db431 Author: yan Date: 2008-06-19 11:26 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/38e32b2db431 6706121: makefile: unnecessary Motif classes compilation in JDK7 Summary: removed 80 obsolete .c and .java files, temporary modified some more Reviewed-by: denis ! make/sun/awt/FILES_c_unix.gmk ! make/sun/awt/FILES_export_unix.gmk ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers-linux ! make/sun/awt/mawt.gmk ! make/sun/jawt/Makefile - src/solaris/classes/sun/awt/motif/MButtonPeer.java - src/solaris/classes/sun/awt/motif/MCanvasPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxPeer.java - src/solaris/classes/sun/awt/motif/MChoicePeer.java - src/solaris/classes/sun/awt/motif/MComponentPeer.java - src/solaris/classes/sun/awt/motif/MCustomCursor.java - src/solaris/classes/sun/awt/motif/MDataTransferer.java - src/solaris/classes/sun/awt/motif/MDialogPeer.java - src/solaris/classes/sun/awt/motif/MDragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/MDropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/MEmbedCanvasPeer.java - src/solaris/classes/sun/awt/motif/MEmbeddedFrame.java - src/solaris/classes/sun/awt/motif/MEmbeddedFramePeer.java - src/solaris/classes/sun/awt/motif/MFileDialogPeer.java - src/solaris/classes/sun/awt/motif/MFramePeer.java - src/solaris/classes/sun/awt/motif/MGlobalCursorManager.java - src/solaris/classes/sun/awt/motif/MInputMethod.java - src/solaris/classes/sun/awt/motif/MInputMethodControl.java - src/solaris/classes/sun/awt/motif/MInputMethodDescriptor.java - src/solaris/classes/sun/awt/motif/MLabelPeer.java - src/solaris/classes/sun/awt/motif/MListPeer.java - src/solaris/classes/sun/awt/motif/MMenuBarPeer.java - src/solaris/classes/sun/awt/motif/MMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MMenuPeer.java - src/solaris/classes/sun/awt/motif/MMouseDragGestureRecognizer.java - src/solaris/classes/sun/awt/motif/MPanelPeer.java - src/solaris/classes/sun/awt/motif/MPopupMenuPeer.java - src/solaris/classes/sun/awt/motif/MRobotPeer.java - src/solaris/classes/sun/awt/motif/MScrollPanePeer.java - src/solaris/classes/sun/awt/motif/MScrollbarPeer.java - src/solaris/classes/sun/awt/motif/MTextAreaPeer.java - src/solaris/classes/sun/awt/motif/MTextFieldPeer.java ! src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MWindowPeer.java - src/solaris/classes/sun/awt/motif/X11Clipboard.java - src/solaris/classes/sun/awt/motif/X11DragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/X11DropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/X11Selection.java - src/solaris/classes/sun/awt/motif/X11SelectionHolder.java - src/solaris/native/sun/awt/awt_Button.c - src/solaris/native/sun/awt/awt_Canvas.c - src/solaris/native/sun/awt/awt_Checkbox.c - src/solaris/native/sun/awt/awt_Choice12.c - src/solaris/native/sun/awt/awt_Choice21.c - src/solaris/native/sun/awt/awt_Component.c - src/solaris/native/sun/awt/awt_Cursor.c - src/solaris/native/sun/awt/awt_DataTransferer.c - src/solaris/native/sun/awt/awt_DataTransferer.h ! src/solaris/native/sun/awt/awt_DrawingSurface.c - src/solaris/native/sun/awt/awt_FileDialog.c - src/solaris/native/sun/awt/awt_GlobalCursorManager.c - src/solaris/native/sun/awt/awt_KeyboardFocusManager.c - src/solaris/native/sun/awt/awt_Label.c - src/solaris/native/sun/awt/awt_List.c ! src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_Menu.c - src/solaris/native/sun/awt/awt_Menu.h - src/solaris/native/sun/awt/awt_MenuBar.c - src/solaris/native/sun/awt/awt_MenuBar.h - src/solaris/native/sun/awt/awt_MenuComponent.c - src/solaris/native/sun/awt/awt_MenuItem.c - src/solaris/native/sun/awt/awt_PopupMenu.c ! src/solaris/native/sun/awt/awt_Robot.c - src/solaris/native/sun/awt/awt_ScrollPane.c - src/solaris/native/sun/awt/awt_Scrollbar.c - src/solaris/native/sun/awt/awt_Selection.c - src/solaris/native/sun/awt/awt_TextArea.c - src/solaris/native/sun/awt/awt_TextArea.h - src/solaris/native/sun/awt/awt_TextField.c - src/solaris/native/sun/awt/awt_TextField.h - src/solaris/native/sun/awt/awt_TopLevel.c - src/solaris/native/sun/awt/awt_XmDnD.c - src/solaris/native/sun/awt/awt_XmDnD.h - src/solaris/native/sun/awt/awt_dnd.c - src/solaris/native/sun/awt/awt_dnd.h - src/solaris/native/sun/awt/awt_dnd_ds.c - src/solaris/native/sun/awt/awt_dnd_dt.c - src/solaris/native/sun/awt/awt_motif.c - src/solaris/native/sun/awt/awt_motif12.c - src/solaris/native/sun/awt/awt_motif21.c ! src/solaris/native/sun/awt/awt_p.h - src/solaris/native/sun/awt/awt_xembed.c - src/solaris/native/sun/awt/canvas.c - src/solaris/native/sun/awt/cursor.c ! src/solaris/native/sun/awt/initIDs.c ! src/solaris/native/sun/awt/multi_font.c Changeset: fae7c1f5ba78 Author: dav Date: 2008-06-19 16:09 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/fae7c1f5ba78 6694792: Syntax error in java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_2.java Reviewed-by: yan ! test/java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_2.java Changeset: 9b66576b81f0 Author: ant Date: 2008-06-23 14:42 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/9b66576b81f0 6682536: java\awt\FullScreen\NonfocusableFrameFullScreenTest\NonfocusableFrameFullScreenTest.java fails Summary: always-on-top property should be restored on exiting full-screen. Reviewed-by: tdv ! src/windows/native/sun/windows/awt_Win32GraphicsDevice.cpp Changeset: 59e34bb65340 Author: anthony Date: 2008-06-23 16:03 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/59e34bb65340 6704896: FD_SET usage can cause stack corruption (sol) Summary: Using poll() instead of select() Reviewed-by: yan, denis ! src/solaris/native/sun/awt/splashscreen/splashscreen_sys.c Changeset: 4ccac6957211 Author: dcherepanov Date: 2008-06-26 14:23 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/4ccac6957211 6581899: JTextField & JTextArea - Poor performance with JRE 1.5.0_08 Summary: acquire the first|last components only when the key is a traversal key Reviewed-by: ant ! src/share/classes/sun/awt/EmbeddedFrame.java Changeset: d2165ac39874 Author: dcherepanov Date: 2008-07-07 15:36 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/d2165ac39874 6582346: javaw launcher does not display MessageBox after change to the resource files Summary: call InitCommonControlsEx to perform UI initialization Reviewed-by: art ! src/windows/native/sun/windows/ComCtl32Util.cpp ! src/windows/native/sun/windows/ComCtl32Util.h Changeset: d635c9a971c9 Author: dav Date: 2008-07-07 16:09 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/d635c9a971c9 6693974: Unify EventQueue$EventQueueItem and SunToolkit.$EventQueueItem classes Reviewed-by: volk, art ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/sun/awt/SunToolkit.java Changeset: 9a1b30777d9d Author: dav Date: 2008-07-07 16:32 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/9a1b30777d9d Merge Changeset: 5a75640258ba Author: anthony Date: 2008-07-07 17:24 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/5a75640258ba 6682046: Mixing code does not always recalculate shapes correctly when resizing components Summary: The valid property is now encapsulated in Component. Reviewed-by: art ! src/share/classes/java/awt/Button.java ! src/share/classes/java/awt/Checkbox.java ! src/share/classes/java/awt/Choice.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/Frame.java ! src/share/classes/java/awt/Label.java ! src/share/classes/java/awt/TextField.java Changeset: 3361b420a0a2 Author: anthony Date: 2008-07-07 17:39 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/3361b420a0a2 6723018: Need to push the test for 6682046 Summary: Pushed the test Reviewed-by: art + test/java/awt/Mixing/Validating.java Changeset: 9c9f18a2cdef Author: dav Date: 2008-07-08 16:20 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/9c9f18a2cdef 6723013: Incomplete push for 6693974 Reviewed-by: art + src/share/classes/sun/awt/EventQueueItem.java Changeset: 250129565224 Author: art Date: 2008-07-25 15:19 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/250129565224 6235443: REG:Overlapping a swing app with an AWT app causes flickering in the background swing app on Windows Summary: AWT text area no longer uses LockWindowUpdate Reviewed-by: uta, dcherepanov ! src/windows/native/sun/windows/awt_TextArea.cpp Changeset: 97d85ec01100 Author: yan Date: 2008-08-05 15:26 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/97d85ec01100 6454041: decimal separator munches the character standing at the right (sk keyboard) Summary: in a group of keysyms associated with a key, check for keypad-ness of more keysyms Reviewed-by: art ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/classes/sun/awt/X11/keysym2ucs.h Changeset: f0043a2428f6 Author: yan Date: 2008-08-08 03:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/f0043a2428f6 Merge - make/java/nio/spp.sh ! make/sun/awt/FILES_export_unix.gmk ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers-linux - make/tools/winver/Makefile - make/tools/winver/bin/winver.exe - make/tools/winver/src/StdAfx.cpp - make/tools/winver/src/StdAfx.h - make/tools/winver/src/winver.cpp - src/share/classes/com/sun/jmx/mbeanserver/OpenConverter.java ! src/share/classes/java/awt/Button.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java - src/share/classes/javax/management/ToQueryString.java ! src/solaris/native/sun/awt/splashscreen/splashscreen_sys.c - src/windows/classes/sun/java2d/d3d/D3DBackBufferSurfaceData.java - src/windows/classes/sun/java2d/windows/DDBlitLoops.java - src/windows/classes/sun/java2d/windows/DDRenderer.java - src/windows/classes/sun/java2d/windows/DDScaleLoops.java - src/windows/classes/sun/java2d/windows/Win32OffScreenSurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceDataProxy.java - src/windows/classes/sun/java2d/windows/WinBackBuffer.java - src/windows/classes/sun/java2d/windows/WinBackBufferSurfaceData.java - src/windows/classes/sun/java2d/windows/WinVolatileSurfaceManager.java - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.cpp - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.h - src/windows/native/sun/java2d/d3d/D3DTestRaster.h - src/windows/native/sun/java2d/d3d/D3DTextRenderer_md.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.h - src/windows/native/sun/java2d/windows/DDBlitLoops.cpp - src/windows/native/sun/java2d/windows/DDRenderer.cpp - src/windows/native/sun/java2d/windows/RegistryKey.cpp - src/windows/native/sun/java2d/windows/RegistryKey.h - src/windows/native/sun/java2d/windows/Win32OffScreenSurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.h - src/windows/native/sun/java2d/windows/WinBackBufferSurfaceData.cpp - src/windows/native/sun/java2d/windows/ddrawObject.cpp - src/windows/native/sun/java2d/windows/ddrawObject.h - src/windows/native/sun/java2d/windows/ddrawUtils.cpp - src/windows/native/sun/java2d/windows/ddrawUtils.h - src/windows/native/sun/java2d/windows/dxCapabilities.cpp - src/windows/native/sun/java2d/windows/dxCapabilities.h - src/windows/native/sun/java2d/windows/dxInit.cpp - src/windows/native/sun/java2d/windows/dxInit.h ! src/windows/native/sun/windows/awt_Win32GraphicsDevice.cpp Changeset: 5e61b8180623 Author: art Date: 2008-08-12 12:00 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/5e61b8180623 6735584: XNETProtocol:setStateHelper() produces bad _NET_WM_STATE messages Reviewed-by: yan ! src/solaris/classes/sun/awt/X11/XNETProtocol.java Changeset: 99658a8d42fa Author: art Date: 2008-08-14 12:58 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/99658a8d42fa 6708392: Provide internal API to create OverrideRedirect windows, XToolkit Summary: SunToolkit.setOverrideRedirect() method is introduced Reviewed-by: mlapshin, yan ! src/share/classes/javax/swing/Popup.java ! src/share/classes/sun/awt/SunToolkit.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: e8301d67f7fa Author: dcherepanov Date: 2008-08-25 19:15 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/e8301d67f7fa 6737722: api/java_awt/TrayIcon/index.html#TrayIconHeadlessMode Summary: isSupported() should skip tray initialization in case of headless Reviewed-by: art, ant ! src/share/classes/java/awt/SystemTray.java ! src/share/classes/java/awt/TrayIcon.java + test/java/awt/Toolkit/HeadlessTray/HeadlessTray.java Changeset: 9d5e52760d53 Author: lana Date: 2008-08-25 13:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/9d5e52760d53 Merge - src/solaris/classes/sun/awt/motif/MButtonPeer.java - src/solaris/classes/sun/awt/motif/MCanvasPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxPeer.java - src/solaris/classes/sun/awt/motif/MChoicePeer.java - src/solaris/classes/sun/awt/motif/MComponentPeer.java - src/solaris/classes/sun/awt/motif/MCustomCursor.java - src/solaris/classes/sun/awt/motif/MDataTransferer.java - src/solaris/classes/sun/awt/motif/MDialogPeer.java - src/solaris/classes/sun/awt/motif/MDragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/MDropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/MEmbedCanvasPeer.java - src/solaris/classes/sun/awt/motif/MEmbeddedFrame.java - src/solaris/classes/sun/awt/motif/MEmbeddedFramePeer.java - src/solaris/classes/sun/awt/motif/MFileDialogPeer.java - src/solaris/classes/sun/awt/motif/MFramePeer.java - src/solaris/classes/sun/awt/motif/MGlobalCursorManager.java - src/solaris/classes/sun/awt/motif/MInputMethod.java - src/solaris/classes/sun/awt/motif/MInputMethodControl.java - src/solaris/classes/sun/awt/motif/MInputMethodDescriptor.java - src/solaris/classes/sun/awt/motif/MLabelPeer.java - src/solaris/classes/sun/awt/motif/MListPeer.java - src/solaris/classes/sun/awt/motif/MMenuBarPeer.java - src/solaris/classes/sun/awt/motif/MMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MMenuPeer.java - src/solaris/classes/sun/awt/motif/MMouseDragGestureRecognizer.java - src/solaris/classes/sun/awt/motif/MPanelPeer.java - src/solaris/classes/sun/awt/motif/MPopupMenuPeer.java - src/solaris/classes/sun/awt/motif/MRobotPeer.java - src/solaris/classes/sun/awt/motif/MScrollPanePeer.java - src/solaris/classes/sun/awt/motif/MScrollbarPeer.java - src/solaris/classes/sun/awt/motif/MTextAreaPeer.java - src/solaris/classes/sun/awt/motif/MTextFieldPeer.java - src/solaris/classes/sun/awt/motif/MWindowPeer.java - src/solaris/classes/sun/awt/motif/X11Clipboard.java - src/solaris/classes/sun/awt/motif/X11DragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/X11DropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/X11Selection.java - src/solaris/classes/sun/awt/motif/X11SelectionHolder.java - src/solaris/native/sun/awt/awt_Button.c - src/solaris/native/sun/awt/awt_Canvas.c - src/solaris/native/sun/awt/awt_Checkbox.c - src/solaris/native/sun/awt/awt_Choice12.c - src/solaris/native/sun/awt/awt_Choice21.c - src/solaris/native/sun/awt/awt_Component.c - src/solaris/native/sun/awt/awt_Cursor.c - src/solaris/native/sun/awt/awt_DataTransferer.c - src/solaris/native/sun/awt/awt_DataTransferer.h - src/solaris/native/sun/awt/awt_FileDialog.c - src/solaris/native/sun/awt/awt_GlobalCursorManager.c - src/solaris/native/sun/awt/awt_KeyboardFocusManager.c - src/solaris/native/sun/awt/awt_Label.c - src/solaris/native/sun/awt/awt_List.c - src/solaris/native/sun/awt/awt_Menu.c - src/solaris/native/sun/awt/awt_Menu.h - src/solaris/native/sun/awt/awt_MenuBar.c - src/solaris/native/sun/awt/awt_MenuBar.h - src/solaris/native/sun/awt/awt_MenuComponent.c - src/solaris/native/sun/awt/awt_MenuItem.c - src/solaris/native/sun/awt/awt_PopupMenu.c - src/solaris/native/sun/awt/awt_ScrollPane.c - src/solaris/native/sun/awt/awt_Scrollbar.c - src/solaris/native/sun/awt/awt_Selection.c - src/solaris/native/sun/awt/awt_TextArea.c - src/solaris/native/sun/awt/awt_TextArea.h - src/solaris/native/sun/awt/awt_TextField.c - src/solaris/native/sun/awt/awt_TextField.h - src/solaris/native/sun/awt/awt_TopLevel.c - src/solaris/native/sun/awt/awt_XmDnD.c - src/solaris/native/sun/awt/awt_XmDnD.h - src/solaris/native/sun/awt/awt_dnd.c - src/solaris/native/sun/awt/awt_dnd.h - src/solaris/native/sun/awt/awt_dnd_ds.c - src/solaris/native/sun/awt/awt_dnd_dt.c - src/solaris/native/sun/awt/awt_motif.c - src/solaris/native/sun/awt/awt_motif12.c - src/solaris/native/sun/awt/awt_motif21.c - src/solaris/native/sun/awt/awt_xembed.c - src/solaris/native/sun/awt/canvas.c - src/solaris/native/sun/awt/cursor.c Changeset: 134fd1a656ea Author: lana Date: 2008-09-19 19:38 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/134fd1a656ea Merge - src/solaris/classes/sun/awt/motif/MButtonPeer.java - src/solaris/classes/sun/awt/motif/MCanvasPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxPeer.java - src/solaris/classes/sun/awt/motif/MChoicePeer.java - src/solaris/classes/sun/awt/motif/MComponentPeer.java - src/solaris/classes/sun/awt/motif/MCustomCursor.java - src/solaris/classes/sun/awt/motif/MDataTransferer.java - src/solaris/classes/sun/awt/motif/MDialogPeer.java - src/solaris/classes/sun/awt/motif/MDragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/MDropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/MEmbedCanvasPeer.java - src/solaris/classes/sun/awt/motif/MEmbeddedFrame.java - src/solaris/classes/sun/awt/motif/MEmbeddedFramePeer.java - src/solaris/classes/sun/awt/motif/MFileDialogPeer.java - src/solaris/classes/sun/awt/motif/MFramePeer.java - src/solaris/classes/sun/awt/motif/MGlobalCursorManager.java - src/solaris/classes/sun/awt/motif/MInputMethod.java - src/solaris/classes/sun/awt/motif/MInputMethodControl.java - src/solaris/classes/sun/awt/motif/MInputMethodDescriptor.java - src/solaris/classes/sun/awt/motif/MLabelPeer.java - src/solaris/classes/sun/awt/motif/MListPeer.java - src/solaris/classes/sun/awt/motif/MMenuBarPeer.java - src/solaris/classes/sun/awt/motif/MMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MMenuPeer.java - src/solaris/classes/sun/awt/motif/MMouseDragGestureRecognizer.java - src/solaris/classes/sun/awt/motif/MPanelPeer.java - src/solaris/classes/sun/awt/motif/MPopupMenuPeer.java - src/solaris/classes/sun/awt/motif/MRobotPeer.java - src/solaris/classes/sun/awt/motif/MScrollPanePeer.java - src/solaris/classes/sun/awt/motif/MScrollbarPeer.java - src/solaris/classes/sun/awt/motif/MTextAreaPeer.java - src/solaris/classes/sun/awt/motif/MTextFieldPeer.java - src/solaris/classes/sun/awt/motif/MWindowPeer.java - src/solaris/classes/sun/awt/motif/X11Clipboard.java - src/solaris/classes/sun/awt/motif/X11DragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/X11DropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/X11Selection.java - src/solaris/classes/sun/awt/motif/X11SelectionHolder.java - src/solaris/native/sun/awt/awt_Button.c - src/solaris/native/sun/awt/awt_Canvas.c - src/solaris/native/sun/awt/awt_Checkbox.c - src/solaris/native/sun/awt/awt_Choice12.c - src/solaris/native/sun/awt/awt_Choice21.c - src/solaris/native/sun/awt/awt_Component.c - src/solaris/native/sun/awt/awt_Cursor.c - src/solaris/native/sun/awt/awt_DataTransferer.c - src/solaris/native/sun/awt/awt_DataTransferer.h - src/solaris/native/sun/awt/awt_FileDialog.c - src/solaris/native/sun/awt/awt_GlobalCursorManager.c - src/solaris/native/sun/awt/awt_KeyboardFocusManager.c - src/solaris/native/sun/awt/awt_Label.c - src/solaris/native/sun/awt/awt_List.c - src/solaris/native/sun/awt/awt_Menu.c - src/solaris/native/sun/awt/awt_Menu.h - src/solaris/native/sun/awt/awt_MenuBar.c - src/solaris/native/sun/awt/awt_MenuBar.h - src/solaris/native/sun/awt/awt_MenuComponent.c - src/solaris/native/sun/awt/awt_MenuItem.c - src/solaris/native/sun/awt/awt_PopupMenu.c - src/solaris/native/sun/awt/awt_ScrollPane.c - src/solaris/native/sun/awt/awt_Scrollbar.c - src/solaris/native/sun/awt/awt_Selection.c - src/solaris/native/sun/awt/awt_TextArea.c - src/solaris/native/sun/awt/awt_TextArea.h - src/solaris/native/sun/awt/awt_TextField.c - src/solaris/native/sun/awt/awt_TextField.h - src/solaris/native/sun/awt/awt_TopLevel.c - src/solaris/native/sun/awt/awt_XmDnD.c - src/solaris/native/sun/awt/awt_XmDnD.h - src/solaris/native/sun/awt/awt_dnd.c - src/solaris/native/sun/awt/awt_dnd.h - src/solaris/native/sun/awt/awt_dnd_ds.c - src/solaris/native/sun/awt/awt_dnd_dt.c - src/solaris/native/sun/awt/awt_motif.c - src/solaris/native/sun/awt/awt_motif12.c - src/solaris/native/sun/awt/awt_motif21.c - src/solaris/native/sun/awt/awt_xembed.c - src/solaris/native/sun/awt/canvas.c - src/solaris/native/sun/awt/cursor.c Changeset: 73b3e1a40bdf Author: xdono Date: 2008-09-25 12:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/73b3e1a40bdf Added tag jdk7-b36 for changeset 134fd1a656ea ! .hgtags From john.coomes at sun.com Fri Sep 26 02:56:14 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 26 Sep 2008 09:56:14 +0000 Subject: hg: jdk7/hotspot-comp/langtools: 7 new changesets Message-ID: <20080926095626.83A07D331@hg.openjdk.java.net> Changeset: e571266ae14f Author: jjg Date: 2008-08-26 14:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/e571266ae14f 6508981: cleanup file separator handling in JavacFileManager Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java + src/share/classes/com/sun/tools/javac/file/RelativePath.java ! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/javax/tools/StandardLocation.java + test/tools/javac/6508981/TestInferBinaryName.java + test/tools/javac/6508981/p/A.java ! test/tools/javac/T6725036.java Changeset: 5e89c4ca637c Author: jjg Date: 2008-08-29 11:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/5e89c4ca637c 6597471: unused imports in javax.tools.JavaCompiler 6597531: unused imports and unused private const. in com.sun.tools.javac.Server.java Reviewed-by: mcimadamore Contributed-by: davide.angelocola at gmail.com ! src/share/classes/com/sun/tools/javac/Server.java ! src/share/classes/com/sun/tools/javac/api/JavacScope.java ! src/share/classes/com/sun/tools/javac/api/WrappingJavaFileManager.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Env.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/model/FilteredMemberList.java ! src/share/classes/com/sun/tools/javac/parser/DocCommentScanner.java ! src/share/classes/com/sun/tools/javac/parser/EndPosParser.java ! src/share/classes/com/sun/tools/javac/processing/JavacFiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java ! src/share/classes/com/sun/tools/javac/processing/ServiceProxy.java ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/Context.java Changeset: 7b59e34898ff Author: tbell Date: 2008-08-31 12:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/7b59e34898ff Merge Changeset: ceaa6549687a Author: jjg Date: 2008-09-03 10:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/ceaa6549687a 6743107: clean up use of static caches in file manager Reviewed-by: mcimadamore + src/share/classes/com/sun/tools/javac/file/CacheFSInfo.java + src/share/classes/com/sun/tools/javac/file/FSInfo.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/main/Main.java Changeset: 5a9b808557b6 Author: tbell Date: 2008-09-04 14:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/5a9b808557b6 Merge Changeset: 258af9b67b7c Author: tbell Date: 2008-09-12 14:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/258af9b67b7c Merge Changeset: 2c643f1be517 Author: xdono Date: 2008-09-25 12:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/2c643f1be517 Added tag jdk7-b36 for changeset 258af9b67b7c ! .hgtags From mark at klomp.org Fri Sep 26 04:02:20 2008 From: mark at klomp.org (Mark Wielaard) Date: Fri, 26 Sep 2008 13:02:20 +0200 Subject: hotspot JIT producing incorrect code -how should I report a bug? In-Reply-To: <48DC115F.2050106@sun.com> References: <4873C510.6030100@streambase.com> <4873DBBF.1020900@sun.com> <48740CBD.8060705@streambase.com> <4876805F.4030700@Sun.COM> <487E66C9.4050601@Sun.COM> <20080925215747.GA16445@gnu.wildebeest.org> <48DC115F.2050106@sun.com> Message-ID: <1222426940.3266.109.camel@dijkstra.wildebeest.org> Hi Chuck, On Thu, 2008-09-25 at 15:31 -0700, Chuck Rasbold wrote: > I don't think that you need to backport #6726504 and #6730192. Thanks for the info. > As for the test case, I love it, but based on the channel in which the > test case was submitted, Sun does not have ownership rights to the code, > so I can't add it to OpenJDK. I am not a lawyer, but someone who is > should feel free to correct me. You probably cannot claim copyright on the test case itself. But I would be surprised if when you ask the submitter to use the testcase you would be denied that. Obviously it was submitted precisely to get you a good testcase. Cheers, Mark From mark at klomp.org Fri Sep 26 04:20:52 2008 From: mark at klomp.org (Mark Wielaard) Date: Fri, 26 Sep 2008 13:20:52 +0200 Subject: More hotspot tests and some backported fixes Message-ID: <1222428052.3266.116.camel@dijkstra.wildebeest.org> Hi, I noticed openjdk6 and openjdk7 seem to have a mutually exclusive set of tests under hotspot/test/compiler. Since I believe having more tests is a good thing I merged them in icedtea6. That uncovered two crasher bugs in the hotspot form openjdk6 that we use. So I tracked down the fixes for those and backported them (patches attached). All 20 tests now PASS. It is probably a good idea to also merge the tests from 6 to 7. But I haven't done that yet. Note that again I did only backport for the hotspot from openjdk6, not the one that zero/shark uses (7b24). Cheers, Mark -------------- next part -------------- A non-text attachment was scrubbed... Name: icedtea-6700047-loopopts.patch Type: text/x-patch Size: 1446 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20080926/f24bdf5d/attachment.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: icedtea-6712835-ifnode.patch Type: text/x-patch Size: 1037 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20080926/f24bdf5d/attachment-0001.bin From Dalibor.Topic at Sun.COM Fri Sep 26 09:30:53 2008 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Fri, 26 Sep 2008 18:30:53 +0200 Subject: hotspot JIT producing incorrect code -how should I report a bug? In-Reply-To: <1222426940.3266.109.camel@dijkstra.wildebeest.org> References: <4873C510.6030100@streambase.com> <4873DBBF.1020900@sun.com> <48740CBD.8060705@streambase.com> <4876805F.4030700@Sun.COM> <487E66C9.4050601@Sun.COM> <20080925215747.GA16445@gnu.wildebeest.org> <48DC115F.2050106@sun.com> <1222426940.3266.109.camel@dijkstra.wildebeest.org> Message-ID: <48DD0E3D.1040507@sun.com> Mark Wielaard wrote: > You probably cannot claim copyright on the test case itself. But I would > be surprised if when you ask the submitter to use the testcase you would > be denied that. Obviously it was submitted precisely to get you a good > testcase. I'm happy to do the asking - could you point me to the test case & the submitter? cheers, dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer Vorsitzender des Aufsichtsrates: Martin H?ring From mlists at juma.me.uk Fri Sep 26 09:36:37 2008 From: mlists at juma.me.uk (Ismael Juma) Date: Fri, 26 Sep 2008 16:36:37 +0000 (UTC) Subject: hotspot JIT producing incorrect code -how should I report a bug? References: <4873C510.6030100@streambase.com> <4873DBBF.1020900@sun.com> <48740CBD.8060705@streambase.com> <4876805F.4030700@Sun.COM> <487E66C9.4050601@Sun.COM> <20080925215747.GA16445@gnu.wildebeest.org> <48DC115F.2050106@sun.com> <1222426940.3266.109.camel@dijkstra.wildebeest.org> <48DD0E3D.1040507@sun.com> Message-ID: Hi, Dalibor Topic writes: > Mark Wielaard wrote: > > You probably cannot claim copyright on the test case itself. But I would > > be surprised if when you ask the submitter to use the testcase you would > > be denied that. Obviously it was submitted precisely to get you a good > > testcase. > I'm happy to do the asking - could you point me to the test case & the > submitter? The bugs are: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6707044 https://issues.apache.org/jira/browse/LUCENE-1282 I think Michael would be happy to see his test case included. After all, I am sure he doesn't want to have to hunt down a similar bug again in the future. :) Regards, Ismael From gnu_andrew at member.fsf.org Fri Sep 26 15:42:35 2008 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Fri, 26 Sep 2008 23:42:35 +0100 Subject: More hotspot tests and some backported fixes In-Reply-To: <1222428052.3266.116.camel@dijkstra.wildebeest.org> References: <1222428052.3266.116.camel@dijkstra.wildebeest.org> Message-ID: <20080926224235.GB10172@rivendell.middle-earth.co.uk> On 13:20 Fri 26 Sep , Mark Wielaard wrote: > Hi, > > I noticed openjdk6 and openjdk7 seem to have a mutually exclusive set of > tests under hotspot/test/compiler. Since I believe having more tests is > a good thing I merged them in icedtea6. That uncovered two crasher bugs > in the hotspot form openjdk6 that we use. So I tracked down the fixes > for those and backported them (patches attached). All 20 tests now PASS. > > It is probably a good idea to also merge the tests from 6 to 7. But I > haven't done that yet. > > Note that again I did only backport for the hotspot from openjdk6, not > the one that zero/shark uses (7b24). > > Cheers, > > Mark > 6700047: C2 failed in idom_no_update > Summary: partial peeling shouldn't place clones into loop > > diff -r 4aebfff4f8a2 hotspot/src/share/vm/opto/loopopts.cpp > --- openjdk.orig/hotspot/src/share/vm/opto/loopopts.cpp Mon Sep 15 11:38:34 2008 +0200 > +++ openjdk/hotspot/src/share/vm/opto/loopopts.cpp Fri Sep 26 11:29:06 2008 +0200 > @@ -1865,18 +1865,19 @@ > _igvn.hash_delete(use); > use->set_req(j, n_clone); > _igvn._worklist.push(use); > + Node* use_c; > if (!use->is_Phi()) { > - Node* use_c = has_ctrl(use) ? get_ctrl(use) : use->in(0); > - set_ctrl(n_clone, use_c); > - assert(!loop->is_member(get_loop(use_c)), "should be outside loop"); > - get_loop(use_c)->_body.push(n_clone); > + use_c = has_ctrl(use) ? get_ctrl(use) : use->in(0); > } else { > // Use in a phi is considered a use in the associated predecessor block > - Node *prevbb = use->in(0)->in(j); > - set_ctrl(n_clone, prevbb); > - assert(!loop->is_member(get_loop(prevbb)), "should be outside loop"); > - get_loop(prevbb)->_body.push(n_clone); > + use_c = use->in(0)->in(j); > } > + if (use_c->is_CountedLoop()) { > + use_c = use_c->in(LoopNode::EntryControl); > + } > + set_ctrl(n_clone, use_c); > + assert(!loop->is_member(get_loop(use_c)), "should be outside loop"); > + get_loop(use_c)->_body.push(n_clone); > _igvn.register_new_node_with_optimizer(n_clone); > #if !defined(PRODUCT) > if (TracePartialPeeling) { > 6712835: Server compiler fails with assertion (loop_count < K,"infinite loop in PhaseIterGVN::transform") > > diff -r 4aebfff4f8a2 hotspot/src/share/vm/opto/ifnode.cpp > --- openjdk.orig/hotspot/src/share/vm/opto/ifnode.cpp Mon Sep 15 11:38:34 2008 +0200 > +++ openjdk/hotspot/src/share/vm/opto/ifnode.cpp Fri Sep 26 11:56:32 2008 +0200 > @@ -569,6 +569,11 @@ > int true_path = phi->is_diamond_phi(); > if( true_path == 0 ) return NULL; > > + // Make sure that iff and the control of the phi are different. This > + // should really only happen for dead control flow since it requires > + // an illegal cycle. > + if (phi->in(0)->in(1)->in(0) == iff) return NULL; > + > // phi->region->if_proj->ifnode->bool->cmp > BoolNode *bol2 = phi->in(0)->in(1)->in(0)->in(1)->as_Bool(); > > @@ -595,6 +600,7 @@ > } > > Node* new_bol = (flip ? phase->transform( bol2->negate(phase) ) : bol2); > + assert(new_bol != iff->in(1), "must make progress"); > iff->set_req(1, new_bol); > // Intervening diamond probably goes dead > phase->C->set_major_progress(); Given that the b24 patch for zero only does a partial replacement of HotSpot (the old make and test directories) remain, the work probably still applies. On this note, though, I think it best if, instead of maintaining this patch, we download the last OpenJDK7 HotSpot for a zero build and use this. This also ensures zero continues working with 7 at no extra cost. If this seems a worthwhile proposal, I'll look into it over the next few days. This would of course mean that the zero HotSpot then has all the tests and fixes found in the OpenJDK7 one, instead of using a rapidly aging snapshot (b24 is 24 weeks old, at a rough guess - there's a build drop every two weeks and we are now on 36 - so about six months...) -- Andrew :) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From mark at klomp.org Sat Sep 27 04:50:16 2008 From: mark at klomp.org (Mark Wielaard) Date: Sat, 27 Sep 2008 13:50:16 +0200 Subject: hotspot JIT producing incorrect code -how should I report a bug? In-Reply-To: <48DD0E3D.1040507@sun.com> References: <4873C510.6030100@streambase.com> <4873DBBF.1020900@sun.com> <48740CBD.8060705@streambase.com> <4876805F.4030700@Sun.COM> <487E66C9.4050601@Sun.COM> <20080925215747.GA16445@gnu.wildebeest.org> <48DC115F.2050106@sun.com> <1222426940.3266.109.camel@dijkstra.wildebeest.org> <48DD0E3D.1040507@sun.com> Message-ID: <1222516216.22140.11.camel@hermans.wildebeest.org> Hi Dalibor, On Fri, 2008-09-26 at 18:30 +0200, Dalibor Topic wrote: > Mark Wielaard wrote: > > You probably cannot claim copyright on the test case itself. But I would > > be surprised if when you ask the submitter to use the testcase you would > > be denied that. Obviously it was submitted precisely to get you a good > > testcase. > I'm happy to do the asking - could you point me to the test case & the > submitter? I think it was the intention of the submitter of the bug report. See bug #6707044, which is a stripped down test case for the upstream Lucene bug at https://issues.apache.org/jira/browse/LUCENE-1282. The test case was attached to my backport patch in my previous email as applied to IcedTea6. Cheers, Mark From volker.simonis at gmail.com Tue Sep 30 00:32:50 2008 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 30 Sep 2008 09:32:50 +0200 Subject: More hotspot tests and some backported fixes In-Reply-To: <1222428052.3266.116.camel@dijkstra.wildebeest.org> References: <1222428052.3266.116.camel@dijkstra.wildebeest.org> Message-ID: Hi, I think these kind of tests are intersting and usefull but unfortuantely, there are jus a small handfull of them available under "hotspot/test/compiler". Does anybody from SUN know if there are more of these hotspot/compiler kind of test avaialble within SUN which are just waiting to get open sourced? I think for porters they would be very interesting and helpfull. Especially tests which cover corner cases of the HotSpot like for example: - Java to Native transitions - Deoptimzations and OSR in various situations - above a compiled frame - above an interpreted frame - the various adapters (I2C, C2I, I2N,...) - the various calls (static, virtual, leaf, ...) - stack overflow situations - exception handling in various situations - JIT inlining - Synchronization (lightweight-, heavyweight-, biased locki Does anybody know if such kind of tests exist somewhere? Regards, Volker On 9/26/08, Mark Wielaard wrote: > Hi, > > I noticed openjdk6 and openjdk7 seem to have a mutually exclusive set of > tests under hotspot/test/compiler. Since I believe having more tests is > a good thing I merged them in icedtea6. That uncovered two crasher bugs > in the hotspot form openjdk6 that we use. So I tracked down the fixes > for those and backported them (patches attached). All 20 tests now PASS. > > It is probably a good idea to also merge the tests from 6 to 7. But I > haven't done that yet. > > Note that again I did only backport for the hotspot from openjdk6, not > the one that zero/shark uses (7b24). > > Cheers, > > > Mark > > From Chuck.Rasbold at Sun.COM Tue Sep 30 07:19:15 2008 From: Chuck.Rasbold at Sun.COM (Chuck Rasbold) Date: Tue, 30 Sep 2008 07:19:15 -0700 Subject: More hotspot tests and some backported fixes In-Reply-To: References: <1222428052.3266.116.camel@dijkstra.wildebeest.org> Message-ID: <48E23563.7050107@sun.com> Volker - There are about 100 tests in the "closed" compiler repository. They are of widely varying quality and value. Some are good, others awful. And while some are more exhaustive, many just test for a specific regression. The reason they are closed is because we didn't have the time to verify the ownership of the code in every test so that Sun could distribute it under OpenJDK. We should really put it on our list of things to-do. Thanks for reminding us. -- Chuck On 09/30/08 00:32, Volker Simonis wrote: > Hi, > > I think these kind of tests are intersting and usefull but > unfortuantely, there are jus a small handfull of them available under > "hotspot/test/compiler". Does anybody from SUN know if there are more > of these hotspot/compiler kind of test avaialble within SUN which are > just waiting to get open sourced? > > I think for porters they would be very interesting and helpfull. > Especially tests which cover corner cases of the HotSpot like for > example: > - Java to Native transitions > - Deoptimzations and OSR in various situations > - above a compiled frame > - above an interpreted frame > - the various adapters (I2C, C2I, I2N,...) > - the various calls (static, virtual, leaf, ...) > - stack overflow situations > - exception handling in various situations > - JIT inlining > - Synchronization (lightweight-, heavyweight-, biased locki > > Does anybody know if such kind of tests exist somewhere? > > Regards, > Volker > > On 9/26/08, Mark Wielaard wrote: >> Hi, >> >> I noticed openjdk6 and openjdk7 seem to have a mutually exclusive set of >> tests under hotspot/test/compiler. Since I believe having more tests is >> a good thing I merged them in icedtea6. That uncovered two crasher bugs >> in the hotspot form openjdk6 that we use. So I tracked down the fixes >> for those and backported them (patches attached). All 20 tests now PASS. >> >> It is probably a good idea to also merge the tests from 6 to 7. But I >> haven't done that yet. >> >> Note that again I did only backport for the hotspot from openjdk6, not >> the one that zero/shark uses (7b24). >> >> Cheers, >> >> >> Mark >> >> From Kelly.Ohair at Sun.COM Tue Sep 30 13:00:17 2008 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 30 Sep 2008 13:00:17 -0700 Subject: More hotspot tests and some backported fixes In-Reply-To: References: <1222428052.3266.116.camel@dijkstra.wildebeest.org> Message-ID: <48E28551.3010901@sun.com> Historically, it was the j2se (now jdk) repository that utilized the test/ directory in the repository to hold what we called 'jtreg' or regression tests, usually each test mapped to a bug or set of bugs. Hotspot started using the test/ directory a little later, so that's why there are so many more of these tests in the jdk repository (and langtools repository) than the other repositories in the forest. As to the quality of these jtreg tests, many are good and solid tests, but some are not as solid or reliable, just a warning. The Hotspot tests were primarily not opened up due to a lack of time in verifying ownership of the files, as Chuck has stated in his response. We still have quite a few jdk tests in the same state, I think. It takes time to go through the history of the files, and also make sure they weren't copied in from some other non-opensource friendly places. One of the issues with these jtreg tests and Hotspot was the issue of jtreg needing to know how to compile native code, which it did not learn to do as far as I know (but not sure it should). Not sure Hotspot has any tests that required native compilation, but it was an issue at one time. -kto Volker Simonis wrote: > Hi, > > I think these kind of tests are intersting and usefull but > unfortuantely, there are jus a small handfull of them available under > "hotspot/test/compiler". Does anybody from SUN know if there are more > of these hotspot/compiler kind of test avaialble within SUN which are > just waiting to get open sourced? > > I think for porters they would be very interesting and helpfull. > Especially tests which cover corner cases of the HotSpot like for > example: > - Java to Native transitions > - Deoptimzations and OSR in various situations > - above a compiled frame > - above an interpreted frame > - the various adapters (I2C, C2I, I2N,...) > - the various calls (static, virtual, leaf, ...) > - stack overflow situations > - exception handling in various situations > - JIT inlining > - Synchronization (lightweight-, heavyweight-, biased locki > > Does anybody know if such kind of tests exist somewhere? > > Regards, > Volker > > On 9/26/08, Mark Wielaard wrote: >> Hi, >> >> I noticed openjdk6 and openjdk7 seem to have a mutually exclusive set of >> tests under hotspot/test/compiler. Since I believe having more tests is >> a good thing I merged them in icedtea6. That uncovered two crasher bugs >> in the hotspot form openjdk6 that we use. So I tracked down the fixes >> for those and backported them (patches attached). All 20 tests now PASS. >> >> It is probably a good idea to also merge the tests from 6 to 7. But I >> haven't done that yet. >> >> Note that again I did only backport for the hotspot from openjdk6, not >> the one that zero/shark uses (7b24). >> >> Cheers, >> >> >> Mark >> >> From thomas.rodriguez at sun.com Tue Sep 30 14:06:10 2008 From: thomas.rodriguez at sun.com (thomas.rodriguez at sun.com) Date: Tue, 30 Sep 2008 21:06:10 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6753795: HotSpot crash in strlen() when JVMTI is used Message-ID: <20080930210612.E50CED7A6@hg.openjdk.java.net> Changeset: dbec32712472 Author: never Date: 2008-09-30 11:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/dbec32712472 6753795: HotSpot crash in strlen() when JVMTI is used Summary: test for null instead of strlen Reviewed-by: rasbold ! src/share/vm/prims/jvmtiEnvBase.cpp