for review (XXL): 6655638 method handles for invokedynamic
John Rose
John.Rose at Sun.COM
Tue Apr 7 01:38:25 PDT 2009
On Apr 7, 2009, at 12:37 AM, John Rose wrote:
>> Don't do the (int32_t)NULL_WORD cast here:
>> __ cmpptr(arg_slots.as_register(), (int32_t) NULL_WORD);
>
> Right.
I was too quick to agree. I remembered Xiaobin's fix to remove such
casts, but something is not right here.
If I take out the cast, the compile fails on Mac. And I notice that
there are similar casts elsewhere, such as in vtableStubs_x86_*.cpp.
For my part, I guess I can avoid the issue by this dodge:
intptr_t zero = 0;
__ cmpptr(arg_slots.as_register(), zero);
Not very satisfying. But I don't want to fight the NULL_WORD battle.
-- John
More information about the hotspot-compiler-dev
mailing list