Request for reviews (XL): 6655646: dynamic languages need dynamically linked call sites

[John Rose]

On Apr 14, 2009, at 3:16 AM, Christian Thalinger wrote:
> src/share/vm/interpreter/bytecode.cpp:
> int Bytecode_invoke::index() const {
> +  if (has_giant_index())
> +    return Bytes::get_native_u4(bcp() + 1);
I added this comment:
  // Note:  Rewriter::rewrite changes the Java_u2 of an invokedynamic  
to a native_u4,
  // at the same time it allocates per-call-site CP cache entries.
> Can you explain to me why the giant index of an invokedynamic is a
> native 32-bit index?
Does that explain?

> src/share/vm/oops/generateOopMap.cpp:
> void GenerateOopMap::interp1(BytecodeStream *itr) {
>
> Shouldn't there be _invokedynamic cases in that method?
Yes, thanks!

> src/share/vm/oops/cpCacheOop.hpp:
> +//            for invokedynamic (a variant of invokeiterface), f1  
> contains
>
> Typo.
Updated comment:
//            for invokedynamic, f1 contains the CallSite object for  
the invocation

Thanks, Christian.

-- John

(P.S.  More please? :-)