review (S) for 6828024: verification of fixed interval usage is too weak

[Vladimir Kozlov]

Could you put "()" around "==" expression?:

3179           check_live = move->patch_code() == lir_patch_none;


I am not sure about next code (don't have knowledge):

3196        if (interval_at(reg_num(opr)) == interval) {
3197          ok = true;
3198          break;
3199        }
3200        int hi = reg_numHi(opr);
3201        if (hi != -1 && interval_at(hi) == interval) {
3202          ok = true;
3203          break;
3204        }

should it be this?:

       if (interval_at(reg_num(opr)) == interval) {
         int hi = reg_numHi(opr);
         if (hi != -1 && interval_at(hi) == interval) {
           ok = true;
           break;
         }
       }

Thanks,
Vladimir

Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/6828024/