Request for reviews (XS): 6869822: assert(Universe::narrow_oop_shift() == 0,"use unscaled narrow oop")

[John Coomes]

Vladimir Kozlov (Vladimir.Kozlov at Sun.COM) wrote:
> Thank you, John
> 
> I used your suggestion to move new check up:
> 
> http://cr.openjdk.java.net/~kvn/6869822/webrev.01

Looks good to me.

-John

> John Coomes wrote:
> > Vladimir Kozlov (Vladimir.Kozlov at Sun.COM) wrote:
> >> Solution:
> >> Replace the assert with narrow_oop_shift set to 0.
> >> Also use specified on command line HeapBaseMinAddress value as
> >> heap base address for the first (from three) request.
> > 
> > Looks good, modulo a couple of nits.  Add { } for the body of the new
> > if statement.  Also the assignment base = NULL on line 776 is
> > redundant (doesn't hurt, though).
> > 
> > FWIW, if you put the new if statement towards the top, just after the
> > assert that checks the mode, you wouldn't need the new "base" var.
> > But either way is fine.
> > 
> > -John
> >