review (S) for 6862863: C2 compiler fails in elide_copy()

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Wed Aug 12 13:52:57 PDT 2009



Tom Rodriguez wrote:
>>>> (and corresponding nreg_lo mapping for register pair).
>>>> May be it needs additional comment in your changes.
>>> It's got a comment to that effect already.  What kind of comment were 
>>> you thinking?
>>
>> Something like this:
>>
>> // Clear out a dead value mapped by the register to update
>> // the register->node mapping even if 'n' defines the same value.
> 
> Where do you want this comment?
> 

You can just update the new comment you added by replacing
the first sentence ?:

// Clear out a dead value before starting.

Vladimir



More information about the hotspot-compiler-dev mailing list