review (M) for 6862956: PhaseIdealLoop should have a CFG verification mode

[Tom Rodriguez]

On Aug 12, 2009, at 1:59 PM, Vladimir Kozlov wrote:

>
> Tom Rodriguez wrote:
>> No I haven't.  It's certainly not free.  I can add some TracePhases  
>> and do some runs.  I also moved the first verify into the  
>> preceeding block of PhaseIdealLoop passes so we aren't doing doing  
>> multiple verifies for code without loops.  I'll get some numbers.
>
> Thanks you.
>
> I looked more and found that you miss break in the error case in  
> verify_dominance().

Right, otherwise we'll just assert in idom.  Thanks.

tom

>
> Vladimir
>
>> tom
>> On Aug 12, 2009, at 12:53 PM, Vladimir Kozlov wrote:
>>> Thank you, Tom, for doing this.
>>>
>>> Changes look good.
>>> Did you measure how much time compiler spends in the verification  
>>> code
>>> (in PhaseIdealLoop::verify(igvn))?
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> Tom Rodriguez wrote:
>>>> http://cr.openjdk.java.net/~never/6862956/