review (XS) for 6855215: Calculation error (NaN) after about 1500 calculations

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Tue Aug 25 15:30:35 PDT 2009


On Aug 25, 2009, at 2:14 PM, Vladimir Kozlov wrote:

> Tom,
>
> In new log/log10 definition tmp1 is illegalOpr but
> in c1_LIR.cpp you cloned sin/cos code which use both temps.
> Is it correct? Could you also add a comment there? sin/cos has  
> comment.

It could really be done either way but since we needed a single tmp I  
figured on using the field called tmp for it instead of using opr2 for  
it.  I consolidated the tan/sin/cos and log/log10 cases in c1_LIR.cpp  
and augmented the comment.

tom

>
> Vladimir
>
> Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/6855215



More information about the hotspot-compiler-dev mailing list