Request for reviews (XS): 6875577

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Thu Aug 27 17:00:39 PDT 2009


Thanks, Changpeng

Vladimir

Changpeng Fang wrote:
> Looks good!
> 
> Changpeng
> 
> 
> On 08/27/09 16:53, Vladimir Kozlov wrote:
>>
>> http://cr.openjdk.java.net/~kvn/6875577/webrev.00
>>
>> Fixed 6875577: CTW fails with /hotspot/src/share/vm/opto/memnode.cpp
>>
>> Problem:
>> do_null_check checks for unloaded klass only for instances.
>> In the test case C2 tries to generate Object.clone() intrinsic
>> for array with unloaded element's klass.
>>
>> Solution:
>> Fix do_null_check to check for unloaded klass for all oop pointers.
>> Add check for stopped() state into PreserveReexecuteState destructor
>> and assert into its contructor.
>> Add assert to check that allocation's CheckCastPP node used in
>> arraycopy has more precise type then Object. Otherwise it will
>> fold with new CheckCastPP node and incorrect graph will be generated.
>>
>> Reviewed by:
>>
>> Fix verified (y/n): y, test
>>
>> Other testing:
>> JPRT
>>
> 


More information about the hotspot-compiler-dev mailing list