Request for reviews (S): 6876276: assert(!is_visited, "visit only once")

[Tom Rodriguez]

Looks good.

tom

On Aug 27, 2009, at 5:15 PM, Changpeng Fang wrote:

> http://cr.openjdk.java.net/~cfang/6876276/webrev.00/
>
> Problem:
> SuperWord scheduling of loads uses the memory state of the last  
> executed load in the packet
> for the SuperWord load. This is not correct because memory order may  
> be violated. The test case
> that has problem is like this:
> store1
> load1
> store2
> load2
> after scheduling, it becomes:
> store1
> store2
> load1
> load2
> It turns out that store2 depends on load1, so the memory edge for  
> the superword load (combination of load1 and load2)
> is not correct.
>
> Solution:
> Schedule the superword loads based on dependence (we have already  
> done this for superword stores, and I don't know
> why I didn't do this for the loads at that time).
>
> Minor changes: Use "97" as the exit code (instead of "-1") for the  
> Tests in test/compiler/6636138
>
> Tests:
> JPRT, CompileTheWord, and Tests in test/compiler/6636138
>
> Thanks,
>
> Changpeng