Request for reviews (L): 6893081: method handle & invokedynamic code needs additional cleanup (post 6815692, 6858164)
Christian Thalinger
Christian.Thalinger at Sun.COM
Tue Dec 1 07:20:22 PST 2009
On Mon, 2009-11-30 at 16:01 -0800, Vladimir Kozlov wrote:
> src/cpu/x86/vm/methodHandles_x86.cpp
>
> Need comment update, 16+8+8+8 == 40
> 678 // original 32-bit vmdata word must be of this form:
> 679 // | MBZ:16 | signBitCount:8 | srcDstTypes:8 | conversionOp:8 |
Done.
> Use short jmpb() :
> 688 __ jmp(done);
Done.
> src/cpu/x86/vm/sharedRuntime_x86_64.cpp
>
> + // we be generated.
> ^ will
Done.
> src/cpu/x86/vm/templateInterpreter_x86_<32|64>.cpp
> Do you have a bug for this problem to not forget about it?
John, do we?
Here is the updated webrev:
http://cr.openjdk.java.net/~twisti/6893081/webrev.03/
-- Christian
More information about the hotspot-compiler-dev
mailing list