Request for reviews (L): 6893081: method handle & invokedynamic code needs additional cleanup (post 6815692, 6858164)

Christian Thalinger Christian.Thalinger at Sun.COM
Wed Dec 2 07:39:20 PST 2009


On Tue, 2009-12-01 at 10:29 -0800, Vladimir Kozlov wrote:
> Christian Thalinger wrote:
> >> Use short jmpb() :
> >> 688       __ jmp(done);
> > 
> > Done.
> > 
> 
> Christian, I should have been more clear. I wanted you to use short jumps
> for all jumps in this code. Could you use jccb for next also?:
>   684        __ jcc(Assembler::zero, zero_extend);

Ohh, sorry, I did not get that.  I changed all jumps I could find and
think they are safe to change.  I ran a couple of test locally, but I
will commit the change to the mlvm repository and do further testing.

Updated webrev here:

http://cr.openjdk.java.net/~twisti/6893081/webrev.04/

-- Christian



More information about the hotspot-compiler-dev mailing list