Request for reviews (XL): 6829187: compiler optimizations required for JSR 292

[Tom Rodriguez]

Shouldn't the code in lcm.cpp be guarded by a check for whether the call is an invokedynamic?  You're making it appear to always be killed which isn't true.  It could also use a comment explaining what it's doing.  MachCallJavaNode::in_RegMask could also use a comment.  Otherwise this looks good.

tom

On Dec 2, 2009, at 9:07 AM, Christian Thalinger wrote:

> On Tue, 2009-12-01 at 10:39 -0800, Vladimir Kozlov wrote:
>> Christian Thalinger wrote:
>>>> src/cpu/x86/vm/x86_{32|64}.ad
>>>> Instead of using "/MethodHandle" in format %{%}
>>>> I would fix MachCallStaticJavaNode::dump_spec().
>>> 
>>> Hmm, I tried that but it is not printed with PrintOptoAssembly.  The
>>> printed output seems to be generated by output_h.cpp.  Am I missing
>>> something here?
>> 
>> You are right. In this case can you just use " "(space) instead of "/",
>> "/" seems confusing for me.
> 
> Done.
> 
> New webrev here:
> 
> http://cr.openjdk.java.net/~twisti/6829187/webrev.03/
> 
> -- Christian
>