Request reviews (M): 6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Wed Dec 2 16:37:26 PST 2009


Thank you, Tom

Vladimir

Tom Rodriguez wrote:
> I think this looks ok.
> 
> tom
> 
> On Nov 20, 2009, at 2:04 PM, Vladimir Kozlov wrote:
> 
>> http://cr.openjdk.java.net/~kvn/6896727/webrev.06
>>
>> Fixed 6896727: nsk/logging/LoggingPermission/LoggingPermission/logperm002 fails with G1, EscapeAnalisys
>>
>> Problem:
>> EA incorrectly allows to bypass one memory store by an other
>> without updating its users. As result node's memory references
>> could missing on some paths.
>>
>> Solution:
>> When updating input memory edge for a store move
>> its memory users to corresponding memory slices.
>> I also added several asserts to verify correctness
>> of memory splitting during EA.
>>
>> Reviewed by:
>>
>> Fix verified (y/n): y, test
>>
>> Other testing:
>> JPRT,CTW
>>
> 


More information about the hotspot-compiler-dev mailing list