Request for reviews (XXL): 6893268: additional dynamic language related optimizations in C2

[John Rose]

FYI:  Here's the code I'm playing with.  But I think I prefer your startsWith method.

I think we're also missing ciSymbol::utf8_byte_at to do '/' checks w/o allocations.

-- John

   On Dec 9, 2009, at 3:15 AM, Christian Thalinger wrote:

> On Tue, 2009-12-08 at 17:11 -0800, Tom Rodriguez wrote:
>>> and used the first one in places where it's appropriate.  Here is a
>>> webrev of the changes:
>>> 
>>> http://cr.openjdk.java.net/~twisti/starts_with/webrev.01/
>>> 
>>> Could I roll that into this change?
>> 
>> It seems overly complicated.  If the actual class name is java/dyn
>> then you'll get a range check on the final byte_at(len) test.  Why not
>> just require the trailing / and check it via asserts?
> 
> If John wants to add the feature he was talking about yesterday (to be
> able to add packages via a command line option), I think we should make
> it as robust as possible and add another check in
> ciKlass::is_in_package:
> 
>  // Test if the class name is something like "java/lang".
>  if ((len + 1) > name()->utf8_length())
>    return false
> 
> I like to have complete and robust class methods which do all the work
> for you.
> 
> -- Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: trustfinal.patch.gz
Type: application/x-gzip
Size: 1523 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20091215/2a3cab8b/attachment.bin