Request for reviews (XXL): 6893268: additional dynamic language related optimizations in C2
Tom Rodriguez
Thomas.Rodriguez at Sun.COM
Wed Dec 16 14:09:40 PST 2009
The only comment I'd make is that I don't think you need to the ResourceMark in is_in_package anymore and you might consider adding a VM_ENTRY_MARK at the top so that you only have to do one VM transition. Everything you are calling requires a VM transition and is implemented with GUARDED_VM_ENTRY. Otherwise I'm ok with it.
tom
On Dec 16, 2009, at 2:30 AM, Christian Thalinger wrote:
> On Wed, 2009-12-16 at 10:04 +0100, Christian Thalinger wrote:
>> On Tue, 2009-12-15 at 14:42 -0800, John Rose wrote:
>>> FYI: Here's the code I'm playing with. But I think I prefer your startsWith method.
>>
>> Good, then I'll roll that into the patch.
>
> Here is the final webrev:
>
> http://cr.openjdk.java.net/~twisti/6893268/webrev.04/
>
> If there is no objection I will commit this tomorrow.
>
> -- Christian
>
More information about the hotspot-compiler-dev
mailing list