review (S) for 5057818: codecache full and compiler disabled in bigapps fastdebug run

[Vladimir Kozlov]

Good.

Vladimir

Tom Rodriguez wrote:
> Oops.  I've fixed that too.
> 
> tom
> 
> On Dec 16, 2009, at 2:30 PM, Vladimir Kozlov wrote:
> 
>> It returns false (not true)
>> "if another thread performed the transition"
>>
>> Vladimir
>>
>> Tom Rodriguez wrote:
>>> Fixed.  Thanks!
>>> tom
>>> On Dec 16, 2009, at 1:48 PM, Vladimir Kozlov wrote:
>>>> New comments are messed up (is,it,if,of) in nmethod.hpp:
>>>>
>>>> !   // Returns true is this thread changed the state of the nmethod of
>>>> !   // if another thread performed the transition.
>>>>
>>>>
>>>> !   // alive.  It is used when an uncommon trap happens.  Returns true
>>>> !   // is this thread changed the state of the nmethod of if another
>>>> !   // thread performed the transition.
>>>>
>>>> nmethod.cpp:
>>>>
>>>> 1190       // this effectively makes the nmethod not entrant
>>>>                                       ^ osr
>>>>
>>>> Otherwise looks good.
>>>>
>>>> Thanks,
>>>> Vladimir
>>>>
>>>> Tom Rodriguez wrote:
>>>>> http://cr.openjdk.java.net/~never/5057818
>