Request for reviews (S): 6799693: Server compiler leads to data corruption when expression throws an Exception

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Thu Feb 5 12:27:04 PST 2009


I think this looks good.  I'm not sure why we bother trying to use the  
raw memory in the slow path though.  It doesn't improve anything about  
the code generation.  I'm fine with keeping it as you've changed it.

tom

On Feb 5, 2009, at 10:38 AM, Vladimir Kozlov wrote:

>
> http://webrev.invokedynamic.info/kvn/6799693/index.html
>
> Fixed 6799693: Server compiler leads to data corruption when  
> expression throws an Exception
>
> Problem:
> Both 6799693 and 6795161 bugs has the same cause.
> A store can flow below the call on the slow path of an allocation
> since an allocation consumes only raw memory slice.
> As result when exception happened during the allocation call
> the value of store's memory slice is incorrect.
>
> Solution:
> Use merged memory state for an allocation's slow path
> and raw memory for the fast path.
>
> Reviewed by:
>
> Fix verified (y/n): y, bugs test cases
>
> Other testing:
> JPRT
>




More information about the hotspot-compiler-dev mailing list