Request for reviews (S): 6791852: assert(b->_nodes[insidx] == n,"got insidx set incorrectly")

[Vladimir Kozlov]

I updated changes and webrev based on reviews:

http://cr.openjdk.java.net/~kvn/6791852/webrev.01

Thanks,
Vladimir

Vladimir Kozlov wrote:
> http://cr.openjdk.java.net/~kvn/6791852/webrev.00
> 
> Fixed 6791852: assert(b->_nodes[insidx] == n,"got insidx set incorrectly")
> 
> Problem:
> The code in PhaseChaitin::Split() in the part "Handle Crossing HRP Boundry"
> expects that a new MachSpillCopy node is inserted before the current node.
> After 6782232 fix it is not true if the current node is CreateEx.
> 
> Solution:
> Remove the original fix for 6782232 in PhaseChaitin::insert_proj().
> Move the CreateEx up before each round of IFG construction to produce
> correct interference graph.
> Move verification checks in chaitin after IFG construction.
> Add additional check into PhaseCFG::verify().
> Fix check in PhaseChaitin::verify_base_ptrs().
> 
> Reviewed by: never, phh
> 
> Fix verified (y/n): y, bug's test case
> 
> Other testing:
> JPRT, CTW (with -XX:+VerifyRegisterAllocator)
>