Request for review (XS): 6800154: Add comments to long_by_long_mulhi() for better understandability

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Fri Feb 13 08:06:01 PST 2009


Looks good.

What the problem with Chuck's test you have?

To move a test to open I would create new
directory test/compiler/6603011 for it and replace
the copyright head in the test source.

Vladimir

Christian Thalinger wrote:
> On Wed, 2009-02-04 at 19:19 +0100, Christian Thalinger wrote:
>> On Mon, 2009-02-02 at 18:40 +0100, Christian Thalinger wrote:
>>> http://webrev.invokedynamic.info/twisti/6800154/
>> I have uploaded a new version of the patch which includes a testcase.
> 
> A last version of the patch:
> 
> http://cr.openjdk.java.net/~twisti/6800154/webrev.00/
> 
> Only the test changed.  Actually I wanted to integrate the test from
> Chuck Rasbold for 6603011 but I had problems with that.  I try to move
> that test into the open.
> 
> I think it's okay to push the changeset as the patch hasn't changed.
> 
> -- Christian
> 



More information about the hotspot-compiler-dev mailing list