Request for review (XS): 6800154: Add comments to long_by_long_mulhi() for better understandability
Vladimir Kozlov
Vladimir.Kozlov at Sun.COM
Fri Feb 13 08:34:34 PST 2009
Why not to add it to this push (6800154)?
In the bug report (6800154) add a comment to explain
what you did with the test. I think it should be enough.
Vladimir
Christian Thalinger wrote:
> On Fri, 2009-02-13 at 08:06 -0800, Vladimir Kozlov wrote:
>> Looks good.
>>
>> What the problem with Chuck's test you have?
>
> It didn't work for some corner-cases I wanted to add and I didn't want
> to spend too much time on it.
>
>> To move a test to open I would create new
>> directory test/compiler/6603011 for it and replace
>> the copyright head in the test source.
>
> Under what CR should I commit it?
>
> -- Christian
>
More information about the hotspot-compiler-dev
mailing list