Request for reviews (S): 6802499: EA: assert(false,"unknown node on this path")

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Thu Feb 19 15:51:13 PST 2009


Looks good.

tom

On Feb 18, 2009, at 6:50 PM, Vladimir Kozlov wrote:

>
> http://cr.openjdk.java.net/~kvn/6802499/webrev.00
>
> Fixed 6802499: EA: assert(false,"unknown node on this path")
>
> Problem:
> Escape analysis code miss checks for SCMemProj node
> when working memory edges.
>
> Solution:
> Add missing checks for SCMemProj node.
>
> Note: object should not be scalar replaceable if a LoadStore
> node access its field, the corresponding check done during
> ConnectionGraph construction.
>
> Reviewed by:
>
> Fix verified (y/n): y, test case
>
> Other testing:
> JPRT, CTW (with -XX:+DoEscapeAnalysis)
>




More information about the hotspot-compiler-dev mailing list