Request for reviews (S): 6791572: assert("duplicating node that's already been matched")
Vladimir Kozlov
Vladimir.Kozlov at Sun.COM
Thu Feb 19 18:57:24 PST 2009
I updated the fix after discussion with Tom.
http://cr.openjdk.java.net/~kvn/6791572/webrev.01
Thanks,
Vladimir
Vladimir Kozlov wrote:
>
> http://cr.openjdk.java.net/~kvn/6791572/webrev.00
>
> Fixed 6791572: assert("duplicating node that's already been matched")
>
> Problem:
> AddP, LShiftX nodes and their inputs are marked as visited
> on x86 during the first address expression processing.
> AddP, LShiftX inputs will be not marked as shared since
> AddP, LShiftX will be marked as shared first.
> And this causes the problem since after AddP, LShiftX
> are folded into address expressions their inputs
> will be shared by several address expressions.
>
> Solution:
> Delay marking nodes as visited if they are inputs
> to an address expression.
>
> Reviewed by:
>
> Fix verified (y/n): y, test case
>
> Other testing:
> JPRT
>
More information about the hotspot-compiler-dev
mailing list