Request for reviews (XS): 6857661: 64-bit server VM: assert(is_Initialize(),"invalid node class")

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Mon Jul 6 12:00:57 PDT 2009


Looks good.

tom

On Jul 6, 2009, at 10:37 AM, Vladimir Kozlov wrote:

> http://cr.openjdk.java.net/~kvn/6857661/webrev.00
>
> Fixed 6857661: 64-bit server VM: assert(is_Initialize(),"invalid  
> node class")
>
> Problem:
> It is regression after 6840775 fix.
> The secondary raw memory barrier (Initialize node)
> is misplaced on zero length path in generate_arraycopy().
> It should be generated only if the path is not dead
> (in the bug case the copy length is negative) and only
> after a zeroing code for a new allocated object.
>
> Solution:
> Move the secondary raw memory barrier to the correct place.
>
> Reviewed by:
>
> Fix verified (y/n): y, bug's test
>
> Other testing:
> JPRT
>




More information about the hotspot-compiler-dev mailing list