Request for reviews (L): 6829187: compiler optimizations required for JSR 292
Christian Thalinger
Christian.Thalinger at Sun.COM
Fri Jul 10 09:34:32 PDT 2009
Christian Thalinger wrote:
> Here is the inlining part of the invokedynamic compiler support:
>
> http://cr.openjdk.java.net/~twisti/6829187/webrev.01/
To review my own patch, I'm not sure this is correct:
+ // Currently we online support DirectMethodHandles which are
+ // bound to a methodOop.
+ if (!method_handle->does_dispatch()) {
I think there is another check missing since the last MethodHandle in a
chain can be a DirectMethodHandle which does not do a dispatch but I'm
not taking care of the MethodHandles before, which could bind arguments
or whatever.
Maybe something like?
!does_dispatch && !binds_arguments && !adapter
-- Christian
More information about the hotspot-compiler-dev
mailing list