Request for review (M): 6860469: remix_address_expressions sets incorrect control causing crash in split_if_with_block_post

Chuck Rasbold rasbold at google.com
Wed Jul 15 09:27:14 PDT 2009


http://cr.openjdk.java.net/~rasbold/6860469/webrev.00<http://cr.openjdk.java.net/%7Erasbold/6860469/webrev.00>

Fixed 6860469: remix_address_expressions sets incorrect control causing
crash in split_if_with_block_post

Consult the control node of both inputs when deciding where to place
new LShiftI node.

Previously, we assumed the invar input should set the new node's
control, and the scale input was irrelevant for control's sake.
However, sometimes the invar input is a constant, allowing it to be
higher in the dom tree than the scale.

Fix provided by Hiroshi Yamauchi (yamauchi at google.com)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20090715/67c007c2/attachment.html 


More information about the hotspot-compiler-dev mailing list