Request for review (M): 6860469: remix_address_expressions sets incorrect control causing crash in split_if_with_block_post

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Wed Jul 15 12:57:39 PDT 2009


Looks good.

Vladimir

Chuck Rasbold wrote:
> http://cr.openjdk.java.net/~rasbold/6860469/webrev.00 
> <http://cr.openjdk.java.net/%7Erasbold/6860469/webrev.00>
> 
> Fixed 6860469: remix_address_expressions sets incorrect control causing 
> crash in split_if_with_block_post
> 
> Consult the control node of both inputs when deciding where to place
> new LShiftI node.
> 
> Previously, we assumed the invar input should set the new node's
> control, and the scale input was irrelevant for control's sake.
> However, sometimes the invar input is a constant, allowing it to be
> higher in the dom tree than the scale.
> 
> Fix provided by Hiroshi Yamauchi (yamauchi at google.com 
> <mailto:yamauchi at google.com>)
> 



More information about the hotspot-compiler-dev mailing list