Request for reviews (XS): 6851386: assert(b->find_node(def) < j,"uses must follow definitions")

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Fri Jul 24 16:04:42 PDT 2009


Thanks, Tom

Yes, you are right. I will change it to 1.

Vladimir

Tom Rodriguez wrote:
> Shouldn't the search start at 1 instead of 0?  Otherwise it looks fine.
> 
> tom
> 
> On Jul 24, 2009, at 3:43 PM, Vladimir Kozlov wrote:
> 
>>
>> http://cr.openjdk.java.net/~kvn/6851386/webrev.00
>>
>> Fixed 6851386: assert(b->find_node(def) < j,"uses must follow 
>> definitions")
>>
>> Problem:
>> The assert added for 6791852 misses the case when
>> the head of a tight loop is not LoopNode.
>> In the bugs case it is RegionNode with 4 input edges.
>>
>> Solution:
>> Add additional check for a tight loop.
>>
>> Reviewed by:
>>
>> Fix verified (y/n): y, bug's test
>>
>> Other testing:
>> JPRT
>>
> 



More information about the hotspot-compiler-dev mailing list