Request for reviews .02 (XS): 6863155: Server compiler generates incorrect code (x86, long, bitshift, bitmask)

Christian Thalinger Christian.Thalinger at Sun.COM
Mon Jul 27 13:10:05 PDT 2009


Christian Thalinger wrote:
> Tom Rodriguez wrote:
>> Don't you just want to replace the existing mask with  
>> 0xffffffff80000000 to test for this?  Testing separately is unneeded.
> 
> Yeah, Vladimir also asked me that question.  I wanted to do that, but I
> thought it's easier to understand when kept separated.  But I think I
> change it and write a good comment.

Here is the updated webrev:

http://cr.openjdk.java.net/~twisti/6863155/webrev.02/

-- Christian



More information about the hotspot-compiler-dev mailing list