Request for reviews (S): 6865031: Application gives bad result (throws bad exception) with compressed oops
changpeng fang - Sun Microsystems - Santa Clara United States
Changpeng.Fang at Sun.COM
Fri Jul 31 11:56:35 PDT 2009
Looks good to me.
Changpeng
On 07/30/09 13:35, Vladimir Kozlov wrote:
>
> http://cr.openjdk.java.net/~kvn/6865031/webrev.00
>
> Fixed 6865031: Application gives bad result (throws bad exception)
> with compressed oops
>
> Problem:
> The problem at the same place as in 6851282.
> The new Phi narrow type is incorrect since it is based
> on the type of one of inputs which could be subtype of
> the original Phi's type. The Phi is used in CmpP node
> which gives a wrong result since Phi's type is wrong.
> It leads to incorrect graph and generated code.
>
> Solution:
> Produce narrow type for new Phi from the original type
> instead of using a type of Phi's input.
>
> Reviewed by:
>
> Fix verified (y/n): y, bug's test and 6851282 test
>
> Other testing:
> JPRT, CTW with +UseCompressedOops
>
More information about the hotspot-compiler-dev
mailing list