From gbenson at redhat.com Tue Jun 2 05:10:51 2009 From: gbenson at redhat.com (Gary Benson) Date: Tue, 2 Jun 2009 13:10:51 +0100 Subject: Embed ciMethod's methodOop into CodeBuffer? Message-ID: <20090602121051.GA3173@redhat.com> Hi all, I've been looking at the method call stuff in Shark, and I figure there's a whole bunch of optimizations I can perform if I can embed the methodOop corresponding to a given ciMethod into the CodeBuffer. Is this possible? Cheers, Gary -- http://gbenson.net/ From Thomas.Rodriguez at Sun.COM Tue Jun 2 09:36:14 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 02 Jun 2009 09:36:14 -0700 Subject: Embed ciMethod's methodOop into CodeBuffer? In-Reply-To: <20090602121051.GA3173@redhat.com> References: <20090602121051.GA3173@redhat.com> Message-ID: <929C7BA6-6287-4C5A-9B84-D82E46032D62@sun.com> You can safely embed perm oops in nmethods but not regular CodeBuffers. During code generation you use methods in the MacroAssembler to embed references to a JNI handle in the code, along with relocation information to describe it. When the compilation CodeBuffer is converted into an nmethod, the jobject is dereferenced and that object is placed into the code stream. This dance is required partly because the compiler is running in native mode, so it has to use JNI for GC safety. On intel look at movoop and the associated code for that, along with oop_Relocation in relocInfo.hpp and OopRecorder in oopRecorder.hpp. I'm not sure how well our strategy is going to work for Zero since it requires the ability to patch the instruction stream after a GC to update any oops which have moved. Are you able to support that? tom On Jun 2, 2009, at 5:10 AM, Gary Benson wrote: > Hi all, > > I've been looking at the method call stuff in Shark, and I figure > there's a whole bunch of optimizations I can perform if I can embed > the methodOop corresponding to a given ciMethod into the CodeBuffer. > Is this possible? > > Cheers, > Gary > > -- > http://gbenson.net/ From gbenson at redhat.com Wed Jun 3 01:32:53 2009 From: gbenson at redhat.com (Gary Benson) Date: Wed, 3 Jun 2009 09:32:53 +0100 Subject: Embed ciMethod's methodOop into CodeBuffer? In-Reply-To: <929C7BA6-6287-4C5A-9B84-D82E46032D62@sun.com> References: <20090602121051.GA3173@redhat.com> <929C7BA6-6287-4C5A-9B84-D82E46032D62@sun.com> Message-ID: <20090603083253.GA3213@redhat.com> Hi Tom, Thanks for that, I guessed it ought to be possible but I couldn't figure out the exact steps. For Shark we can't patch the instruction stream itself (that's generated by LLVM into its own buffer) but we still have the HotSpot codebuffer so I plan to drop the oops into that and then load them from there. It's not quite the same as having the address as an immediate in the code, but it's the next best thing. Cheers, Gary Tom Rodriguez wrote: > You can safely embed perm oops in nmethods but not regular > CodeBuffers. During code generation you use methods in the > MacroAssembler to embed references to a JNI handle in the code, > along with relocation information to describe it. When the > compilation CodeBuffer is converted into an nmethod, the jobject > is dereferenced and that object is placed into the code stream. > This dance is required partly because the compiler is running in > native mode, so it has to use JNI for GC safety. On intel look > at movoop and the associated code for that, along with > oop_Relocation in relocInfo.hpp and OopRecorder in oopRecorder.hpp. > I'm not sure how well our strategy is going to work for Zero since > it requires the ability to patch the instruction stream after a GC > to update any oops which have moved. Are you able to support that? > > tom > > On Jun 2, 2009, at 5:10 AM, Gary Benson wrote: > > Hi all, > > > > I've been looking at the method call stuff in Shark, and I figure > > there's a whole bunch of optimizations I can perform if I can > > embed the methodOop corresponding to a given ciMethod into the > > CodeBuffer. Is this possible? > > > > Cheers, > > Gary > > > > -- > > http://gbenson.net/ -- http://gbenson.net/ From gbenson at redhat.com Wed Jun 3 07:58:19 2009 From: gbenson at redhat.com (Gary Benson) Date: Wed, 3 Jun 2009 15:58:19 +0100 Subject: Embed ciMethod's methodOop into CodeBuffer? In-Reply-To: <20090603083253.GA3213@redhat.com> References: <20090602121051.GA3173@redhat.com> <929C7BA6-6287-4C5A-9B84-D82E46032D62@sun.com> <20090603083253.GA3213@redhat.com> Message-ID: <20090603145819.GC19979@redhat.com> Hi Tom, I have this working now, thanks for your help! Cheers, Gary Gary Benson wrote: > Hi Tom, > > Thanks for that, I guessed it ought to be possible but I couldn't > figure out the exact steps. For Shark we can't patch the > instruction stream itself (that's generated by LLVM into its own > buffer) but we still have the HotSpot codebuffer so I plan to drop > the oops into that and then load them from there. It's not quite > the same as having the address as an immediate in the code, but it's > the next best thing. > > Cheers, > Gary > > Tom Rodriguez wrote: > > You can safely embed perm oops in nmethods but not regular > > CodeBuffers. During code generation you use methods in the > > MacroAssembler to embed references to a JNI handle in the code, > > along with relocation information to describe it. When the > > compilation CodeBuffer is converted into an nmethod, the jobject > > is dereferenced and that object is placed into the code stream. > > This dance is required partly because the compiler is running in > > native mode, so it has to use JNI for GC safety. On intel look > > at movoop and the associated code for that, along with > > oop_Relocation in relocInfo.hpp and OopRecorder in oopRecorder.hpp. > > I'm not sure how well our strategy is going to work for Zero since > > it requires the ability to patch the instruction stream after a GC > > to update any oops which have moved. Are you able to support that? > > > > tom > > > > On Jun 2, 2009, at 5:10 AM, Gary Benson wrote: > > > Hi all, > > > > > > I've been looking at the method call stuff in Shark, and I figure > > > there's a whole bunch of optimizations I can perform if I can > > > embed the methodOop corresponding to a given ciMethod into the > > > CodeBuffer. Is this possible? > > > > > > Cheers, > > > Gary > > > > > > -- > > > http://gbenson.net/ > > -- > http://gbenson.net/ -- http://gbenson.net/ From Thomas.Rodriguez at Sun.COM Wed Jun 3 12:23:24 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 03 Jun 2009 12:23:24 -0700 Subject: Embed ciMethod's methodOop into CodeBuffer? In-Reply-To: <20090603145819.GC19979@redhat.com> References: <20090602121051.GA3173@redhat.com> <929C7BA6-6287-4C5A-9B84-D82E46032D62@sun.com> <20090603083253.GA3213@redhat.com> <20090603145819.GC19979@redhat.com> Message-ID: <2C6CEFD0-0741-4FF1-B2B5-00C0FDE35DBB@sun.com> Glad I could help. tom On Jun 3, 2009, at 7:58 AM, Gary Benson wrote: > Hi Tom, > > I have this working now, thanks for your help! > > Cheers, > Gary > > Gary Benson wrote: >> Hi Tom, >> >> Thanks for that, I guessed it ought to be possible but I couldn't >> figure out the exact steps. For Shark we can't patch the >> instruction stream itself (that's generated by LLVM into its own >> buffer) but we still have the HotSpot codebuffer so I plan to drop >> the oops into that and then load them from there. It's not quite >> the same as having the address as an immediate in the code, but it's >> the next best thing. >> >> Cheers, >> Gary >> >> Tom Rodriguez wrote: >>> You can safely embed perm oops in nmethods but not regular >>> CodeBuffers. During code generation you use methods in the >>> MacroAssembler to embed references to a JNI handle in the code, >>> along with relocation information to describe it. When the >>> compilation CodeBuffer is converted into an nmethod, the jobject >>> is dereferenced and that object is placed into the code stream. >>> This dance is required partly because the compiler is running in >>> native mode, so it has to use JNI for GC safety. On intel look >>> at movoop and the associated code for that, along with >>> oop_Relocation in relocInfo.hpp and OopRecorder in oopRecorder.hpp. >>> I'm not sure how well our strategy is going to work for Zero since >>> it requires the ability to patch the instruction stream after a GC >>> to update any oops which have moved. Are you able to support that? >>> >>> tom >>> >>> On Jun 2, 2009, at 5:10 AM, Gary Benson wrote: >>>> Hi all, >>>> >>>> I've been looking at the method call stuff in Shark, and I figure >>>> there's a whole bunch of optimizations I can perform if I can >>>> embed the methodOop corresponding to a given ciMethod into the >>>> CodeBuffer. Is this possible? >>>> >>>> Cheers, >>>> Gary >>>> >>>> -- >>>> http://gbenson.net/ >> >> -- >> http://gbenson.net/ > > -- > http://gbenson.net/ From thomas.rodriguez at sun.com Wed Jun 3 17:50:14 2009 From: thomas.rodriguez at sun.com (thomas.rodriguez at sun.com) Date: Thu, 04 Jun 2009 00:50:14 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 2 new changesets Message-ID: <20090604005019.19FA8EF30@hg.openjdk.java.net> Changeset: 435f0808b826 Author: never Date: 2009-06-03 15:02 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/435f0808b826 6847305: solaris reorder mapfiles generate too many warnings Reviewed-by: kvn ! make/solaris/makefiles/reorder_COMPILER1_i486 ! make/solaris/makefiles/reorder_COMPILER1_sparc ! make/solaris/makefiles/reorder_COMPILER2_amd64 ! make/solaris/makefiles/reorder_COMPILER2_sparcv9 ! make/solaris/makefiles/reorder_TIERED_i486 ! make/solaris/makefiles/reorder_TIERED_sparc Changeset: 8b0b8998e1c3 Author: never Date: 2009-06-03 15:16 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/8b0b8998e1c3 Merge From thomas.rodriguez at sun.com Wed Jun 3 20:47:13 2009 From: thomas.rodriguez at sun.com (thomas.rodriguez at sun.com) Date: Thu, 04 Jun 2009 03:47:13 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 11 new changesets Message-ID: <20090604034741.C2F00EF4D@hg.openjdk.java.net> Changeset: 622212a69394 Author: iveresov Date: 2009-05-08 15:20 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/622212a69394 6838842: NUMA allocator: Segfault during startup on Linux Summary: Restored os::free_memory() semantics Reviewed-by: apetrusenko ! src/os/linux/vm/os_linux.cpp Changeset: cf71f149d7ae Author: iveresov Date: 2009-05-12 15:55 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/cf71f149d7ae 6840196: NUMA allocator: crash in fastdebug during startup on Linux Summary: With libnuma >1.2 explicity use 1.1 symbols Reviewed-by: ysr ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp Changeset: 8078631685e4 Author: trims Date: 2009-05-07 21:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/8078631685e4 Merge - make/jprt.config Changeset: fede134842ab Author: trims Date: 2009-05-07 21:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/fede134842ab 6838819: Bump the HS16 build number to 03 Summary: Update the HS16 build number to 03 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 7e1dbef51011 Author: trims Date: 2009-05-08 19:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/7e1dbef51011 Merge Changeset: 07c1c01e0315 Author: trims Date: 2009-05-13 08:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/07c1c01e0315 Merge Changeset: 313b56165de7 Author: vasya Date: 2009-05-11 12:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/313b56165de7 Added tag jdk7-b58 for changeset 53d9bf689e80 ! .hgtags Changeset: c55be0c7bd32 Author: trims Date: 2009-05-13 08:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/c55be0c7bd32 Merge Changeset: 47ffceb239d0 Author: thurka Date: 2009-05-20 09:36 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/47ffceb239d0 6839599: JVM crash while profiling Tomcat and Liferay Summary: constantPoolOopDesc::copy_cpool_bytes() - do the brute-force search search through 'tbl' when SymbolTable::lookup_only() returns NULL Reviewed-by: kamg ! src/share/vm/oops/constantPoolOop.cpp Changeset: f1f3a2719a55 Author: xlu Date: 2009-05-22 16:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/f1f3a2719a55 6843580: JavaThread.getStackBase throws sun.jvm.hotspot.WrongTypeException invoked by jstack Reviewed-by: phh, dice, never, swamyv ! agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java Changeset: 085dd9ee61aa Author: never Date: 2009-06-03 18:15 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/085dd9ee61aa Merge From Changpeng.Fang at Sun.COM Fri Jun 5 09:08:10 2009 From: Changpeng.Fang at Sun.COM (Changpeng Fang) Date: Fri, 05 Jun 2009 09:08:10 -0700 Subject: Request for reviews (XS): 6848466: frame::frame_size() assertion failure with -XX:+DebugDeoptimization In-Reply-To: <4A17634A.5070709@sun.com> References: <4A17634A.5070709@sun.com> Message-ID: <4A2942EA.5010200@Sun.COM> http://cr.openjdk.java.net/~cfang/6848466/webrev.00/ Fixed 6848466: frame::frame_size() assertion failure with -XX:+DebugDeoptimization Problem: The current implementation of frame::frame_size for X86 builds RegisterMap from the current thread. This only works for the top frame, and will cause assertion failure for other frames. For the server vm, -XX:DeoptimizeALot -XX:+DebugDeoptimizatiuon exposes the problem. Solution: Add an argument (RegisterMap *map) for frame::frame_size, and the caller is responsible for providing a RegisterMap for frame::frame_size to compute the sender frame. Thanks, Changpeng From Thomas.Rodriguez at Sun.COM Fri Jun 5 10:11:21 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Fri, 05 Jun 2009 10:11:21 -0700 Subject: Request for reviews (XS): 6848466: frame::frame_size() assertion failure with -XX:+DebugDeoptimization In-Reply-To: <4A2942EA.5010200@Sun.COM> References: <4A17634A.5070709@sun.com> <4A2942EA.5010200@Sun.COM> Message-ID: looks good. tom On Jun 5, 2009, at 9:08 AM, Changpeng Fang wrote: > http://cr.openjdk.java.net/~cfang/6848466/webrev.00/ > > Fixed 6848466: frame::frame_size() assertion failure with -XX: > +DebugDeoptimization > > Problem: > The current implementation of frame::frame_size for X86 builds > RegisterMap from > the current thread. This only works for the top frame, and will > cause assertion failure > for other frames. For the server vm, -XX:DeoptimizeALot -XX: > +DebugDeoptimizatiuon > exposes the problem. > > Solution: > Add an argument (RegisterMap *map) for frame::frame_size, and the > caller is responsible > for providing a RegisterMap for frame::frame_size to compute the > sender frame. > > Thanks, > > Changpeng From Vladimir.Kozlov at Sun.COM Fri Jun 5 11:52:24 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Fri, 05 Jun 2009 11:52:24 -0700 Subject: Request for reviews (XS): 6848466: frame::frame_size() assertion failure with -XX:+DebugDeoptimization In-Reply-To: <4A2942EA.5010200@Sun.COM> References: <4A17634A.5070709@sun.com> <4A2942EA.5010200@Sun.COM> Message-ID: <4A296968.7030907@sun.com> Good. Vladimir Changpeng Fang wrote: > http://cr.openjdk.java.net/~cfang/6848466/webrev.00/ > > Fixed 6848466: frame::frame_size() assertion failure with > -XX:+DebugDeoptimization > > Problem: > The current implementation of frame::frame_size for X86 builds > RegisterMap from > the current thread. This only works for the top frame, and will cause > assertion failure > for other frames. For the server vm, -XX:DeoptimizeALot > -XX:+DebugDeoptimizatiuon > exposes the problem. > > Solution: > Add an argument (RegisterMap *map) for frame::frame_size, and the caller > is responsible > for providing a RegisterMap for frame::frame_size to compute the sender > frame. > > Thanks, > > Changpeng > From changpeng.fang at sun.com Fri Jun 5 13:00:16 2009 From: changpeng.fang at sun.com (changpeng.fang at sun.com) Date: Fri, 05 Jun 2009 20:00:16 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6848466: frame::frame_size() assertion failure with -XX:+DebugDeoptimization Message-ID: <20090605200024.6E2A7EFD9@hg.openjdk.java.net> Changeset: eacd97c88873 Author: cfang Date: 2009-06-05 10:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/eacd97c88873 6848466: frame::frame_size() assertion failure with -XX:+DebugDeoptimization Summary: add a RegisterMap* argument to frame::frame_size() to correctly compute the sender frame Reviewed-by: never ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/x86/vm/frame_x86.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/vframe.cpp From Christian.Thalinger at Sun.COM Fri Jun 5 15:59:37 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Fri, 05 Jun 2009 15:59:37 -0700 Subject: constant pool question In-Reply-To: <1243358360.24377.15.camel@macbook> References: <1243289747.26040.47.camel@macbook> <1243358360.24377.15.camel@macbook> Message-ID: <4A29A359.1020301@Sun.COM> Christian Thalinger wrote: > On Tue, 2009-05-26 at 09:47 -0700, Tom Rodriguez wrote: >> What do you think is wrong with using is_field_or_method in these calls? > > Well, I thought a method like > constantPoolOopDesc::impl_name_and_type_ref_index_at() should check for > JVM_CONSTANT_NameAndType, no? It seems I was just confused because of the naming of the methods. -- Christian From gbenson at redhat.com Mon Jun 8 08:22:59 2009 From: gbenson at redhat.com (Gary Benson) Date: Mon, 8 Jun 2009 16:22:59 +0100 Subject: Interface calls Message-ID: <20090608152259.GB5081@redhat.com> Hi all, Shark's implementation of invokeinterface currently mirrors what the interpreter does, and I'm trying to rewrite it to be more efficient. The current implementation pulls the index from the constant pool, which is ugly. Is it possible to get this from the typeflow at compile time? I tried looking to see how opto does it, but I don't really understand how opto does calls at all :( Cheers, Gary -- http://gbenson.net/ From Thomas.Rodriguez at Sun.COM Mon Jun 8 15:37:26 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Mon, 08 Jun 2009 15:37:26 -0700 Subject: Interface calls In-Reply-To: <20090608152259.GB5081@redhat.com> References: <20090608152259.GB5081@redhat.com> Message-ID: <712238EC-09B9-4293-9406-B730A8445168@sun.com> For any vanilla interface call you have to do a search in the itable for the appropriate method to call. This is the worst case behaviour of an interface call and is the default in the interpreter. C1 and C2 may be able to do better in a couple ways. The first is that the type of the actual object may be more precise than the interface type of the invoke, allowing you to bind it like a virtual call. This will often happen as a result of inlining but it assumes your compiler has at least a minimal type system to make that type visible. There are cases where a method local type flow might allow you to bind directly without going through an interface. Consider the following Java code: List l = new ArrayList(); l.add("foo"); javac will emit an invokeinterface of List.add instead of emitting an invokevirtual of ArrayList.add because it will use the declared type of l instead of the actual type. In this case a type flow should be able to tell you that the receiver is actually an ArrayList. You can use ciMethod::resolve_invoke to map from the interface method back to the method you'd use an invokevirtual on. C2 also uses type profiling in the interpreter to get a good guess of the actual type and emits a guarded call to the most frequent receiver type which does a good job of devirtualizing interface calls. C1 has an optimization where if an interface has only a single implementor it will assume that all references to that interface must be of the implementor class. This of course involves a dynamic guard since interface types are completely untrustworthy. The other potential fast path is the fact that all our call sites have an inline cache, so if the invokeinterface site is actually monomorphic then the call site dispatch will get you directly to the right method with a few extra dynamic checks in the unverified entry point. This requires the ability to rewrite the call site though. You might be able to build something like that by hand and you can get a fair amount of mileage out of it. It can be tricky to deal with the atomicity and invalidation issues though. tom On Jun 8, 2009, at 8:22 AM, Gary Benson wrote: > Hi all, > > Shark's implementation of invokeinterface currently mirrors what the > interpreter does, and I'm trying to rewrite it to be more efficient. > The current implementation pulls the index from the constant pool, > which is ugly. Is it possible to get this from the typeflow at > compile time? I tried looking to see how opto does it, but I don't > really understand how opto does calls at all :( > > Cheers, > Gary > > -- > http://gbenson.net/ From Thomas.Rodriguez at Sun.COM Tue Jun 9 12:10:43 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 09 Jun 2009 12:10:43 -0700 Subject: Request for reviews (L): 6837472: com/sun/jdi/MonitorFrameInfo.java fails with Escape Analysis In-Reply-To: <4A1F0E88.1080306@sun.com> References: <4A1F0E88.1080306@sun.com> Message-ID: <5A492BFC-11D1-4511-BA46-2DF506B284D9@sun.com> Looks good. tom On May 28, 2009, at 3:22 PM, Vladimir Kozlov wrote: > > http://cr.openjdk.java.net/~kvn/6837472/webrev.00 > > Fixed 6837472: com/sun/jdi/MonitorFrameInfo.java fails with Escape > Analysis > > Problem: > JDI test sets a breakpoint in callee method and expects > to be inside the lock in caller method. > But EA eliminated the locked object and the lock > in caller method since the object does not escape. > > Solution: > Disable escape analysis when jvmti/debugger is used. > Add the information about scalar replaced objects into > MonitorInfo and StackValue. > Add support for scalar replaced objects and eliminated locks > into Serviceability Agent. > > Reviewed by: > > Fix verified (y/n): y, bug's test > > Other testing: > JPRT, CTW, NSK testing with EA. > From vladimir.kozlov at sun.com Tue Jun 9 18:39:05 2009 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Wed, 10 Jun 2009 01:39:05 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6837472: com/sun/jdi/MonitorFrameInfo.java fails with AggressiveOpts in 6u14 Message-ID: <20090610013910.7519EE1FE@hg.openjdk.java.net> Changeset: b109e761e927 Author: kvn Date: 2009-06-09 16:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/b109e761e927 6837472: com/sun/jdi/MonitorFrameInfo.java fails with AggressiveOpts in 6u14 Summary: Disable escape analysis when jvmti/debugger is used. Add support for EA ibto SA. Reviewed-by: never ! agent/src/share/classes/sun/jvm/hotspot/code/DebugInfoReadStream.java ! agent/src/share/classes/sun/jvm/hotspot/code/MonitorValue.java + agent/src/share/classes/sun/jvm/hotspot/code/ObjectValue.java ! agent/src/share/classes/sun/jvm/hotspot/code/ScopeDesc.java ! agent/src/share/classes/sun/jvm/hotspot/code/ScopeValue.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/ObjectReferenceImpl.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/ThreadReferenceImpl.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/CompiledVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/InterpretedVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/MonitorInfo.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/StackValue.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaThread.java ! src/share/vm/opto/c2compiler.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/runtime/biasedLocking.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/stackValue.cpp ! src/share/vm/runtime/stackValue.hpp ! src/share/vm/runtime/vframe.cpp ! src/share/vm/runtime/vframe.hpp ! src/share/vm/runtime/vframeArray.cpp ! src/share/vm/runtime/vframe_hp.cpp From Thomas.Rodriguez at Sun.COM Wed Jun 10 11:21:59 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 10 Jun 2009 11:21:59 -0700 Subject: review (XS) for 6849574: VM crash using NonBlockingHashMap (high_scale_lib) Message-ID: <226B4520-D643-4B72-BCAC-EE50A8F9F79E@sun.com> http://cr.openjdk.java.net/~never/6849574 From Vladimir.Kozlov at Sun.COM Wed Jun 10 11:48:24 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Wed, 10 Jun 2009 11:48:24 -0700 Subject: review (XS) for 6849574: VM crash using NonBlockingHashMap (high_scale_lib) In-Reply-To: <226B4520-D643-4B72-BCAC-EE50A8F9F79E@sun.com> References: <226B4520-D643-4B72-BCAC-EE50A8F9F79E@sun.com> Message-ID: <4A2FFFF8.2080708@sun.com> Tom, In c1_LIRGenerator.cpp you changed code to do imprecise card mark on object. What happens if the object is large and the field is outside of imprecise card mark? Also can you explain the original comment there (could be related to the first question)? ! // Precise cardmarks don't work thanks, Vladimir Tom Rodriguez wrote: > http://cr.openjdk.java.net/~never/6849574 From Thomas.Rodriguez at Sun.COM Wed Jun 10 12:00:02 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 10 Jun 2009 12:00:02 -0700 Subject: review (XS) for 6849574: VM crash using NonBlockingHashMap (high_scale_lib) In-Reply-To: <4A2FFFF8.2080708@sun.com> References: <226B4520-D643-4B72-BCAC-EE50A8F9F79E@sun.com> <4A2FFFF8.2080708@sun.com> Message-ID: <2336919A-7141-4ABC-A52D-03C2E9723A23@Sun.COM> On Jun 10, 2009, at 11:48 AM, Vladimir Kozlov wrote: > Tom, > > In c1_LIRGenerator.cpp you changed code to do imprecise card mark on > object. > What happens if the object is large and the field is outside of > imprecise card mark? PRECISE_CARDMARK is never defined so I didn't change anything. I was just removing meaningless code. > Also can you explain the original comment there (could be related to > the first question)? > ! // Precise cardmarks don't work I don't know what that comment meant. Precise cardmarks do work since they are used in the other places where they are required. tom > > thanks, > Vladimir > > Tom Rodriguez wrote: >> http://cr.openjdk.java.net/~never/6849574 From Vladimir.Kozlov at Sun.COM Wed Jun 10 12:04:33 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Wed, 10 Jun 2009 12:04:33 -0700 Subject: review (XS) for 6849574: VM crash using NonBlockingHashMap (high_scale_lib) In-Reply-To: <2336919A-7141-4ABC-A52D-03C2E9723A23@Sun.COM> References: <226B4520-D643-4B72-BCAC-EE50A8F9F79E@sun.com> <4A2FFFF8.2080708@sun.com> <2336919A-7141-4ABC-A52D-03C2E9723A23@Sun.COM> Message-ID: <4A3003C1.2050403@sun.com> Fine then. One more thing - you did not put copyright header into the test. Thanks, Vladimir Tom Rodriguez wrote: > > On Jun 10, 2009, at 11:48 AM, Vladimir Kozlov wrote: > >> Tom, >> >> In c1_LIRGenerator.cpp you changed code to do imprecise card mark on >> object. >> What happens if the object is large and the field is outside of >> imprecise card mark? > > PRECISE_CARDMARK is never defined so I didn't change anything. I was > just removing meaningless code. > >> Also can you explain the original comment there (could be related to >> the first question)? >> ! // Precise cardmarks don't work > > I don't know what that comment meant. Precise cardmarks do work since > they are used in the other places where they are required. > > tom > >> >> thanks, >> Vladimir >> >> Tom Rodriguez wrote: >>> http://cr.openjdk.java.net/~never/6849574 > From Thomas.Rodriguez at Sun.COM Wed Jun 10 12:13:48 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 10 Jun 2009 12:13:48 -0700 Subject: review (XS) for 6849574: VM crash using NonBlockingHashMap (high_scale_lib) In-Reply-To: <4A3003C1.2050403@sun.com> References: <226B4520-D643-4B72-BCAC-EE50A8F9F79E@sun.com> <4A2FFFF8.2080708@sun.com> <2336919A-7141-4ABC-A52D-03C2E9723A23@Sun.COM> <4A3003C1.2050403@sun.com> Message-ID: Oops. I thought the file looked strangely short. I'll fix it. Thanks! tom On Jun 10, 2009, at 12:04 PM, Vladimir Kozlov wrote: > Fine then. > One more thing - you did not put copyright header into the test. > > Thanks, > Vladimir > > Tom Rodriguez wrote: >> On Jun 10, 2009, at 11:48 AM, Vladimir Kozlov wrote: >>> Tom, >>> >>> In c1_LIRGenerator.cpp you changed code to do imprecise card mark >>> on object. >>> What happens if the object is large and the field is outside of >>> imprecise card mark? >> PRECISE_CARDMARK is never defined so I didn't change anything. I >> was just removing meaningless code. >>> Also can you explain the original comment there (could be related >>> to the first question)? >>> ! // Precise cardmarks don't work >> I don't know what that comment meant. Precise cardmarks do work >> since they are used in the other places where they are required. >> tom >>> >>> thanks, >>> Vladimir >>> >>> Tom Rodriguez wrote: >>>> http://cr.openjdk.java.net/~never/6849574 From Thomas.Rodriguez at Sun.COM Wed Jun 10 12:33:16 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 10 Jun 2009 12:33:16 -0700 Subject: review (S) for 6818666: G1: Type lost in g1 pre-barrierr In-Reply-To: <6988EA7C-C743-40FE-871C-D9C844D933D1@Sun.COM> References: <49F8D5EB.5000608@sun.com> <6988EA7C-C743-40FE-871C-D9C844D933D1@Sun.COM> Message-ID: <60697EB7-69BA-4360-9F6C-3B242C04D26C@sun.com> I've corrected this logic to match do_put_xxx and retested. Everything looks good. tom On May 4, 2009, at 1:20 PM, Tom Rodriguez wrote: > > On Apr 29, 2009, at 3:34 PM, Vladimir Kozlov wrote: > >> In GraphKit::store_oop_to_unknown() should you also check field- >> >type()->is_loaded()? > > You're right. It should mirror the logic in do_put_xxx in > parse3.cpp. I'm going to fix that and retest. I want to exercise > that logic a bit more to make sure it's working the way I think. > > tom > >> >> >> Thanks, >> Vladimir >> >> Tom Rodriguez wrote: >>> http://cr.openjdk.java.net/~never/6818666 > From Vladimir.Kozlov at Sun.COM Wed Jun 10 13:36:03 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Wed, 10 Jun 2009 13:36:03 -0700 Subject: review (S) for 6818666: G1: Type lost in g1 pre-barrierr In-Reply-To: <60697EB7-69BA-4360-9F6C-3B242C04D26C@sun.com> References: <49F8D5EB.5000608@sun.com> <6988EA7C-C743-40FE-871C-D9C844D933D1@Sun.COM> <60697EB7-69BA-4360-9F6C-3B242C04D26C@sun.com> Message-ID: <4A301933.9000502@sun.com> Looks good. Vladimir Tom Rodriguez wrote: > I've corrected this logic to match do_put_xxx and retested. Everything > looks good. > > tom > > On May 4, 2009, at 1:20 PM, Tom Rodriguez wrote: > >> >> On Apr 29, 2009, at 3:34 PM, Vladimir Kozlov wrote: >> >>> In GraphKit::store_oop_to_unknown() should you also check >>> field->type()->is_loaded()? >> >> You're right. It should mirror the logic in do_put_xxx in >> parse3.cpp. I'm going to fix that and retest. I want to exercise >> that logic a bit more to make sure it's working the way I think. >> >> tom >> >>> >>> >>> Thanks, >>> Vladimir >>> >>> Tom Rodriguez wrote: >>>> http://cr.openjdk.java.net/~never/6818666 >> > From Christian.Thalinger at Sun.COM Wed Jun 10 14:21:23 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Wed, 10 Jun 2009 23:21:23 +0200 Subject: Request for reviews .03 (L): 5057225: Remove useless I2L conversions In-Reply-To: <1242662497.29179.35.camel@macbook> References: <1242159760.15714.5.camel@macbook> <1242213534.15714.24.camel@macbook> <1242302492.1482.5.camel@macbook> <1242662497.29179.35.camel@macbook> Message-ID: <4A3023D3.6040604@Sun.COM> Christian Thalinger wrote: > On Thu, 2009-05-14 at 14:01 +0200, Christian Thalinger wrote: >> On Wed, 2009-05-13 at 13:18 +0200, Christian Thalinger wrote: >>> http://cr.openjdk.java.net/~twisti/5057225/webrev.02/ >>> >>> This is an updated version with the changes of 6814842 merged in. >> I found a problem during testing and have to investigate that further. > > This patch fixes the above problem: > > http://cr.openjdk.java.net/~twisti/5057225/webrev.03/ Can I get a review for that one? -- Christian From thomas.rodriguez at sun.com Wed Jun 10 14:55:03 2009 From: thomas.rodriguez at sun.com (thomas.rodriguez at sun.com) Date: Wed, 10 Jun 2009 21:55:03 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6849574: VM crash using NonBlockingHashMap (high_scale_lib) Message-ID: <20090610215514.CF9BBE315@hg.openjdk.java.net> Changeset: c6386080541b Author: never Date: 2009-06-10 12:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/c6386080541b 6849574: VM crash using NonBlockingHashMap (high_scale_lib) Reviewed-by: kvn ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp + test/compiler/6849574/Test.java From Vladimir.Kozlov at Sun.COM Wed Jun 10 15:45:23 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Wed, 10 Jun 2009 15:45:23 -0700 Subject: Request for reviews .03 (L): 5057225: Remove useless I2L conversions In-Reply-To: <4A3023D3.6040604@Sun.COM> References: <1242159760.15714.5.camel@macbook> <1242213534.15714.24.camel@macbook> <1242302492.1482.5.camel@macbook> <1242662497.29179.35.camel@macbook> <4A3023D3.6040604@Sun.COM> Message-ID: <4A303783.4070700@sun.com> Christian, On x86 (32-,64-bit) if an arithmetic instruction is used it will kill flags. You have to add "effect(KILL cr)" when you use and/xor. Thanks, Vladimir Christian Thalinger wrote: > Christian Thalinger wrote: >> On Thu, 2009-05-14 at 14:01 +0200, Christian Thalinger wrote: >>> On Wed, 2009-05-13 at 13:18 +0200, Christian Thalinger wrote: >>>> http://cr.openjdk.java.net/~twisti/5057225/webrev.02/ >>>> >>>> This is an updated version with the changes of 6814842 merged in. >>> I found a problem during testing and have to investigate that further. >> >> This patch fixes the above problem: >> >> http://cr.openjdk.java.net/~twisti/5057225/webrev.03/ > > Can I get a review for that one? > > -- Christian From Christian.Thalinger at Sun.COM Thu Jun 11 11:18:21 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Thu, 11 Jun 2009 20:18:21 +0200 Subject: Request for reviews .03 (L): 5057225: Remove useless I2L conversions In-Reply-To: <4A303783.4070700@sun.com> References: <1242159760.15714.5.camel@macbook> <1242213534.15714.24.camel@macbook> <1242302492.1482.5.camel@macbook> <1242662497.29179.35.camel@macbook> <4A3023D3.6040604@Sun.COM> <4A303783.4070700@sun.com> Message-ID: <4A314A6D.8010305@Sun.COM> Vladimir Kozlov wrote: > Christian, > > On x86 (32-,64-bit) if an arithmetic instruction is used it will kill > flags. > You have to add "effect(KILL cr)" when you use and/xor. Right, I missed that. Thanks! -- Christian From john.coomes at sun.com Thu Jun 11 21:46:32 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 12 Jun 2009 04:46:32 +0000 Subject: hg: jdk7/hotspot-comp: 6 new changesets Message-ID: <20090612044633.1CBDDE412@hg.openjdk.java.net> Changeset: a942ea653d97 Author: aph Date: 2009-04-17 15:37 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/a942ea653d97 6829575: 100028: Debug information is incomplete or missing Summary: Enable debugging in many places Reviewed-by: ohair Contributed-by: Andrew Haley ! make/sanity-rules.gmk Changeset: f5ab6d6ae4b1 Author: xdono Date: 2009-05-07 10:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/f5ab6d6ae4b1 Merge - make/jprt.config Changeset: 37fad8722d92 Author: ohair Date: 2009-03-26 16:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/37fad8722d92 6822913: Consolidate make/jprt.config files, let JPRT manage this file make it optional in repos Reviewed-by: tbell - make/jprt.config Changeset: b284e021293c Author: ohair Date: 2009-05-08 16:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/b284e021293c Merge Changeset: 39565502682c Author: ohair Date: 2009-05-15 13:27 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/39565502682c Merge Changeset: 472c21584cfd Author: xdono Date: 2009-06-11 10:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/472c21584cfd Added tag jdk7-b60 for changeset 39565502682c ! .hgtags From john.coomes at sun.com Thu Jun 11 21:53:55 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 12 Jun 2009 04:53:55 +0000 Subject: hg: jdk7/hotspot-comp/corba: 6 new changesets Message-ID: <20090612045401.B64A7E429@hg.openjdk.java.net> Changeset: 7b47536c234e Author: ohair Date: 2009-03-26 16:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/7b47536c234e 6822374: Windows: detect X64 when PROCESSOR_IDENTIFIER contains EM64T or Intel64 6822913: Consolidate make/jprt.config files, let JPRT manage this file make it optional in repos Reviewed-by: tbell ! make/common/shared/Platform.gmk - make/jprt.config Changeset: 39aa6ae82075 Author: ohair Date: 2009-05-08 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/39aa6ae82075 Merge Changeset: da27d54e06bd Author: ohair Date: 2009-05-15 13:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/da27d54e06bd Merge Changeset: 5dcbe748e580 Author: ohair Date: 2009-05-19 17:38 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/5dcbe748e580 6843041: Remove duplicate README files in repositories (make/README) Reviewed-by: robilad - make/README Changeset: f1e1cccbd13a Author: ohair Date: 2009-05-19 18:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/f1e1cccbd13a 6733313: corba build warnings: /bin/sh: gcc: not found Reviewed-by: tbell ! make/common/shared/Compiler-gcc.gmk ! make/common/shared/Compiler-sun.gmk Changeset: e906b16a12a9 Author: xdono Date: 2009-06-11 10:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/e906b16a12a9 Added tag jdk7-b60 for changeset f1e1cccbd13a ! .hgtags From john.coomes at sun.com Thu Jun 11 22:05:27 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 12 Jun 2009 05:05:27 +0000 Subject: hg: jdk7/hotspot-comp/jaxp: 8 new changesets Message-ID: <20090612050539.B0AB2E436@hg.openjdk.java.net> Changeset: 19c316392d9e Author: aph Date: 2009-04-17 15:55 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/19c316392d9e 6829575: 100028: Debug information is incomplete or missing Summary: Enable debugging in many places Reviewed-by: ohair Contributed-by: Andrew Haley ! make/Makefile ! make/build.xml Changeset: 7967d26b229c Author: aph Date: 2009-04-20 19:00 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/7967d26b229c 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Summary: Correct fallout from 100028 patch Reviewed-by: ohair Contributed-by: Andrew Haley ! make/Makefile Changeset: 04af70c1189c Author: ohair Date: 2009-05-06 11:27 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/04af70c1189c 6837665: Deal with windows ant problem where commas in -D options do not work Reviewed-by: xdono ! make/Makefile ! make/build.properties Changeset: 44e5ca2a846c Author: xdono Date: 2009-05-07 10:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/44e5ca2a846c Merge Changeset: 0ea9bb9c6ddc Author: xdono Date: 2009-05-07 12:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/0ea9bb9c6ddc Merge - src/share/classes/com/sun/org/apache/xalan/internal/client/XSLTProcessorApplet.java - src/share/classes/com/sun/org/apache/xalan/internal/client/package.html Changeset: cdc8761f136a Author: ohair Date: 2009-05-15 13:24 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/cdc8761f136a Merge Changeset: 259aef5045a1 Author: ohair Date: 2009-05-19 17:38 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/259aef5045a1 6843041: Remove duplicate README files in repositories (make/README) Reviewed-by: robilad - make/README Changeset: f1ac756616ea Author: xdono Date: 2009-06-11 10:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/f1ac756616ea Added tag jdk7-b60 for changeset 259aef5045a1 ! .hgtags From john.coomes at sun.com Thu Jun 11 22:13:25 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 12 Jun 2009 05:13:25 +0000 Subject: hg: jdk7/hotspot-comp/jaxws: 8 new changesets Message-ID: <20090612051338.65889E441@hg.openjdk.java.net> Changeset: a92183572d99 Author: aph Date: 2009-04-17 15:56 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/a92183572d99 6829575: 100028: Debug information is incomplete or missing Summary: Enable debugging in many places Reviewed-by: ohair Contributed-by: Andrew Haley ! make/Makefile ! make/build.xml Changeset: ab30d5761947 Author: aph Date: 2009-04-20 19:01 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/ab30d5761947 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Summary: Correct fallout from 100028 patch Reviewed-by: ohair Contributed-by: Andrew Haley ! make/Makefile Changeset: 35c29ff8d904 Author: ohair Date: 2009-05-06 11:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/35c29ff8d904 6837665: Deal with windows ant problem where commas in -D options do not work Reviewed-by: xdono ! make/Makefile ! make/build.properties Changeset: d95fec0fa489 Author: xdono Date: 2009-05-07 10:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/d95fec0fa489 Merge ! make/Makefile ! make/build.xml - src/share/classes/com/sun/tools/internal/txw2/AntErrorListener.java - src/share/classes/com/sun/tools/internal/txw2/ConsoleErrorReporter.java - src/share/classes/com/sun/tools/internal/txw2/ErrorListener.java - src/share/classes/com/sun/tools/internal/txw2/Main.java - src/share/classes/com/sun/tools/internal/txw2/NameUtil.java - src/share/classes/com/sun/tools/internal/txw2/RELAXNGLoader.java - src/share/classes/com/sun/tools/internal/txw2/SchemaBuilder.java - src/share/classes/com/sun/tools/internal/txw2/TxwOptions.java - src/share/classes/com/sun/tools/internal/txw2/TxwTask.java - src/share/classes/com/sun/tools/internal/txw2/XmlSchemaLoader.java - src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/AnnotationsImpl.java - src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/CommentListImpl.java - src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/DataPatternBuilderImpl.java - src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/DatatypeFactory.java - src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/DivImpl.java - src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/ElementAnnotationBuilderImpl.java - src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/GrammarImpl.java - src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/GrammarSectionImpl.java - src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/SchemaBuilderImpl.java - src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/package.html - src/share/classes/com/sun/tools/internal/txw2/builder/xsd/XmlSchemaBuilder.java - src/share/classes/com/sun/tools/internal/txw2/builder/xsd/package.html - src/share/classes/com/sun/tools/internal/txw2/model/Attribute.java - src/share/classes/com/sun/tools/internal/txw2/model/CycleIterator.java - src/share/classes/com/sun/tools/internal/txw2/model/Data.java - src/share/classes/com/sun/tools/internal/txw2/model/Define.java - src/share/classes/com/sun/tools/internal/txw2/model/Element.java - src/share/classes/com/sun/tools/internal/txw2/model/Empty.java - src/share/classes/com/sun/tools/internal/txw2/model/Grammar.java - src/share/classes/com/sun/tools/internal/txw2/model/Leaf.java - src/share/classes/com/sun/tools/internal/txw2/model/List.java - src/share/classes/com/sun/tools/internal/txw2/model/Node.java - src/share/classes/com/sun/tools/internal/txw2/model/NodeSet.java - src/share/classes/com/sun/tools/internal/txw2/model/Ref.java - src/share/classes/com/sun/tools/internal/txw2/model/Text.java - src/share/classes/com/sun/tools/internal/txw2/model/Value.java - src/share/classes/com/sun/tools/internal/txw2/model/WriterNode.java - src/share/classes/com/sun/tools/internal/txw2/model/XmlNode.java - src/share/classes/com/sun/tools/internal/txw2/model/prop/AttributeProp.java - src/share/classes/com/sun/tools/internal/txw2/model/prop/ElementProp.java - src/share/classes/com/sun/tools/internal/txw2/model/prop/LeafElementProp.java - src/share/classes/com/sun/tools/internal/txw2/model/prop/Prop.java - src/share/classes/com/sun/tools/internal/txw2/model/prop/ValueProp.java - src/share/classes/com/sun/tools/internal/txw2/model/prop/XmlItemProp.java - src/share/classes/com/sun/tools/internal/ws/processor/Processor.java - src/share/classes/com/sun/tools/internal/ws/processor/ProcessorAction.java - src/share/classes/com/sun/tools/internal/ws/processor/ProcessorActionVersion.java - src/share/classes/com/sun/tools/internal/ws/processor/ProcessorConstants.java - src/share/classes/com/sun/tools/internal/ws/processor/ProcessorNotificationListener.java - src/share/classes/com/sun/tools/internal/ws/processor/ProcessorOptions.java - src/share/classes/com/sun/tools/internal/ws/processor/config/ClassModelInfo.java - src/share/classes/com/sun/tools/internal/ws/processor/config/Configuration.java - src/share/classes/com/sun/tools/internal/ws/processor/config/ConfigurationException.java - src/share/classes/com/sun/tools/internal/ws/processor/config/HandlerChainInfo.java - src/share/classes/com/sun/tools/internal/ws/processor/config/HandlerInfo.java - src/share/classes/com/sun/tools/internal/ws/processor/config/ModelInfo.java - src/share/classes/com/sun/tools/internal/ws/processor/config/WSDLModelInfo.java - src/share/classes/com/sun/tools/internal/ws/processor/config/parser/ClassModelParser.java - src/share/classes/com/sun/tools/internal/ws/processor/config/parser/CustomizationParser.java - src/share/classes/com/sun/tools/internal/ws/processor/config/parser/InputParser.java - src/share/classes/com/sun/tools/internal/ws/processor/config/parser/JAXWSBindingInfoParser.java - src/share/classes/com/sun/tools/internal/ws/processor/config/parser/ParserUtil.java - src/share/classes/com/sun/tools/internal/ws/processor/config/parser/Reader.java - src/share/classes/com/sun/tools/internal/ws/processor/generator/JAXBTypeGenerator.java - src/share/classes/com/sun/tools/internal/ws/processor/generator/SimpleToBoxedUtil.java - src/share/classes/com/sun/tools/internal/ws/processor/modeler/ModelerUtils.java - src/share/classes/com/sun/tools/internal/ws/processor/modeler/annotation/WebServiceReferenceCollector.java - src/share/classes/com/sun/tools/internal/ws/processor/util/ClientProcessorEnvironment.java - src/share/classes/com/sun/tools/internal/ws/processor/util/GeneratedFileInfo.java - src/share/classes/com/sun/tools/internal/ws/processor/util/ProcessorEnvironment.java - src/share/classes/com/sun/tools/internal/ws/processor/util/ProcessorEnvironmentBase.java - src/share/classes/com/sun/tools/internal/ws/util/JAXWSClassFactory.java - src/share/classes/com/sun/tools/internal/ws/util/JavaCompilerHelper.java - src/share/classes/com/sun/tools/internal/ws/util/MapBase.java - src/share/classes/com/sun/tools/internal/ws/util/ToolBase.java - src/share/classes/com/sun/tools/internal/ws/util/xml/NodeListIterator.java - src/share/classes/com/sun/tools/internal/ws/util/xml/NullEntityResolver.java - src/share/classes/com/sun/tools/internal/ws/util/xml/PrettyPrintingXmlWriter.java - src/share/classes/com/sun/tools/internal/ws/util/xml/XmlWriter.java - src/share/classes/com/sun/tools/internal/ws/wscompile/ActionConstants.java - src/share/classes/com/sun/tools/internal/ws/wscompile/CompileTool.java - src/share/classes/com/sun/tools/internal/ws/wsdl/document/schema/BuiltInTypes.java - src/share/classes/com/sun/tools/internal/ws/wsdl/document/schema/Schema.java - src/share/classes/com/sun/tools/internal/ws/wsdl/document/schema/SchemaAttribute.java - src/share/classes/com/sun/tools/internal/ws/wsdl/document/schema/SchemaDocument.java - src/share/classes/com/sun/tools/internal/ws/wsdl/document/schema/SchemaElement.java - src/share/classes/com/sun/tools/internal/ws/wsdl/document/schema/SchemaEntity.java - src/share/classes/com/sun/tools/internal/ws/wsdl/framework/Extensible.java - src/share/classes/com/sun/tools/internal/ws/wsdl/framework/Extension.java - src/share/classes/com/sun/tools/internal/ws/wsdl/framework/ParserContext.java - src/share/classes/com/sun/tools/internal/ws/wsdl/framework/WriterContext.java - src/share/classes/com/sun/tools/internal/ws/wsdl/parser/ExtensionHandler.java - src/share/classes/com/sun/tools/internal/ws/wsdl/parser/ExtensionHandlerBase.java - src/share/classes/com/sun/tools/internal/ws/wsdl/parser/SchemaExtensionHandler.java - src/share/classes/com/sun/tools/internal/ws/wsdl/parser/SchemaParser.java - src/share/classes/com/sun/tools/internal/ws/wsdl/parser/SchemaWriter.java - src/share/classes/com/sun/tools/internal/ws/wsdl/parser/WSDLWriter.java - src/share/classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/DOM4JLocator.java - src/share/classes/com/sun/tools/internal/xjc/util/XMLStreamReaderToContentHandler.java - src/share/classes/com/sun/xml/internal/bind/v2/doc-files/packages.png - src/share/classes/com/sun/xml/internal/bind/v2/doc-files/packages.vsd - src/share/classes/com/sun/xml/internal/bind/v2/doc-files/readme.txt - src/share/classes/com/sun/xml/internal/ws/binding/http/HTTPBindingImpl.java - src/share/classes/com/sun/xml/internal/ws/binding/soap/SOAPBindingImpl.java - src/share/classes/com/sun/xml/internal/ws/client/AsyncHandlerService.java - src/share/classes/com/sun/xml/internal/ws/client/ClientConfigurationException.java - src/share/classes/com/sun/xml/internal/ws/client/ContactInfoBase.java - src/share/classes/com/sun/xml/internal/ws/client/ContactInfoListImpl.java - src/share/classes/com/sun/xml/internal/ws/client/ContactInfoListIteratorBase.java - src/share/classes/com/sun/xml/internal/ws/client/ContextMap.java - src/share/classes/com/sun/xml/internal/ws/client/EndpointIFBase.java - src/share/classes/com/sun/xml/internal/ws/client/EndpointIFContext.java - src/share/classes/com/sun/xml/internal/ws/client/EndpointIFInvocationHandler.java - src/share/classes/com/sun/xml/internal/ws/client/InternalBindingProvider.java - src/share/classes/com/sun/xml/internal/ws/client/PortInfoBase.java - src/share/classes/com/sun/xml/internal/ws/client/ServiceContext.java - src/share/classes/com/sun/xml/internal/ws/client/ServiceContextBuilder.java - src/share/classes/com/sun/xml/internal/ws/client/WSFuture.java - src/share/classes/com/sun/xml/internal/ws/client/dispatch/DispatchBase.java - src/share/classes/com/sun/xml/internal/ws/client/dispatch/DispatchContext.java - src/share/classes/com/sun/xml/internal/ws/client/dispatch/ResponseImpl.java - src/share/classes/com/sun/xml/internal/ws/client/dispatch/impl/DispatchContactInfoList.java - src/share/classes/com/sun/xml/internal/ws/client/dispatch/impl/DispatchDelegate.java - src/share/classes/com/sun/xml/internal/ws/client/dispatch/impl/encoding/DispatchSerializer.java - src/share/classes/com/sun/xml/internal/ws/client/dispatch/impl/encoding/DispatchUtil.java - src/share/classes/com/sun/xml/internal/ws/client/dispatch/impl/protocol/MessageDispatcherHelper.java - src/share/classes/com/sun/xml/internal/ws/encoding/EncoderDecoderBase.java - src/share/classes/com/sun/xml/internal/ws/encoding/JAXWSAttachmentMarshaller.java - src/share/classes/com/sun/xml/internal/ws/encoding/JAXWSAttachmentUnmarshaller.java - src/share/classes/com/sun/xml/internal/ws/encoding/internal/InternalEncoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/jaxb/JAXBBeanInfo.java - src/share/classes/com/sun/xml/internal/ws/encoding/jaxb/JAXBBridgeInfo.java - src/share/classes/com/sun/xml/internal/ws/encoding/jaxb/JAXBTypeSerializer.java - src/share/classes/com/sun/xml/internal/ws/encoding/jaxb/RpcLitPayload.java - src/share/classes/com/sun/xml/internal/ws/encoding/jaxb/RpcLitPayloadSerializer.java - src/share/classes/com/sun/xml/internal/ws/encoding/simpletype/EncoderUtils.java - src/share/classes/com/sun/xml/internal/ws/encoding/simpletype/SimpleTypeConstants.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/ClientEncoderDecoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/EncoderDecoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/SOAPDecoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/SOAPEPTFactory.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/SOAPEncoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/SOAPVersion.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/ServerEncoderDecoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/client/SOAP12XMLDecoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/client/SOAP12XMLEncoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/client/SOAPXMLDecoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/client/SOAPXMLEncoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/AttachmentBlock.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/BodyBlock.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/DelegateBase.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/HeaderBlock.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/InternalMessage.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/MessageBlock.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/MessageInfoBase.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/SOAP12NotUnderstoodHeaderBlock.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/FaultCode.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/FaultCodeEnum.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/FaultReason.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/FaultReasonText.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/FaultSubcode.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/SOAP12FaultInfo.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/SOAPFaultInfo.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/SOAPMsgCreateException.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/SOAPMsgFactoryCreateException.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/server/ProviderSED.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/server/SOAP12XMLDecoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/server/SOAP12XMLEncoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/server/SOAPXMLDecoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/soap/server/SOAPXMLEncoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/xml/XMLDecoder.java - src/share/classes/com/sun/xml/internal/ws/encoding/xml/XMLEPTFactory.java - src/share/classes/com/sun/xml/internal/ws/encoding/xml/XMLEncoder.java - src/share/classes/com/sun/xml/internal/ws/handler/HandlerChainCaller.java - src/share/classes/com/sun/xml/internal/ws/handler/HandlerContext.java - src/share/classes/com/sun/xml/internal/ws/handler/HandlerResolverImpl.java - src/share/classes/com/sun/xml/internal/ws/handler/MessageContextUtil.java - src/share/classes/com/sun/xml/internal/ws/handler/SHDSOAPMessageContext.java - src/share/classes/com/sun/xml/internal/ws/handler/SOAPHandlerContext.java - src/share/classes/com/sun/xml/internal/ws/handler/XMLHandlerContext.java - src/share/classes/com/sun/xml/internal/ws/handler/XMLLogicalMessageContextImpl.java - src/share/classes/com/sun/xml/internal/ws/handler/XMLLogicalMessageImpl.java - src/share/classes/com/sun/xml/internal/ws/handler/package-info.java - src/share/classes/com/sun/xml/internal/ws/model/CheckedException.java - src/share/classes/com/sun/xml/internal/ws/model/ExceptionType.java - src/share/classes/com/sun/xml/internal/ws/model/JavaMethod.java - src/share/classes/com/sun/xml/internal/ws/model/Mode.java - src/share/classes/com/sun/xml/internal/ws/model/Parameter.java - src/share/classes/com/sun/xml/internal/ws/model/ParameterBinding.java - src/share/classes/com/sun/xml/internal/ws/model/RuntimeModel.java - src/share/classes/com/sun/xml/internal/ws/model/soap/SOAPBinding.java - src/share/classes/com/sun/xml/internal/ws/model/soap/SOAPRuntimeModel.java - src/share/classes/com/sun/xml/internal/ws/model/soap/Style.java - src/share/classes/com/sun/xml/internal/ws/model/soap/Use.java - src/share/classes/com/sun/xml/internal/ws/modeler/RuntimeModeler.java - src/share/classes/com/sun/xml/internal/ws/modeler/RuntimeModelerException.java - src/share/classes/com/sun/xml/internal/ws/pept/Delegate.java - src/share/classes/com/sun/xml/internal/ws/pept/encoding/Decoder.java - src/share/classes/com/sun/xml/internal/ws/pept/encoding/Encoder.java - src/share/classes/com/sun/xml/internal/ws/pept/ept/Acceptor.java - src/share/classes/com/sun/xml/internal/ws/pept/ept/ContactInfo.java - src/share/classes/com/sun/xml/internal/ws/pept/ept/ContactInfoList.java - src/share/classes/com/sun/xml/internal/ws/pept/ept/ContactInfoListIterator.java - src/share/classes/com/sun/xml/internal/ws/pept/ept/EPTFactory.java - src/share/classes/com/sun/xml/internal/ws/pept/ept/MessageInfo.java - src/share/classes/com/sun/xml/internal/ws/pept/presentation/MessageStruct.java - src/share/classes/com/sun/xml/internal/ws/pept/presentation/Stub.java - src/share/classes/com/sun/xml/internal/ws/pept/presentation/TargetFinder.java - src/share/classes/com/sun/xml/internal/ws/pept/presentation/Tie.java - src/share/classes/com/sun/xml/internal/ws/pept/protocol/Interceptors.java - src/share/classes/com/sun/xml/internal/ws/pept/protocol/MessageDispatcher.java - src/share/classes/com/sun/xml/internal/ws/protocol/soap/client/SOAPMessageDispatcher.java - src/share/classes/com/sun/xml/internal/ws/protocol/soap/server/ProviderSOAPMD.java - src/share/classes/com/sun/xml/internal/ws/protocol/soap/server/SOAPMessageDispatcher.java - src/share/classes/com/sun/xml/internal/ws/protocol/xml/client/XMLMessageDispatcher.java - src/share/classes/com/sun/xml/internal/ws/protocol/xml/server/ProviderXMLMD.java - src/share/classes/com/sun/xml/internal/ws/protocol/xml/server/XMLMessageDispatcher.java - src/share/classes/com/sun/xml/internal/ws/server/AppMsgContextImpl.java - src/share/classes/com/sun/xml/internal/ws/server/DocInfo.java - src/share/classes/com/sun/xml/internal/ws/server/EPTFactoryBase.java - src/share/classes/com/sun/xml/internal/ws/server/EPTFactoryFactoryBase.java - src/share/classes/com/sun/xml/internal/ws/server/PeptTie.java - src/share/classes/com/sun/xml/internal/ws/server/RuntimeContext.java - src/share/classes/com/sun/xml/internal/ws/server/RuntimeEndpointInfo.java - src/share/classes/com/sun/xml/internal/ws/server/TargetFinderImpl.java - src/share/classes/com/sun/xml/internal/ws/server/Tie.java - src/share/classes/com/sun/xml/internal/ws/server/XMLEPTFactoryImpl.java - src/share/classes/com/sun/xml/internal/ws/server/provider/ProviderModel.java - src/share/classes/com/sun/xml/internal/ws/server/provider/ProviderPeptTie.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/Binding.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/ClientTransportFactory.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/ClientTransportFactoryTypes.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/InternalSoapEncoder.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/Invoker.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/MessageContext.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/MtomCallback.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/RuntimeEndpointInfo.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/SOAPMessageContext.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/StubBase.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/SystemHandlerDelegate.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/SystemHandlerDelegateFactory.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/Tie.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/WSConnection.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/WebServiceContext.java - src/share/classes/com/sun/xml/internal/ws/spi/runtime/package-info.java - src/share/classes/com/sun/xml/internal/ws/streaming/XMLStreamReaderFactory.java - src/share/classes/com/sun/xml/internal/ws/streaming/XMLStreamWriterFactory.java - src/share/classes/com/sun/xml/internal/ws/transport/WSConnectionImpl.java - src/share/classes/com/sun/xml/internal/ws/transport/http/client/HttpClientTransportFactory.java - src/share/classes/com/sun/xml/internal/ws/transport/http/server/EndpointDocInfo.java - src/share/classes/com/sun/xml/internal/ws/transport/http/server/EndpointEntityResolver.java - src/share/classes/com/sun/xml/internal/ws/transport/http/server/WebServiceContextImpl.java - src/share/classes/com/sun/xml/internal/ws/transport/local/LocalMessage.java - src/share/classes/com/sun/xml/internal/ws/transport/local/client/LocalClientTransport.java - src/share/classes/com/sun/xml/internal/ws/transport/local/client/LocalClientTransportFactory.java - src/share/classes/com/sun/xml/internal/ws/transport/local/server/LocalConnectionImpl.java - src/share/classes/com/sun/xml/internal/ws/transport/local/server/LocalWSContextImpl.java - src/share/classes/com/sun/xml/internal/ws/util/Base64Util.java - src/share/classes/com/sun/xml/internal/ws/util/MessageInfoUtil.java - src/share/classes/com/sun/xml/internal/ws/util/NullIterator.java - src/share/classes/com/sun/xml/internal/ws/util/SOAPConnectionUtil.java - src/share/classes/com/sun/xml/internal/ws/util/SOAPUtil.java - src/share/classes/com/sun/xml/internal/ws/util/SunStAXReflection.java - src/share/classes/com/sun/xml/internal/ws/util/XMLConnectionUtil.java - src/share/classes/com/sun/xml/internal/ws/util/xml/XMLStreamReaderToContentHandler.java - src/share/classes/com/sun/xml/internal/ws/wsdl/WSDLContext.java - src/share/classes/com/sun/xml/internal/ws/wsdl/parser/Binding.java - src/share/classes/com/sun/xml/internal/ws/wsdl/parser/BindingOperation.java - src/share/classes/com/sun/xml/internal/ws/wsdl/parser/Message.java - src/share/classes/com/sun/xml/internal/ws/wsdl/parser/Part.java - src/share/classes/com/sun/xml/internal/ws/wsdl/parser/Port.java - src/share/classes/com/sun/xml/internal/ws/wsdl/parser/PortType.java - src/share/classes/com/sun/xml/internal/ws/wsdl/parser/PortTypeOperation.java - src/share/classes/com/sun/xml/internal/ws/wsdl/parser/Service.java - src/share/classes/com/sun/xml/internal/ws/wsdl/parser/WSDLDocument.java - src/share/classes/com/sun/xml/internal/ws/wsdl/writer/WSDLOutputResolver.java - src/share/classes/com/sun/xml/internal/xsom/impl/util/ConcatIterator.java - src/share/classes/com/sun/xml/internal/xsom/impl/util/FilterIterator.java Changeset: 1626ba49a98e Author: xdono Date: 2009-05-07 12:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/1626ba49a98e Merge Changeset: af4d62e31af8 Author: ohair Date: 2009-05-15 13:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/af4d62e31af8 Merge Changeset: 3b054db3e277 Author: ohair Date: 2009-05-19 17:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/3b054db3e277 6843041: Remove duplicate README files in repositories (make/README) Reviewed-by: robilad - make/README Changeset: aeabf802f2a1 Author: xdono Date: 2009-06-11 10:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/aeabf802f2a1 Added tag jdk7-b60 for changeset 3b054db3e277 ! .hgtags From john.coomes at sun.com Thu Jun 11 22:21:33 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 12 Jun 2009 05:21:33 +0000 Subject: hg: jdk7/hotspot-comp/jdk: 31 new changesets Message-ID: <20090612052811.47991E44D@hg.openjdk.java.net> Changeset: 9ad7e6462145 Author: aph Date: 2009-04-17 15:56 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/9ad7e6462145 6829575: 100028: Debug information is incomplete or missing Summary: Enable debugging in many places Reviewed-by: ohair Contributed-by: Andrew Haley ! make/common/Defs-linux.gmk ! make/sun/awt/mawt.gmk Changeset: 5ceb9eb621d1 Author: chegar Date: 2009-05-07 17:02 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/5ceb9eb621d1 6837982: SCTP API docs not being generated. Summary: Update docs makefile to build javadoc for the com.sun.nio.sctp package. Reviewed-by: jccollet, alanb, weijun ! make/docs/Makefile Changeset: 86d2541a9ba2 Author: xdono Date: 2009-05-07 10:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/86d2541a9ba2 Merge - src/share/native/java/util/zip/ZipEntry.c - src/share/native/sun/java2d/pipe/RenderBuffer.c - test/com/sun/awt/Translucency/TranslucentJAppletTest/TranslucentJAppletTest.java - test/com/sun/awt/Translucency/TranslucentShapedFrameTest/TSFrame.java - test/com/sun/awt/Translucency/TranslucentShapedFrameTest/TranslucentShapedFrameTest.form - test/com/sun/awt/Translucency/TranslucentShapedFrameTest/TranslucentShapedFrameTest.java Changeset: 39d93fb6926c Author: xdono Date: 2009-05-07 12:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/39d93fb6926c Merge Changeset: 6ca1c622dd6e Author: ohair Date: 2009-05-07 18:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/6ca1c622dd6e 6835803: Type error in src/windows/native/sun/windows/awt_Window.cpp Reviewed-by: prr ! src/windows/native/sun/windows/awt_Window.cpp Changeset: 7ec6857812d2 Author: ohair Date: 2009-05-08 11:24 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/7ec6857812d2 Merge ! src/windows/native/sun/windows/awt_Window.cpp Changeset: 9eeeeee69368 Author: ohair Date: 2009-05-15 13:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/9eeeeee69368 6841873: Fix windows redist default location for msvc runtime dlls Reviewed-by: tbell ! make/common/shared/Defs-windows.gmk Changeset: 97064d73976f Author: ohair Date: 2009-05-15 13:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/97064d73976f Merge Changeset: fdbc48164a8b Author: ohair Date: 2009-05-18 10:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/fdbc48164a8b 6842023: Improve test reliability, Increase timeout factor on jtreg tests, etc. Reviewed-by: tbell ! make/jprt.properties ! test/Makefile ! test/java/lang/ThreadGroup/NullThreadName.java ! test/java/util/ResourceBundle/RestrictedBundleTest.java ! test/java/util/WeakHashMap/GCDuringIteration.java Changeset: c06d30bd8c69 Author: andrew Date: 2009-05-21 16:29 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/c06d30bd8c69 6841728: Make building the Nimbus L 'n' F optional (100054) Summary: Add DISABLE_NIMBUS variable to prevent Nimbus subdirs being built Reviewed-by: mr, ohair ! make/common/shared/Sanity.gmk ! make/javax/swing/plaf/Makefile ! make/tools/Makefile Changeset: 238591c80bc5 Author: aph Date: 2009-05-21 18:41 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/238591c80bc5 6839133: lcms 1.18 update breaks ICC_ProfileRGB Tests Reviewed-by: avu, prr ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: f62f7fcc9965 Author: art Date: 2009-05-15 15:40 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/f62f7fcc9965 6678385: Random java.lang.StackOverflowError from various JDKs Reviewed-by: stayer ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11/MotifDnDConstants.java ! src/solaris/classes/sun/awt/X11/MotifDnDDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/MotifDnDDropTargetProtocol.java ! src/solaris/classes/sun/awt/X11/WindowPropertyGetter.java ! src/solaris/classes/sun/awt/X11/XAWTXSettings.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XDnDDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/XDnDDropTargetProtocol.java ! src/solaris/classes/sun/awt/X11/XDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/XDropTargetRegistry.java ! src/solaris/classes/sun/awt/X11/XEmbedCanvasPeer.java + src/solaris/classes/sun/awt/X11/XErrorHandler.java ! src/solaris/classes/sun/awt/X11/XProtocol.java ! src/solaris/classes/sun/awt/X11/XQueryTree.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XTranslateCoordinates.java ! src/solaris/classes/sun/awt/X11/XWM.java ! src/solaris/classes/sun/awt/X11/XlibUtil.java ! src/solaris/classes/sun/awt/X11/XlibWrapper.java ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/awt/awt_InputMethod.c ! src/solaris/native/sun/awt/awt_MToolkit.c ! src/solaris/native/sun/xawt/XToolkit.c ! src/solaris/native/sun/xawt/XlibWrapper.c Changeset: 019fd945ebc5 Author: yan Date: 2009-05-18 12:39 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/019fd945ebc5 6834525: PIT: RowToleranceTransitivityTest test fail with crash on rhel4 x86 and rhel 5x86 Summary: do not try to use released XKB resources Reviewed-by: art ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/keysym2ucs.h Changeset: 875524a2b311 Author: anthony Date: 2009-05-19 12:15 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/875524a2b311 6811219: Deadlock java AWT in XWarningWindow Summary: The locking scheme has been re-architected, the code slightly refactored. Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XWarningWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: 5eaa495dc929 Author: anthony Date: 2009-05-19 14:14 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/5eaa495dc929 6812298: Dynamic GraphicsConfig changes don't work on X11 platforms Summary: The peer gets recreated if the visual of the new GC differs from the previous one Reviewed-by: art, dcherepanov ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/peer/ComponentPeer.java ! src/share/classes/sun/awt/NullComponentPeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedChildProxyPeer.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java Changeset: ac08fa3d6c98 Author: anthony Date: 2009-05-19 14:43 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/ac08fa3d6c98 6833444: _BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms Summary: Added optional _BOOTDIR3 that provides the J: path for the BOOTDIR on Windows Reviewed-by: ohair, xdono ! make/common/Sanity.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Sanity.gmk Changeset: 315f315b8d3c Author: anthony Date: 2009-05-19 17:03 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/315f315b8d3c 6839999: Cumulative fix for 6762511 and 6838003 Summary: Adds support for ARGB and ABGR X11 surfaces. Reviewed-by: art, yan ! src/solaris/classes/sun/awt/X11/generator/sizes.64-solaris-i386 ! src/solaris/classes/sun/awt/X11/generator/xlibtypes.txt ! src/solaris/classes/sun/awt/X11GraphicsConfig.java ! src/solaris/classes/sun/java2d/x11/X11PMBlitBgLoops.java ! src/solaris/classes/sun/java2d/x11/X11PMBlitLoops.java ! src/solaris/classes/sun/java2d/x11/X11SurfaceData.java ! src/solaris/native/sun/awt/X11Color.c ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/awt/awt_p.h Changeset: b33466bb2fed Author: art Date: 2009-05-21 12:29 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/b33466bb2fed 6794764: Translucent windows are completely repainted on every paint event, on Windows 6719382: Printing of AWT components on windows is not working 6726866: Repainting artifacts when resizing or dragging JInternalFrames in non-opaque toplevel 6683775: Painting artifacts is seen when panel is made setOpaque(false) for a translucent window Reviewed-by: anthony, tdv, alexp ! src/share/classes/java/awt/GraphicsConfiguration.java ! src/share/classes/java/awt/GraphicsDevice.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/peer/WindowPeer.java ! src/share/classes/javax/swing/DefaultDesktopManager.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/share/classes/sun/awt/EmbeddedFrame.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/windows/classes/sun/awt/windows/TranslucentWindowPainter.java ! src/windows/classes/sun/awt/windows/WCanvasPeer.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WObjectPeer.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awt_Window.h + test/javax/swing/JComponent/6683775/bug6683775.java + test/javax/swing/JInternalFrame/6726866/bug6726866.html + test/javax/swing/JInternalFrame/6726866/bug6726866.java Changeset: 97ece6b3d84f Author: ant Date: 2009-05-21 15:04 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/97ece6b3d84f 6833019: KeyboardFocusManager.getCurrentKeyboardFocusManager() throws unspecified HeadlessException Reviewed-by: art ! src/share/classes/sun/awt/HeadlessToolkit.java Changeset: cfe73335a065 Author: dav Date: 2009-05-22 16:09 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/cfe73335a065 6799099: All automatic regression tests that create Robot fail on X11 Reviewed-by: art, ant ! make/sun/xawt/mapfile-vers ! src/share/classes/java/awt/Robot.java ! src/share/classes/java/awt/event/InputEvent.java ! src/share/classes/java/awt/event/MouseEvent.java ! src/share/classes/java/awt/peer/RobotPeer.java ! src/share/classes/sun/awt/SunToolkit.java ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/classes/sun/awt/X11/XDragSourceContextPeer.java ! src/solaris/classes/sun/awt/X11/XRobotPeer.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/motif/MToolkit.java ! src/solaris/native/sun/awt/awt_MToolkit.c ! src/solaris/native/sun/awt/awt_Robot.c ! src/solaris/native/sun/xawt/XToolkit.c ! src/windows/classes/sun/awt/windows/WRobotPeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/native/sun/windows/awt_Robot.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp Changeset: 52493efeb137 Author: dav Date: 2009-05-25 18:22 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/52493efeb137 6844750: Solaris build failed after 6799099 Reviewed-by: yan ! src/solaris/native/sun/xawt/XToolkit.c Changeset: 7da360c3baf6 Author: yan Date: 2009-06-01 01:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/7da360c3baf6 Merge Changeset: f29cd35647b1 Author: peytoia Date: 2009-05-12 15:21 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/f29cd35647b1 6834474: (tz) Support tzdata2009g Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/leapseconds ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/southamerica ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java Changeset: 62bfe2674e48 Author: yan Date: 2009-05-14 00:17 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/62bfe2674e48 Merge - src/share/native/sun/java2d/pipe/RenderBuffer.c Changeset: 455b357442c7 Author: peterz Date: 2009-05-14 18:12 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/455b357442c7 6741426: ClassCastException from ComboBoxEditableState (Nimbus LaF) in JDK 1.6.0_10 RC Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/nimbus/skin.laf + test/javax/swing/plaf/nimbus/Test6741426.java Changeset: af491a9b7c1d Author: peterz Date: 2009-05-15 12:06 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/af491a9b7c1d 6827581: Contextkey does not work in Nimbus Reviewed-by: rupashka ! src/share/classes/sun/swing/plaf/GTKKeybindings.java ! src/share/classes/sun/swing/plaf/WindowsKeybindings.java Changeset: 993a5f0fe2e0 Author: rupashka Date: 2009-05-15 17:26 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/993a5f0fe2e0 6713352: Deadlock in JFileChooser with synchronized custom FileSystemView Reviewed-by: malenkov, peterz ! src/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java ! src/share/classes/sun/awt/shell/ShellFolder.java ! src/windows/classes/sun/awt/shell/Win32ShellFolder2.java ! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java + test/javax/swing/JFileChooser/6713352/bug6713352.java Changeset: 019908df0313 Author: rupashka Date: 2009-05-28 18:11 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/019908df0313 6845805: Test for CR 6713352 is failed under Linux Reviewed-by: malenkov ! test/javax/swing/JFileChooser/6713352/bug6713352.java Changeset: 951ecbad4068 Author: yan Date: 2009-06-01 01:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/951ecbad4068 Merge Changeset: 0c3ef2d612a4 Author: yan Date: 2009-06-09 23:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/0c3ef2d612a4 Merge ! make/common/shared/Defs-windows.gmk ! make/common/shared/Sanity.gmk ! src/windows/native/sun/windows/awt_Window.cpp Changeset: f72c0dc047b9 Author: xdono Date: 2009-06-11 10:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/f72c0dc047b9 Added tag jdk7-b60 for changeset 0c3ef2d612a4 ! .hgtags From john.coomes at sun.com Thu Jun 11 22:43:37 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 12 Jun 2009 05:43:37 +0000 Subject: hg: jdk7/hotspot-comp/langtools: 8 new changesets Message-ID: <20090612054352.DC3E7E45C@hg.openjdk.java.net> Changeset: 4b72c2556789 Author: aph Date: 2009-04-17 15:56 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/4b72c2556789 6829575: 100028: Debug information is incomplete or missing Summary: Enable debugging in many places Reviewed-by: ohair Contributed-by: Andrew Haley ! make/Makefile Changeset: 321854d9ab19 Author: aph Date: 2009-04-20 19:01 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/321854d9ab19 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Summary: Correct fallout from 100028 patch Reviewed-by: ohair Contributed-by: Andrew Haley ! make/Makefile Changeset: f3d27f02683c Author: aph Date: 2009-05-06 18:04 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/f3d27f02683c 6837665: Deal with windows ant problem where commas in -D options do not work Summary: Rewrite to avoid commas in -D options Reviewed-by: ohair ! make/Makefile ! make/build.xml Changeset: 43a781cc6473 Author: xdono Date: 2009-05-07 10:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/43a781cc6473 Merge Changeset: 846944dd48a4 Author: xdono Date: 2009-05-07 12:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/846944dd48a4 Merge Changeset: 65f2ee956fb9 Author: ohair Date: 2009-05-15 13:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/65f2ee956fb9 Merge Changeset: 5cdce469ea2a Author: ohair Date: 2009-05-19 17:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/5cdce469ea2a 6843041: Remove duplicate README files in repositories (make/README) Reviewed-by: robilad ! README - make/README Changeset: 522520757dd3 Author: xdono Date: 2009-06-11 10:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/522520757dd3 Added tag jdk7-b60 for changeset 5cdce469ea2a ! .hgtags From Christian.Thalinger at Sun.COM Tue Jun 16 05:42:28 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Tue, 16 Jun 2009 14:42:28 +0200 Subject: Request for reviews .03 (L): 5057225: Remove useless I2L conversions In-Reply-To: <4A314A6D.8010305@Sun.COM> References: <1242159760.15714.5.camel@macbook> <1242213534.15714.24.camel@macbook> <1242302492.1482.5.camel@macbook> <1242662497.29179.35.camel@macbook> <4A3023D3.6040604@Sun.COM> <4A303783.4070700@sun.com> <4A314A6D.8010305@Sun.COM> Message-ID: <4A379334.1050106@Sun.COM> Christian Thalinger wrote: > Vladimir Kozlov wrote: >> Christian, >> >> On x86 (32-,64-bit) if an arithmetic instruction is used it will kill >> flags. >> You have to add "effect(KILL cr)" when you use and/xor. ...and SAR. I hope I got all cases: http://cr.openjdk.java.net/~twisti/5057225/webrev.04/ -- Christian From Christian.Thalinger at Sun.COM Wed Jun 17 02:53:49 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Wed, 17 Jun 2009 11:53:49 +0200 Subject: Request for reviews (XXS): 6851829: solaris build fails with 5.8 compilers Message-ID: <4A38BD2D.4090406@Sun.COM> http://cr.openjdk.java.net/~twisti/6851829/webrev.01/ From Thomas.Rodriguez at Sun.COM Wed Jun 17 09:01:47 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 17 Jun 2009 09:01:47 -0700 Subject: Request for reviews (XXS): 6851829: solaris build fails with 5.8 compilers In-Reply-To: <4A38BD2D.4090406@Sun.COM> References: <4A38BD2D.4090406@Sun.COM> Message-ID: <3EDC0255-969B-4BDD-A79B-193B5FFE3272@sun.com> Looks good. tom On Jun 17, 2009, at 2:53 AM, Christian Thalinger wrote: > http://cr.openjdk.java.net/~twisti/6851829/webrev.01/ From John.Coomes at sun.com Wed Jun 17 10:26:42 2009 From: John.Coomes at sun.com (John Coomes) Date: Wed, 17 Jun 2009 10:26:42 -0700 Subject: Request for reviews (XXS): 6851829: solaris build fails with 5.8 compilers In-Reply-To: <4A38BD2D.4090406@Sun.COM> References: <4A38BD2D.4090406@Sun.COM> Message-ID: <19001.10066.327038.635326@sun.com> Christian Thalinger (Christian.Thalinger at Sun.COM) wrote: > http://cr.openjdk.java.net/~twisti/6851829/webrev.01/ Looks good to me. -John From rasbold at google.com Thu Jun 18 07:54:47 2009 From: rasbold at google.com (Chuck Rasbold) Date: Thu, 18 Jun 2009 07:54:47 -0700 Subject: Request for review (M): 6837094: False positive for "meet not symmetric" failure Message-ID: <4149a0430906180754l5ef2eef1gd92793440a5b1eb4@mail.gmail.com> http://cr.openjdk.java.net/~rasbold/6837094/webrev.00 Fixed 6837094: False positive for "meet not symmetric" failure Have the meet not symmetric check recursively do the interface-vs-oop check on array subtypes. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20090618/f717335d/attachment.html From John.Rose at Sun.COM Thu Jun 18 14:24:00 2009 From: John.Rose at Sun.COM (John Rose) Date: Thu, 18 Jun 2009 14:24:00 -0700 Subject: Request for review (M): 6837094: False positive for "meet not symmetric" failure In-Reply-To: <4149a0430906180754l5ef2eef1gd92793440a5b1eb4@mail.gmail.com> References: <4149a0430906180754l5ef2eef1gd92793440a5b1eb4@mail.gmail.com> Message-ID: Reviewed. Thanks! -- John P.S. Interface types in the JIT IR are much pain for little gain, since the bytecode verifier doesn't guarantee them. I wonder what would happen if we just erased all interfaces to Object in C2. Would probably disable some type-check constant foldings. The right answer, I think, is to treat C2 interface types as assertions collected in addition to class information, not in the place of class information. On Jun 18, 2009, at 7:54 AM, Chuck Rasbold wrote: > http://cr.openjdk.java.net/~rasbold/6837094/webrev.00 > > Fixed 6837094: False positive for "meet not symmetric" failure > > Have the meet not symmetric check recursively do the interface-vs-oop > check on array subtypes. > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20090618/ea471a0c/attachment.html From john.coomes at sun.com Thu Jun 18 21:22:19 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Jun 2009 04:22:19 +0000 Subject: hg: jdk7/hotspot-comp: Added tag jdk7-b61 for changeset 472c21584cfd Message-ID: <20090619042219.DC89DEA77@hg.openjdk.java.net> Changeset: 68836ec8bcc7 Author: xdono Date: 2009-06-18 13:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/68836ec8bcc7 Added tag jdk7-b61 for changeset 472c21584cfd ! .hgtags From john.coomes at sun.com Thu Jun 18 21:26:48 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Jun 2009 04:26:48 +0000 Subject: hg: jdk7/hotspot-comp/corba: Added tag jdk7-b61 for changeset e906b16a12a9 Message-ID: <20090619042649.8841AEA7C@hg.openjdk.java.net> Changeset: c73934e09f00 Author: xdono Date: 2009-06-18 13:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/c73934e09f00 Added tag jdk7-b61 for changeset e906b16a12a9 ! .hgtags From john.coomes at sun.com Thu Jun 18 21:36:56 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Jun 2009 04:36:56 +0000 Subject: hg: jdk7/hotspot-comp/jaxp: Added tag jdk7-b61 for changeset f1ac756616ea Message-ID: <20090619043658.CB895EA81@hg.openjdk.java.net> Changeset: db1d07f881a1 Author: xdono Date: 2009-06-18 13:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/db1d07f881a1 Added tag jdk7-b61 for changeset f1ac756616ea ! .hgtags From john.coomes at sun.com Thu Jun 18 21:41:53 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Jun 2009 04:41:53 +0000 Subject: hg: jdk7/hotspot-comp/jaxws: Added tag jdk7-b61 for changeset aeabf802f2a1 Message-ID: <20090619044156.0EDA3EA86@hg.openjdk.java.net> Changeset: 55681156ec1a Author: xdono Date: 2009-06-18 13:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/55681156ec1a Added tag jdk7-b61 for changeset aeabf802f2a1 ! .hgtags From john.coomes at sun.com Thu Jun 18 21:46:28 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Jun 2009 04:46:28 +0000 Subject: hg: jdk7/hotspot-comp/jdk: Added tag jdk7-b61 for changeset f72c0dc047b9 Message-ID: <20090619044655.D2F4FEA8B@hg.openjdk.java.net> Changeset: 03f2ac812821 Author: xdono Date: 2009-06-18 13:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/03f2ac812821 Added tag jdk7-b61 for changeset f72c0dc047b9 ! .hgtags From john.coomes at sun.com Thu Jun 18 21:59:53 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Jun 2009 04:59:53 +0000 Subject: hg: jdk7/hotspot-comp/langtools: Added tag jdk7-b61 for changeset 522520757dd3 Message-ID: <20090619045956.2F313EA90@hg.openjdk.java.net> Changeset: 950d50e13a9e Author: xdono Date: 2009-06-18 13:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/950d50e13a9e Added tag jdk7-b61 for changeset 522520757dd3 ! .hgtags From Vladimir.Kozlov at Sun.COM Tue Jun 23 09:55:25 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Tue, 23 Jun 2009 09:55:25 -0700 Subject: Request for reviews .03 (L): 5057225: Remove useless I2L conversions In-Reply-To: <4A379334.1050106@Sun.COM> References: <1242159760.15714.5.camel@macbook> <1242213534.15714.24.camel@macbook> <1242302492.1482.5.camel@macbook> <1242662497.29179.35.camel@macbook> <4A3023D3.6040604@Sun.COM> <4A303783.4070700@sun.com> <4A314A6D.8010305@Sun.COM> <4A379334.1050106@Sun.COM> Message-ID: <4A4108FD.90308@sun.com> Christian, Changes look good. Thanks, Vladimir Christian Thalinger wrote: > Christian Thalinger wrote: >> Vladimir Kozlov wrote: >>> Christian, >>> >>> On x86 (32-,64-bit) if an arithmetic instruction is used it will kill >>> flags. >>> You have to add "effect(KILL cr)" when you use and/xor. > > ...and SAR. I hope I got all cases: > > http://cr.openjdk.java.net/~twisti/5057225/webrev.04/ > > -- Christian From Vladimir.Kozlov at Sun.COM Tue Jun 23 16:46:35 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Tue, 23 Jun 2009 16:46:35 -0700 Subject: Request for reviews (L): 6840775: Multiple JVM crashes seen with 1.6.0_10 through early access of 1.6.0_14 Message-ID: <4A41695B.9070801@sun.com> http://cr.openjdk.java.net/~kvn/6840775/webrev.01 Fixed 6840775: Multiple JVM crashes seen with 1.6.0_10 through early access of 1.6.0_14 Problem: There is no live oop value (only raw) across the call to slow_arraycopy() corresponding to new array allocation followed by arraycopy. The original CheckCastPP is moved after the call and the new CheckCastPP lives only until the call. As result the reference to allocated array in copyOf() intrinsic is not put into OopMap and we get wrong reference after the call when GC happens on the exit from the call to slow_arraycopy(). Solution: Replace raw memory edge in the original CheckCastPP with new CheckCastPP to have a live oop across safepoints. Also: - don't disconnect the original InitializeNode; - use a secondary InitializeNode as raw memory barrier only on zero copy length path since other paths have stub or runtime calls as raw memory barriers; - remove incorrect stack restore in generate_slow_arraycopy; - separate code for arrays and instances in inline_native_clone; - add assert in SharedRuntime::slow_arraycopy_C() to verify that no GC happened during copy_array() call; - add assert to check for possible live raw values at safepoint which are oops (there are CheckCastPP for the raw value); - fix SA to display an object with bad oop fields; - fix typo in optimized.make. Reviewed by: Fix verified (y/n): y, bug's test Other testing: JPRT, CTW From Vladimir.Kozlov at Sun.COM Tue Jun 23 17:26:47 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Tue, 23 Jun 2009 17:26:47 -0700 Subject: Request for review (M): 6837094: False positive for "meet not symmetric" failure In-Reply-To: <4149a0430906180754l5ef2eef1gd92793440a5b1eb4@mail.gmail.com> References: <4149a0430906180754l5ef2eef1gd92793440a5b1eb4@mail.gmail.com> Message-ID: <4A4172C7.2060507@sun.com> Looks good. I will go with push. Thanks, Vladimir Chuck Rasbold wrote: > http://cr.openjdk.java.net/~rasbold/6837094/webrev.00 > > > Fixed 6837094: False positive for "meet not symmetric" failure > > Have the meet not symmetric check recursively do the interface-vs-oop > check on array subtypes. > From vladimir.kozlov at sun.com Tue Jun 23 22:20:55 2009 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Wed, 24 Jun 2009 05:20:55 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6837094: False positive for "meet not symmetric" failure Message-ID: <20090624052057.8CC60EF2A@hg.openjdk.java.net> Changeset: 915cc9c5ebc6 Author: kvn Date: 2009-06-23 17:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/915cc9c5ebc6 6837094: False positive for "meet not symmetric" failure Summary: Have the meet not symmetric check recursively do the interface-vs-oop check on array subtypes. Reviewed-by: jrose Contributed-by: rasbold at google.com ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp + test/compiler/6837094/Test.java From Christian.Thalinger at Sun.COM Wed Jun 24 03:04:48 2009 From: Christian.Thalinger at Sun.COM (Christian.Thalinger at Sun.COM) Date: Wed, 24 Jun 2009 10:04:48 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 2 new changesets Message-ID: <20090624100452.133B5EF41@hg.openjdk.java.net> Changeset: d1fe2c2fbdac Author: twisti Date: 2009-06-17 09:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/d1fe2c2fbdac 6851829: solaris build fails with 5.8 compilers Summary: Solaris builds with the CC 5.8 compilers (used for jdk6 update builds) fail while compiling adlc. Reviewed-by: never ! make/solaris/makefiles/adlc.make Changeset: e306d7c7222c Author: twisti Date: 2009-06-24 02:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/e306d7c7222c Merge From Vladimir.Kozlov at Sun.COM Wed Jun 24 10:26:01 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Wed, 24 Jun 2009 10:26:01 -0700 Subject: Request for reviews (XS): 6841800: Incorrect boundary values behavior for option -XX:MaxLabelRootDepth=0-6 leads to jvm crash Message-ID: <4A4261A9.30905@sun.com> http://cr.openjdk.java.net/~kvn/6841800/webrev.00 Fixed 6841800: Incorrect boundary values behavior for option -XX:MaxLabelRootDepth=0-6 leads to jvm crash Problem: MaxLabelRootDepth value less then 10 is invalid since some required stubs will not be compiled. Solution: Assert if MaxLabelRootDepth is too small. In product version set it to 100 if it < 100. Reviewed by: Fix verified (y/n): y, bug's test Other testing: JPRT From Thomas.Rodriguez at Sun.COM Wed Jun 24 11:48:45 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 24 Jun 2009 11:48:45 -0700 Subject: Request for reviews (XS): 6841800: Incorrect boundary values behavior for option -XX:MaxLabelRootDepth=0-6 leads to jvm crash In-Reply-To: <4A4261A9.30905@sun.com> References: <4A4261A9.30905@sun.com> Message-ID: <158DAA78-51A7-46AD-9DC3-284139767BCE@sun.com> Looks good. tom On Jun 24, 2009, at 10:26 AM, Vladimir Kozlov wrote: > > http://cr.openjdk.java.net/~kvn/6841800/webrev.00 > > Fixed 6841800: Incorrect boundary values behavior for option - > XX:MaxLabelRootDepth=0-6 leads to jvm crash > > Problem: > MaxLabelRootDepth value less then 10 is invalid since > some required stubs will not be compiled. > > Solution: > Assert if MaxLabelRootDepth is too small. > In product version set it to 100 if it < 100. > > Reviewed by: > > Fix verified (y/n): y, bug's test > > Other testing: > JPRT > From Vladimir.Kozlov at Sun.COM Wed Jun 24 11:54:18 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Wed, 24 Jun 2009 11:54:18 -0700 Subject: Request for reviews (XS): 6841800: Incorrect boundary values behavior for option -XX:MaxLabelRootDepth=0-6 leads to jvm crash In-Reply-To: <158DAA78-51A7-46AD-9DC3-284139767BCE@sun.com> References: <4A4261A9.30905@sun.com> <158DAA78-51A7-46AD-9DC3-284139767BCE@sun.com> Message-ID: <4A42765A.8080801@sun.com> Thank you, Tom Vladimir Tom Rodriguez wrote: > Looks good. > > tom > > On Jun 24, 2009, at 10:26 AM, Vladimir Kozlov wrote: > >> >> http://cr.openjdk.java.net/~kvn/6841800/webrev.00 >> >> Fixed 6841800: Incorrect boundary values behavior for option >> -XX:MaxLabelRootDepth=0-6 leads to jvm crash >> >> Problem: >> MaxLabelRootDepth value less then 10 is invalid since >> some required stubs will not be compiled. >> >> Solution: >> Assert if MaxLabelRootDepth is too small. >> In product version set it to 100 if it < 100. >> >> Reviewed by: >> >> Fix verified (y/n): y, bug's test >> >> Other testing: >> JPRT >> > From vladimir.kozlov at sun.com Wed Jun 24 15:45:21 2009 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Wed, 24 Jun 2009 22:45:21 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6841800: Incorrect boundary values behavior for option -XX:MaxLabelRootDepth=0-6 leads to jvm crash Message-ID: <20090624224523.7DF4DEFE9@hg.openjdk.java.net> Changeset: 14367225a853 Author: kvn Date: 2009-06-24 12:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/14367225a853 6841800: Incorrect boundary values behavior for option -XX:MaxLabelRootDepth=0-6 leads to jvm crash Summary: MaxLabelRootDepth value less then 10 is invalid. Reviewed-by: never ! src/share/vm/opto/matcher.cpp From john.coomes at sun.com Thu Jun 25 21:49:05 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 26 Jun 2009 04:49:05 +0000 Subject: hg: jdk7/hotspot-comp: 6 new changesets Message-ID: <20090626044905.53F07E20D@hg.openjdk.java.net> Changeset: 54d14906940b Author: jjg Date: 2009-05-20 14:02 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/54d14906940b 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Defs-internal.gmk Changeset: 2734c0deab69 Author: tbell Date: 2009-06-11 21:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/2734c0deab69 Merge Changeset: e84b527d8be8 Author: tbell Date: 2009-06-21 23:49 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/e84b527d8be8 Merge Changeset: 60b818e5e4f9 Author: andrew Date: 2009-06-17 20:53 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/60b818e5e4f9 6851515: awt_p.h incorporates a chunk of the XRender header Summary: Use XRender header directly rather than copying chunks locally Reviewed-by: anthony, ohair ! README-builds.html Changeset: c7ed15ab92ce Author: yan Date: 2009-06-23 23:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/c7ed15ab92ce Merge Changeset: 57f7e028c7ad Author: xdono Date: 2009-06-25 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/rev/57f7e028c7ad Added tag jdk7-b62 for changeset c7ed15ab92ce ! .hgtags From john.coomes at sun.com Thu Jun 25 21:53:49 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 26 Jun 2009 04:53:49 +0000 Subject: hg: jdk7/hotspot-comp/corba: 4 new changesets Message-ID: <20090626045353.A2F95E212@hg.openjdk.java.net> Changeset: 2752d8bd4142 Author: jjg Date: 2009-05-20 13:41 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/2752d8bd4142 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Makefile Changeset: 23f2c435056b Author: tbell Date: 2009-06-11 21:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/23f2c435056b Merge Changeset: 65b66117dbd7 Author: tbell Date: 2009-06-21 23:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/65b66117dbd7 Merge Changeset: d20e45cd539f Author: xdono Date: 2009-06-25 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/corba/rev/d20e45cd539f Added tag jdk7-b62 for changeset 65b66117dbd7 ! .hgtags From john.coomes at sun.com Thu Jun 25 22:05:43 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 26 Jun 2009 05:05:43 +0000 Subject: hg: jdk7/hotspot-comp/jaxp: 4 new changesets Message-ID: <20090626050549.DAA9BE217@hg.openjdk.java.net> Changeset: bdaf6acaf6e3 Author: jjg Date: 2009-05-20 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/bdaf6acaf6e3 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Makefile ! make/build.properties ! make/build.xml Changeset: 97344798aaf7 Author: tbell Date: 2009-06-11 21:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/97344798aaf7 Merge ! make/Makefile ! make/build.properties ! make/build.xml Changeset: a97dd57a6260 Author: tbell Date: 2009-06-21 23:51 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/a97dd57a6260 Merge Changeset: ae449e9c04c1 Author: xdono Date: 2009-06-25 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxp/rev/ae449e9c04c1 Added tag jdk7-b62 for changeset a97dd57a6260 ! .hgtags From john.coomes at sun.com Thu Jun 25 22:10:31 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 26 Jun 2009 05:10:31 +0000 Subject: hg: jdk7/hotspot-comp/jaxws: 4 new changesets Message-ID: <20090626051037.C1276E221@hg.openjdk.java.net> Changeset: 605e1cdeba48 Author: jjg Date: 2009-05-20 13:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/605e1cdeba48 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Makefile ! make/build.properties ! make/build.xml Changeset: 2ec98e99e4ea Author: tbell Date: 2009-06-11 21:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/2ec98e99e4ea Merge ! make/Makefile ! make/build.properties ! make/build.xml Changeset: 75c801c13ea1 Author: tbell Date: 2009-06-21 23:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/75c801c13ea1 Merge Changeset: b8a6e883c0a6 Author: xdono Date: 2009-06-25 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jaxws/rev/b8a6e883c0a6 Added tag jdk7-b62 for changeset 75c801c13ea1 ! .hgtags From john.coomes at sun.com Thu Jun 25 22:16:29 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 26 Jun 2009 05:16:29 +0000 Subject: hg: jdk7/hotspot-comp/jdk: 47 new changesets Message-ID: <20090626052621.17607E247@hg.openjdk.java.net> Changeset: 842fb12a21d7 Author: sherman Date: 2009-05-19 15:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/842fb12a21d7 6831794: charset EUC_TW is 12.6% of the total size of charsets.jar 6229811: Several codepoints in EUC_TW failed in roundtrip conversion Summary: Re-write EUC_TW charset to address the size and roundtrip issue. Reviewed-by: alanb ! make/java/nio/Makefile ! make/sun/Makefile ! make/sun/nio/FILES_java.gmk ! make/sun/nio/Makefile ! make/tools/CharsetMapping/Makefile ! make/tools/src/build/tools/charsetmapping/CharsetMapping.java ! make/tools/src/build/tools/charsetmapping/GenerateMapping.java ! make/tools/src/build/tools/charsetmapping/GenerateSBCS.java ! src/share/classes/sun/io/ByteToCharEUC_TW.java ! src/share/classes/sun/io/CharToByteEUC_TW.java ! src/share/classes/sun/nio/cs/ext/EUC_TW.java ! src/share/classes/sun/nio/cs/ext/ISO2022.java ! src/share/classes/sun/nio/cs/ext/ISO2022_CN.java ! src/solaris/classes/sun/awt/motif/X11CNS11643.java ! test/sun/nio/cs/TestISO2022CNDecoder.java Changeset: 72e4312ea1e0 Author: sherman Date: 2009-05-19 16:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/72e4312ea1e0 6843079: Putback for the new EUC_TW is not complete Summary: Putback the files missed in last putback Reviewed-by: alanb + make/tools/CharsetMapping/euc_tw.map + make/tools/src/build/tools/charsetmapping/GenerateEUC_TW.java + make/tools/src/build/tools/charsetmapping/Main.java + test/sun/nio/cs/EUC_TW_OLD.java + test/sun/nio/cs/TestEUC_TW.java + test/sun/nio/cs/TestX11CNS.java + test/sun/nio/cs/X11CNS11643.java + test/sun/nio/cs/X11CNS11643P1.java + test/sun/nio/cs/X11CNS11643P2.java + test/sun/nio/cs/X11CNS11643P3.java Changeset: 49478a651a28 Author: sherman Date: 2009-05-19 16:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/49478a651a28 6728376: Wrong error handling in Java_java_util_zip_Deflater_deflateBytes leads to size 0 if compress fails 6735255: ZipFile.close() does not close ZipFileInputStreams, contrary to the API document Summary: Throws OOM when malloc failed. Closes all outstanding streams when closing Reviewed-by: alanb ! src/share/classes/java/util/zip/ZipFile.java ! src/share/native/java/util/zip/Deflater.c ! src/share/native/java/util/zip/Inflater.c Changeset: 057cc7d16812 Author: sherman Date: 2009-05-19 16:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/057cc7d16812 Merge Changeset: 02b02a886b9b Author: weijun Date: 2009-05-20 10:11 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/02b02a886b9b 6832016: {DigestMD5Base,Des3DkCrypto}.setParityBit should use Integer.bitCount Reviewed-by: weijun Contributed-by: Christian Thalinger ! src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java ! src/share/classes/sun/security/krb5/internal/crypto/dk/Des3DkCrypto.java Changeset: 4d607dc5cb22 Author: weijun Date: 2009-05-20 10:12 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/4d607dc5cb22 6682516: SPNEGO_HTTP_AUTH/WWW_KRB and SPNEGO_HTTP_AUTH/WWW_SPNEGO failed on all non-windows platforms Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/PrincipalName.java + test/sun/security/krb5/canonicalize/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/sun/security/krb5/canonicalize/Test.java Changeset: eb46247f6c53 Author: weijun Date: 2009-05-20 10:12 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/eb46247f6c53 6832353: Krb5LoginModule: use the KRB5CCNAME when searching for Kerberos ticket cache Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java Changeset: 1bc5be8665cc Author: jjg Date: 2009-05-20 13:55 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/1bc5be8665cc 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/common/shared/Defs-control.gmk ! make/common/shared/Defs-java.gmk ! make/javax/swing/beaninfo/SwingBeans.gmk Changeset: 914c33c7de3e Author: sherman Date: 2009-05-21 23:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/914c33c7de3e 6843578: Re-implement IBM doublebyte charsets 6639450: IBM949C encoder modifies state of IBM949 encoder 6569191: Cp943 io converter returns U+0000 and U+FFFD for unconvertable character 6577466: Character encoder IBM970 throws a BufferOverflowException 5065777: CharsetEncoder canEncode() methods often incorrectly return false Summary: Re-write 11 IBM doublebyte charsets. Thanks Ulf.Zibis for the codereview! Reviewed-by: martin ! make/sun/nio/FILES_java.gmk ! make/sun/nio/Makefile + make/tools/CharsetMapping/DoubleByte-X.java + make/tools/CharsetMapping/IBM1381.c2b + make/tools/CharsetMapping/IBM1381.map + make/tools/CharsetMapping/IBM1383.c2b + make/tools/CharsetMapping/IBM1383.map + make/tools/CharsetMapping/IBM1383.nr + make/tools/CharsetMapping/IBM930.c2b + make/tools/CharsetMapping/IBM930.map + make/tools/CharsetMapping/IBM930.nr + make/tools/CharsetMapping/IBM933.c2b + make/tools/CharsetMapping/IBM933.map + make/tools/CharsetMapping/IBM935.c2b + make/tools/CharsetMapping/IBM935.map + make/tools/CharsetMapping/IBM935.nr + make/tools/CharsetMapping/IBM937.c2b + make/tools/CharsetMapping/IBM937.map + make/tools/CharsetMapping/IBM937.nr + make/tools/CharsetMapping/IBM939.c2b + make/tools/CharsetMapping/IBM939.map + make/tools/CharsetMapping/IBM939.nr + make/tools/CharsetMapping/IBM942.c2b + make/tools/CharsetMapping/IBM942.map + make/tools/CharsetMapping/IBM943.map + make/tools/CharsetMapping/IBM943.nr + make/tools/CharsetMapping/IBM948.c2b + make/tools/CharsetMapping/IBM948.map + make/tools/CharsetMapping/IBM949.map + make/tools/CharsetMapping/IBM950.c2b + make/tools/CharsetMapping/IBM950.map + make/tools/CharsetMapping/IBM970.c2b + make/tools/CharsetMapping/IBM970.map + make/tools/CharsetMapping/dbcs + make/tools/src/build/tools/charsetmapping/GenerateDBCS.java ! make/tools/src/build/tools/charsetmapping/Main.java ! src/share/classes/sun/io/ByteToCharCp1381.java ! src/share/classes/sun/io/ByteToCharCp1383.java ! src/share/classes/sun/io/ByteToCharCp834.java ! src/share/classes/sun/io/ByteToCharCp930.java ! src/share/classes/sun/io/ByteToCharCp933.java ! src/share/classes/sun/io/ByteToCharCp935.java ! src/share/classes/sun/io/ByteToCharCp937.java ! src/share/classes/sun/io/ByteToCharCp939.java ! src/share/classes/sun/io/ByteToCharCp942.java ! src/share/classes/sun/io/ByteToCharCp942C.java ! src/share/classes/sun/io/ByteToCharCp943.java ! src/share/classes/sun/io/ByteToCharCp943C.java ! src/share/classes/sun/io/ByteToCharCp948.java ! src/share/classes/sun/io/ByteToCharCp949.java ! src/share/classes/sun/io/ByteToCharCp949C.java ! src/share/classes/sun/io/ByteToCharCp950.java ! src/share/classes/sun/io/ByteToCharCp970.java ! src/share/classes/sun/io/ByteToCharDBCS_ASCII.java ! src/share/classes/sun/io/ByteToCharDBCS_EBCDIC.java + src/share/classes/sun/io/ByteToCharEUC2.java ! src/share/classes/sun/io/CharToByteCp1381.java ! src/share/classes/sun/io/CharToByteCp1383.java ! src/share/classes/sun/io/CharToByteCp834.java ! src/share/classes/sun/io/CharToByteCp930.java ! src/share/classes/sun/io/CharToByteCp933.java ! src/share/classes/sun/io/CharToByteCp935.java ! src/share/classes/sun/io/CharToByteCp937.java ! src/share/classes/sun/io/CharToByteCp939.java ! src/share/classes/sun/io/CharToByteCp942.java ! src/share/classes/sun/io/CharToByteCp942C.java ! src/share/classes/sun/io/CharToByteCp943.java ! src/share/classes/sun/io/CharToByteCp943C.java ! src/share/classes/sun/io/CharToByteCp948.java ! src/share/classes/sun/io/CharToByteCp949.java ! src/share/classes/sun/io/CharToByteCp949C.java ! src/share/classes/sun/io/CharToByteCp950.java ! src/share/classes/sun/io/CharToByteCp970.java ! src/share/classes/sun/io/CharToByteDBCS_ASCII.java ! src/share/classes/sun/io/CharToByteDBCS_EBCDIC.java - src/share/classes/sun/nio/cs/ext/DBCSDecoderMapping.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Decoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Encoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Decoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Encoder.java - src/share/classes/sun/nio/cs/ext/DBCS_ONLY_IBM_EBCDIC_Decoder.java + src/share/classes/sun/nio/cs/ext/DoubleByte.java - src/share/classes/sun/nio/cs/ext/IBM1381.java - src/share/classes/sun/nio/cs/ext/IBM1383.java ! src/share/classes/sun/nio/cs/ext/IBM834.java - src/share/classes/sun/nio/cs/ext/IBM930.java - src/share/classes/sun/nio/cs/ext/IBM933.java - src/share/classes/sun/nio/cs/ext/IBM935.java - src/share/classes/sun/nio/cs/ext/IBM937.java - src/share/classes/sun/nio/cs/ext/IBM939.java - src/share/classes/sun/nio/cs/ext/IBM942.java ! src/share/classes/sun/nio/cs/ext/IBM942C.java - src/share/classes/sun/nio/cs/ext/IBM943.java ! src/share/classes/sun/nio/cs/ext/IBM943C.java - src/share/classes/sun/nio/cs/ext/IBM948.java - src/share/classes/sun/nio/cs/ext/IBM949.java ! src/share/classes/sun/nio/cs/ext/IBM949C.java - src/share/classes/sun/nio/cs/ext/IBM950.java - src/share/classes/sun/nio/cs/ext/IBM970.java - src/share/classes/sun/nio/cs/ext/SimpleEUCDecoder.java ! test/sun/nio/cs/FindCanEncodeBugs.java ! test/sun/nio/cs/FindEncoderBugs.java + test/sun/nio/cs/OLD/DBCSDecoderMapping.java + test/sun/nio/cs/OLD/DBCS_IBM_ASCII_Decoder.java + test/sun/nio/cs/OLD/DBCS_IBM_ASCII_Encoder.java + test/sun/nio/cs/OLD/DBCS_IBM_EBCDIC_Decoder.java + test/sun/nio/cs/OLD/DBCS_IBM_EBCDIC_Encoder.java + test/sun/nio/cs/OLD/DBCS_ONLY_IBM_EBCDIC_Decoder.java + test/sun/nio/cs/OLD/IBM1381_OLD.java + test/sun/nio/cs/OLD/IBM1383_OLD.java + test/sun/nio/cs/OLD/IBM930_OLD.java + test/sun/nio/cs/OLD/IBM933_OLD.java + test/sun/nio/cs/OLD/IBM935_OLD.java + test/sun/nio/cs/OLD/IBM937_OLD.java + test/sun/nio/cs/OLD/IBM939_OLD.java + test/sun/nio/cs/OLD/IBM942C_OLD.java + test/sun/nio/cs/OLD/IBM942_OLD.java + test/sun/nio/cs/OLD/IBM943C_OLD.java + test/sun/nio/cs/OLD/IBM943_OLD.java + test/sun/nio/cs/OLD/IBM948_OLD.java + test/sun/nio/cs/OLD/IBM949C_OLD.java + test/sun/nio/cs/OLD/IBM949_OLD.java + test/sun/nio/cs/OLD/IBM950_OLD.java + test/sun/nio/cs/OLD/IBM970_OLD.java + test/sun/nio/cs/OLD/SimpleEUCDecoder.java + test/sun/nio/cs/OLD/TestIBMDB.java ! test/sun/nio/cs/TestEUC_TW.java ! test/sun/nio/cs/TestIBMBugs.java Changeset: 8d2efec31d78 Author: xlu Date: 2009-05-24 16:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/8d2efec31d78 6622432: RFE: Performance improvements to java.math.BigDecimal Reviewed-by: darcy ! src/share/classes/java/math/BigDecimal.java ! src/share/classes/java/math/BigInteger.java ! src/share/classes/java/math/BitSieve.java ! src/share/classes/java/math/MathContext.java ! src/share/classes/java/math/MutableBigInteger.java ! src/share/classes/java/math/SignedMutableBigInteger.java ! test/java/math/BigDecimal/AddTests.java ! test/java/math/BigDecimal/DivideTests.java Changeset: 3994c5c669cb Author: xlu Date: 2009-05-24 16:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/3994c5c669cb 6806261: BigDecimal.longValueExact() method throws NullPointerException Summary: add various tests to test the change to 6622432 Reviewed-by: darcy + test/java/math/BigDecimal/EqualsTests.java + test/java/math/BigDecimal/LongValueExactTests.java + test/java/math/BigDecimal/MultiplyTests.java + test/java/math/BigDecimal/PrecisionTests.java + test/java/math/BigInteger/CompareToTests.java Changeset: 206d73d299d4 Author: jccollet Date: 2009-05-25 22:27 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/206d73d299d4 6349566: java.net.CookieManager doesn't set default domain Summary: Enforce default domain in CookieManager Reviewed-by: michaelm ! src/share/classes/java/net/CookieManager.java ! test/java/net/CookieHandler/CookieManagerTest.java Changeset: dc3865883a5a Author: weijun Date: 2009-05-26 10:12 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/dc3865883a5a 6844887: NPE in TextCallbackHandler Reviewed-by: xuelei ! src/share/classes/com/sun/security/auth/callback/TextCallbackHandler.java + test/com/sun/security/auth/callback/TextCallbackHandler/NPE.java Changeset: d93b7df1e260 Author: xuelei Date: 2009-05-26 16:19 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/d93b7df1e260 6822460: support self-issued certificate Summary: checking self-issued certificate during certification path building Reviewed-by: mullan, weijun ! src/share/classes/sun/security/validator/PKIXValidator.java ! src/share/classes/sun/security/validator/SimpleValidator.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/SelfIssuedCert.java Changeset: c3c5cc0f2a3e Author: xuelei Date: 2009-05-26 16:43 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/c3c5cc0f2a3e 6720721: CRL check with circular depency support needed Summary: checking AKID of certificates and CRLs Reviewed-by: mullan, weijun ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java + test/java/security/cert/CertPathValidator/indirectCRL/CircularCRLOneLevel.java + test/java/security/cert/CertPathValidator/indirectCRL/CircularCRLOneLevelRevoked.java + test/java/security/cert/CertPathValidator/indirectCRL/CircularCRLTwoLevel.java + test/java/security/cert/CertPathValidator/indirectCRL/CircularCRLTwoLevelRevoked.java + test/java/security/cert/CertPathValidator/indirectCRL/README + test/java/security/cert/CertPathValidator/indirectCRL/generate.sh + test/java/security/cert/CertPathValidator/indirectCRL/openssl.cnf Changeset: 045aeb76b0ff Author: jccollet Date: 2009-05-26 16:03 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/045aeb76b0ff 6726695: HttpURLConnection shoul support 'Expect: 100-contimue' headers for PUT Summary: Added code triggered when 'Expect: 100-continue' header has been added Reviewed-by: chegar ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/http/KeepAliveStreamCleaner.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/http/HttpClient/B6726695.java Changeset: 25db260cb810 Author: xuelei Date: 2009-05-27 17:48 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/25db260cb810 6845286: Add regression test for name constraints Summary: create regression test cases on name constraints Reviewed-by: weijun + test/java/security/cert/CertPathValidator/nameConstraints/NameConstraintsWithRID.java + test/java/security/cert/CertPathValidator/nameConstraints/NameConstraintsWithUnexpectedRID.java + test/java/security/cert/CertPathValidator/nameConstraints/NameConstraintsWithoutRID.java + test/java/security/cert/CertPathValidator/nameConstraints/generate.sh + test/java/security/cert/CertPathValidator/nameConstraints/openssl.cnf Changeset: 7772d77bd7c2 Author: mchung Date: 2009-05-26 17:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/7772d77bd7c2 6829636: test/java/util/logging/LoggingDeadlock2.java is flaky Summary: remove @ignore Reviewed-by: swamyv ! src/share/classes/java/net/URLConnection.java ! test/Makefile ! test/java/util/logging/LoggingDeadlock2.java Changeset: 2aeaffb6c897 Author: mchung Date: 2009-05-26 17:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/2aeaffb6c897 6798842: TEST_BUG: ThreadStackTrace.java fails intermittently with unexpected thread status. Summary: remove @ignore Reviewed-by: swamyv ! test/java/lang/management/ThreadMXBean/ThreadStackTrace.java + test/java/lang/management/ThreadMXBean/Utils.java Changeset: fba2425da9b1 Author: mchung Date: 2009-05-26 18:02 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/fba2425da9b1 5080203: TEST_BUG: ThreadStateTest fails intermittently. Summary: Retry a few times to check thread status before reporting failure Reviewed-by: swamyv ! test/java/lang/management/ThreadMXBean/ThreadStateTest.java Changeset: a7a38e606a7a Author: mchung Date: 2009-05-26 18:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/a7a38e606a7a 6512493: TEST_BUG: unexpected LockInfo failure in LockedSynchronizers.java Summary: Retry a few times to check thread status before reporting failure Reviewed-by: swamyv ! test/java/lang/management/ThreadMXBean/LockingThread.java ! test/java/lang/management/ThreadMXBean/MonitorDeadlock.java Changeset: fb97068670e6 Author: mchung Date: 2009-05-26 18:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/fb97068670e6 6535104: TEST_BUG: FindDeadlocks.java fails intermittently. Summary: Retry a few times to check thread status before reporting failure Reviewed-by: swamyv ! test/java/lang/management/ThreadMXBean/SynchronizerDeadlock.java ! test/java/lang/management/ThreadMXBean/SynchronizerLockingThread.java Changeset: 742b55c45a70 Author: mchung Date: 2009-05-27 13:02 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/742b55c45a70 Merge Changeset: 59bbb9f3f430 Author: kamg Date: 2009-05-27 13:20 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/59bbb9f3f430 6838211: jdk docs creation broken for tracing docs Summary: Fix javadoc makefile macro Reviewed-by: ohair, jjg ! make/docs/Makefile Changeset: 8e77f61508cc Author: kamg Date: 2009-05-27 15:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/8e77f61508cc Merge Changeset: 928e0f1043e6 Author: chegar Date: 2009-05-29 15:51 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/928e0f1043e6 6807602: Increase MAX_BUFFER_LEN and MAX_HEAP_BUFFER_LEN on 64-bit Solaris and Linux Reviewed-by: alanb ! src/solaris/native/java/net/net_util_md.h Changeset: aece9096d5cd Author: jjg Date: 2009-05-29 16:27 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/aece9096d5cd 6838199: remove support for old javap Reviewed-by: ohair, mcimadamore ! make/common/Release.gmk ! make/common/internal/Defs-langtools.gmk ! make/launchers/Makefile Changeset: d26c268597ed Author: sherman Date: 2009-05-29 16:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/d26c268597ed 6808625: Incomplete code sample in Deflater javadoc Summary: added compresser.end() into example Reviewed-by: martin ! src/share/classes/java/util/zip/Deflater.java Changeset: 045743e0eb2d Author: xuelei Date: 2009-06-04 11:28 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/045743e0eb2d 6847459: Allow trust anchor self-issued intermediate version 1 and version 2 certificate Reviewed-by: weijun ! src/share/classes/sun/security/provider/certpath/ConstraintsChecker.java Changeset: 8f405b65ddac Author: weijun Date: 2009-06-09 14:17 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/8f405b65ddac 6578647: Undefined requesting URL in java.net.Authenticator.getPasswordAuthentication() Reviewed-by: chegar, valeriep ! src/share/classes/sun/net/www/protocol/http/AuthenticationHeader.java + src/share/classes/sun/net/www/protocol/http/HttpCallerInfo.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java ! src/share/classes/sun/net/www/protocol/http/NegotiateCallbackHandler.java ! src/share/classes/sun/net/www/protocol/http/NegotiatorImpl.java + src/share/classes/sun/security/jgss/GSSCaller.java ! src/share/classes/sun/security/jgss/GSSManagerImpl.java ! src/share/classes/sun/security/jgss/GSSUtil.java + src/share/classes/sun/security/jgss/HttpCaller.java ! src/share/classes/sun/security/jgss/LoginConfigImpl.java ! src/share/classes/sun/security/jgss/ProviderList.java ! src/share/classes/sun/security/jgss/krb5/InitialToken.java ! src/share/classes/sun/security/jgss/krb5/Krb5AcceptCredential.java ! src/share/classes/sun/security/jgss/krb5/Krb5Context.java ! src/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java ! src/share/classes/sun/security/jgss/krb5/Krb5MechFactory.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java ! src/share/classes/sun/security/jgss/spnego/SpNegoMechFactory.java ! src/share/classes/sun/security/jgss/wrapper/NativeGSSFactory.java ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! test/sun/security/jgss/DefaultGssConfig.java ! test/sun/security/jgss/GssNPE.java + test/sun/security/krb5/auto/HttpNegotiateServer.java ! test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/auto/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor Changeset: 4da7b972b391 Author: mullan Date: 2009-06-10 09:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/4da7b972b391 6845161: Bottleneck in Configuration.getConfiguration synchronized call Summary: Reduce scope of synchronized block Reviewed-by: weijun ! src/share/classes/javax/security/auth/login/Configuration.java Changeset: ffbcf1d1103c Author: xuelei Date: 2009-06-12 09:00 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/ffbcf1d1103c 6570344: Invalid RSA OID in sun.security.x509.AlgorithmId Summary: change RSA OID to "2.5.8.1.1" Reviewed-by: mullan ! src/share/classes/sun/security/x509/AlgorithmId.java Changeset: 328148f45b31 Author: tbell Date: 2009-06-11 21:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/328148f45b31 Merge ! make/docs/Makefile - src/share/classes/sun/nio/cs/ext/DBCSDecoderMapping.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Decoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Encoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Decoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Encoder.java - src/share/classes/sun/nio/cs/ext/DBCS_ONLY_IBM_EBCDIC_Decoder.java - src/share/classes/sun/nio/cs/ext/IBM1381.java - src/share/classes/sun/nio/cs/ext/IBM1383.java - src/share/classes/sun/nio/cs/ext/IBM930.java - src/share/classes/sun/nio/cs/ext/IBM933.java - src/share/classes/sun/nio/cs/ext/IBM935.java - src/share/classes/sun/nio/cs/ext/IBM937.java - src/share/classes/sun/nio/cs/ext/IBM939.java - src/share/classes/sun/nio/cs/ext/IBM942.java - src/share/classes/sun/nio/cs/ext/IBM943.java - src/share/classes/sun/nio/cs/ext/IBM948.java - src/share/classes/sun/nio/cs/ext/IBM949.java - src/share/classes/sun/nio/cs/ext/IBM950.java - src/share/classes/sun/nio/cs/ext/IBM970.java - src/share/classes/sun/nio/cs/ext/SimpleEUCDecoder.java ! test/Makefile Changeset: 74aefd0ab26d Author: martin Date: 2009-06-14 14:23 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/74aefd0ab26d 6850720: (process) Use clone(CLONE_VM), not fork, on Linux to avoid swap exhaustion Summary: Use clone(CLONE_VM) on Linux; Reluctantly implement execvpe. Reviewed-by: michaelm ! src/solaris/native/java/lang/UNIXProcess_md.c ! test/java/lang/ProcessBuilder/Basic.java + test/java/lang/ProcessBuilder/BigFork.java Changeset: d0de3e41426b Author: martin Date: 2009-06-14 14:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/d0de3e41426b 6511515: poor performance of LogRecord.inferCaller depending on java.lang.Throwable.getStackTraceElement Summary: Allow random access to stack trace elements; retrieve only needed ones Reviewed-by: swamyv Contributed-by: jeremymanson at google.com ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/Throwable.java ! src/share/classes/java/util/logging/LogRecord.java ! src/share/classes/sun/misc/JavaLangAccess.java Changeset: 5a5b56904855 Author: tbell Date: 2009-06-21 12:02 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/5a5b56904855 6853336: (process) disable or remove clone-exec feature (6850720) Summary: clone-exec feature (6850720) needs more work on 32-bit Linux Reviewed-by: alanb, michaelm Contributed-by: Martin Buchholz ! src/solaris/native/java/lang/UNIXProcess_md.c Changeset: 55a584478eac Author: tbell Date: 2009-06-21 23:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/55a584478eac Merge Changeset: 6f1f159aed75 Author: yan Date: 2009-06-03 17:41 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/6f1f159aed75 6839645: Swing application prints message in Control Panel if language is changed Summary: just remove debug printout from production builds; ignore multicharacter-generating keys Reviewed-by: uta ! src/windows/native/sun/windows/awt_Component.cpp Changeset: a3f970a8600b Author: anthony Date: 2009-06-04 15:18 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/a3f970a8600b 6832386: Fix JTreg test: java/awt/Graphics/DrawImageBG/SystemBgColorTest.java Summary: Removed unneeded System.exit(0) call. Reviewed-by: art, ohair, anthony Contributed-by: Omair Majid ! test/java/awt/Graphics/DrawImageBG/SystemBgColorTest.java Changeset: 7289003cd1c9 Author: dcherepanov Date: 2009-06-05 17:30 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/7289003cd1c9 6829180: Removing focused component from a window causes a JVM crash for JDK7b50+ on WinXP/Vista Summary: access pData on the toolkit thread Reviewed-by: art, anthony, naoto ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_InputMethod.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_Toolkit.h ! src/windows/native/sun/windows/awtmsg.h Changeset: 70654407b626 Author: dcherepanov Date: 2009-06-15 11:15 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/70654407b626 6847584: closed/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html fails Reviewed-by: anthony + test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html ! test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.java Changeset: 0e441c781cdc Author: yan Date: 2009-06-16 00:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/0e441c781cdc Merge - src/share/native/sun/java2d/pipe/RenderBuffer.c Changeset: 2a526ccd12e8 Author: andrew Date: 2009-06-17 21:13 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/2a526ccd12e8 6851515: awt_p.h incorporates a chunk of the XRender header Summary: Use XRender header directly rather than copying chunks locally Reviewed-by: anthony, ohair ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/awt/awt_p.h Changeset: 1bbbd0ef5d04 Author: peytoia Date: 2009-06-13 06:43 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/1bbbd0ef5d04 6850113: Bidi class needs to be updated to support Unicode 5.1 Reviewed-by: okutsu ! make/java/text/FILES_java.gmk ! make/sun/font/FILES_c.gmk ! make/sun/font/Makefile ! make/sun/font/mapfile-vers ! make/sun/font/mapfile-vers.openjdk ! src/share/classes/java/text/Bidi.java + src/share/classes/sun/text/bidi/BidiBase.java + src/share/classes/sun/text/bidi/BidiLine.java + src/share/classes/sun/text/bidi/BidiRun.java ! src/share/classes/sun/text/normalizer/UCharacter.java - src/share/native/sun/font/bidi/cmemory.h - src/share/native/sun/font/bidi/jbidi.c - src/share/native/sun/font/bidi/jbidi.h - src/share/native/sun/font/bidi/ubidi.c - src/share/native/sun/font/bidi/ubidi.h - src/share/native/sun/font/bidi/ubidiimp.h - src/share/native/sun/font/bidi/ubidiln.c - src/share/native/sun/font/bidi/uchardir.c - src/share/native/sun/font/bidi/uchardir.h - src/share/native/sun/font/bidi/utypes.h ! src/share/native/sun/font/layout/LETypes.h ! test/java/text/Bidi/BidiBug.java + test/java/text/Bidi/BidiConformance.java ! test/java/text/Bidi/BidiEmbeddingTest.java + test/java/text/Bidi/Bug6850113.java Changeset: 45316d7cc9dc Author: yan Date: 2009-06-17 23:27 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/45316d7cc9dc Merge - src/share/native/sun/font/bidi/cmemory.h - src/share/native/sun/font/bidi/jbidi.c - src/share/native/sun/font/bidi/jbidi.h - src/share/native/sun/font/bidi/ubidi.c - src/share/native/sun/font/bidi/ubidi.h - src/share/native/sun/font/bidi/ubidiimp.h - src/share/native/sun/font/bidi/ubidiln.c - src/share/native/sun/font/bidi/uchardir.c - src/share/native/sun/font/bidi/uchardir.h - src/share/native/sun/font/bidi/utypes.h Changeset: 12e11fab9a83 Author: yan Date: 2009-06-23 23:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/12e11fab9a83 Merge - src/share/native/sun/font/bidi/cmemory.h - src/share/native/sun/font/bidi/jbidi.c - src/share/native/sun/font/bidi/jbidi.h - src/share/native/sun/font/bidi/ubidi.c - src/share/native/sun/font/bidi/ubidi.h - src/share/native/sun/font/bidi/ubidiimp.h - src/share/native/sun/font/bidi/ubidiln.c - src/share/native/sun/font/bidi/uchardir.c - src/share/native/sun/font/bidi/uchardir.h - src/share/native/sun/font/bidi/utypes.h Changeset: 8905d218cd0d Author: xdono Date: 2009-06-25 12:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/jdk/rev/8905d218cd0d Added tag jdk7-b62 for changeset 12e11fab9a83 ! .hgtags From john.coomes at sun.com Thu Jun 25 22:43:37 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 26 Jun 2009 05:43:37 +0000 Subject: hg: jdk7/hotspot-comp/langtools: 15 new changesets Message-ID: <20090626054402.7769CE24D@hg.openjdk.java.net> Changeset: b5872f0790e7 Author: jjg Date: 2009-05-19 11:27 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/b5872f0790e7 6841422: classfile: add Type visitor Reviewed-by: mcimadamore Contributed-by: kevin.t.looney at sun.com ! src/share/classes/com/sun/tools/classfile/Type.java Changeset: f838537fb1ac Author: jjg Date: 2009-05-19 11:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/f838537fb1ac 6841420: classfile: add new methods to ConstantClassInfo Reviewed-by: mcimadamore Contributed-by: kevin.t.looney at sun.com ! src/share/classes/com/sun/tools/classfile/ConstantPool.java Changeset: fc634a593812 Author: jjg Date: 2009-05-19 11:43 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/fc634a593812 6841419: classfile: add constant pool iterator Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/ClassTranslator.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/ConstantPool.java Changeset: cd0630109de5 Author: jjg Date: 2009-05-19 11:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/cd0630109de5 6824493: experimental support for additional info for instructions Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/StackMapTable_attribute.java ! src/share/classes/com/sun/tools/javap/BasicWriter.java ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java + src/share/classes/com/sun/tools/javap/InstructionDetailWriter.java ! src/share/classes/com/sun/tools/javap/JavapTask.java + src/share/classes/com/sun/tools/javap/Messages.java ! src/share/classes/com/sun/tools/javap/Options.java + src/share/classes/com/sun/tools/javap/SourceWriter.java + src/share/classes/com/sun/tools/javap/StackMapWriter.java + src/share/classes/com/sun/tools/javap/TryBlockWriter.java ! src/share/classes/com/sun/tools/javap/resources/javap.properties + test/tools/javap/T6824493.java Changeset: 0c6cd88f72b9 Author: jjg Date: 2009-05-19 13:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/0c6cd88f72b9 6843013: missing files in fix for 6824493 Reviewed-by: darcy + src/share/classes/com/sun/tools/javap/LocalVariableTableWriter.java + src/share/classes/com/sun/tools/javap/LocalVariableTypeTableWriter.java Changeset: 4ce1c1400334 Author: jjg Date: 2009-05-19 15:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/4ce1c1400334 6832154: refactor Paths to be just a utility class for JavacFileManager Reviewed-by: darcy ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java Changeset: 79eb8795a1de Author: jjg Date: 2009-05-20 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/79eb8795a1de 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Makefile ! make/build.properties ! make/build.xml ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java Changeset: 44eaac2b4501 Author: jjg Date: 2009-05-20 19:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/44eaac2b4501 6843648: tools/javac/versions/check.sh is broken Reviewed-by: darcy ! test/tools/javac/6341866/Anno.java ! test/tools/javac/6464451/BigFinally.java ! test/tools/javac/6464451/DeepNestedFinally.java ! test/tools/javac/6464451/ManyExitsInTry.java ! test/tools/javac/ClassLit.java ! test/tools/javac/T6557865.java ! test/tools/javac/foreach/T6682380.java ! test/tools/javac/processing/6348499/A.java ! test/tools/javac/processing/6414633/A.java ! test/tools/javac/processing/6430209/b6341534.java ! test/tools/javac/processing/T6439826.java ! test/tools/javac/stackmap/T4955930.sh ! test/tools/javac/versions/check.sh Changeset: d402db1005ad Author: mcimadamore Date: 2009-05-21 10:56 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/d402db1005ad 6722234: javac diagnostics need better integration with the type-system Summary: Added RichDiagnosticFormatter which provides better formatting capabilities for javac types/symbols Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java + src/share/classes/com/sun/tools/javac/util/ForwardingDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java + src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/6304921/T6304921.java ! test/tools/javac/6304921/T6304921.out ! test/tools/javac/6491592/T6491592.out + test/tools/javac/Diagnostics/6722234/T6722234a.java + test/tools/javac/Diagnostics/6722234/T6722234a_1.out + test/tools/javac/Diagnostics/6722234/T6722234a_2.out + test/tools/javac/Diagnostics/6722234/T6722234b.java + test/tools/javac/Diagnostics/6722234/T6722234b_1.out + test/tools/javac/Diagnostics/6722234/T6722234b_2.out + test/tools/javac/Diagnostics/6722234/T6722234c.java + test/tools/javac/Diagnostics/6722234/T6722234c.out + test/tools/javac/Diagnostics/6722234/T6722234d.java + test/tools/javac/Diagnostics/6722234/T6722234d_1.out + test/tools/javac/Diagnostics/6722234/T6722234d_2.out ! test/tools/javac/ExtendArray.java ! test/tools/javac/ExtendArray.out ! test/tools/javac/OverridePosition.java ! test/tools/javac/OverridePosition.out ! test/tools/javac/T4093617/T4093617.java ! test/tools/javac/T4093617/T4093617.out ! test/tools/javac/T5003235/T5003235c.java ! test/tools/javac/T5003235/T5003235c.out ! test/tools/javac/miranda/T4666866.java ! test/tools/javac/miranda/T4666866.out ! test/tools/javac/protectedAccess/ProtectedMemberAccess2.java ! test/tools/javac/protectedAccess/ProtectedMemberAccess3.java ! test/tools/javac/protectedAccess/ProtectedMemberAccess4.java Changeset: 84061bd68019 Author: darcy Date: 2009-05-27 22:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/84061bd68019 6843761: Update langtools tests to remove unncessary -source and -target options Reviewed-by: jjg ! test/com/sun/javadoc/testIndex/TestIndex.java ! test/com/sun/javadoc/testInterface/TestInterface.java ! test/com/sun/javadoc/testNavagation/TestNavagation.java ! test/com/sun/javadoc/testTagInheritence/TestTagInheritence.java ! test/tools/javac/5005368.java ! test/tools/javac/Ambig3.java ! test/tools/javac/ArrayCast.java ! test/tools/javac/BadCovar.java ! test/tools/javac/ClassLiterals/InitializeOuter.java ! test/tools/javac/ClassLiterals/InitializeTarget.java ! test/tools/javac/ClassToTypeParm.java ! test/tools/javac/Closure1.java ! test/tools/javac/Closure2.java ! test/tools/javac/Closure3.java ! test/tools/javac/Closure4.java ! test/tools/javac/Closure5.java ! test/tools/javac/CompoundBox.java ! test/tools/javac/ConditionalArgTypes_1.java ! test/tools/javac/ConditionalArgTypes_2.java ! test/tools/javac/DefiniteAssignment/DUAssert.java ! test/tools/javac/EarlyAssert.java ! test/tools/javac/Enum1.java ! test/tools/javac/GoodCovar.java ! test/tools/javac/HexFloatLiterals.java ! test/tools/javac/HexThree.java ! test/tools/javac/InterfaceAssert.java ! test/tools/javac/InvalidIntfCast.java ! test/tools/javac/NewGeneric.java ! test/tools/javac/ObjectMethodRefFromInterface.java ! test/tools/javac/PrivateLocalConstructor.java ! test/tools/javac/RawCrash.java ! test/tools/javac/SynthName2.java ! test/tools/javac/T5090006/compiler.sh ! test/tools/javac/T5092545.java ! test/tools/javac/T5105890.java ! test/tools/javac/annotations/default/A.java ! test/tools/javac/annotations/neg/AnnComma.java ! test/tools/javac/annotations/neg/ArrayLit.java ! test/tools/javac/annotations/neg/Constant.java ! test/tools/javac/annotations/neg/Cycle1.java ! test/tools/javac/annotations/neg/Cycle2.java ! test/tools/javac/annotations/neg/Cycle3.java ! test/tools/javac/annotations/neg/Dep.java ! test/tools/javac/annotations/neg/Dup.java ! test/tools/javac/annotations/neg/DupTarget.java ! test/tools/javac/annotations/neg/MemberOver.java ! test/tools/javac/annotations/neg/ObjectMembers.java ! test/tools/javac/annotations/neg/OverrideNo.java ! test/tools/javac/annotations/neg/Package.java ! test/tools/javac/annotations/neg/Recovery.java ! test/tools/javac/annotations/neg/Recovery1.java ! test/tools/javac/annotations/neg/Scope.java ! test/tools/javac/annotations/neg/Syntax1.java ! test/tools/javac/annotations/neg/WrongTarget.java ! test/tools/javac/annotations/neg/WrongTarget2.java ! test/tools/javac/annotations/neg/WrongValue.java ! test/tools/javac/annotations/neg/Z1.java ! test/tools/javac/annotations/neg/Z10.java ! test/tools/javac/annotations/neg/Z11.java ! test/tools/javac/annotations/neg/Z12.java ! test/tools/javac/annotations/neg/Z13.java ! test/tools/javac/annotations/neg/Z14.java ! test/tools/javac/annotations/neg/Z15.java ! test/tools/javac/annotations/neg/Z16.java ! test/tools/javac/annotations/neg/Z2.java ! test/tools/javac/annotations/neg/Z3.java ! test/tools/javac/annotations/neg/Z4.java ! test/tools/javac/annotations/neg/Z5.java ! test/tools/javac/annotations/neg/Z8.java ! test/tools/javac/annotations/neg/Z9.java ! test/tools/javac/annotations/pos/AnnoteElideBraces.java ! test/tools/javac/annotations/pos/ClassA.java ! test/tools/javac/annotations/pos/Dep.java ! test/tools/javac/annotations/pos/Enum1.java ! test/tools/javac/annotations/pos/Local.java ! test/tools/javac/annotations/pos/Members.java ! test/tools/javac/annotations/pos/NType.java ! test/tools/javac/annotations/pos/OverrideCheck.java ! test/tools/javac/annotations/pos/OverrideOK.java ! test/tools/javac/annotations/pos/Parameter.java ! test/tools/javac/annotations/pos/Primitives.java ! test/tools/javac/annotations/pos/RightTarget.java ! test/tools/javac/annotations/pos/Z1.java ! test/tools/javac/annotations/pos/Z2.java ! test/tools/javac/annotations/pos/Z3.java ! test/tools/javac/annotations/pos/Z4.java ! test/tools/javac/annotations/pos/package-info.java ! test/tools/javac/assert/Attach.java ! test/tools/javac/assert/DU1.java ! test/tools/javac/assert/DU2.java ! test/tools/javac/assert/Position.java ! test/tools/javac/boxing/BoxedForeach.java ! test/tools/javac/boxing/Boxing1.java ! test/tools/javac/boxing/Boxing2.java ! test/tools/javac/boxing/Boxing4.java ! test/tools/javac/boxing/BoxingCaching.java ! test/tools/javac/capture/Capture1.java ! test/tools/javac/capture/Capture2.java ! test/tools/javac/capture/Capture3.java ! test/tools/javac/capture/Capture5.java ! test/tools/javac/cast/BoxedArray.java ! test/tools/javac/enum/AbstractEmptyEnum.java ! test/tools/javac/enum/AbstractEnum1.java ! test/tools/javac/enum/DA1.java ! test/tools/javac/enum/DA2.java ! test/tools/javac/enum/DA3.java ! test/tools/javac/enum/Def.java ! test/tools/javac/enum/Enum1.java ! test/tools/javac/enum/Enum2.java ! test/tools/javac/enum/Enum3.java ! test/tools/javac/enum/EnumImplicitPrivateConstructor.java ! test/tools/javac/enum/EnumInit.java ! test/tools/javac/enum/EnumPrivateConstructor.java ! test/tools/javac/enum/EnumProtectedConstructor.java ! test/tools/javac/enum/EnumPublicConstructor.java ! test/tools/javac/enum/EnumSwitch1.java ! test/tools/javac/enum/EnumSwitch2.java ! test/tools/javac/enum/EnumSwitch3.java ! test/tools/javac/enum/EnumSwitch4.java ! test/tools/javac/enum/ExplicitlyAbstractEnum1.java ! test/tools/javac/enum/ExplicitlyAbstractEnum2.java ! test/tools/javac/enum/ExplicitlyFinalEnum1.java ! test/tools/javac/enum/ExplicitlyFinalEnum2.java ! test/tools/javac/enum/FauxEnum1.java ! test/tools/javac/enum/FauxEnum3.java ! test/tools/javac/enum/FauxSpecialEnum1.java ! test/tools/javac/enum/FauxSpecialEnum2.java ! test/tools/javac/enum/LocalEnum.java ! test/tools/javac/enum/NoFinal.java ! test/tools/javac/enum/NoFinal2.java ! test/tools/javac/enum/NoFinal3.java ! test/tools/javac/enum/NoFinal4.java ! test/tools/javac/enum/NoFinal5.java ! test/tools/javac/enum/OkFinal.java ! test/tools/javac/enum/SynthValues.java ! test/tools/javac/enum/T5075242.java ! test/tools/javac/enum/T5081785.java ! test/tools/javac/enum/TrailingComma.java ! test/tools/javac/enum/UserValue.java ! test/tools/javac/enum/ValueOf.java ! test/tools/javac/enum/enumSwitch/EnumSwitch.java ! test/tools/javac/foreach/Foreach.java ! test/tools/javac/foreach/GenericIterator.java ! test/tools/javac/foreach/IntersectIterator.java ! test/tools/javac/foreach/ListOfListTest.java ! test/tools/javac/foreach/SpecIterable.java ! test/tools/javac/foreach/StaticBlock.java ! test/tools/javac/foreach/SuperfluousAbstract.java ! test/tools/javac/generics/ArrayClone.java ! test/tools/javac/generics/ArrayTypearg.java ! test/tools/javac/generics/BridgeClash.java ! test/tools/javac/generics/BridgeOrder.java ! test/tools/javac/generics/CastCrash.java ! test/tools/javac/generics/Casting.java ! test/tools/javac/generics/Casting2.java ! test/tools/javac/generics/Casting3.java ! test/tools/javac/generics/Casting4.java ! test/tools/javac/generics/Conditional.java ! test/tools/javac/generics/Covar2.java ! test/tools/javac/generics/Covar3.java ! test/tools/javac/generics/Covar4.java ! test/tools/javac/generics/Crash01.java ! test/tools/javac/generics/Crash02.java ! test/tools/javac/generics/CyclicInheritance3.java ! test/tools/javac/generics/CyclicInheritance5.java ! test/tools/javac/generics/ErasureClashCrash.java ! test/tools/javac/generics/ExtendedRaw1.java ! test/tools/javac/generics/ExtendedRaw2.java ! test/tools/javac/generics/ExtendedRaw3.java ! test/tools/javac/generics/ExtendedRaw4.java ! test/tools/javac/generics/FinalBridge.java ! test/tools/javac/generics/GenLit1.java ! test/tools/javac/generics/GenLit2.java ! test/tools/javac/generics/GenericAnonCtor.java ! test/tools/javac/generics/GenericMerge.java ! test/tools/javac/generics/GenericOverride.java ! test/tools/javac/generics/GenericThrowable.java ! test/tools/javac/generics/GetClass.java ! test/tools/javac/generics/GetClass2.java ! test/tools/javac/generics/InheritanceConflict.java ! test/tools/javac/generics/InheritanceConflict2.java ! test/tools/javac/generics/InheritanceConflict3.java ! test/tools/javac/generics/InnerInterface1.java ! test/tools/javac/generics/InnerInterface2.java ! test/tools/javac/generics/InstanceOf1.java ! test/tools/javac/generics/InstanceOf2.java ! test/tools/javac/generics/InstanceOf3.java ! test/tools/javac/generics/InterfaceCast1.java ! test/tools/javac/generics/LoadOrder.java ! test/tools/javac/generics/MissingBridge.java ! test/tools/javac/generics/MissingCast.java ! test/tools/javac/generics/Multibound1.java ! test/tools/javac/generics/MultipleInheritance.java ! test/tools/javac/generics/NameOrder.java ! test/tools/javac/generics/Nonlinear.java ! test/tools/javac/generics/ParametricException.java ! test/tools/javac/generics/ParenVerify.java ! test/tools/javac/generics/PermuteBound.java ! test/tools/javac/generics/PrimitiveClass.java ! test/tools/javac/generics/PrimitiveVariant.java ! test/tools/javac/generics/RawClient.java ! test/tools/javac/generics/RefEqual.java ! test/tools/javac/generics/RelaxedArrays.java ! test/tools/javac/generics/ReverseOrder.java ! test/tools/javac/generics/SelfImplement.java ! test/tools/javac/generics/SilentUnchecked.java ! test/tools/javac/generics/SuperTypeargs.java ! test/tools/javac/generics/T4661029.java ! test/tools/javac/generics/T4683314.java ! test/tools/javac/generics/T4684378.java ! test/tools/javac/generics/T4695348.java ! test/tools/javac/generics/T4695415.java ! test/tools/javac/generics/T4695847.java ! test/tools/javac/generics/T4711570.java ! test/tools/javac/generics/T4711572.java ! test/tools/javac/generics/T4711694.java ! test/tools/javac/generics/T4738171.java ! test/tools/javac/generics/T4739399.java ! test/tools/javac/generics/T4757416.java ! test/tools/javac/generics/T4784207a.java ! test/tools/javac/generics/T4784219.java ! test/tools/javac/generics/T5011073.java ! test/tools/javac/generics/T5094318.java ! test/tools/javac/generics/TyparamLit.java ! test/tools/javac/generics/TyparamStaticScope.java ! test/tools/javac/generics/TyparamStaticScope2.java ! test/tools/javac/generics/UncheckedArray.java ! test/tools/javac/generics/UncheckedConstructor.java ! test/tools/javac/generics/UncheckedCovariance.java ! test/tools/javac/generics/UnsoundInference.java ! test/tools/javac/generics/Varargs.java ! test/tools/javac/generics/Varargs2.java ! test/tools/javac/generics/WrongNew.java ! test/tools/javac/generics/abstract/T4717181c.java ! test/tools/javac/generics/bridge1/D.java ! test/tools/javac/generics/classreader/HArrayMethod.java ! test/tools/javac/generics/compat/CovariantCompat1.java ! test/tools/javac/generics/compat/OverrideBridge1.java ! test/tools/javac/generics/forwardSeparateBound/ForwardSeparateBound2.java ! test/tools/javac/generics/genericAbstract/A.java ! test/tools/javac/generics/odersky/BadTest.java ! test/tools/javac/generics/odersky/BadTest2.java ! test/tools/javac/generics/odersky/BadTest3.java ! test/tools/javac/generics/odersky/BadTest4.java ! test/tools/javac/generics/odersky/Test.java ! test/tools/javac/generics/odersky/Test2.java ! test/tools/javac/generics/odersky/Test3.java ! test/tools/javac/generics/odersky/Test4.java ! test/tools/javac/generics/parametricException/J.java ! test/tools/javac/generics/rare/Rare1.java ! test/tools/javac/generics/rare/Rare10.java ! test/tools/javac/generics/rare/Rare11.java ! test/tools/javac/generics/rare/Rare2.java ! test/tools/javac/generics/rare/Rare3.java ! test/tools/javac/generics/rare/Rare4.java ! test/tools/javac/generics/rare/Rare5.java ! test/tools/javac/generics/rare/Rare6.java ! test/tools/javac/generics/rare/Rare7.java ! test/tools/javac/generics/rare/Rare8.java ! test/tools/javac/generics/rare/Rare9.java ! test/tools/javac/generics/rawSeparate/RetroLexer.java ! test/tools/javac/generics/typeargs/Basic.java ! test/tools/javac/generics/typeargs/Metharg1.java ! test/tools/javac/generics/typeargs/Metharg2.java ! test/tools/javac/generics/typeargs/Newarg1.java ! test/tools/javac/generics/typeargs/Newarg2.java ! test/tools/javac/generics/typeargs/Superarg1.java ! test/tools/javac/generics/typeargs/Superarg2.java ! test/tools/javac/generics/typeargs/ThisArg.java ! test/tools/javac/generics/typevars/4856983/T4856983.java ! test/tools/javac/generics/typevars/4856983/T4856983a.java ! test/tools/javac/generics/typevars/4856983/T4856983b.java ! test/tools/javac/generics/wildcards/AssignmentDifferentTypes1.java ! test/tools/javac/generics/wildcards/AssignmentDifferentTypes2.java ! test/tools/javac/generics/wildcards/AssignmentDifferentTypes3.java ! test/tools/javac/generics/wildcards/AssignmentDifferentTypes4.java ! test/tools/javac/generics/wildcards/AssignmentDifferentTypes5.java ! test/tools/javac/generics/wildcards/AssignmentDifferentTypes6.java ! test/tools/javac/generics/wildcards/AssignmentDifferentTypes7.java ! test/tools/javac/generics/wildcards/AssignmentDifferentTypes8.java ! test/tools/javac/generics/wildcards/AssignmentDifferentTypes9.java ! test/tools/javac/generics/wildcards/AssignmentSameType1.java ! test/tools/javac/generics/wildcards/AssignmentSameType2.java ! test/tools/javac/generics/wildcards/AssignmentSameType3.java ! test/tools/javac/generics/wildcards/AssignmentSameType4.java ! test/tools/javac/generics/wildcards/AssignmentSameType5.java ! test/tools/javac/generics/wildcards/AssignmentSameType6.java ! test/tools/javac/generics/wildcards/AssignmentSameType7.java ! test/tools/javac/generics/wildcards/AssignmentSameType8.java ! test/tools/javac/generics/wildcards/BoundBug.java ! test/tools/javac/generics/wildcards/ContraArg.java ! test/tools/javac/generics/wildcards/T5097548.java ! test/tools/javac/generics/wildcards/T5097548b.java ! test/tools/javac/generics/wildcards/UnboundArray.java ! test/tools/javac/generics/wildcards/neg/AmbiguousCast.java ! test/tools/javac/generics/wildcards/neg/Capture.java ! test/tools/javac/generics/wildcards/neg/CastFail1.java ! test/tools/javac/generics/wildcards/neg/CastFail10.java ! test/tools/javac/generics/wildcards/neg/CastFail11.java ! test/tools/javac/generics/wildcards/neg/CastFail12.java ! test/tools/javac/generics/wildcards/neg/CastFail13.java ! test/tools/javac/generics/wildcards/neg/CastFail14.java ! test/tools/javac/generics/wildcards/neg/CastFail15.java ! test/tools/javac/generics/wildcards/neg/CastFail16.java ! test/tools/javac/generics/wildcards/neg/CastFail17.java ! test/tools/javac/generics/wildcards/neg/CastFail18.java ! test/tools/javac/generics/wildcards/neg/CastFail19.java ! test/tools/javac/generics/wildcards/neg/CastFail2.java ! test/tools/javac/generics/wildcards/neg/CastFail20.java ! test/tools/javac/generics/wildcards/neg/CastFail21.java ! test/tools/javac/generics/wildcards/neg/CastFail3.java ! test/tools/javac/generics/wildcards/neg/CastFail4.java ! test/tools/javac/generics/wildcards/neg/CastFail5.java ! test/tools/javac/generics/wildcards/neg/CastFail6.java ! test/tools/javac/generics/wildcards/neg/CastFail7.java ! test/tools/javac/generics/wildcards/neg/CastFail8.java ! test/tools/javac/generics/wildcards/neg/CastFail9.java ! test/tools/javac/generics/wildcards/neg/CastWarn10.java ! test/tools/javac/generics/wildcards/neg/CastWarn11.java ! test/tools/javac/generics/wildcards/neg/CastWarn12.java ! test/tools/javac/generics/wildcards/neg/CastWarn13.java ! test/tools/javac/generics/wildcards/neg/CastWarn14.java ! test/tools/javac/generics/wildcards/neg/CastWarn2.java ! test/tools/javac/generics/wildcards/neg/CastWarn3.java ! test/tools/javac/generics/wildcards/neg/CastWarn4.java ! test/tools/javac/generics/wildcards/neg/CastWarn5.java ! test/tools/javac/generics/wildcards/neg/CastWarn6.java ! test/tools/javac/generics/wildcards/neg/CastWarn7.java ! test/tools/javac/generics/wildcards/neg/CastWarn8.java ! test/tools/javac/generics/wildcards/neg/CastWarn9.java ! test/tools/javac/generics/wildcards/neg/ParamCast.java ! test/tools/javac/generics/wildcards/neg/Readonly.java ! test/tools/javac/generics/wildcards/neg/Unbounded.java ! test/tools/javac/generics/wildcards/pos/AmbiguousCast2.java ! test/tools/javac/generics/wildcards/pos/BoundsCollision.java ! test/tools/javac/generics/wildcards/pos/Capture.java ! test/tools/javac/generics/wildcards/pos/CastTest.java ! test/tools/javac/generics/wildcards/pos/InstanceOf.java ! test/tools/javac/generics/wildcards/pos/ParamCast.java ! test/tools/javac/generics/wildcards/pos/RvalConversion.java ! test/tools/javac/generics/wildcards/pos/UncheckedCast1.java ! test/tools/javac/importscope/A.java ! test/tools/javac/limits/FinallyNesting.java ! test/tools/javac/lint/Unchecked.java ! test/tools/javac/miranda/T4711325.java ! test/tools/javac/mixedTarget/CompatibleAbstracts1.java ! test/tools/javac/mixedTarget/ExtendCovariant2.java ! test/tools/javac/overload/T5090220.java ! test/tools/javac/processing/environment/TestSourceVersion.java ! test/tools/javac/stackmap/UninitThis.java ! test/tools/javac/staticImport/Ambig1.java ! test/tools/javac/staticImport/ImportInherit.java ! test/tools/javac/staticImport/ImportPrivate.java ! test/tools/javac/staticImport/PrivateStaticImport.java ! test/tools/javac/staticImport/Shadow.java ! test/tools/javac/staticImport/StaticImport.java ! test/tools/javac/staticImport/StaticImport2.java ! test/tools/javac/unicode/Unmappable.java ! test/tools/javac/varargs/Anon.java ! test/tools/javac/varargs/BadSyntax2.java ! test/tools/javac/varargs/Varargs1.java ! test/tools/javac/varargs/VarargsOverride.java ! test/tools/javac/varargs/Warn1.java ! test/tools/javac/varargs/Warn2.java ! test/tools/javac/varargs/warning/Warn2.java ! test/tools/javac/varargs/warning/Warn3.java ! test/tools/javadoc/LangVers.java ! test/tools/javadoc/annotations/annotateMethodsFields/Main.java ! test/tools/javadoc/annotations/annotatePackage/Main.java ! test/tools/javadoc/annotations/annotateParams/Main.java ! test/tools/javadoc/annotations/defaults/Main.java ! test/tools/javadoc/annotations/elementTypes/Main.java ! test/tools/javadoc/annotations/shortcuts/Main.java ! test/tools/javadoc/enum/docComments/Main.java ! test/tools/javadoc/enum/enumType/Main.java ! test/tools/javadoc/generics/genericClass/Main.java ! test/tools/javadoc/generics/genericInnerAndOuter/Main.java ! test/tools/javadoc/generics/genericInterface/Main.java ! test/tools/javadoc/generics/genericMethod/Main.java ! test/tools/javadoc/generics/genericSuper/Main.java ! test/tools/javadoc/generics/supertypes/Main.java ! test/tools/javadoc/generics/throwsGeneric/Main.java ! test/tools/javadoc/generics/tparamCycle/Main.java ! test/tools/javadoc/generics/tparamTagOnMethod/Main.java ! test/tools/javadoc/generics/tparamTagOnType/Main.java ! test/tools/javadoc/generics/wildcards/Main.java ! test/tools/javadoc/lib/Tester.java ! test/tools/javadoc/varArgs/Main.java Changeset: d4828eba4939 Author: jjg Date: 2009-05-28 09:49 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/d4828eba4939 6802102: unignore @ignored tests where possible Reviewed-by: mcimadamore ! test/tools/javac/T6405099.java ! test/tools/javac/api/6431257/T6431257.java ! test/tools/javac/api/TestJavacTaskScanner.java ! test/tools/javac/code/ArrayClone.java - test/tools/javac/code/ArrayClone.sh ! test/tools/javac/generics/inference/6365166/NewTest.java Changeset: 47cf04bb80c9 Author: jjg Date: 2009-05-29 16:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/47cf04bb80c9 6838199: remove support for old javap Reviewed-by: ohair, mcimadamore ! make/build.xml ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/Main.java ! src/share/classes/com/sun/tools/javap/resources/javap.properties - src/share/classes/sun/tools/javap/AttrData.java - src/share/classes/sun/tools/javap/CPX.java - src/share/classes/sun/tools/javap/CPX2.java - src/share/classes/sun/tools/javap/ClassData.java - src/share/classes/sun/tools/javap/Constants.java - src/share/classes/sun/tools/javap/FieldData.java - src/share/classes/sun/tools/javap/InnerClassData.java - src/share/classes/sun/tools/javap/JavapEnvironment.java - src/share/classes/sun/tools/javap/JavapPrinter.java - src/share/classes/sun/tools/javap/LineNumData.java - src/share/classes/sun/tools/javap/LocVarData.java - src/share/classes/sun/tools/javap/Main.java - src/share/classes/sun/tools/javap/MethodData.java - src/share/classes/sun/tools/javap/RuntimeConstants.java - src/share/classes/sun/tools/javap/StackMapData.java - src/share/classes/sun/tools/javap/StackMapTableData.java - src/share/classes/sun/tools/javap/Tables.java - src/share/classes/sun/tools/javap/TrapData.java - src/share/classes/sun/tools/javap/TypeSignature.java ! test/tools/javap/ExtPath.java - test/tools/javap/ListTest.java - test/tools/javap/OptionTest.java Changeset: 163f5d75f77a Author: tbell Date: 2009-06-11 21:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/163f5d75f77a Merge ! make/Makefile ! make/build.xml - src/share/classes/sun/tools/javap/AttrData.java - src/share/classes/sun/tools/javap/CPX.java - src/share/classes/sun/tools/javap/CPX2.java - src/share/classes/sun/tools/javap/ClassData.java - src/share/classes/sun/tools/javap/Constants.java - src/share/classes/sun/tools/javap/FieldData.java - src/share/classes/sun/tools/javap/InnerClassData.java - src/share/classes/sun/tools/javap/JavapEnvironment.java - src/share/classes/sun/tools/javap/JavapPrinter.java - src/share/classes/sun/tools/javap/LineNumData.java - src/share/classes/sun/tools/javap/LocVarData.java - src/share/classes/sun/tools/javap/Main.java - src/share/classes/sun/tools/javap/MethodData.java - src/share/classes/sun/tools/javap/RuntimeConstants.java - src/share/classes/sun/tools/javap/StackMapData.java - src/share/classes/sun/tools/javap/StackMapTableData.java - src/share/classes/sun/tools/javap/Tables.java - src/share/classes/sun/tools/javap/TrapData.java - src/share/classes/sun/tools/javap/TypeSignature.java - test/tools/javac/code/ArrayClone.sh - test/tools/javap/ListTest.java - test/tools/javap/OptionTest.java Changeset: 6855e5aa3348 Author: tbell Date: 2009-06-21 23:55 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/6855e5aa3348 Merge Changeset: 5c2c81120555 Author: xdono Date: 2009-06-25 12:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/langtools/rev/5c2c81120555 Added tag jdk7-b62 for changeset 6855e5aa3348 ! .hgtags From Christian.Thalinger at Sun.COM Fri Jun 26 10:01:00 2009 From: Christian.Thalinger at Sun.COM (Christian.Thalinger at Sun.COM) Date: Fri, 26 Jun 2009 17:01:00 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 5057225: Remove useless I2L conversions Message-ID: <20090626170107.DD210E36A@hg.openjdk.java.net> Changeset: 18a08a7e16b5 Author: twisti Date: 2009-06-26 07:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/18a08a7e16b5 5057225: Remove useless I2L conversions Summary: The optimizer should be told to normalize (AndL (ConvI2L x) 0xFF) to (ConvI2L (AndI x 0xFF)), and then the existing matcher rule will work for free. Reviewed-by: kvn ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/mulnode.cpp + test/compiler/5057225/Test5057225.java From Thomas.Rodriguez at Sun.COM Fri Jun 26 13:29:28 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Fri, 26 Jun 2009 13:29:28 -0700 Subject: Request for reviews (L): 6840775: Multiple JVM crashes seen with 1.6.0_10 through early access of 1.6.0_14 In-Reply-To: <4A41695B.9070801@sun.com> References: <4A41695B.9070801@sun.com> Message-ID: <7DBC493B-C4EC-4131-8DE2-E47180399E32@sun.com> The change in slow_arraycopy_C seems like overkill but wouldn't a No_Safepoint_Verifier be more appropriate? Could you refactor the copy code so that there aren't two copies of the code? They do almost exactly the same thing apart from a few checks. It's hard to see the overall structure with those big chunks in the middle as well. The code itself looks good to me. tom On Jun 23, 2009, at 4:46 PM, Vladimir Kozlov wrote: > > http://cr.openjdk.java.net/~kvn/6840775/webrev.01 > > Fixed 6840775: Multiple JVM crashes seen with 1.6.0_10 through early > access of 1.6.0_14 > > Problem: > There is no live oop value (only raw) across the call > to slow_arraycopy() corresponding to new array allocation > followed by arraycopy. The original CheckCastPP > is moved after the call and the new CheckCastPP lives > only until the call. As result the reference to allocated array > in copyOf() intrinsic is not put into OopMap and we get > wrong reference after the call when GC happens on the exit > from the call to slow_arraycopy(). > > Solution: > Replace raw memory edge in the original CheckCastPP with > new CheckCastPP to have a live oop across safepoints. > Also: > - don't disconnect the original InitializeNode; > - use a secondary InitializeNode as raw memory barrier > only on zero copy length path since other paths have > stub or runtime calls as raw memory barriers; > - remove incorrect stack restore in generate_slow_arraycopy; > - separate code for arrays and instances in inline_native_clone; > - add assert in SharedRuntime::slow_arraycopy_C() to verify that > no GC happened during copy_array() call; > - add assert to check for possible live raw values at safepoint > which are oops (there are CheckCastPP for the raw value); > - fix SA to display an object with bad oop fields; > - fix typo in optimized.make. > > Reviewed by: > > Fix verified (y/n): y, bug's test > > Other testing: > JPRT, CTW > From Thomas.Rodriguez at Sun.COM Fri Jun 26 14:46:29 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Fri, 26 Jun 2009 14:46:29 -0700 Subject: review (XS) for 6851908: interpreter null check profiling broken causing extra compilation invalidation Message-ID: <124DB678-F574-4AB6-A1CA-705769E12C82@Sun.COM> http://cr.openjdk.java.net/~never/6851908 From thomas.rodriguez at sun.com Fri Jun 26 15:31:19 2009 From: thomas.rodriguez at sun.com (thomas.rodriguez at sun.com) Date: Fri, 26 Jun 2009 22:31:19 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6818666: G1: Type lost in g1 pre-barrier Message-ID: <20090626223133.0E1A4E3BD@hg.openjdk.java.net> Changeset: 8f5825e0aeaa Author: never Date: 2009-06-26 13:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/8f5825e0aeaa 6818666: G1: Type lost in g1 pre-barrier Reviewed-by: kvn ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp From Vladimir.Kozlov at Sun.COM Fri Jun 26 15:53:24 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Fri, 26 Jun 2009 15:53:24 -0700 Subject: Request for reviews (L): 6840775: Multiple JVM crashes seen with 1.6.0_10 through early access of 1.6.0_14 In-Reply-To: <7DBC493B-C4EC-4131-8DE2-E47180399E32@sun.com> References: <4A41695B.9070801@sun.com> <7DBC493B-C4EC-4131-8DE2-E47180399E32@sun.com> Message-ID: <4A455164.2020506@sun.com> Thank you, Tom Tom Rodriguez wrote: > The change in slow_arraycopy_C seems like overkill but wouldn't a > No_Safepoint_Verifier be more appropriate? Replaced my code with debug_only(No_Safepoint_Verifier nsv;). > > Could you refactor the copy code so that there aren't two copies of the > code? They do almost exactly the same thing apart from a few checks. > It's hard to see the overall structure with those big chunks in the > middle as well. The code itself looks good to me. Agree, I will do it. Thanks, Vladimir > > tom > > On Jun 23, 2009, at 4:46 PM, Vladimir Kozlov wrote: > >> >> http://cr.openjdk.java.net/~kvn/6840775/webrev.01 >> >> Fixed 6840775: Multiple JVM crashes seen with 1.6.0_10 through early >> access of 1.6.0_14 >> >> Problem: >> There is no live oop value (only raw) across the call >> to slow_arraycopy() corresponding to new array allocation >> followed by arraycopy. The original CheckCastPP >> is moved after the call and the new CheckCastPP lives >> only until the call. As result the reference to allocated array >> in copyOf() intrinsic is not put into OopMap and we get >> wrong reference after the call when GC happens on the exit >> from the call to slow_arraycopy(). >> >> Solution: >> Replace raw memory edge in the original CheckCastPP with >> new CheckCastPP to have a live oop across safepoints. >> Also: >> - don't disconnect the original InitializeNode; >> - use a secondary InitializeNode as raw memory barrier >> only on zero copy length path since other paths have >> stub or runtime calls as raw memory barriers; >> - remove incorrect stack restore in generate_slow_arraycopy; >> - separate code for arrays and instances in inline_native_clone; >> - add assert in SharedRuntime::slow_arraycopy_C() to verify that >> no GC happened during copy_array() call; >> - add assert to check for possible live raw values at safepoint >> which are oops (there are CheckCastPP for the raw value); >> - fix SA to display an object with bad oop fields; >> - fix typo in optimized.make. >> >> Reviewed by: >> >> Fix verified (y/n): y, bug's test >> >> Other testing: >> JPRT, CTW >> > From Vladimir.Kozlov at Sun.COM Fri Jun 26 16:07:08 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Fri, 26 Jun 2009 16:07:08 -0700 Subject: review (XS) for 6851908: interpreter null check profiling broken causing extra compilation invalidation In-Reply-To: <124DB678-F574-4AB6-A1CA-705769E12C82@Sun.COM> References: <124DB678-F574-4AB6-A1CA-705769E12C82@Sun.COM> Message-ID: <4A45549C.4000508@sun.com> Looks good. Vladimir Tom Rodriguez wrote: > http://cr.openjdk.java.net/~never/6851908 From thomas.rodriguez at sun.com Fri Jun 26 20:42:51 2009 From: thomas.rodriguez at sun.com (thomas.rodriguez at sun.com) Date: Sat, 27 Jun 2009 03:42:51 +0000 Subject: hg: jdk7/hotspot-comp/hotspot: 6851908: interpreter null check profiling broken causing extra compilation invalidation Message-ID: <20090627034300.BBAD5E3E2@hg.openjdk.java.net> Changeset: 3f06f139ef53 Author: never Date: 2009-06-26 16:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/3f06f139ef53 6851908: interpreter null check profiling broken causing extra compilation invalidation Reviewed-by: kvn ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp From Vladimir.Kozlov at Sun.COM Mon Jun 29 15:29:15 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Mon, 29 Jun 2009 15:29:15 -0700 Subject: Request for reviews (L): 6840775: Multiple JVM crashes seen with 1.6.0_10 through early access of 1.6.0_14 In-Reply-To: <7DBC493B-C4EC-4131-8DE2-E47180399E32@sun.com> References: <4A41695B.9070801@sun.com> <7DBC493B-C4EC-4131-8DE2-E47180399E32@sun.com> Message-ID: <4A49403B.9050503@sun.com> Tom Rodriguez wrote: > The change in slow_arraycopy_C seems like overkill but wouldn't a > No_Safepoint_Verifier be more appropriate? > Tom, I will remove the check in slow_arraycopy_C. After I replaced my code in slow_arraycopy_C with No_Safepoint_Verifier I hit assert when the callee tries to throw allocatable exception: // Check is all offsets and lengths are non negative if (src_pos < 0 || dst_pos < 0 || length < 0) { THROW(vmSymbols::java_lang_ArrayIndexOutOfBoundsException()); } I also can't move No_Safepoint_Verifier into objArrayKlass::copy_array() since when an element's class does not match the array's class it will also throw exception: THROW(vmSymbols::java_lang_ArrayStoreException()); The copy_array() (and do_copy()) code should be GC safe since it will not copy after an exception. Thanks, Vladimir From Vladimir.Kozlov at Sun.COM Mon Jun 29 15:47:44 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Mon, 29 Jun 2009 15:47:44 -0700 Subject: Resend: Request for reviews (L): 6840775: Multiple JVM crashes seen with 1.6.0_10 through early access of 1.6.0_14 Message-ID: <4A494490.3080203@sun.com> Updated changes: Removed changes in sharedRuntime.cpp. Put the duplicated code in inline_native_clone() into separate helper method copy_to_clone(). http://cr.openjdk.java.net/~kvn/6840775/webrev.02 Fixed 6840775: Multiple JVM crashes seen with 1.6.0_10 through early access of 1.6.0_14 Problem: There is no live oop value (only raw) across the call to slow_arraycopy() corresponding to new array allocation followed by arraycopy. The original CheckCastPP is moved after the call and the new CheckCastPP lives only until the call. As result the reference to allocated array in copyOf() intrinsic is not put into OopMap and we get wrong reference after the call when GC happens on the exit from the call to slow_arraycopy(). Solution: Replace raw memory edge in the original CheckCastPP with new CheckCastPP to have a live oop across safepoints. Also: - don't disconnect the original InitializeNode; - use a secondary InitializeNode as raw memory barrier only on zero copy length path since other paths have stub or runtime calls as raw memory barriers; - remove incorrect stack restore in generate_slow_arraycopy; - separate code for arrays and instances in inline_native_clone and put common code into separate helper method; - add assert to check for possible live raw values at safepoint which are oops (there are CheckCastPP for the raw value); - fix SA to display an object with bad oop fields; - fix typo in optimized.make. Reviewed by: never Fix verified (y/n): y, bug's test Other testing: JPRT, CTW From Thomas.Rodriguez at Sun.COM Mon Jun 29 18:06:23 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Mon, 29 Jun 2009 18:06:23 -0700 Subject: Resend: Request for reviews (L): 6840775: Multiple JVM crashes seen with 1.6.0_10 through early access of 1.6.0_14 In-Reply-To: <4A494490.3080203@sun.com> References: <4A494490.3080203@sun.com> Message-ID: <09639963-C1FF-433D-9A77-B3BDAFED2069@sun.com> I think it looks good. Thanks for rearranging the code. tom On Jun 29, 2009, at 3:47 PM, Vladimir Kozlov wrote: > Updated changes: > Removed changes in sharedRuntime.cpp. Put the duplicated code > in inline_native_clone() into separate helper method copy_to_clone(). > > http://cr.openjdk.java.net/~kvn/6840775/webrev.02 > > Fixed 6840775: Multiple JVM crashes seen with 1.6.0_10 through early > access of 1.6.0_14 > > Problem: > There is no live oop value (only raw) across the call > to slow_arraycopy() corresponding to new array allocation > followed by arraycopy. The original CheckCastPP > is moved after the call and the new CheckCastPP lives > only until the call. As result the reference to allocated array > in copyOf() intrinsic is not put into OopMap and we get > wrong reference after the call when GC happens on the exit > from the call to slow_arraycopy(). > > Solution: > Replace raw memory edge in the original CheckCastPP with > new CheckCastPP to have a live oop across safepoints. > Also: > - don't disconnect the original InitializeNode; > - use a secondary InitializeNode as raw memory barrier > only on zero copy length path since other paths have > stub or runtime calls as raw memory barriers; > - remove incorrect stack restore in generate_slow_arraycopy; > - separate code for arrays and instances in inline_native_clone > and put common code into separate helper method; > - add assert to check for possible live raw values at safepoint > which are oops (there are CheckCastPP for the raw value); > - fix SA to display an object with bad oop fields; > - fix typo in optimized.make. > > Reviewed by: never > > Fix verified (y/n): y, bug's test > > Other testing: > JPRT, CTW > From Thomas.Rodriguez at Sun.COM Tue Jun 30 13:37:22 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 30 Jun 2009 13:37:22 -0700 Subject: review (S) for 6856025: assert(_base >= OopPtr && _base <= KlassPtr,"Not a Java pointer") Message-ID: <1CE392AF-E750-4350-A133-4F236E20DA08@sun.com> http://cr.openjdk.java.net/~never/6856025/ From Vladimir.Kozlov at Sun.COM Tue Jun 30 14:26:58 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Tue, 30 Jun 2009 14:26:58 -0700 Subject: review (S) for 6856025: assert(_base >= OopPtr && _base <= KlassPtr,"Not a Java pointer") In-Reply-To: <1CE392AF-E750-4350-A133-4F236E20DA08@sun.com> References: <1CE392AF-E750-4350-A133-4F236E20DA08@sun.com> Message-ID: <4A4A8322.2020100@sun.com> Looks good. Vladimir Tom Rodriguez wrote: > http://cr.openjdk.java.net/~never/6856025/ From Vladimir.Kozlov at Sun.COM Tue Jun 30 14:33:51 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Tue, 30 Jun 2009 14:33:51 -0700 Subject: review (S) for 6856025: assert(_base >= OopPtr && _base <= KlassPtr,"Not a Java pointer") In-Reply-To: <4A4A8322.2020100@sun.com> References: <1CE392AF-E750-4350-A133-4F236E20DA08@sun.com> <4A4A8322.2020100@sun.com> Message-ID: <4A4A84BF.9030002@sun.com> After sending this I don't see that you fixed store_oop_to_unknown. Is it intentional to use TypeInstPtr::BOTTOM as val_type in case of narrow field/element? Thanks, Vladimir Vladimir Kozlov wrote: > Looks good. > > Vladimir > > Tom Rodriguez wrote: >> http://cr.openjdk.java.net/~never/6856025/ From Thomas.Rodriguez at Sun.COM Tue Jun 30 14:44:56 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 30 Jun 2009 14:44:56 -0700 Subject: review (S) for 6856025: assert(_base >= OopPtr && _base <= KlassPtr,"Not a Java pointer") In-Reply-To: <4A4A84BF.9030002@sun.com> References: <1CE392AF-E750-4350-A133-4F236E20DA08@sun.com> <4A4A8322.2020100@sun.com> <4A4A84BF.9030002@sun.com> Message-ID: <8E3DCC85-CE9B-41E3-96BA-DDFD38816A0B@Sun.COM> On Jun 30, 2009, at 2:33 PM, Vladimir Kozlov wrote: > After sending this I don't see that you fixed store_oop_to_unknown. > Is it intentional to use TypeInstPtr::BOTTOM as val_type in case of > narrow field/element? The value_type for the prebarrier is declared to be TypeOopPtr since it bottoms out in LoadNode::make which always returns the wide type. So TypeInstPtr::BOTTOM is the worst case type for the store_oop_to_unknown case. Is there something wrong with that? tom > > Thanks, > Vladimir > > Vladimir Kozlov wrote: >> Looks good. >> Vladimir >> Tom Rodriguez wrote: >>> http://cr.openjdk.java.net/~never/6856025/ From Vladimir.Kozlov at Sun.COM Tue Jun 30 14:49:20 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Tue, 30 Jun 2009 14:49:20 -0700 Subject: review (S) for 6856025: assert(_base >= OopPtr && _base <= KlassPtr,"Not a Java pointer") In-Reply-To: <8E3DCC85-CE9B-41E3-96BA-DDFD38816A0B@Sun.COM> References: <1CE392AF-E750-4350-A133-4F236E20DA08@sun.com> <4A4A8322.2020100@sun.com> <4A4A84BF.9030002@sun.com> <8E3DCC85-CE9B-41E3-96BA-DDFD38816A0B@Sun.COM> Message-ID: <4A4A8860.1090902@sun.com> Tom Rodriguez wrote: > > On Jun 30, 2009, at 2:33 PM, Vladimir Kozlov wrote: > >> After sending this I don't see that you fixed store_oop_to_unknown. >> Is it intentional to use TypeInstPtr::BOTTOM as val_type in case of >> narrow field/element? > > The value_type for the prebarrier is declared to be TypeOopPtr since it > bottoms out in LoadNode::make which always returns the wide type. So > TypeInstPtr::BOTTOM is the worst case type for the store_oop_to_unknown > case. Is there something wrong with that? Nothing wrong with it. I'm just wondering why you don't use more precise type for array's element (instance's field type is fine) by using make_oopptr(). Vladimir > > tom > >> >> Thanks, >> Vladimir >> >> Vladimir Kozlov wrote: >>> Looks good. >>> Vladimir >>> Tom Rodriguez wrote: >>>> http://cr.openjdk.java.net/~never/6856025/ > From Thomas.Rodriguez at Sun.COM Tue Jun 30 14:57:01 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 30 Jun 2009 14:57:01 -0700 Subject: review (S) for 6856025: assert(_base >= OopPtr && _base <= KlassPtr,"Not a Java pointer") In-Reply-To: <4A4A8860.1090902@sun.com> References: <1CE392AF-E750-4350-A133-4F236E20DA08@sun.com> <4A4A8322.2020100@sun.com> <4A4A84BF.9030002@sun.com> <8E3DCC85-CE9B-41E3-96BA-DDFD38816A0B@Sun.COM> <4A4A8860.1090902@sun.com> Message-ID: <36AFFD71-876C-4604-97AC-6B7F54672828@Sun.COM> On Jun 30, 2009, at 2:49 PM, Vladimir Kozlov wrote: > Tom Rodriguez wrote: >> On Jun 30, 2009, at 2:33 PM, Vladimir Kozlov wrote: >>> After sending this I don't see that you fixed store_oop_to_unknown. >>> Is it intentional to use TypeInstPtr::BOTTOM as val_type in case >>> of narrow field/element? >> The value_type for the prebarrier is declared to be TypeOopPtr >> since it bottoms out in LoadNode::make which always returns the >> wide type. So TypeInstPtr::BOTTOM is the worst case type for the >> store_oop_to_unknown case. Is there something wrong with that? > > Nothing wrong with it. I'm just wondering why you don't use more > precise > type for array's element (instance's field type is fine) by using > make_oopptr(). I'm confused. This whole chunk tries to pick the best type it can for store_oop_to_unknown. const TypeOopPtr* val_type = NULL; if (adr_type->isa_instptr()) { if (at->field() != NULL) { // known field. This code is a copy of the do_put_xxx logic. ciField* field = at->field(); if (!field->type()->is_loaded()) { val_type = TypeInstPtr::BOTTOM; } else { val_type = TypeOopPtr::make_from_klass(field->type()- >as_klass()); } } } else if (adr_type->isa_aryptr()) { val_type = adr_type->is_aryptr()->elem()->make_oopptr(); } if (val_type == NULL) { val_type = TypeInstPtr::BOTTOM; } What change are you suggesting? tom > > Vladimir > >> tom >>> >>> Thanks, >>> Vladimir >>> >>> Vladimir Kozlov wrote: >>>> Looks good. >>>> Vladimir >>>> Tom Rodriguez wrote: >>>>> http://cr.openjdk.java.net/~never/6856025/ From Vladimir.Kozlov at Sun.COM Tue Jun 30 15:13:31 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Tue, 30 Jun 2009 15:13:31 -0700 Subject: review (S) for 6856025: assert(_base >= OopPtr && _base <= KlassPtr,"Not a Java pointer") In-Reply-To: <36AFFD71-876C-4604-97AC-6B7F54672828@Sun.COM> References: <1CE392AF-E750-4350-A133-4F236E20DA08@sun.com> <4A4A8322.2020100@sun.com> <4A4A84BF.9030002@sun.com> <8E3DCC85-CE9B-41E3-96BA-DDFD38816A0B@Sun.COM> <4A4A8860.1090902@sun.com> <36AFFD71-876C-4604-97AC-6B7F54672828@Sun.COM> Message-ID: <4A4A8E0B.3060606@sun.com> Sorry, in the original webrev (webrev/g1) which you sent me there were no changes in graphKit.cpp so I assumed you missed it. But I see now in the final changes you have it. Sorry for confusion. Thanks, Vladimir Tom Rodriguez wrote: > > On Jun 30, 2009, at 2:49 PM, Vladimir Kozlov wrote: > >> Tom Rodriguez wrote: >>> On Jun 30, 2009, at 2:33 PM, Vladimir Kozlov wrote: >>>> After sending this I don't see that you fixed store_oop_to_unknown. >>>> Is it intentional to use TypeInstPtr::BOTTOM as val_type in case of >>>> narrow field/element? >>> The value_type for the prebarrier is declared to be TypeOopPtr since >>> it bottoms out in LoadNode::make which always returns the wide type. >>> So TypeInstPtr::BOTTOM is the worst case type for the >>> store_oop_to_unknown case. Is there something wrong with that? >> >> Nothing wrong with it. I'm just wondering why you don't use more precise >> type for array's element (instance's field type is fine) by using >> make_oopptr(). > > I'm confused. This whole chunk tries to pick the best type it can for > store_oop_to_unknown. > > const TypeOopPtr* val_type = NULL; > if (adr_type->isa_instptr()) { > if (at->field() != NULL) { > // known field. This code is a copy of the do_put_xxx logic. > ciField* field = at->field(); > if (!field->type()->is_loaded()) { > val_type = TypeInstPtr::BOTTOM; > } else { > val_type = TypeOopPtr::make_from_klass(field->type()->as_klass()); > } > } > } else if (adr_type->isa_aryptr()) { > val_type = adr_type->is_aryptr()->elem()->make_oopptr(); > } > if (val_type == NULL) { > val_type = TypeInstPtr::BOTTOM; > } > > What change are you suggesting? > > tom > >> >> Vladimir >> >>> tom >>>> >>>> Thanks, >>>> Vladimir >>>> >>>> Vladimir Kozlov wrote: >>>>> Looks good. >>>>> Vladimir >>>>> Tom Rodriguez wrote: >>>>>> http://cr.openjdk.java.net/~never/6856025/ > From Thomas.Rodriguez at Sun.COM Tue Jun 30 15:34:48 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 30 Jun 2009 15:34:48 -0700 Subject: review (S) for 6856025: assert(_base >= OopPtr && _base <= KlassPtr,"Not a Java pointer") In-Reply-To: <4A4A8E0B.3060606@sun.com> References: <1CE392AF-E750-4350-A133-4F236E20DA08@sun.com> <4A4A8322.2020100@sun.com> <4A4A84BF.9030002@sun.com> <8E3DCC85-CE9B-41E3-96BA-DDFD38816A0B@Sun.COM> <4A4A8860.1090902@sun.com> <36AFFD71-876C-4604-97AC-6B7F54672828@Sun.COM> <4A4A8E0B.3060606@sun.com> Message-ID: Oh yeah, that's right. I hadn't fixed it before but the one I sent our for review has it. Sorry. tom On Jun 30, 2009, at 3:13 PM, Vladimir Kozlov wrote: > Sorry, in the original webrev (webrev/g1) which you sent me > there were no changes in graphKit.cpp so I assumed you missed it. > But I see now in the final changes you have it. > > Sorry for confusion. > > Thanks, > Vladimir > > Tom Rodriguez wrote: >> On Jun 30, 2009, at 2:49 PM, Vladimir Kozlov wrote: >>> Tom Rodriguez wrote: >>>> On Jun 30, 2009, at 2:33 PM, Vladimir Kozlov wrote: >>>>> After sending this I don't see that you fixed >>>>> store_oop_to_unknown. >>>>> Is it intentional to use TypeInstPtr::BOTTOM as val_type in case >>>>> of narrow field/element? >>>> The value_type for the prebarrier is declared to be TypeOopPtr >>>> since it bottoms out in LoadNode::make which always returns the >>>> wide type. So TypeInstPtr::BOTTOM is the worst case type for the >>>> store_oop_to_unknown case. Is there something wrong with that? >>> >>> Nothing wrong with it. I'm just wondering why you don't use more >>> precise >>> type for array's element (instance's field type is fine) by using >>> make_oopptr(). >> I'm confused. This whole chunk tries to pick the best type it can >> for store_oop_to_unknown. >> const TypeOopPtr* val_type = NULL; >> if (adr_type->isa_instptr()) { >> if (at->field() != NULL) { >> // known field. This code is a copy of the do_put_xxx logic. >> ciField* field = at->field(); >> if (!field->type()->is_loaded()) { >> val_type = TypeInstPtr::BOTTOM; >> } else { >> val_type = TypeOopPtr::make_from_klass(field->type()- >> >as_klass()); >> } >> } >> } else if (adr_type->isa_aryptr()) { >> val_type = adr_type->is_aryptr()->elem()->make_oopptr(); >> } >> if (val_type == NULL) { >> val_type = TypeInstPtr::BOTTOM; >> } >> What change are you suggesting? >> tom >>> >>> Vladimir >>> >>>> tom >>>>> >>>>> Thanks, >>>>> Vladimir >>>>> >>>>> Vladimir Kozlov wrote: >>>>>> Looks good. >>>>>> Vladimir >>>>>> Tom Rodriguez wrote: >>>>>>> http://cr.openjdk.java.net/~never/6856025/