review (XS) for 6849574: VM crash using NonBlockingHashMap (high_scale_lib)

[Tom Rodriguez]

Oops.  I thought the file looked strangely short.  I'll fix it.  Thanks!

tom

On Jun 10, 2009, at 12:04 PM, Vladimir Kozlov wrote:

> Fine then.
> One more thing - you did not put copyright header into the test.
>
> Thanks,
> Vladimir
>
> Tom Rodriguez wrote:
>> On Jun 10, 2009, at 11:48 AM, Vladimir Kozlov wrote:
>>> Tom,
>>>
>>> In c1_LIRGenerator.cpp you changed code to do imprecise card mark  
>>> on object.
>>> What happens if the object is large and the field is outside of  
>>> imprecise card mark?
>> PRECISE_CARDMARK is never defined so I didn't change anything.  I  
>> was just removing meaningless code.
>>> Also can you explain the original comment there (could be related  
>>> to the first question)?
>>> !     // Precise cardmarks don't work
>> I don't know what that comment meant.  Precise cardmarks do work  
>> since they are used in the other places where they are required.
>> tom
>>>
>>> thanks,
>>> Vladimir
>>>
>>> Tom Rodriguez wrote:
>>>> http://cr.openjdk.java.net/~never/6849574