review (S) for 6818666: G1: Type lost in g1 pre-barrierr

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Wed Jun 10 13:36:03 PDT 2009


Looks good.

Vladimir

Tom Rodriguez wrote:
> I've corrected this logic to match do_put_xxx and retested.  Everything 
> looks good.
> 
> tom
> 
> On May 4, 2009, at 1:20 PM, Tom Rodriguez wrote:
> 
>>
>> On Apr 29, 2009, at 3:34 PM, Vladimir Kozlov wrote:
>>
>>> In GraphKit::store_oop_to_unknown() should you also check 
>>> field->type()->is_loaded()?
>>
>> You're right.  It should mirror the logic in do_put_xxx in 
>> parse3.cpp.  I'm going to fix that and retest.  I want to exercise 
>> that logic a bit more to make sure it's working the way I think.
>>
>> tom
>>
>>>
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> Tom Rodriguez wrote:
>>>> http://cr.openjdk.java.net/~never/6818666
>>
> 



More information about the hotspot-compiler-dev mailing list