Request for reviews .03 (L): 5057225: Remove useless I2L conversions

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Wed Jun 10 15:45:23 PDT 2009


Christian,

On x86 (32-,64-bit) if an arithmetic instruction is used it will kill flags.
You have to add "effect(KILL cr)" when you use and/xor.

Thanks,
Vladimir

Christian Thalinger wrote:
> Christian Thalinger wrote:
>> On Thu, 2009-05-14 at 14:01 +0200, Christian Thalinger wrote:
>>> On Wed, 2009-05-13 at 13:18 +0200, Christian Thalinger wrote:
>>>> http://cr.openjdk.java.net/~twisti/5057225/webrev.02/
>>>>
>>>> This is an updated version with the changes of 6814842 merged in.
>>> I found a problem during testing and have to investigate that further.
>>
>> This patch fixes the above problem:
>>
>> http://cr.openjdk.java.net/~twisti/5057225/webrev.03/
> 
> Can I get a review for that one?
> 
> -- Christian



More information about the hotspot-compiler-dev mailing list