Request for reviews .03 (L): 5057225: Remove useless I2L conversions

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Tue Jun 23 09:55:25 PDT 2009


Christian,

Changes look good.

Thanks,
Vladimir

Christian Thalinger wrote:
> Christian Thalinger wrote:
>> Vladimir Kozlov wrote:
>>> Christian,
>>>
>>> On x86 (32-,64-bit) if an arithmetic instruction is used it will kill 
>>> flags.
>>> You have to add "effect(KILL cr)" when you use and/xor.
> 
> ...and SAR.  I hope I got all cases:
> 
> http://cr.openjdk.java.net/~twisti/5057225/webrev.04/
> 
> -- Christian



More information about the hotspot-compiler-dev mailing list