Request for review (L): 6797305: Add LoadUB and LoadUI opcode class
Ulf Zibis
Ulf.Zibis at gmx.de
Fri Mar 6 04:28:23 PST 2009
Hi Christian,
just to be sure, if following is included in your fix:
What's about:
char c = (char)(b & 0xFF)
char c = (char)(i & 0xFF)
After optimization, it should be fast as or faster as
char c = (char)b
Goal: determination, if b is positive, becomes superfluous, so we could use { char c = (char)(i & 0xFF) } in any case without speed loss.
Also consider:
char c = (char)(i & 0xFFFF)
char c = (char)(intarray[i] & 0xFFFF)
-Ulf
Am 06.03.2009 12:15, Christian Thalinger schrieb:
> On Fri, 2009-03-06 at 00:45 -0800, Vladimir Kozlov wrote:
>
>> Looks good.
>>
>> In x86_32.ad in loadB2L you need only 7 bits shift: SAR dst.hi, 7
>> and in loadS2L only 15 bits.
>>
>
> Right. I will change that and push the changeset. Thanks Vladimir!
>
> -- Christian
>
>
>
More information about the hotspot-compiler-dev
mailing list