for review (M): 6812831 factor general subclass check (for 6655638)

John Rose John.Rose at Sun.COM
Sat Mar 7 06:13:16 PST 2009


On Mar 6, 2009, at 2:52 PM, Vladimir Kozlov wrote:

> Looks good. I would suggest to run CTW to verify it.
> Use Tom's script ~never/bin/multictw which use all cpus.

Good idea.  I now have CTWs in progress on 4 CPU types (32/64 sparc/ 
x86).

I'm also doing a trial JPRT run.

> stubGenerator_x86_32.cpp:
> I think you should be careful with using forward jccb for
> L_fallthrough label separated by a big macro instruction
> check_klass_subtype_slow_pat().

I see what you mean; you are right.  I backed off on the jccb's in  
generate_type_check.

After going over the code another time, and fixing the AD files, I  
have updated the webrev:
   http://cr.openjdk.java.net/~jrose/6813212/webrev.01/
   http://cr.openjdk.java.net/~jrose/6813212/00-to-01.patch.txt

Thanks for the reviews!

-- John



More information about the hotspot-compiler-dev mailing list