Request for review (L): 6797305: Add LoadUB and LoadUI opcode class

Christian Thalinger Christian.Thalinger at Sun.COM
Tue Mar 10 10:13:33 PDT 2009


On Tue, 2009-03-10 at 13:08 +0100, Christian Thalinger wrote:
> On Tue, 2009-03-03 at 09:56 -0800, Tom Rodriguez wrote:
> > > 2. What about adding load and store assembler instruction like on x86
> > > with an Address argument, e.g.
> > >
> > >  inline void lduw(Address a, Register d);
> > 
> > We could, though fixing that along with what you are doing seems like  
> > loading more than want into your change.  I'd leave the sparc  
> > encodings along for now and we can fix it later to support the Address  
> > stuff.
> 
> For the load shortening changes I'm currently doing it would be useful
> to have these.  Can I add them under a new CR?

...at least I think this is the right way to get rid of stuff like:

  //%%% form3_mem_plus_4_reg is a hack--get rid of it
  enc_class form3_mem_plus_4_reg( memory mem, iRegI dst ) %{
    guarantee($mem$$disp, "cannot offset a reg-reg operand by 4");
    emit_form3_mem_reg(cbuf, this, $primary, -1, $mem$$base, $mem$$disp + 4, $mem$$index, $dst$$reg);
  %}

But maybe there is another, better way that I don't know of.

-- Christian




More information about the hotspot-compiler-dev mailing list