Request for review (L): 6378821: where available, bitCount() should use POPC on SPARC processors and AMD+10h

[Peter B. Kessler]

Some node subclasses have a static "make" factory method to hide the details of calling the placement new and remembering how many in's to specify.  You might want to have one of those for PopCountINode.

			... peter

Tom Rodriguez wrote:
>> and I think I know why that happens.  When I use:
>>
>>  PopCountINode(Node* in1) : Node(0, in1) {}
>>
>> I have to use:
>>
>>    push(_gvn.transform(new (C, 2) PopCountINode(pop())));
>>
>> which is not very obvious to use 2 for the new call.  Should I use the
>> latter anyway?
> 
> That's the style of other nodes of that don't require control.  All the 
> binary operators and many of the unary operators are like this and this 
> one should follow that same style.
> 
> tom
> 
>>
>>
>> -- Christian
>>
>