Request for review (L): 6378821: where available, bitCount() should use POPC on SPARC processors and AMD+10h

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Fri Mar 13 10:14:25 PDT 2009


Usually we use it for several similar nodes, for example, ConNode::make.
In the current case we have only 2 (I/L) nodes. I don't think we need
make factory for them.

Vladimir

Christian Thalinger wrote:
> On Fri, 2009-03-13 at 09:46 -0700, Peter B. Kessler wrote:
>> Some node subclasses have a static "make" factory method to hide the
>> details of calling the placement new and remembering how many in's to
>> specify.  You might want to have one of those for PopCountINode.
> 
> Hmm, didn't know these methods exist.  Is it common practice to use this
> method?
> 
> -- Christian
> 



More information about the hotspot-compiler-dev mailing list