Request for reviews (S): 6810845: Performance regression in mpegaudio on x64
Christian Thalinger
Christian.Thalinger at Sun.COM
Wed Mar 25 21:11:25 PDT 2009
On Tue, 2009-03-24 at 13:32 -0700, Vladimir Kozlov wrote:
> http://cr.openjdk.java.net/~kvn/6810845/webrev.00
>
> Fixed 6810845: Performance regression in mpegaudio on x64
I looked at the webrev and it looks good, at least to me, but I don't
know very much about GCM or the other code you touched. Only one thing
jumped into my eye:
// be conservative if we do not recognize the type
if (tp == NULL) {
+ assert(false, "should not be here");
return TypePtr::BOTTOM;
}
But I guess not having the assert in a product build just means that it
may produce worse code.
-- Christian
More information about the hotspot-compiler-dev
mailing list